From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>,
Matthew Wilcox <willy@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Suren Baghdasaryan <surenb@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Gao Xiang <xiang@kernel.org>,
Chao Yu <chao@kernel.org>,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/5] mm: add PSI accounting around ->read_folio and ->readahead calls
Date: Sat, 10 Sep 2022 05:34:02 -0600 [thread overview]
Message-ID: <bcabe527-7940-8658-1728-28d64bd3cf80@kernel.dk> (raw)
In-Reply-To: <20220910065058.3303831-2-hch@lst.de>
On 9/10/22 12:50 AM, Christoph Hellwig wrote:
> @@ -2390,8 +2392,13 @@ static int filemap_read_folio(struct file *file, filler_t filler,
> * fails.
> */
> folio_clear_error(folio);
> +
> /* Start the actual read. The read will unlock the page. */
> + if (unlikely(workingset))
> + psi_memstall_enter(&pflags);
> error = filler(file, folio);
> + if (unlikely(workingset))
> + psi_memstall_leave(&pflags);
> if (error)
> return error;
I think this would read better as:
/* Start the actual read. The read will unlock the page. */
if (unlikely(workingset)) {
psi_memstall_enter(&pflags);
error = filler(file, folio);
psi_memstall_leave(&pflags);
} else {
error = filler(file, folio);
}
if (error)
return error;
--
Jens Axboe
next prev parent reply other threads:[~2022-09-10 11:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 6:50 improve pagecache PSI annotations Christoph Hellwig
2022-09-10 6:50 ` [PATCH 1/5] mm: add PSI accounting around ->read_folio and ->readahead calls Christoph Hellwig
2022-09-10 11:34 ` Jens Axboe [this message]
2022-09-12 8:35 ` Christoph Hellwig
2022-09-10 18:26 ` Matthew Wilcox
2022-09-12 8:33 ` Christoph Hellwig
2022-09-14 11:41 ` Johannes Weiner
2022-09-10 6:50 ` [PATCH 2/5] sched/psi: export psi_memstall_{enter,leave} Christoph Hellwig
2022-09-14 11:42 ` Johannes Weiner
2022-09-10 6:50 ` [PATCH 3/5] btrfs: add manual PSI accounting for compressed reads Christoph Hellwig
2022-09-12 15:28 ` David Sterba
2022-09-14 11:46 ` Johannes Weiner
2022-09-10 6:50 ` [PATCH 4/5] erofs: add manual PSI accounting for the compressed address space Christoph Hellwig
2022-09-14 11:47 ` Johannes Weiner
2022-09-14 12:47 ` Gao Xiang
2022-09-10 6:50 ` [PATCH 5/5] block: remove PSI accounting from the bio layer Christoph Hellwig
2022-09-14 11:48 ` Johannes Weiner
2022-09-10 11:32 ` improve pagecache PSI annotations Jens Axboe
2022-09-15 9:41 improve pagecache PSI annotations v2 Christoph Hellwig
2022-09-15 9:41 ` [PATCH 1/5] mm: add PSI accounting around ->read_folio and ->readahead calls Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcabe527-7940-8658-1728-28d64bd3cf80@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox