From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C642FC35274 for ; Mon, 18 Dec 2023 11:25:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C8666B006E; Mon, 18 Dec 2023 06:25:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 129EE6B0075; Mon, 18 Dec 2023 06:25:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E99AE6B0078; Mon, 18 Dec 2023 06:25:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D416A6B006E for ; Mon, 18 Dec 2023 06:25:33 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id ABD511C0D10 for ; Mon, 18 Dec 2023 11:25:33 +0000 (UTC) X-FDA: 81579708546.14.61D6A62 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id EFD51C0015 for ; Mon, 18 Dec 2023 11:25:30 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="gZ6zcqR/"; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702898731; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ldc2f04tPQnL7mptFYAJQ0E8xfxLz+eKZoc7PtpvgL0=; b=6giBYMiAYXqWB0u9O7bnEHnnPHTQLKDSAoOU/XCppvT2A9OjEaHExpLRLPgSn5JX6Fvloa BeLC6QK0a96kdgGgda6AzxbNv8PuPGFPpPYlyY0JY0g12DsDhfmPlii6CHvltfkr+lGjNT 8gFndRciincUOBkYtl7H4jUARRQ91Ts= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="gZ6zcqR/"; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702898731; a=rsa-sha256; cv=none; b=zY/wDAJ9eWnSk3NcXgf511xtO5dkj1AqlaUlhOtG8MPSgH/RRn9QZKlmmHOuhQhuYU104Z YyzaA5pPfE6EUCnRTsenhwuSorCDau6EMHuiaXuMZc1a5u+C0ms3YfCTxwFVKK6eo73lE4 lVhiQ2zSqsshVjiM2WgV/qsnfY2aKCk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702898730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ldc2f04tPQnL7mptFYAJQ0E8xfxLz+eKZoc7PtpvgL0=; b=gZ6zcqR/cLxGCJyLMsYOdwTBmAsrGqb/yTBDVF2xNDerHoEuksGGatEIfgd2iWjToCSVbM FLPPxv1UBIK6GyXCMtf+4+PmTrDPKZ2cKtmXtEhmqs4mvFgG55dEbN41PgNRkAWGgVuIgR Vtp6iSuY+15trCPixz25cBzSZYv7HMg= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-210-IeEHZyYxPwSlJlbiQhSJNw-1; Mon, 18 Dec 2023 06:25:28 -0500 X-MC-Unique: IeEHZyYxPwSlJlbiQhSJNw-1 Received: by mail-il1-f197.google.com with SMTP id e9e14a558f8ab-35f49926297so51894955ab.3 for ; Mon, 18 Dec 2023 03:25:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702898728; x=1703503528; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ldc2f04tPQnL7mptFYAJQ0E8xfxLz+eKZoc7PtpvgL0=; b=vzEGmX8/Sj1/W+YQhNjeuNkEtjv0TsHY5ORRzrN7jieQolnEF97PNxosIb0FZpvuPN YSszLwNulRAtU/X5fY2CU/kmmpilUc7Vz/j28PAd4rVqAq9XEyETi8gnxJW1YXqWoZRQ arbCmb5+afXhcSLeNKgTle5UDkKc4b6Y+EbO7ICziU5JMAylrXg0OiDh4XpsPMkILb68 xAOK0vc7/xihRYIrHxKsvcp0qTT5a1X9/AYuocgpBNqPQC2plLw0Pgt0FDwMPGKGlZkL TweVKjrmf0yCbm8zwrYPj9BCU7BQcVgMps6q1RpPbdNLWe12MQnyf+nC12a9Z6jRmIEz dByg== X-Gm-Message-State: AOJu0YzTSxI1EGsSrL0FBVax8xQfYPGxUQwhzXEfNxvgGsRQ34DLw9+b 5HOtFqwCqb5+91076W780AoZ7NABfavtIdePGfp8U6oq0G5ZOINV64HW0ewKzLp+N4sspo2GfM8 Q+J9BV/awZUI= X-Received: by 2002:a05:6e02:148a:b0:35d:695a:d323 with SMTP id n10-20020a056e02148a00b0035d695ad323mr27097801ilk.70.1702898728017; Mon, 18 Dec 2023 03:25:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeie7lEw5N6j/3h4eqdlAkM0zcI6bCN54t1JVtwOxfjSPEpDnMO4wFZ4LAoaomtGqd8QaKnQ== X-Received: by 2002:a05:6e02:148a:b0:35d:695a:d323 with SMTP id n10-20020a056e02148a00b0035d695ad323mr27097787ilk.70.1702898727560; Mon, 18 Dec 2023 03:25:27 -0800 (PST) Received: from ?IPV6:2003:cb:c72b:b500:b53e:6e32:1408:27ac? (p200300cbc72bb500b53e6e32140827ac.dip0.t-ipconnect.de. [2003:cb:c72b:b500:b53e:6e32:1408:27ac]) by smtp.gmail.com with ESMTPSA id v28-20020a63151c000000b005c60cdb08f0sm17724802pgl.0.2023.12.18.03.25.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 03:25:27 -0800 (PST) Message-ID: Date: Mon, 18 Dec 2023 12:25:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/4] mm/ksm: add sysfs knobs for advisor To: Stefan Roesch , kernel-team@fb.com Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20231213182729.587081-1-shr@devkernel.io> <20231213182729.587081-3-shr@devkernel.io> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231213182729.587081-3-shr@devkernel.io> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EFD51C0015 X-Rspam-User: X-Stat-Signature: w8yfzzs9dpazs3b4f8cdc7sipn3kgyo7 X-Rspamd-Server: rspam01 X-HE-Tag: 1702898730-98101 X-HE-Meta: U2FsdGVkX18MKplvUkI/OWvSHwGEvKK5hYtl5aX8x1mLF+ohj05+SEGUBjeZZLmctDYURHC7zZpyGM5Maa6uZq725wkPNvlnpdzItAHsY3mxo2OsmV7Ybi8AwAZa7lPKnx2414xozutdk5coUmmabp3sTZyX/27+BIm0zrR8S5vg+wr4y+QnQyjPHIu5TgIfEJblWkR44dzFyQ1jhbj+4Tnxe+cGxXfSlnOqXU7C0wXF/44/xoqBQa8R7PX7wBYZ+u77KwIRVj4voZcCb3XgduTBOm/y6r+4r5Q+TNLRJZPiaY7Gw8tviaOHj0yaNY1a/EC05q2Ewhrvwjzc5RnMQgxCFW5ss1jyQnFEnaQAYkhpilT/Ng4HTvDIYlIMZS5Bta0I0j6HdRbaqcv3qxso/INI3lsiUt0MhBfvp4RXixUXTP2JVUSTBWBLKv0B0GPF2Bg+N2r29mNrUlgw0H5udRWotV9jIZGk9t70nyMLlphHCF25/klmAQZiIbiyfgMI4hi2w/TMvXrhbzXmFGh6fxGFaqP5WGY70huDM1w8yEXu36d7/m+QQ0XQ0bdO8gLQf9FwvJDWpetLuDeP1aij13hrskj9iH0dAfcMnAjNwxT1THbfhRJsV7vkpvWsfh5lFmboDea7vDHDOwo8TGZwmZBxLQ1rvKmQVkfJ302Ha5shFJD+Ku0Fy6RBLYXyN6G9pAYMbR0dqEHZqDm00bIvAoIruJveLObPLY8ysLxakGtZurMAPBC9NYFyWPX4Ln2XR/D6GmyVTGte0TI5NmlpxP0CAuIigFQXXYjQ+D0kdJEzmp/E7n6EwQLi5e7Oxoh9XWvo+G1hW5GHmYttQvGEaLwjfXlCq4+J3mhahPXhGjEfkCcpY8TFyBcA4H0EWwRfwrCio8GfUyimzGY0I3f6aJKlUegwxfbMybmHGdOLKL0n/qNbADQNDIQh63Y8J4zargvS5P1Pzx31+0bRyzf SYhb6mlm eU+Zbw7fTCkaslMZejl5Y0+Rr60CLVr84DzhHRH1u0tjzXiCqVdJB2YFtJiSC2hNz1Nqi6kZGru1HBbUIgl/0TJZUPgwjTXFDIPRFuyWK6FQg+8YFKfRAb4OygoX3r+rfHX5L9qsfFJXzUMkZSdkEpYk3RNhv22R0VjrVRkCPzbOiTSX/OvKlL7m+5/4ejnJ+ha82JPoNjbJnrPHJ5wdtbPt4SUsm4/Tf8QVMunEWQXbMrhOBzSXX72299bGtrK6VInddCCYEoys+YTruHQc5xSfF/FsgkLkJGIzqcRpmObQfVoM8I58kTNmGVL/wR0U+rNrZtZdIaqwK9jgrQys2aBCB7rc0EPGY/QbKgU2ZbMuhpMbtAbkuuWcglAa33ez/bpSf03Ol3kGLb4nJ5gWE3t26RLTZI+EgJmkFR5JgeWdBMUY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.12.23 19:27, Stefan Roesch wrote: > This adds four new knobs for the KSM advisor to influence its behaviour. > > The knobs are: > - advisor_mode: > none: no advisor (default) > scan-time: scan time advisor > - advisor_max_cpu: 70 (default, cpu usage percent) > - advisor_min_pages_to_scan: 500 (default) > - advisor_max_pages_to_scan: 30000 (default) > - advisor_target_scan_time: 200 (default in seconds) > > The new values will take effect on the next scan round. > > Signed-off-by: Stefan Roesch > --- > mm/ksm.c | 142 +++++++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 139 insertions(+), 3 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 4f7b71a1f3112..f7387a6d02050 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -302,10 +302,10 @@ unsigned long ksm_zero_pages; > static unsigned long ksm_pages_skipped; > > /* Don't scan more than max pages per batch. */ > -static unsigned long ksm_advisor_max_pages = 30000; > +static unsigned long ksm_advisor_max_pages_to_scan = 30000; > > /* At least scan this many pages per batch. */ > -static unsigned long ksm_advisor_min_pages = 500; > +static unsigned long ksm_advisor_min_pages_to_scan = 500; > That renaming should go into the previous patch. > /* Min CPU for scanning pages per scan */ > static unsigned int ksm_advisor_min_cpu = 10; > @@ -341,6 +341,16 @@ enum ksm_advisor_type { > }; > static enum ksm_advisor_type ksm_advisor; > > +static void set_advisor_defaults(void) > +{ > + if (ksm_advisor == KSM_ADVISOR_NONE) { > + ksm_thread_pages_to_scan = DEFAULT_PAGES_TO_SCAN; > + } else if (ksm_advisor == KSM_ADVISOR_SCAN_TIME) { > + advisor_ctx = (const struct advisor_ctx){ 0 }; > + ksm_thread_pages_to_scan = ksm_advisor_min_pages_to_scan; > + } > +} > + > static inline void advisor_start_scan(void) > { > if (ksm_advisor == KSM_ADVISOR_SCAN_TIME) > @@ -434,7 +444,7 @@ static void scan_time_advisor(void) > > pages = min(pages, per_page_cost * ksm_advisor_max_cpu); > pages = max(pages, per_page_cost * ksm_advisor_min_cpu); > - pages = min(pages, ksm_advisor_max_pages); > + pages = min(pages, ksm_advisor_max_pages_to_scan); > > /* Update advisor context */ > advisor_ctx.change = change; > @@ -3722,6 +3732,127 @@ static ssize_t smart_scan_store(struct kobject *kobj, > } > KSM_ATTR(smart_scan); > > +static ssize_t advisor_mode_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) > +{ > + const char *output; > + > + if (ksm_advisor == KSM_ADVISOR_NONE) > + output = "[none] scan-time"; > + else if (ksm_advisor == KSM_ADVISOR_SCAN_TIME) > + output = "none [scan-time]"; > + > + return sysfs_emit(buf, "%s\n", output); > +} > + > +static ssize_t advisor_mode_store(struct kobject *kobj, > + struct kobj_attribute *attr, const char *buf, > + size_t count) > +{ > + if (sysfs_streq("scan-time", buf)) > + ksm_advisor = KSM_ADVISOR_SCAN_TIME; > + else if (sysfs_streq("none", buf)) > + ksm_advisor = KSM_ADVISOR_NONE; > + else > + return -EINVAL; > + > + /* Set advisor default values */ > + set_advisor_defaults(); It probably makes sense to not reset the defaults if the ksm_advisor didn't change. Apart form that, LGTM. -- Cheers, David / dhildenb