From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 582F1C433E0 for ; Tue, 30 Jun 2020 01:05:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1B6772078D for ; Tue, 30 Jun 2020 01:05:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B6772078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8C12F6B009A; Mon, 29 Jun 2020 21:05:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 870FC6B009B; Mon, 29 Jun 2020 21:05:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 786326B009E; Mon, 29 Jun 2020 21:05:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 607386B009A for ; Mon, 29 Jun 2020 21:05:33 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B08641EF1 for ; Tue, 30 Jun 2020 01:05:32 +0000 (UTC) X-FDA: 76984085304.09.judge30_1d074ce26e73 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 869D9180AD80F for ; Tue, 30 Jun 2020 01:05:32 +0000 (UTC) X-HE-Tag: judge30_1d074ce26e73 X-Filterd-Recvd-Size: 3483 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 30 Jun 2020 01:05:31 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0AD2D1FB; Mon, 29 Jun 2020 18:05:31 -0700 (PDT) Received: from [10.163.84.101] (unknown [10.163.84.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 07D753F68F; Mon, 29 Jun 2020 18:05:26 -0700 (PDT) From: Anshuman Khandual Subject: Re: [PATCH V2] arm64/hugetlb: Reserve CMA areas for gigantic pages on 16K and 64K configs To: kernel test robot , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, robin.murphy@arm.com, Catalin Marinas , Will Deacon , Mark Rutland , Mike Kravetz , Barry Song , Andrew Morton References: <1593413107-12779-1-git-send-email-anshuman.khandual@arm.com> <202006291913.9GQyi7Go%lkp@intel.com> Message-ID: Date: Tue, 30 Jun 2020 06:35:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <202006291913.9GQyi7Go%lkp@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 869D9180AD80F X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/29/2020 04:38 PM, kernel test robot wrote: > Hi Anshuman, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on v5.8-rc3] > [also build test WARNING on next-20200629] > [cannot apply to arm64/for-next/core] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Anshuman-Khandual/arm64-hugetlb-Reserve-CMA-areas-for-gigantic-pages-on-16K-and-64K-configs/20200629-144736 > base: 9ebcfadb0610322ac537dd7aa5d9cbc2b2894c68 > config: arm64-defconfig (attached as .config) > compiler: aarch64-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > >>> arch/arm64/mm/hugetlbpage.c:40:13: warning: no previous prototype for 'arm64_hugetlb_cma_reserve' [-Wmissing-prototypes] > 40 | void __init arm64_hugetlb_cma_reserve(void) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ This only comes up with W=1 and I wonder if this is truly a valid warning. Should all non-static function needs to have a declaration in a header file ? In this case, there is a declaration for this function near the call site itself, why should not that be sufficient. #if defined(CONFIG_HUGETLB_PAGE) && defined(CONFIG_CMA) void arm64_hugetlb_cma_reserve(void); <--------- Declaration #else static inline void arm64_hugetlb_cma_reserve(void) { } #endif