From: Anshuman Khandual <anshuman.khandual@arm.com>
To: kernel test robot <lkp@intel.com>, linux-mm@kvack.org
Cc: kbuild-all@lists.01.org, robin.murphy@arm.com,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Barry Song <song.bao.hua@hisilicon.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH V2] arm64/hugetlb: Reserve CMA areas for gigantic pages on 16K and 64K configs
Date: Tue, 30 Jun 2020 06:35:14 +0530 [thread overview]
Message-ID: <bc923e0a-37c8-24b6-6a67-0ff205c001d1@arm.com> (raw)
In-Reply-To: <202006291913.9GQyi7Go%lkp@intel.com>
On 06/29/2020 04:38 PM, kernel test robot wrote:
> Hi Anshuman,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on v5.8-rc3]
> [also build test WARNING on next-20200629]
> [cannot apply to arm64/for-next/core]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Anshuman-Khandual/arm64-hugetlb-Reserve-CMA-areas-for-gigantic-pages-on-16K-and-64K-configs/20200629-144736
> base: 9ebcfadb0610322ac537dd7aa5d9cbc2b2894c68
> config: arm64-defconfig (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>>> arch/arm64/mm/hugetlbpage.c:40:13: warning: no previous prototype for 'arm64_hugetlb_cma_reserve' [-Wmissing-prototypes]
> 40 | void __init arm64_hugetlb_cma_reserve(void)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
This only comes up with W=1 and I wonder if this is truly a
valid warning. Should all non-static function needs to have
a declaration in a header file ? In this case, there is a
declaration for this function near the call site itself, why
should not that be sufficient.
#if defined(CONFIG_HUGETLB_PAGE) && defined(CONFIG_CMA)
void arm64_hugetlb_cma_reserve(void); <--------- Declaration
#else
static inline void arm64_hugetlb_cma_reserve(void)
{
}
#endif
next prev parent reply other threads:[~2020-06-30 1:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 6:45 Anshuman Khandual
2020-06-29 11:08 ` kernel test robot
2020-06-30 1:05 ` Anshuman Khandual [this message]
2020-07-02 4:51 ` [kbuild-all] " Xia, Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc923e0a-37c8-24b6-6a67-0ff205c001d1@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=mike.kravetz@oracle.com \
--cc=robin.murphy@arm.com \
--cc=song.bao.hua@hisilicon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox