From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E16D4C021B8 for ; Tue, 4 Mar 2025 10:04:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 577DC6B0085; Tue, 4 Mar 2025 05:04:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 527836B0089; Tue, 4 Mar 2025 05:04:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C8A86B008A; Tue, 4 Mar 2025 05:04:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 21DEE6B0085 for ; Tue, 4 Mar 2025 05:04:00 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C4130141980 for ; Tue, 4 Mar 2025 10:03:59 +0000 (UTC) X-FDA: 83183432598.27.3AE6E9C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf29.hostedemail.com (Postfix) with ESMTP id 466E6120016 for ; Tue, 4 Mar 2025 10:03:57 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fevk0FpW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="A/4EtMBJ"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fevk0FpW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="A/4EtMBJ"; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741082637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vdopM4wwSJn/cEXZWx2FfXqtlS3x8lYFpZOMNw5eYjw=; b=jOTo0NuDbiHpwEMEOT8BN6wuDGDMjO8nhEFXmCGRpj8LbfHkXxcXZzUn9mdYM4doJD+h3y kuKlvRSFw3NS9zkh5K3z/XiRr/G9ZRjNdaSZHpTGFq8zerp064nGr708IZsXYhSJUScq/+ DLKGP7ZRrMY5do3XZM46B6jbkdbWkOQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fevk0FpW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="A/4EtMBJ"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fevk0FpW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="A/4EtMBJ"; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741082637; a=rsa-sha256; cv=none; b=pUmAIhxGnSUky70BXW6UeWs5kot01D4lxY6xKtWcvANNPofxPXczdzXvEjgK4S1DOh0sKX 1fogK3DhAXrEmAnsKwxnTr0WlhvM6aXg7t72nkHwy1037Ky2fwGjHtV1oQ2O6wsvWxsQLg OgxdLvsj6Ubuxgi6+SzKosspw9GUefI= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 73F6D1F444; Tue, 4 Mar 2025 10:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741082635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vdopM4wwSJn/cEXZWx2FfXqtlS3x8lYFpZOMNw5eYjw=; b=fevk0FpWfZ83U0RvxcH2vGJYc6tCKYQoDqUJ7EQN43NDkD9/JAqfcKxxErCOY391TwngI/ ZcOHIpFZhNoo23NBob3QImzecWT125kED6dGhM16aqC0ttmbi8SafKKhZKOQVu7qCriXk7 hs5NplGSSFfh+fravMAJMnuSJvBwMzE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741082635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vdopM4wwSJn/cEXZWx2FfXqtlS3x8lYFpZOMNw5eYjw=; b=A/4EtMBJMqVV5k3BzlRmcgaJ7oNGGlg+SD0EuuBUyEKhN42sYjCZE4dD3bGIxd+Qmb2mP9 E7Xa90RD5J40/zDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741082635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vdopM4wwSJn/cEXZWx2FfXqtlS3x8lYFpZOMNw5eYjw=; b=fevk0FpWfZ83U0RvxcH2vGJYc6tCKYQoDqUJ7EQN43NDkD9/JAqfcKxxErCOY391TwngI/ ZcOHIpFZhNoo23NBob3QImzecWT125kED6dGhM16aqC0ttmbi8SafKKhZKOQVu7qCriXk7 hs5NplGSSFfh+fravMAJMnuSJvBwMzE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741082635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vdopM4wwSJn/cEXZWx2FfXqtlS3x8lYFpZOMNw5eYjw=; b=A/4EtMBJMqVV5k3BzlRmcgaJ7oNGGlg+SD0EuuBUyEKhN42sYjCZE4dD3bGIxd+Qmb2mP9 E7Xa90RD5J40/zDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 571CB13967; Tue, 4 Mar 2025 10:03:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id y7ilFAvQxmcSWgAAD6G6ig (envelope-from ); Tue, 04 Mar 2025 10:03:55 +0000 Message-ID: Date: Tue, 4 Mar 2025 11:03:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/slab: call __kmalloc_noprof() when size isn't builtin constant in kmalloc_array_noprof() Content-Language: en-US To: Harry Yoo , Ye Bin Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, linux-mm@kvack.org, yebin10@huawei.com References: <20250301083720.380063-1-yebin@huaweicloud.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 466E6120016 X-Stat-Signature: z68ouoanjszagnmsorwqtp9yysyn7i47 X-HE-Tag: 1741082637-229615 X-HE-Meta: U2FsdGVkX1+DkSt6hhdtsYcZS4p++XHMy1TO9bld7m0VFcV5l2d7XTc0xYNSW91ESLYOcb9ksfJk7/ISkF4x50R4jtB2UH4hOYqcVV7/QQKRMqGcxOFwXK8VWA8MgE3y14YEHh8BSMmFE2EMIGeuJ4Z0Mpg6P03ca5uQ2yWMVmvHMTrEIxJGEOtl4cEJMLUEfUDxZbzm8q0Amf10nzFPON40jfOOQ7sqrpoFKXR5XkUP+qQvuAiJ7fdnPsyVxBZ60+2WFr2mvctC+hr/hMygxqP0Bdh8F/Q3vz7wD7eyhnt8iPSquWeM2awE9mbbQW8eKMsU1L4Pd9CbBsn4T9ST85HJjOrd2e8SRtdvFcSXeLfPboeH5hX4NgCsCZlg1lPWvi29QhfDqkr8WXQC/Mffo02OkZCTXKmmEj+QoIgJy8rw0omj/nA6ZNTs7t49OtNJhKunQnbbYUJaD8MyIKG5YruuuFSrcWtlM9uRL/BGEQUdqyFE5pNnIlgUWGaVYT27LOnpEccWnC8h8w8AZVKZQGLtnKe8OCrHD0x9kyvufj07cnIKQFlyw/m9J1qMeEMlRPyEWcLwX/maLYitPd3sxyiXBOjORIIwUZcsH7U1FEc75EI1n/4wfeBYULy3gzsJEF7j+cvtv60Y43RAEo0qgdeG3+Xl3F4c7quzAj0wK9+AjPg0ZznCBHqxMnJLv9uAB1pbCCW2+S7LEJiGHbdZjtDNTWd4S6Pw7VEhzE5Yr0zIPYEcuvpRzei2LujCkRvlBVo7aMY3mZ9frD2fH2amvE4NMgNdY6XnWyoEVvvtGHl1TZMjR3NXTUMZT54PVnoa3IdejDf4C7zPz0D6hx+A+w/hvxCnoyC4B2rqLWfGhtbrk1aJcytK4SO2E2i7QOF+Tn0GH4ER3YuOrlqW57DBOWMmGepOuHatmnH1LXo/EFEVZDz15VN8EpDb5IPiIn0u1ZeMJzltQ1S0buHQcvZ Xh5JUCCm 1UzFxSGTNKow7m8vV+vgpohYJPZqsE/ysviZTf+UJ81hUrtg1vieEuOU8hRUfh/+JZ3Ke/IqTNW3xn8VZ82tIEmSj16pEElivnQJDAlK8WaPQJ/8TXU0JaGn3GvcGDXTvfzGqYLY14Bec1YMwkuGIl8QV3DFlZCarrozQ3jGw7n3a0SdJmgiVP0Y6nmQa6X2vX1qaBPhAe22mwTD31N97Nf2gnsHYMftiInb9oqDoRmUTa58+lzM6oCWDCJiOAJPRS8aR0984x6jGFGZRffi3pK8uCmn8jeQNiq3JwyrX8cFmKViKx8LC8/66YsHu/5C6dezt4fmrZ0llBdWG5qHMDFfDQOi+bNH3VS3GE40gkF7tIjfDFMC/zQimp/Z0nNmlm+cyB8dnqmavDPM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/2/25 14:30, Harry Yoo wrote: > On Sat, Mar 01, 2025 at 04:37:20PM +0800, Ye Bin wrote: >> From: Ye Bin >> >> If 'n' or 'size' isn't builtin constant just call __kmalloc_noprof() >> in kmalloc_array_noprof(). >> >> Fixes: 7bd230a26648 ("mm/slab: enable slab allocation tagging for kmalloc and friends") >> Signed-off-by: Ye Bin >> --- >> include/linux/slab.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/slab.h b/include/linux/slab.h >> index 3b03b31831a9..0edb8363fc4f 100644 >> --- a/include/linux/slab.h >> +++ b/include/linux/slab.h >> @@ -947,7 +947,7 @@ static inline __alloc_size(1, 2) void *kmalloc_array_noprof(size_t n, size_t siz >> return NULL; >> if (__builtin_constant_p(n) && __builtin_constant_p(size)) >> return kmalloc_noprof(bytes, flags); >> - return kmalloc_noprof(bytes, flags); >> + return __kmalloc_noprof(bytes, flags); > > Can we simply call kmalloc_noprof(bytes, flags) once instead? > > The compiler should know 'bytes' is a constant if both 'n' and 'size' are > constants. Right, applied like this, hope it's ok? commit a6553ee4b00ba4b1466a81fb00fa4679b7ce5339 (HEAD -> slab/for-6.15/fixes-cleanups) Author: Ye Bin Date: Sat Mar 1 16:37:20 2025 +0800 mm/slab: call kmalloc_noprof() unconditionally in kmalloc_array_noprof() If 'n' or 'size' isn't builtin constant, we used to call __kmalloc() before commit 7bd230a26648 ("mm/slab: enable slab allocation tagging for kmalloc and friends"), which inadvertedly changed both paths to kmalloc_noprof(). As Harry Yoo points out we can just call kmalloc_noprof() unconditionally. If the compiler knows n and size are constants it doesn't guarantee that bytes will be also seen as constant, and that is the important test in kmalloc_noprof() here, so we can just defer to it always. [ vbabka@suse.cz: change as Harry suggested and adjust commit log ] Fixes: 7bd230a26648 ("mm/slab: enable slab allocation tagging for kmalloc and friends") Signed-off-by: Ye Bin Signed-off-by: Vlastimil Babka diff --git a/include/linux/slab.h b/include/linux/slab.h index 09eedaecf120..ab05a143d09a 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -941,8 +941,6 @@ static inline __alloc_size(1, 2) void *kmalloc_array_noprof(size_t n, size_t siz if (unlikely(check_mul_overflow(n, size, &bytes))) return NULL; - if (__builtin_constant_p(n) && __builtin_constant_p(size)) - return kmalloc_noprof(bytes, flags); return kmalloc_noprof(bytes, flags); } #define kmalloc_array(...) alloc_hooks(kmalloc_array_noprof(__VA_ARGS__))