From: andrey.konovalov@linux.dev
To: Marco Elver <elver@google.com>, Alexander Potapenko <glider@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
kasan-dev@googlegroups.com, Evgenii Stepanov <eugenis@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrey Konovalov <andreyknvl@google.com>
Subject: [PATCH RFC 01/20] kasan: rename kasan_slab_free_mempool to kasan_mempool_poison_object
Date: Mon, 6 Nov 2023 21:10:10 +0100 [thread overview]
Message-ID: <bc70b448d766ef7f78a631d1fb6b98919f12b197.1699297309.git.andreyknvl@google.com> (raw)
In-Reply-To: <cover.1699297309.git.andreyknvl@google.com>
From: Andrey Konovalov <andreyknvl@google.com>
Rename kasan_slab_free_mempool to kasan_mempool_poison_object.
kasan_slab_free_mempool is a slightly confusing name: it is unclear
whether this function poisons the object when it is freed into mempool
or does something when the object is freed from mempool to the underlying
allocator.
The new name also aligns with other mempool-related KASAN hooks added in
the following patches in this series.
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
---
include/linux/kasan.h | 8 ++++----
io_uring/alloc_cache.h | 3 +--
mm/kasan/common.c | 4 ++--
mm/mempool.c | 2 +-
4 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/include/linux/kasan.h b/include/linux/kasan.h
index 72cb693b075b..6310435f528b 100644
--- a/include/linux/kasan.h
+++ b/include/linux/kasan.h
@@ -172,11 +172,11 @@ static __always_inline void kasan_kfree_large(void *ptr)
__kasan_kfree_large(ptr, _RET_IP_);
}
-void __kasan_slab_free_mempool(void *ptr, unsigned long ip);
-static __always_inline void kasan_slab_free_mempool(void *ptr)
+void __kasan_mempool_poison_object(void *ptr, unsigned long ip);
+static __always_inline void kasan_mempool_poison_object(void *ptr)
{
if (kasan_enabled())
- __kasan_slab_free_mempool(ptr, _RET_IP_);
+ __kasan_mempool_poison_object(ptr, _RET_IP_);
}
void * __must_check __kasan_slab_alloc(struct kmem_cache *s,
@@ -256,7 +256,7 @@ static inline bool kasan_slab_free(struct kmem_cache *s, void *object, bool init
return false;
}
static inline void kasan_kfree_large(void *ptr) {}
-static inline void kasan_slab_free_mempool(void *ptr) {}
+static inline void kasan_mempool_poison_object(void *ptr) {}
static inline void *kasan_slab_alloc(struct kmem_cache *s, void *object,
gfp_t flags, bool init)
{
diff --git a/io_uring/alloc_cache.h b/io_uring/alloc_cache.h
index 241245cb54a6..8de0414e8efe 100644
--- a/io_uring/alloc_cache.h
+++ b/io_uring/alloc_cache.h
@@ -16,8 +16,7 @@ static inline bool io_alloc_cache_put(struct io_alloc_cache *cache,
if (cache->nr_cached < cache->max_cached) {
cache->nr_cached++;
wq_stack_add_head(&entry->node, &cache->list);
- /* KASAN poisons object */
- kasan_slab_free_mempool(entry);
+ kasan_mempool_poison_object(entry);
return true;
}
return false;
diff --git a/mm/kasan/common.c b/mm/kasan/common.c
index 256930da578a..e42d6f349ae2 100644
--- a/mm/kasan/common.c
+++ b/mm/kasan/common.c
@@ -261,7 +261,7 @@ static inline bool ____kasan_kfree_large(void *ptr, unsigned long ip)
/*
* The object will be poisoned by kasan_poison_pages() or
- * kasan_slab_free_mempool().
+ * kasan_mempool_poison_object().
*/
return false;
@@ -272,7 +272,7 @@ void __kasan_kfree_large(void *ptr, unsigned long ip)
____kasan_kfree_large(ptr, ip);
}
-void __kasan_slab_free_mempool(void *ptr, unsigned long ip)
+void __kasan_mempool_poison_object(void *ptr, unsigned long ip)
{
struct folio *folio;
diff --git a/mm/mempool.c b/mm/mempool.c
index 734bcf5afbb7..768cb39dc5e2 100644
--- a/mm/mempool.c
+++ b/mm/mempool.c
@@ -107,7 +107,7 @@ static inline void poison_element(mempool_t *pool, void *element)
static __always_inline void kasan_poison_element(mempool_t *pool, void *element)
{
if (pool->alloc == mempool_alloc_slab || pool->alloc == mempool_kmalloc)
- kasan_slab_free_mempool(element);
+ kasan_mempool_poison_object(element);
else if (pool->alloc == mempool_alloc_pages)
kasan_poison_pages(element, (unsigned long)pool->pool_data,
false);
--
2.25.1
next prev parent reply other threads:[~2023-11-06 20:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 20:10 [PATCH RFC 00/20] kasan: save mempool stack traces andrey.konovalov
2023-11-06 20:10 ` andrey.konovalov [this message]
2023-11-06 20:10 ` [PATCH RFC 02/20] kasan: move kasan_mempool_poison_object andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 03/20] kasan: document kasan_mempool_poison_object andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 04/20] kasan: add return value for kasan_mempool_poison_object andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 05/20] kasan: introduce kasan_mempool_unpoison_object andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 06/20] kasan: introduce kasan_mempool_poison_pages andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 07/20] kasan: introduce kasan_mempool_unpoison_pages andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 08/20] kasan: clean up __kasan_mempool_poison_object andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 09/20] kasan: save free stack traces for slab mempools andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 10/20] kasan: clean up and rename ____kasan_kmalloc andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 11/20] kasan: introduce poison_kmalloc_large_redzone andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 12/20] kasan: save alloc stack traces for mempool andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 13/20] mempool: use new mempool KASAN hooks andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 14/20] mempool: introduce mempool_use_prealloc_only andrey.konovalov
2023-11-22 17:20 ` Marco Elver
2023-11-23 18:06 ` Andrey Konovalov
2023-11-23 18:47 ` Marco Elver
2023-11-06 20:10 ` [PATCH RFC 15/20] kasan: add mempool tests andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 16/20] kasan: rename pagealloc tests andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 17/20] kasan: reorder tests andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 18/20] kasan: rename and document kasan_(un)poison_object_data andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 19/20] skbuff: use mempool KASAN hooks andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 20/20] io_uring: use mempool KASAN hook andrey.konovalov
2023-11-22 17:13 ` [PATCH RFC 00/20] kasan: save mempool stack traces Marco Elver
2023-11-23 18:06 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc70b448d766ef7f78a631d1fb6b98919f12b197.1699297309.git.andreyknvl@google.com \
--to=andrey.konovalov@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox