From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C8CDCFA453 for ; Wed, 23 Oct 2024 17:15:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2316B6B0092; Wed, 23 Oct 2024 13:15:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E1526B0098; Wed, 23 Oct 2024 13:15:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05ACD6B009B; Wed, 23 Oct 2024 13:15:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DBCBE6B0092 for ; Wed, 23 Oct 2024 13:15:18 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EE8D8140994 for ; Wed, 23 Oct 2024 17:14:59 +0000 (UTC) X-FDA: 82705517580.11.5A7CBB1 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by imf13.hostedemail.com (Postfix) with ESMTP id 6FC482002A for ; Wed, 23 Oct 2024 17:14:57 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ko2Qejl5; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729703592; a=rsa-sha256; cv=none; b=Df/tuyC1U/cNB2hBITx6ywYjfqlbRK4Y6hX70/CZzPhVUESLkQcr2XC6WefJipzemVs02L dAV4WIjrDdXFlwdcPjcbHhzsh08F7DQhrDgnqL6LfQEXzI2AqlrZ2MVJEU1gTkmw88YMkf 5E9Yu1UcS9BF8cGPijmtCHnhJbwuMJ8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ko2Qejl5; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729703592; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nAf2Ckz4/Yrm14t037b7KvYIFfz3oZGUg3pwmXN8TRE=; b=1owHV8TFCxjAOHzkRd4I5IbKegdrd50px+9D3b/otHCd4UUFQ/7TjlsTltacV0SA9dF5fo /okg2ytYQ2tlS7TY3V5Nqcy/4UJriDnxTw7D/Mq5wld+AI235G/tpS0RnW8wUzV4tPQHVE IPPlGoAlMS1QraunzfFmjwN7re/pNeU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729703715; x=1761239715; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=zuyNVckBZ4DNK/TY1WDnCB7cAukgyN/LVjx4ft0olEc=; b=ko2Qejl5aRm383y2gy9IJWm1qp4qUvbbOJQ/xrzuNAe0v8woDlpZFbS3 uYBf0vjx02Ih46rhmN/zsT1tuw0MlXH0R19Ni/uE18X+R6lR5UX7kjBQp ivt0vHM8CXxVmT3ky9F3/LwPCI16wpUrLWeyMJd6dsb1icZXnxVLyMQzk frHQFCV2mpjHgbGkqX779zbWCBYSNsFBJFIs+VKxaijyS3Q8lLHWWRmgO 91rMZf4y9HdKMwdtztGp+BLit3yo6aU6E/+Bv8zkuAfvjHEx3hPgAgqe+ XjIqHhTIlC+DrdPQ3JwLIo3qdRTXNkVsg4LjS6Wce9F0aoDaYgJWB9Z+H g==; X-CSE-ConnectionGUID: NOvuKtKhTZW85Qs8PJe0fQ== X-CSE-MsgGUID: YoQ5vwA7S7i9fLSL05IaQQ== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="29466573" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="29466573" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2024 10:15:14 -0700 X-CSE-ConnectionGUID: 2KVAZG3NR9uacRkQ07F3qQ== X-CSE-MsgGUID: xpIrf6a1QUqugTaWv4DAVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,226,1725346800"; d="scan'208";a="79874170" Received: from rfrazer-mobl3.amr.corp.intel.com (HELO [10.124.221.6]) ([10.124.221.6]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2024 10:15:13 -0700 Message-ID: Date: Wed, 23 Oct 2024 10:15:12 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] x86/percpu: Cast -1 to argument type when comparing in percpu_add_op() To: "Christoph Lameter (Ampere)" Cc: Peter Zijlstra , Andy Shevchenko , Ingo Molnar , Uros Bizjak , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Dennis Zhou , Tejun Heo , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt References: <20240905170356.260300-1-andriy.shevchenko@linux.intel.com> <20241016192011.GY17263@noisy.programming.kicks-ass.net> <20241017181859.GB17263@noisy.programming.kicks-ass.net> <4b1a26b2-cccb-75d8-ee2f-f30ae211e598@gentwo.org> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <4b1a26b2-cccb-75d8-ee2f-f30ae211e598@gentwo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6FC482002A X-Stat-Signature: st9hnkdmfj1rgktwwxkfo13afk64ox13 X-Rspam-User: X-HE-Tag: 1729703697-946032 X-HE-Meta: U2FsdGVkX1+fj/KrsvOknMl5OP86GecVIbPWIcJ+pxymVuniXlqOKomhfUDIUQjH6bqhW7x/43EYcZkW3JB/g0zso3rhuCp9S/owB/Sue840Rkx78Pn80rdcUmiwkY+nQivuCq2y5izQrXUPLe95iPrMCk8I+lTrU/L88pzlbxTeVOsq9wj7AuClUXKPUk0Fq4wnaT/vFLoF9D1dq6APtroF8x53sNVScdZ6Ij6I/Yts8mnkjmB2lWBU+sWqHxFs3bcWQ/PQcvetoXcZQtuRURCUs0zeO+s3mTOzQbJWPVamxxPzKBbxdArrrV4FbYk6Nxps/jP1C+kJ6XKMPy1DrDIDRCew4I0bd1wA9OLFOwrju1V39EOyL85NeMmsciJiMFv16nWdwdleBYBgpIiFjtBus9UBa8/bL8mD7R7ZT15bC16TODQB80DHVQyh3KPQF3Ogotvw9d8s1c2/mxNlBgsehxGwXlOmRKv7zJYTCV8hOUnNydv0AnWJgJvHdF40vpjP4j9et7gf+6ur1fcqamvIy0Ed6OrUbUEK7cOVvSXBHKrzdk2tk3VTz8nZrxWh1u0WCVnssZcyIA2/zFjmNRrux7mpx55ifiuvZ0Bb1cdUshJU0jJ2iX90FjZxe1kDMcw8wOQKdHnC6YCMTAi8orxijLNocRQcUZe4OmoKWYyBcDjLlejbTeI117eldfPKotCCdKUWEOufXBlGtVZkM1wVfuZeAlNSpzJy8eCtRHgUHZCklxGBafZGrgsf/tj65Xh3PMu0zPXIGjOAguSB+wqmVyruEbMAe3mB0TWf7e+SVqOQ+KwEytwn1J7TfhwrnNF188eOzbMWc6qvQgwtYj2D0sgk1c6/0+mgoqQVTfvEGgedmCUiGDcDKoHbw50sY9rc3CcnFTgxt0vgLRF6pELqzNtS+mMoBSF5k5WhszT2hhCiSvsGe5PhBqE7Z08OH4Xe+i/SHCDrOQmhE5g mXLBc1h0 5OZGCjaY4IBA5SyQNoJ/Ll9mOZ5Rec9SXD9QbttXjY71irlfXXZ4G6YlgzbXbtxfLZn4hv5onToi9KmK8wDRk8tcQVaib/dlQLfP0i26XV0PBud7C3yNiwFUw1X8tt5k7tQDrTwlJ7iBn/WPM7ZNg/F10fFnENVjVKddEPwlNzP9dfLxafs00UKM0qbXpZn000x6iGupNXjZgwJ6UK2oHUZKnyYEjYUTYHBb/MTZV7ioPgXCdBkq4Skb8PFqIMqwvvpLs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/22/24 16:24, Christoph Lameter (Ampere) wrote: > On Tue, 22 Oct 2024, Dave Hansen wrote: > >> So I think Peter's version was the best. It shuts up clang and also >> preserves the existing (good) gcc 'sub' behavior. I'll send it out for >> real in a bit, but I'm thinking of something like the attached patch. > The desired behavior is a "dec". "sub" has a longer op code AFAICT. Gah, yes, of course. I misspoke. We want "inc" and "dec" for +1 and -1. "add" and "sub" are heftier and get used for everything else.