From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2AB4C43334 for ; Mon, 6 Jun 2022 04:20:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9B4B8D0002; Mon, 6 Jun 2022 00:20:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D52D98D0001; Mon, 6 Jun 2022 00:20:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0EFF8D0002; Mon, 6 Jun 2022 00:20:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AF36A8D0001 for ; Mon, 6 Jun 2022 00:20:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7ED6320505 for ; Mon, 6 Jun 2022 04:20:04 +0000 (UTC) X-FDA: 79546508328.26.EA1CBB7 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf26.hostedemail.com (Postfix) with ESMTP id 2B76214002C for ; Mon, 6 Jun 2022 04:19:59 +0000 (UTC) Received: by mail-qt1-f179.google.com with SMTP id hf10so9631821qtb.7 for ; Sun, 05 Jun 2022 21:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=mUDpDjKHlw04ecDTJy1YcGz6mZ4dDlGdFM8mMbI+Q/g=; b=GIj3P35xR57PKTSk4ZTEZCARXsfcbJ3MbXbKAXxDYMggSfPnDFuaDWpqizSQnwAmnB pqOZxSEri0Gge/VZv5cAmqSGRGzX/b1QkIKw87m2Cu/rMzFMUWWsAKks2B7LDnUIbUZP W1ARt3os5tzG5OxRWGRkLJ7R9ofG7p+Z9SsbvVlpfQJqAT4Gb5xB1tu7MUbfPkJ/2CDa 8QK/i53zXwnio1XDUgueM7aoFrzCwO4LxzrYWJYgBZXxtccZxJBN4r5s60ZFspQH++1W F+2bcFfSiUYI+HbIDL4kkAGqmE4HXDyWX4eSsqvxYEizacmWDaXP6xTyRlbDtozfdGmF 2bZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=mUDpDjKHlw04ecDTJy1YcGz6mZ4dDlGdFM8mMbI+Q/g=; b=jZyU8isiVCM/bTWWaLZWEbg83TqvwAVKMopwa0p9qQQEOBg7dtaMEJr7sMmJTXoRIC tgnuDshSN3SF1oIsraghELDDcqMlk4sSprP0tU1Akk3XHg2F1qj1K589u5EruXKUMakt 5w1wLSjpt4OfOCbt3U5cJgT6rU0Rp9LP5C347JJkfwwg9VnSBU0GTomIJx09zYALralR nxtg9JgZHtONMvl0HzR9LuJSxkf16TF306lvzR4Bsc4CKH7rg5fD2yWMhO+33pCr5Nf3 PbZmNrGRRooFWklyfKiOBUatKFKaA/9PZyzg47/e0APiY7mKHPUdx3R5wWrVWnNljjRA Jgag== X-Gm-Message-State: AOAM531kXdiKzQ+rd8eVb9HzqSIxjwKDcFY51SEZBmgPz1t23Zr0BI4N LVlAgb6DhKw2oRV/1cpD2Iqf9A== X-Google-Smtp-Source: ABdhPJwj8+ocTDAD/HiagwWcIXCHTKeeZm1CBi9/WN3i86qmNo6EF7kg9H2C5AJuyU2E4ygONDfaZA== X-Received: by 2002:ac8:5fd0:0:b0:304:bd3d:d129 with SMTP id k16-20020ac85fd0000000b00304bd3dd129mr17181074qta.685.1654489202951; Sun, 05 Jun 2022 21:20:02 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id bl17-20020a05620a1a9100b006a693056b0dsm7895096qkb.94.2022.06.05.21.20.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 21:20:01 -0700 (PDT) Date: Sun, 5 Jun 2022 21:19:49 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Chen Wandun cc: hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org, david@redhat.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v3 1/3] mm/shmem: check return value of shmem_init_inodecache In-Reply-To: <20220606034530.153505-2-chenwandun@huawei.com> Message-ID: References: <20220606034530.153505-1-chenwandun@huawei.com> <20220606034530.153505-2-chenwandun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=GIj3P35x; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of hughd@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=hughd@google.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2B76214002C X-Stat-Signature: 8bodtjkw7anizoi8hwn67dziczycad1f X-HE-Tag: 1654489199-926481 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 6 Jun 2022, Chen Wandun wrote: > It will result in null pointer access if shmem_init_inodecache fail, > so check return value of shmem_init_inodecache > > Signed-off-by: Chen Wandun Thank you, but NAK. It's a pity that you've been put to the trouble of sending a v3, sorry about that: but if SLAB_PANIC no longer works, or panic() has taken to returning, then that's what needs fixing, not shmem_init_inodecache(). Was this one supposed to be the bugfix? And I'm afraid I don't care for your "cleanups" in 2/3 and 3/3 either: a matter of taste, and our tastes differ. I'd rather not spend the time on these: maybe look for somewhere else to change around than mm/shmem.c? Or better, please help us all by using your time to review the functional patches being posted. Thanks, Hugh > --- > mm/shmem.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 12d45a03f7fc..7419ab219b97 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3775,11 +3775,16 @@ static void shmem_init_inode(void *foo) > inode_init_once(&info->vfs_inode); > } > > -static void shmem_init_inodecache(void) > +static int shmem_init_inodecache(void) > { > shmem_inode_cachep = kmem_cache_create("shmem_inode_cache", > sizeof(struct shmem_inode_info), > 0, SLAB_PANIC|SLAB_ACCOUNT, shmem_init_inode); > + > + if (!shmem_inode_cachep) > + return -ENOMEM; > + > + return 0; > } > > static void shmem_destroy_inodecache(void) > @@ -3923,7 +3928,9 @@ void __init shmem_init(void) > { > int error; > > - shmem_init_inodecache(); > + error = shmem_init_inodecache(); > + if (error) > + goto out2; > > error = register_filesystem(&shmem_fs_type); > if (error) { > -- > 2.25.1