From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F99C77B60 for ; Fri, 28 Apr 2023 15:27:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 897BD6B0072; Fri, 28 Apr 2023 11:27:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86F3A6B007B; Fri, 28 Apr 2023 11:27:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 736396B007D; Fri, 28 Apr 2023 11:27:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 64C636B0072 for ; Fri, 28 Apr 2023 11:27:07 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 12D2412022B for ; Fri, 28 Apr 2023 15:27:07 +0000 (UTC) X-FDA: 80731178094.10.91B1A0C Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf02.hostedemail.com (Postfix) with ESMTP id 2B28280008 for ; Fri, 28 Apr 2023 15:27:04 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=cdp7XfgA; spf=pass (imf02.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682695625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O2zx0Pesg+Vyas6wuwmYRVG5JjnsY56E7pVRSXIfHE4=; b=J8J3/jL72GfAqklgEPU/wE/2nPzHOjL47gE9DTxgGyZ87C8iq0H9iJe4vdy57jxad1S0Ao wk3ze99fmR8ri4T+0tuhsdWUMPxrPc4+c8K+H9dX3rhYEf8yae7PtErqqjsRZCIKh4AX0w OQfj+kpsb01rYmZtPabbOL7L+wRmEEE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=cdp7XfgA; spf=pass (imf02.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682695625; a=rsa-sha256; cv=none; b=EsGO0BCmPoUBW4JPpqairpY12cXHMVDzHIiEVcMa3xi1V6eel5gEErfJypRdCD9hvmdCpB Gsn6awzhWNQx6JXJbETb3NpCkYTJcgJi/oHdtZZP1QHoMw3Aacm/iKDjzXVHH46wfrBVgf 3TkMvOt2GaKxdgpW/m40rvLRK1SeDnc= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-3f09b4a156eso68644405e9.3 for ; Fri, 28 Apr 2023 08:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682695624; x=1685287624; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O2zx0Pesg+Vyas6wuwmYRVG5JjnsY56E7pVRSXIfHE4=; b=cdp7XfgABc/7D5mxfnUCjUF0HKES7kslOgk0gehVyS8aZJNmbLfd8aMFSQG2SgfPE0 f4+/JCIBoAnMs628TMkTgL6NQdon+VF2sM5oZdOR7/njJt9HEIk0BLunTR72M7ainHZA +begVfnI9mxJZxl960pRhjm2TgVata9tJhY1fftnl6EIw7qKoJBmLdIliklKbmJ0j2NX HG/xfiwoc5+S0mBpe5ho1I7xHLVq1VdsGCu789DMI2VsFh+le0wQNfATrGg94Z2FXTBV rDOC9YmII3SElQi2zR4vcfSaASYMS6KGlGiqEkeSaV6XbeeXWchGt5CZAygJxgqgMGks hHLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682695624; x=1685287624; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O2zx0Pesg+Vyas6wuwmYRVG5JjnsY56E7pVRSXIfHE4=; b=gheaILJKp2olPQfHMRE4K7jLlq5B4qbwEQD2s7ZY/zKBUzlVtX99zPri6s4kTIohcZ 5MUcFOKmTJUSv8ClS6w2R+4czQjAJzhnRAJtchFIB+6+uh5TAc7F07cpcAYEEX0myEWJ ZDRptK3zlBnCRxl6LrvzbcFLdb77EahlDoM7/QkeT6a6jBaeFjqAqpuOV6DFu9Ok8bNP Q2lVqNZuHfB4lwvWQ1cReQOn09Id2W6c/yKOqTjvCMT8qj4RwoxTvCKD2GUTjchI7s0p DT5k88K1KlZYF8XiKLKw9qdZWi4gUM62t9wdKDvwRCm2uPuSMOyARhs87Q0XMGwwo26X NGdA== X-Gm-Message-State: AC+VfDwfI+guo3QsxdEY2VEE64pifBIW4HpWKhS1ykt962DzEtCc8vEQ mTSvDY895odyRSVel0hnjQs= X-Google-Smtp-Source: ACHHUZ4nSeV5pmY8DEQTUOIP6WqtDBNgputeVkyz0n11mhByJU3H9BsMsl6n5qNSHIJkkV7VxKIDNw== X-Received: by 2002:a05:600c:21d8:b0:3f1:8af9:55bd with SMTP id x24-20020a05600c21d800b003f18af955bdmr4712888wmj.26.1682695623736; Fri, 28 Apr 2023 08:27:03 -0700 (PDT) Received: from localhost (host86-156-84-164.range86-156.btcentralplus.com. [86.156.84.164]) by smtp.gmail.com with ESMTPSA id gw19-20020a05600c851300b003ef5bb63f13sm18359888wmb.10.2023.04.28.08.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 08:27:02 -0700 (PDT) Date: Fri, 28 Apr 2023 16:27:02 +0100 From: Lorenzo Stoakes To: Jens Axboe Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Jason Gunthorpe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , Jason Gunthorpe , John Hubbard , Jan Kara , "Kirill A . Shutemov" , Pavel Begunkov , Mika Penttila , David Howells , Christoph Hellwig Subject: Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings by default Message-ID: References: <6b73e692c2929dc4613af711bdf92e2ec1956a66.1682638385.git.lstoakes@gmail.com> <447d0270-9c0e-23f4-3c62-33c3eff325af@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <447d0270-9c0e-23f4-3c62-33c3eff325af@kernel.dk> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2B28280008 X-Stat-Signature: e8pi4eunkn7pen9ai7iadu317fzqjtee X-HE-Tag: 1682695624-771525 X-HE-Meta: U2FsdGVkX19FhjHXXtEhGVXfop5anICAJEm+9VHGdMi1tXSxTKHcURIMKU+ZQNgaOrJKb3gwyXFTcnDqJY8VBCBFOwZuRKdPGIfSjgxflRQglM+22ahDpcW38w/NQElOPhfH03FtmHOU+xi61KF1qW5wple4J4FGdfoHQpmKnz4im/x/EwNYg41+cKCtoS5EkTNShgJmf3zzBqFiBRNEpqjKtXM8kgmbFUPExYEvg0OeXU/gTNHaG/7/sG+XTDUsXS1ieCzxpGKpxK68iMQhmAu6gbD3pUsBQvNbiE4TSbN6//JJ/kudesviiCjQ6dxeEBCQCHy88qyc6j7JcAhb4f3a22PbAYrFwT2A1B69LR1X6Z6Vhfj875sEH/0MHCtibREBaKf4P/u6rUHyYp6Sten5OZV7FRLD+Ldu7syJSKszzbT+p/6rIKpBgcJvFOIo1VShFTm7LJvRI6Ba7JuERuQ2XhQC7JOsUfTMgPmVJyT37Dx2kb20WSqTOq+Pj63sf60CthAHz7Rt63BPWZt6JM6I8c3IRTUUq+/LLQhO35NgSAdajoZH7XYWOzZwUoapkb2sR8NN69F642Hanz+1f0evRTAC8TSDw/rgQuPRCTzp0iw8zOlJhPGWV/6Jttv8iJK9n3HuwWMe/tsGzJROGHG0klYYznWTDnBEbzCBZs57nk/BANsfwMHp0GKTeYgwf72/Ggzh9I68ph3JpAXcD2taIFmfmuHk0pP59cm2v59BYmDcrqc36IE2c60g7rkWT+NOF9EZVm2RITMpT0f2Jf1dWvseJdQAnplWIsQkfdqC8mPRbgekn2Zf65SNmy7BuMXLEEKSU5OCwBvJzuEmSd6CsBvDFVsanH+vAs9KfgF66yH5VqwEX4OOuJUc2WfX6HW2rBoD07+NrtWQd8hl4LRdopl04SUP40PxBhCBoZ9eTtc+EKDIq5AsalSX6LGaAj2ZrjuEJWHqil2TTVO eNAYmA7f fjymkGc+9X0VQQsZ35kggS2XpBOTfB4ZaXKvzBTKLi3OGeuekLRnR+oFjeIA9HCyRJIbqBGam+R62CCvMsm8KPv+YIZy57wk4fgfFiahDUkTbi5UXfTTtjPOlZGhP9f9y+ri61+Y4L6tTFxoXLb+Ad4hA9RpUwDYeDldND246zWlJbYqCcS2JDPlOGNnwhM4RmR1CMr6rOwP3Ete1ikUWg7+ofeEGcjfU/cFwGnY6RBcCOHLGxBI5GccCs2P2wB0uuWEfXpH9ru823PqtDUuBxZC1gRDQS2RpLQShuvX6U/aZSmQ12XMdn0y5rh9Cl9ucYOQdG8+u4WgDPTlFkTgnes0L4Gm5pBGWwxCL5NSJtU5CX3e5uQg1YhQbyVkcXvpXgW4UNy6+Pb5Ya+SKjCmUz1yq5x2QWzmq7/38pHbdOsctcJxfigoaKklnbU5mSaZO10+DGPQLWJeKRiw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 28, 2023 at 09:15:08AM -0600, Jens Axboe wrote: > On 4/28/23 9:13?AM, David Hildenbrand wrote: > >>> I know, Jason und John will disagree, but I don't think we want to be very > >>> careful with changing the default. > >>> > >>> Sure, we could warn, or convert individual users using a flag (io_uring). > >>> But maybe we should invest more energy on a fix? > >> > >> This is proactively blocking a cleanup (eliminating vmas) that I believe > >> will be useful in moving things forward. I am not against an opt-in option > >> (I have been responding to community feedback in adapting my approach), > >> which is the way I implemented it all the way back then :) > > > > There are alternatives: just use a flag as Jason initially suggested > > and use that in io_uring code. Then, you can also bail out on the > > GUP-fast path as "cannot support it right now, never do GUP-fast". > > Since I've seen this brougth up a few times, what's the issue on the > io_uring side? We already dropped the special vma checking, it's in -git > right. Hence I don't believe there are any special cases left for > io_uring at all, and we certainly don't allow real file backings either, > never have done. The purpose from my perspective is being able to have GUP perform the 'is the file-backed mapping sane to GUP' check rather than you having to open code it. There is nothing special beyond that. Personally I think the best solution is an opt-in FOLL_SAFE_WRITE_FILE flag or such that you call and drop the vma check you have. That way we don't risk breaking anything, the vmas patch series can unblock, and you don't have to have raw mm code in your bit :) > > -- > Jens Axboe >