From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5FA2F01836 for ; Fri, 6 Mar 2026 13:16:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E2CE6B008C; Fri, 6 Mar 2026 08:16:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BA5D6B0092; Fri, 6 Mar 2026 08:16:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28EB26B0093; Fri, 6 Mar 2026 08:16:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1A83A6B008C for ; Fri, 6 Mar 2026 08:16:54 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BB0ED1C763 for ; Fri, 6 Mar 2026 13:16:53 +0000 (UTC) X-FDA: 84515688306.10.E4CED1B Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf28.hostedemail.com (Postfix) with ESMTP id EE45AC0003 for ; Fri, 6 Mar 2026 13:16:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iIIEqtJ3; spf=pass (imf28.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1772803012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D/KbYbH7145k5H6ul3BXhxYr3QJZdY2mM5sRTOfoVHs=; b=4OuhjdPYKRWj0+N2DmKr+5zMBmcDin+NjE8uReC29tBsGESwBtitxH8q3Ana4tlh6bXRxA ILIQtFg/a5SstGP4U0SDwEinz4lLHXmNRnozjZJqbPnHn3K6WQuZVI5YK69XqcRwa2pobF WjDjKHWbySXSX7qaHIrpWyOxEZUEBHI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iIIEqtJ3; spf=pass (imf28.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1772803012; a=rsa-sha256; cv=none; b=hKdoVGFKsIPEMq7HiZ/OWEKQ0p+Pqvx/5hke/jZyu0NJ8QqI3fzda631qLGS0tFbzXhurk MezBFv9nwRSw5uPSNuwB14fxxxkUTp2AiI6hbZ/MoOJfkmyY3lR5gh0yoTITysNVmfY1mK Xf1jqONmY1iA7VGSvOKweddW+nptxIw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id A15F74414E; Fri, 6 Mar 2026 13:16:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6669FC2BC86; Fri, 6 Mar 2026 13:16:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772803010; bh=1s6QLN/ghCrLJXZlKMxpYlFZehpnA7MCuk3K8EQdMlY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iIIEqtJ3tRMZ/QwYlyeMDf3S9PjzkVQkuz2ZOMvO4eTfkXzL8qKoudLNUlR5NEwQD 8FNqliqMzEOtiPWm6TIg7UUBnmrYObcaHyEepfOoLaAtXjffktNCOYCvabXVOP1m8L WJWa/LFj2mYn+sTemJgm9xHc/mm1r4dw2qOUR4BC6BQDtNsfRS2HCk7BhPy2gHFDrM CKBuhXifw+SCwzUcqO1D7W/TEfS/I5MBdPyFBT1LQbyQbzFAGTL26JGaPzs1Dl7ZPx ban9iQy4V/ZbzDBUMQy/CEPCUCXZ2WyARWnTuLMg+eRLJIQUk3cWU2Qe3v1kpB6X3N pJOexzVCg18Yg== Message-ID: Date: Fri, 6 Mar 2026 14:16:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 11/16] mm/memory: inline unmap_page_range() into __zap_vma_range() To: "Lorenzo Stoakes (Oracle)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Alice Ryhl , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-12-david@kernel.org> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EE45AC0003 X-Stat-Signature: i3w449g1w76ij8ixtn5a4wuqbrihu6pr X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1772803011-574574 X-HE-Meta: U2FsdGVkX1/dUxteUddd90E6yKisEIo7Dq8PZqqHJ7Fok7XSLo9Bx10TGmN1KmQlb0B91Fv6iM8EM4DGAvGbU8zun5DrCXYXjbome1Q8KtX/6inIX9TN5x1K5F1bsFEkqZZzNl3uO+jQ3n3HlFnfX5ifOZFJzY2dw99QDlP5QTJWP74/IambWS7IAHczFQytLYOFihBblX+VTcogO5i+hA5ye8b/l7gJhrpRAcTcH1oAy4nHCygfpkjdzm0YUL9EaMrfMSSD40a5Vpl5VtEr9OZuvT514vszMQzs/I8P+H/eiLu4Z8Nn9sarXs+4+ka9do/Q0nzALZ6GnV03DDyb8KtfkrHy0W3hHtt3fWVU28DoeSvUycAzgl21aU4djtJjKpTx38G9/IrCJczGm+wMeG5HlYrvo+yateLi4rAevTjn7IFg+/BYLS5jpoJemxLWLutbD3NTrowBkSslqMi9mXM8fOqDUHlqgdMGvoKmIRLV8fRyF55K6cWTk9GypdGpIj3iXJMN4BCXTvKHy6J+1oLFnsOo+pSbx11Xj5HAllKK6WuTI/YAD/Ue7c43fRaJGXH8ajSO48eUYh8b6XQSVuSvNDC0B7c/DnnIj9iFfdyaVOBn42qxbwcXe5Qe4C2O98/BVT4ZR3pOPDPSF9qkXUQTZLbXUaeOjq/JBppoyGcnRGtStcZj8G6w+NKGg2b3Vh9tg0tomQyofQGIAAa+C+dYjZkkX6P6kBzXkh9V7v9AgmzKDCdGcU25jMO47P5ZnQc4KFmpt+3UqFQhw4K7fiRuJtRbFDHu/gT34pREMsx6+pq0N8VB8+IyViO6v8dLYcu4EasHdO1ofD0zjdQLnH0P+gDc8P9xn60tVuwVZLOfX9ghiarNKhVCM4tdjdpSkHHAPzmo2uu6hwuXbSoHslGgFU4jVaTcJi5BjSl4QNdA7tNopNZtRqCstCuVkpo1BbbaAd9AQRWZmCAVZ9P 5BtEw0Z8 XnquU8CeUnR1xYJOV6iFVQFfErosmwGxUzs/+yXtgCJ9aCruya2Q5mDPROCCENp43LZwSdHBOZoTOhzNxUmRv1fvuwTtGUPgsP3jOipBJiXTzynBmZVdT0x2cP62dL01qYaLhcCtJIuGtcnnPaREaVI+yhgxiFlc3u7qzZYUpVmdJ3qySDdouvkug0L6AMx+JsiPQaJzmkXJDk+xa0ZXRuoGHzrekdhYfRnvBqr8k7i6OUdSP7ugNvSXgP9WXGzE9MmzXzYSHM6GKuyz8UJM5zwJcu1oJMURqqkvM Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/6/26 13:29, Lorenzo Stoakes (Oracle) wrote: > On Fri, Feb 27, 2026 at 09:08:42PM +0100, David Hildenbrand (Arm) wrote: >> Let's inline it into the single caller to reduce the number of confusing >> unmap/zap helpers. >> >> Get rid of the unnecessary BUG_ON(). >> >> Signed-off-by: David Hildenbrand (Arm) > > Small nits below, but overall LGTM so: > > Reviewed-by: Lorenzo Stoakes (Oracle) > >> --- >> mm/memory.c | 32 ++++++++++++-------------------- >> 1 file changed, 12 insertions(+), 20 deletions(-) >> >> diff --git a/mm/memory.c b/mm/memory.c >> index 394b2e931974..1c0bcdfc73b7 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -2056,25 +2056,6 @@ static inline unsigned long zap_p4d_range(struct mmu_gather *tlb, >> return addr; >> } >> >> -static void unmap_page_range(struct mmu_gather *tlb, struct vm_area_struct *vma, >> - unsigned long addr, unsigned long end, >> - struct zap_details *details) >> -{ >> - pgd_t *pgd; >> - unsigned long next; >> - >> - BUG_ON(addr >= end); >> - tlb_start_vma(tlb, vma); >> - pgd = pgd_offset(vma->vm_mm, addr); >> - do { >> - next = pgd_addr_end(addr, end); >> - if (pgd_none_or_clear_bad(pgd)) >> - continue; >> - next = zap_p4d_range(tlb, vma, pgd, addr, next, details); >> - } while (pgd++, addr = next, addr != end); >> - tlb_end_vma(tlb, vma); >> -} >> - >> static void __zap_vma_range(struct mmu_gather *tlb, struct vm_area_struct *vma, >> unsigned long start, unsigned long end, >> struct zap_details *details) >> @@ -2100,7 +2081,18 @@ static void __zap_vma_range(struct mmu_gather *tlb, struct vm_area_struct *vma, >> return; >> __unmap_hugepage_range(tlb, vma, start, end, NULL, zap_flags); >> } else { >> - unmap_page_range(tlb, vma, start, end, details); >> + unsigned long next, cur = start; > > VERY nitty, but generally current is abbreviated to curr not cur. > The following might not be fully expressive (but simple to grep): $ git grep "cur_" | wc -l 24261 $ git grep "curr_" | wc -l 9288 Tells me that "cur" is rather common. > It's not a big deal, but why not addr? Good question, I can just do that. :) -- Cheers, David