From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E76B2C7EE23 for ; Tue, 30 May 2023 15:14:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A4AE900003; Tue, 30 May 2023 11:14:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 753C4900002; Tue, 30 May 2023 11:14:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61BA5900003; Tue, 30 May 2023 11:14:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 56B73900002 for ; Tue, 30 May 2023 11:14:53 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2B40E1C7016 for ; Tue, 30 May 2023 15:14:53 +0000 (UTC) X-FDA: 80847268866.02.AD95CEB Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf06.hostedemail.com (Postfix) with ESMTP id A5F6D180015 for ; Tue, 30 May 2023 15:14:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=xOkOoj4c; dmarc=none; spf=pass (imf06.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.47 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685459690; a=rsa-sha256; cv=none; b=hxzUTk4jOM60Izg+/Zy79SYzLQ+KvOZOPIeoiAwrptbdmEoL2wYq7N5AmDUHmGEXEOOCPY jLlFpQTnvR700XvYEDR0NvJm01HSQcRQae3HCI+ByeImzMHC5o5CCBSwLmFczJso2ETFWV M3HYOol8Z+HU62IPbs+q/Sxqmu6Lu0g= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=xOkOoj4c; dmarc=none; spf=pass (imf06.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.47 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685459690; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tp/ySIwwm4tl/YIed7+PvRfuzdgg1UhCSe2CIK+Ly+s=; b=LkynlFCNRENJNw8R/v7+WylxyqghX3ZKmAJhXANFyv9t6xokRbu3DO8xgmBSDNQ2sNNczm H2Xm9zfpWcMCRXMRUaBuR5YrtIWJgoAt9nHoiqcvOcm/CVErbKYH5oN8I71cbSXqdApUZB fLsSYwh11yCX/9xsJF6uoEnw1YMiNk0= Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-760dff4b701so23852039f.0 for ; Tue, 30 May 2023 08:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1685459689; x=1688051689; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tp/ySIwwm4tl/YIed7+PvRfuzdgg1UhCSe2CIK+Ly+s=; b=xOkOoj4cDaSXirzk4uIboFQnwwINYWkE41mSD75bBat4nxEXJuipsA9ArGyo2UeBqx Kq9+mAB55iKthDhGAImEFsxB+rRsmEMgs6FpMVpSTjHfjf+dcWciLu166pMGZmx0Cbom D2CnJp0JOlcSk+AtYAprigutEBdADB/JeK1MfqKHq6SU5zjqHVQvSYnJ/tZe15ZHCmZw obheJiX+2Ze0w6gCDga10r1butszL/v1bdNLsPQJxdDk5hqhOOPZOPc/F51qTRMTFSK9 BVTLgTLAJU3vvbHG1HC9noz2HJsQ7wD6E5CGkvfADErM+d/V4AMklilsjXurfBo7Qg1G 9ITg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685459689; x=1688051689; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tp/ySIwwm4tl/YIed7+PvRfuzdgg1UhCSe2CIK+Ly+s=; b=a57ybZoTKUtj1PjwPRBy6PZOBpw4GUlOjbUBvTpQVo64rctPKvF754zf+oa2B4gCBi SpU6tWuP16vjalwSXB5XrtIzOAjRUOvGoobAlSgzKRubWatp29MnemtMN837Odwp5CHx EwUbZHxBHU+T2rbUeWAqYLE31O8y/hy2+wG/e0j/bRLkfMtTB9C2sodVJk5WzrMN+Q6l MTRWbm8CZd02ThKH5yqcuB8nkPh1ySlkVZ+ekfPigfHVDM5BwP1Pocw8q9q8bgNqH7Y4 YHVBYY8bT0mmuhAd2TgBsZMsQTsb0vSx7upych0NsHgFG746fkn4arrv7/LeI69t6Flv SRXQ== X-Gm-Message-State: AC+VfDyDBvG6D5O2+9la86xOeip/rr3c4MHAOVIjT4EcBUhtnZW9rWVM IKVhC9OBff7+COY4se2bgtXc9A== X-Google-Smtp-Source: ACHHUZ5N9fZwp0C4udilf2wbvP/vXNdHUtnkR6kuIJ7hXoCHV8PblKq9G6f5VgAxs1O6gmhEp8JA/Q== X-Received: by 2002:a05:6e02:ef3:b0:33b:85f4:2edf with SMTP id j19-20020a056e020ef300b0033b85f42edfmr1197714ilk.1.1685459689656; Tue, 30 May 2023 08:14:49 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id i9-20020a056e02054900b00325df6679a7sm2575003ils.26.2023.05.30.08.14.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 08:14:47 -0700 (PDT) Message-ID: Date: Tue, 30 May 2023 09:14:46 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5 00/20] bio: check return values of bio_add_page Content-Language: en-US To: Johannes Thumshirn , "dm-devel@redhat.com" , "snitzer@kernel.org" Cc: "agruenba@redhat.com" , "cluster-devel@redhat.com" , Damien Le Moal , "hare@suse.de" , "hch@lst.de" , "jfs-discussion@lists.sourceforge.net" , "kch@nvidia.com" , "linux-block@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-raid@vger.kernel.org" , "ming.lei@redhat.com" , "rpeterso@redhat.com" , "shaggy@kernel.org" , "song@kernel.org" , "willy@infradead.org" References: <20230502101934.24901-1-johannes.thumshirn@wdc.com> <3235f123-0638-b39f-f902-426059b87f81@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A5F6D180015 X-Stat-Signature: q13knrd3hwccxqjj3y5ptqxmoy48ct7z X-HE-Tag: 1685459690-788497 X-HE-Meta: U2FsdGVkX18PQoA/93nto9g6vX3WnkrHMBzl4gRQ46SEY/ZxVNQPLTlaHZ1Ndmtnum2Sd3tr0skKeR9UpMca71SEn4ihWj14E8jXEBPizxg05h7B8UI2dAdkoeKBKCNjuG929674/jddoqXk33pVaA79hFVace1fFk4/rsWgOTGqEZ2uJYocQR5euvB6+lXEp8KckvNtGBAGrMzeEw/xH56BNJ5bvMKW9J71X6DUHquE2ZjLbfF4HRSPIiAFn4k9MIUFW85T9KbkFqtiSzd95xuj6geqZO10yuxSMWiVVDdbs4JfGrMRAGk3AxTSYGcTWMr+3tsF8fK4KOg4z/b1Ae3ffhD8WqnxJ4d4wx11gbPuyg8i/mzwG4vd8oFIJgKcfODnb7zizdoMIY5Bn7CL1pBRsp9MkXNGUTtN7nJ3hrVcwfTXj7v1KZ4T+tAF86/C8gVNg5YTFECjf9JWOJEcYhgzBQB+8FYl/PKxwtIgMdmSYulrxXmybCnKWR15CO+eLG4gFc9vQbkli+q5kN9I/BQC+jzMKs+4bsCMSyOSFrs4iJTiGSq3QvGOGkz6QKiJWgGoDdjat8X4L1knUJW89P8hUUYFb5Y8EhZ93POsPwNUZCkyiJ+UvzyWKN/wacMv/o5W+asDaXoTxZYtl8z+TO65E+o+tiWWoVgmyCT4S5kGnwNWZUqf4y9J9VR+R7xtv2wBGbDoFU91urcsajokRNB170vLcyFUTGfYUcK/dynpGLbKrmwDqu4a1Zg6xFRaPvezcHa8MAa/dFz/fdsgvMMKyLWz1iMznUZL5XqQoOW48PxaUN2Cnpm4H3+ENkeXrfwsJOdeqal08/y5LjYdbfBCx1Kqgql4xdw9tiRS9naQyQ+aMqowr73QBNqdThNZ3QgdYkuA0te0/HzqIRDTVWD2cvB7rkROf02y2ORVlBuzUq4mRg6nwC7qhRLGB9E0U+aYiE9V7tAqg7uCjmM jKmj8Hro 1V6YyJZWsParCRIpKdrbUphYMJlBtv2L8FmdmRNQcxK/ZnW4ELHhjdsQWeGHqJs79ouheicJZRNnMDBZ5mm5j7+dOROG8AniaxYaDLdAVIDzbGs3jJzP+QenBIMhK9V4nWPe/UyjYSXbAT6LLwFLgYA2gJ1ZBdMVzbvMZWtBoCvwIuNSjQvEe/x40FooQ6E5KHEoztssocGyEz6gpp6CHA/+NBsWa4mQTmG7ZThGYvn07tgCBp0pF+/oA6al1KUGFF8EGVpVBO0d0q+HYX0DqirDWzBCaSMhMWBq8YrPIFvgiuAvSNRuq5B+E6yf0rDZYw4hIntk/pTYpwrsXqja6IHtb4luJrMLga61nnXNMBCIOlDRx5bdvy+cUWQuWV/xQtFmI/G6hsEnA9MiSn3bV4T58HMYbhbarPG4dVzma4UCcLspyBA8brm78XLL+2eLgPoWaHjh1NgODRdOms+VlGbcgIxOykNl8+UyH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/26/23 12:37 AM, Johannes Thumshirn wrote: > On 24.05.23 17:02, Jens Axboe wrote: >> On 5/2/23 4:19?AM, Johannes Thumshirn wrote: >>> We have two functions for adding a page to a bio, __bio_add_page() which is >>> used to add a single page to a freshly created bio and bio_add_page() which is >>> used to add a page to an existing bio. >>> >>> While __bio_add_page() is expected to succeed, bio_add_page() can fail. >>> >>> This series converts the callers of bio_add_page() which can easily use >>> __bio_add_page() to using it and checks the return of bio_add_page() for >>> callers that don't work on a freshly created bio. >>> >>> Lastly it marks bio_add_page() as __must_check so we don't have to go again >>> and audit all callers. >> >> Looks fine to me, though it would be nice if the fs and dm people could >> give this a quick look. Should not take long, any empty bio addition >> should, by definition, be able to use a non-checked page addition for >> the first page. >> > > I think the FS side is all covered. @Mike could you have a look at the dm > patches? Not the iomap one, that was my main concern. Not that this is tricky stuff, but still... -- Jens Axboe