From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE264C02180 for ; Wed, 15 Jan 2025 10:07:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62CD66B0083; Wed, 15 Jan 2025 05:07:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DBAB6B0085; Wed, 15 Jan 2025 05:07:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 430266B0088; Wed, 15 Jan 2025 05:07:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 256516B0083 for ; Wed, 15 Jan 2025 05:07:28 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A2AEE1A121F for ; Wed, 15 Jan 2025 10:07:27 +0000 (UTC) X-FDA: 83009258934.15.52A9FBE Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2050.outbound.protection.outlook.com [40.107.93.50]) by imf08.hostedemail.com (Postfix) with ESMTP id A0A05160016 for ; Wed, 15 Jan 2025 10:07:24 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=f79Rs6Kb; spf=pass (imf08.hostedemail.com: domain of shivankg@amd.com designates 40.107.93.50 as permitted sender) smtp.mailfrom=shivankg@amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736935644; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f1vagzgEz5gQ3ssN13OrBpvumAFqDuIqK9wFNPutOn0=; b=2V+S0arjcm7FyOaVUtEoFxoiskfUdNRi0lbNN45x8cEz0VVdVHgU9/oEiqhKOQ8xSm66bZ /LpesWqj5AxdgmR621okpxTvK1uMaLwk8GdcQG3VXBq2eIJhUi1iJhQ02dMFrbBJ71KE4W iDTxUzM3ZCdhkLGa3M50h6it95vJbhw= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=f79Rs6Kb; spf=pass (imf08.hostedemail.com: domain of shivankg@amd.com designates 40.107.93.50 as permitted sender) smtp.mailfrom=shivankg@amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736935644; a=rsa-sha256; cv=pass; b=qwWvaaCwBKgWuwo6dI1hIMzvqK5H4Wk907iJOo4omMH+8FoZ0ggLSh32xIWvsl3ACgoFd7 J2tC1LR9TpcT/+dPnK+ZWDGwk/iYBYoO0RJlj7Ze1Cut3iaiaXoDLo/IxrVNNjWgu5McAM Z4UrNG2HK3OWyK7L3qhDwqs2rKRJW4A= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tqu/tkcRKL4D/M+RGubbDZC60JOaRBU23M8U8W8TMbPe8Q/noijTewM484pE3JTeRs7hv4yjc4w43Rd9j3fh/2BWb1oseKjTyqppRXvblSrj27DKxm+f3+Abg/KOTD3ctciycNRxoP3qO0GgeGuPmv7BqMo2tq9ou0NpTDkUqrYn4VxgpYm9ffAXSfyGhCIacjnSPHXIOnXtyEl+AnwjlCGYotwmtf5DI3nuXM5KvpDjM9G+jzC5HXJHq0aggBVKQVQXsd19p/w1+1QcAjv7ZFtv3GQPl4QGHuahEfFJl0A8i+Ws7xne3FvAN5NrzgUlbsANeFOTc8pue37uBKk45w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f1vagzgEz5gQ3ssN13OrBpvumAFqDuIqK9wFNPutOn0=; b=P91v4y3eeF36L4GwvPaybPdSSRjTDO3FNeGES/1i13y6sDXsdwDnZo19XfGX5ffxVUfUPZ58D/GXl31UvG7p+fY9IY3YCBsWSIB29N9JIwUULYtGggM5cupC8FIuPHSEjujoML/bWJbpIs+R8MOWaoZFudE2yXujZR+LbiUA6YnMPs9yFz6yd/dAkXHb4FCyvordnyyxXWLThLFGyVV2z8Cxfoo4zGtjHGhY9XaAJLt/FeekQzrI1Zmu2WcudE2tz7VOrkYdn7UPYnmCh6mb3yM+oBLGsBlD7zehUUBcCxmYBXmPVh9qx3K6fKyArp3z9kEZx1OFemfWEeeVcct+9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f1vagzgEz5gQ3ssN13OrBpvumAFqDuIqK9wFNPutOn0=; b=f79Rs6KbvFU7VtMXyUZr9+vFR7PPfDfCYUimSfgt1l9CLBao9N6ZvqPfdRaSgHL+/uAA5/00XIV25oahNvXosMU4gJlUCqFBxrj8op7iofQG5emWQzLfJq7Fi3fHa/mQv0c0o0ss9PI3h53bex3HHIBYXlBRHJG5kaNr8t6u0Vc= Received: from CH2PR12MB4262.namprd12.prod.outlook.com (2603:10b6:610:af::8) by DS7PR12MB8201.namprd12.prod.outlook.com (2603:10b6:8:ef::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.21; Wed, 15 Jan 2025 10:07:22 +0000 Received: from CH2PR12MB4262.namprd12.prod.outlook.com ([fe80::3bdb:bf3d:8bde:7870]) by CH2PR12MB4262.namprd12.prod.outlook.com ([fe80::3bdb:bf3d:8bde:7870%3]) with mapi id 15.20.8356.010; Wed, 15 Jan 2025 10:07:22 +0000 Message-ID: Date: Wed, 15 Jan 2025 15:37:15 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: separate move/undo parts from migrate_pages_batch() To: Byungchul Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: kernel_team@skhynix.com, akpm@linux-foundation.org, ziy@nvidia.com References: <20250115095343.46390-1-byungchul@sk.com> Content-Language: en-US From: Shivank Garg In-Reply-To: <20250115095343.46390-1-byungchul@sk.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0045.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:22::20) To CH2PR12MB4262.namprd12.prod.outlook.com (2603:10b6:610:af::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4262:EE_|DS7PR12MB8201:EE_ X-MS-Office365-Filtering-Correlation-Id: d3deddca-a10a-4c88-3de4-08dd354c6725 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T2Y4UWRSa2ljcCtVY2NiVkhPK2NJSC9WbytUMFdwQ0YwU0dwcytNSEE2RFFK?= =?utf-8?B?SnBuRHZmNGdvZW5uQVRNL3ZpZXZlMWVLRWZ3RkhLZVZpVm1yS0dOdWFXZ1hC?= =?utf-8?B?NVdoNkVzMlVWN0NEMjI3WVhBcnFzVFlZVE5SSHJhbHN0eE8rUmlEM0VQdFJN?= =?utf-8?B?ZnF4U2d3MkNTVXhtQ3Y4ZWE4aXFPZjAvSzYrS2ZYQUhxT1Ntc0kvZlVsUVdm?= =?utf-8?B?bktOQy9vV1BlaXRKbnVCbWhyR3RJc2dXeStIL0l4bU9EbEpXbFFTVGZRRGg2?= =?utf-8?B?ZEt6SGtlQ3pzSDJnMUM1NytSdVRJNnUzZFNybmxiVjlKWFRRdlFBZWQ4L1Av?= =?utf-8?B?MGZwbFgxYzAwME03K01RZXo3dFpRekl1TTJNK1hUUmsrWmhKeWtFVEQ5dDhF?= =?utf-8?B?YVdYUmc3VUtsaG5MTE1iUnkzdWlBckhrS3lDeGZ5ZE1XSDNsZXdsUnBnQ3Vn?= =?utf-8?B?MitSK0ppMStkUG5MbXlGaU55ZVF5cGlpcDJnNWwyR0FzUE1HaGU0dk1uYXVY?= =?utf-8?B?SDRzMnZYUTJuUnJtUitLQXl2Y3hNeTlDL3pDWjh0OVZaQ2R0QXYwczlIQXZy?= =?utf-8?B?dDFEZlN1MHd1SmNNb2VGLzRRL0k0VWRLMUxJUFhUTXR0TkVDa1pWQWYvQ0FH?= =?utf-8?B?NEVvaU9icHRhb3R1YlpNTGRsRU1GVWFFdGdOZW5mc3gwZ3VRSTFsWmxIaXN2?= =?utf-8?B?UDdqRFdIRXJuSVkvcFJkVW5OS3NENWZpSW5RTkkzMzh1VFVFRE5Ya2xhZVFJ?= =?utf-8?B?L05ubkFvT3Njbk4rdlRLbUMydnB4SmdZYjNPSVZFaTFsbzBCb3BNM2lXNkxo?= =?utf-8?B?aWhBbHJndVVUd1Q5WUJySk81S3RSYmo2VmpzNURKR1oxRVhVZHJYMEFiczh0?= =?utf-8?B?TkI4bjltZ3lHSTFyNVBIT2JWb0FMczY0SkMxak5vNmlUWG03dzVXRkVSQnV4?= =?utf-8?B?eml2dHhhSHYvM0ZaQnlzU3h6YktTaW5FeFIvZTJDQXVHZGtEdXNWN1JIWVpL?= =?utf-8?B?cEhQMVNrSGJMdGVJZUJVN0thQnNIM1J3WDVQS0tQR0JKZUZEaFRuQWV4Y3lN?= =?utf-8?B?clAyWGMrUUZnbjBpRGJJRTUrTWZSakxhcUVpK1pMRld0Y1c2U0VFSmRudW9n?= =?utf-8?B?RnNkUzRYTVZyUWpzTDZxby80UGhrYmtNTUhUeU9ETkJzaGYzTWtKZEIrTW0r?= =?utf-8?B?VjAyT3hxRG53SnlYZ01HQ1VzMlYrQ1pWYUw4WU5JQzlSMGJobmllMjVpTkxU?= =?utf-8?B?SGh5MGhtTkJ6ZTNqRStBa21Pd0JpOHZSaUthRVdkN2cyUitHY250eFFFMlVw?= =?utf-8?B?MFh6aTVHK1RaK0xEMUJsNTEwekR2TnZhWWR6eHpoRXk4cjdBYStDZHRwODl0?= =?utf-8?B?NG9NMWJaV1JwaEdreW9STXVLa3FDa3BEbENCb1hCMlltN0hMa1RsekIyN0I4?= =?utf-8?B?ZXhDRm1zamo0dnpXejlLWGdreUtwWnEyK1cydE5WZW8xOTludHdKZWg4cGp4?= =?utf-8?B?dHIzM3Rzay9SS3U0czdJMmpPc1ErbE53c1RCUXNFVFNmL2FXUnJPbzk4ZXo2?= =?utf-8?B?bm4rNXlxUHcreW13YVVValRCbC9yWU1QdHU0S1ZESkM4M3RSZFZxRmY2cW5Z?= =?utf-8?B?cjBpM1RHTVZQZlJwWFQ4WlBlQ0xER1ZXSVErS2dhbVB2RkRsYUpJMVBtZlk4?= =?utf-8?B?RHpQN1NyWENlamltUlpsMGtWa0FTMmNlVmxFdFZYbTdqUkdBbjNmMGhRaUlq?= =?utf-8?B?VUxGOVlPV0UyVnB5ZVpNMHZ0c09kZjVyODNRM2cvTE5yQVY2SXIyNlVsbDkx?= =?utf-8?B?N081ODBIMzdPR2JUalZ1V3JCZy80SXVVSWNlU1JOZ3hIQm44WWQ3Z01QUExV?= =?utf-8?Q?y/t8Sm9hH94jc?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB4262.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1BXZURtYnBwa0wwRWJma2NMU1JCOC8xTTJsQnQ0bEtscGdLMlRVMFpndmRa?= =?utf-8?B?U2tiNkJWNjVyWFYzTDZkaUZrSmFFb0Vqd1gwd1dGWGU4QlNsNHpGVkEwbUs0?= =?utf-8?B?K0R4dHFDaDZxWmdTQ3FCNXg4Qit4UkJSRXpsZDBsOHgwc1Q4dWpWcWtXeU1U?= =?utf-8?B?bVNSaXJtbVZJMW81QkN5TSsvZ2thQ3JEM00xUFp2T2xwSjV3Y3B2MjBFZVpr?= =?utf-8?B?SEwzajY0VmRJM2EwU0xvb094YmVzTnphMXpvZmU4aC9RSjhXOTFEZHQ4Q1Vp?= =?utf-8?B?Sk1lVVVDSFBFQTZLR0w5cCs3M2w3dzV4eGRYV1NhWHBLT1NIYnJiYmZaOEsx?= =?utf-8?B?U2hwaWZneitBaHdWVHcyNVBmSWdXSG1WU0NTUmNuMlFEbzk0cDN4UWhMSURt?= =?utf-8?B?U2tHU3Ewc0xDY2ZKZEFVYk84a2lxZ3hHU1dEbmhvY29NTWp2K3c2Zkczdmo2?= =?utf-8?B?TzFxaTFnZ2RudVhIWHFnTlUrbzQranBFcW04RHJVOUpQT2xsL2VMOGtqTUNF?= =?utf-8?B?SlFaMGR2ZW5aUWl0aTRmeFd3dk53UHRuNWZxSTlReFdJZFQrajJXR25lZU8w?= =?utf-8?B?dzZjcFpzUXUzOXdUckVRaHViL0ovRHRuQmFYNkUrUUQ5c1VXZ24vYmt4Y1JH?= =?utf-8?B?UEpOeDd6NmpXeU5GUE5YRStjaEpSZU53eFJXMEpSZkl1YTRCemlqbjloc0Rt?= =?utf-8?B?T3d4ZzlmYjVldy9nZ1BndFJ6SllTa2hWMWFsZjg5WEVFQVlQTXZ3RmsxS3dM?= =?utf-8?B?bm9HUGI1L1VQaWJhWlREelFnMVE0T2Zqc01vU2FFd0VwdEQ4cktSUExxTnlV?= =?utf-8?B?NEp4ZTJBZU1RWHB4bjdrMnRJMTB2OWJmRTQ5ZEtwalFRaHY0WmEvVTFGSU1K?= =?utf-8?B?aDdWZEJZQmNBR0V0ZFMxVjBja1UrY1dSQ1hyLzc3RXpFdk1VVFF6UFM4TUJZ?= =?utf-8?B?VEV0THhPL0RSdTNvekROYWRpdERJVE4zTkQ5TWt6L2dEZCtwcTVoZnRzckda?= =?utf-8?B?VjkrNTJ3MW91UGhTbGhiekdYdXZuRW4ySnIzN0xrZmcvQzZNNk5GTDNNUU1Z?= =?utf-8?B?QytNdzlmRnI5Tmp6aHlCYzBRN0U5L2hNcklIRks0QUc3NFVlQlRxVUpjeCtu?= =?utf-8?B?Qmhqd0dxaTVDYWlROU9QUDVuQmxaZ2xtekJQLzlreGdsbFhvbDFaNTZDcnUz?= =?utf-8?B?OGVGK2gyQjFLc3NUbGZKdFBkTERSVkJOQmJqN3hzQWtyZEE3bEVUWXJZYm0r?= =?utf-8?B?OHNKQ3Q5d2NWOHpVL3prL1Z6S0VjeUxKMFVrTDBnM21DMkNWYXdWUVNKY01T?= =?utf-8?B?V21VMUtsb0NiWDMyWGxWWXIzek8vUFFwRTBoMFQ5R0JFMzZnTGVWMjY2dFgr?= =?utf-8?B?djREa1NkT3UvZjc1bHNtcmFjcGVoa25ObnpvM2M4elZRVkM4alMxQXg0UjIz?= =?utf-8?B?eS9nd05VVFkyUFJjcXI0L3Y5R3JiN3RyOUd3eWVKWXdyamdkUDhvVXNMcFRr?= =?utf-8?B?WkZZSExnOHlSam9GRGFOY2ZYREF1a0JxRTRXM3MzWXBCVFVrSHdJK0RoOFpJ?= =?utf-8?B?a2dMR2wwK3dlcUdpaWhqN2lCTFJMZG95M0FtWWNyUldzSXcwamk4VVdtVndr?= =?utf-8?B?T0lwbFhhNzY3UEFWS2dwWXczdFFhbmYrcVk2QkFVYlVaeG1wc3hYRndLeFpX?= =?utf-8?B?U2JIVUs1ZjFYT0c2alRJWkhhUG82N0Z0a3R6M0F5UVJsNXJ5Nk9iNEFWeXJa?= =?utf-8?B?akdueHdUdTlrczhKa3duSkhrUVcrcE8yUkRQTHZMelU5Rk93cUJDTDlxZWhW?= =?utf-8?B?MmtNODkzaXAxbzVySU9pSWszWkNMcFY2VXBwMHN3d2xldU01WHk0cGhoUXpS?= =?utf-8?B?VHVJVDZBVFRyNHN4NlAvc2l3VE9tMjNvVDNZMCtDSVhVeUdtZ3llMEwxRnNk?= =?utf-8?B?WTRyT2pTNGhyTU9wYS9yZDY5TjhSeTV4Z3hmTE1CQ2IwcDdLd0RhWTJrMnZS?= =?utf-8?B?RkNndHlic1cxdEtIeUV3VmVSVXFseW96UzhMdG9tQnhqSW5xZmpNSFo0MU1j?= =?utf-8?B?QTBpbk9lckxxTnBQWlRCWTFqQWFzMXpXaGtiZFFwcXdDclpnSVN2TkN2Q0o2?= =?utf-8?Q?fnaJ1wBqz8N3Lut1VAtTtRUDv?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3deddca-a10a-4c88-3de4-08dd354c6725 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4262.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2025 10:07:22.3989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2/o72NkzugpgoJl8puziBpGYEx3wb4ZE6czutzRHYbPeTsIIq43NhS1XSybMVmC9g7b6hxvJLQEyULoOVPIaEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8201 X-Rspamd-Queue-Id: A0A05160016 X-Stat-Signature: xnzi5bdey7idjzaf5r35uhg1y4yz8uas X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736935644-854944 X-HE-Meta: U2FsdGVkX18vpYkZMn5pOhjmWIG/KKNqBqL04Y5SYB+3lDZmLaWCnEQe3bSL6EKP9B0WJPFj0Y/r4FeJbaah29A44VOFZwzLaUCHN7djoUCa1ZX8aKYa6WG9pMK1icY6uld8xVuXksWSZxxnd7s7JQLthmve3SB2BfwcdIB44C7s23qAwG73V2vpKY4ujnBsGqky2RN6NvT6IpZbjdA6G3rSrhCoKdHSpaxQvEKP9+FCXzSXRnLTjg9uVbft6tpNTvkFkBrOQkLD4jpF2wE5gETnW6LSfmBn4Xafj060xM5Wjqc1vyLuJMTkNRb0EbPGdRRZO5q+mjzAEJuckp/ZQvngLeveAhwsTOO5fUdR/0nF7Zq9qLCkWJdWkPsWVVfBgVQPuPI/ffhryPs7MGmzj8miZzssJ7/J/QUDaHfL45joX5u/eokYfpR7jvNt2xpPpIVZ0V4M+EQWDUr9l3IEF2fJfa8Gk2L6N3Fx5qfF7aUFKUW4ti+se2sxet095nIW77TwrOHGx9N5Ka96ov01ahJfU83uPQgCc2s4DE5ehOZff1UIPgSkjxvxbxlexrlbldWi7E2UrcVxxb/nrdWuv7TIEMkG6jc+1zGgANHHuyK5fz2/gh/eSfIM+tcheOZ4+4+JfaBeSSOPeXOmKCf9CDZaTgCHkkLE6r6sFMv4wprE1nzLc2AMGtapUlGeQgkTEiVNSMGeA8htCT1qyuEzLO0FxylxhLoLKt9s2pxRllaz0XDrnpKuNw/Fbub4ngeI3e7d28e+pk8SjZg9wxEAy/pXIIzfY7n6GVnD5h8mmKZEbmzLtgnIw3wv49/hViIZjd3bWfYcawFei1RkZdsi6DRIt4Sgitc2UKve+nboQiVNk2Mi+e4V5xLKHFraZfbIfn+o6AGGF92ayJthiymRZtJS3RJHXDIa87j9Z2Nk8vchvZNQzst/PCWCqWd/D8MKE3lNaC85HgIUVMNA03s q8dn7Aue t9TY1mlNrFqrcIxbJb3yB95a4DoW7KAPCHAdrfgk/Bokg9EpJ0vFP0SWHNAkkJq40Dds75CNMFbVxUt/cLYAr6MZsDR98BtPPGWNWSullBCW3KvwOy01TngqP+zaXMkIYTS17OrPcwOsBuJ25dUtNb6R44bN5QW41QVa7wm51CZB/jinVW3RrTu+9pzj2bJJIDpmbRpxMpxHy499IciIUWDDs+NbLYAaT/aHDxcOYnD7LKSoGnrEiAR+q72OOWrbZyduGCExyTfMHrL9gUCkUHk3cRxmI7ihafxq7us1cChL9p8LDhBHdePWKA0Q5AAFcH6Wn6XO580bjiCBc5Msu1zLpYgpOem116aycVb3tyQWXdeMLnP8Spvo9wmyMa8QkFIv5iHNwKL/fAD47YuYtAWaEw2H9LvNUIasmXDAMIPyivjeQBgolvA6cJ/RnPyJMSksVD5rLW9GlBs0YKYt9G/kSXVChfuFv9Bu/qw9hTPhiV4E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Byungchul, On 1/15/2025 3:23 PM, Byungchul Park wrote: > Hi, > > This is a part of luf(lazy unmap flush) patchset and also referred > several times by e.g. Shivank Garg and Zi Yan who are currently working > on page migration optimization. Why don't we take this first so that > such a migration optimization tries can use it. > > Byungchul > > --->8--- > From a65a6e4975962707bf87171e317f005c6276887e Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Thu, 8 Aug 2024 15:53:58 +0900 > Subject: [PATCH] mm: separate move/undo parts from migrate_pages_batch() > > Functionally, no change. This is a preparation for migration > optimization tries that require to use separated folio lists for its own > handling during migration. Refactored migrate_pages_batch() so as to > separate move/undo parts from migrate_pages_batch(). > > Signed-off-by: Byungchul Park > --- > mm/migrate.c | 134 +++++++++++++++++++++++++++++++-------------------- > 1 file changed, 83 insertions(+), 51 deletions(-) [...] > + */ > + switch(rc) { ^^^ minor nit here - space after 'switch' before the parentheses. This code style issue was present in the original code and was carried over during refactoring. With this fix, please add- Reviewed-by: Shivank Garg > + case -EAGAIN: > + *retry += 1; > + *thp_retry += is_thp; > + *nr_retry_pages += nr_pages; > + break; > + case MIGRATEPAGE_SUCCESS: > + stats->nr_succeeded += nr_pages; > + stats->nr_thp_succeeded += is_thp; > + break; > + default: > + *nr_failed += 1; > + stats->nr_thp_failed += is_thp; > + stats->nr_failed_pages += nr_pages; > + break; > + } > + dst = dst2; > + dst2 = list_next_entry(dst, lru); > + } > +} > + > +static void migrate_folios_undo(struct list_head *src_folios, > + struct list_head *dst_folios, > + free_folio_t put_new_folio, unsigned long private, > + struct list_head *ret_folios) > +{ > + struct folio *folio, *folio2, *dst, *dst2; > + > + dst = list_first_entry(dst_folios, struct folio, lru); > + dst2 = list_next_entry(dst, lru); > + list_for_each_entry_safe(folio, folio2, src_folios, lru) { > + int old_page_state = 0; > + struct anon_vma *anon_vma = NULL; > + > + __migrate_folio_extract(dst, &old_page_state, &anon_vma); > + migrate_folio_undo_src(folio, old_page_state & PAGE_WAS_MAPPED, > + anon_vma, true, ret_folios); > + list_del(&dst->lru); > + migrate_folio_undo_dst(dst, true, put_new_folio, private); > + dst = dst2; > + dst2 = list_next_entry(dst, lru); > + } > +} > + > /* > * migrate_pages_batch() first unmaps folios in the from list as many as > * possible, then move the unmapped folios. > @@ -1717,7 +1792,7 @@ static int migrate_pages_batch(struct list_head *from, > int pass = 0; > bool is_thp = false; > bool is_large = false; > - struct folio *folio, *folio2, *dst = NULL, *dst2; > + struct folio *folio, *folio2, *dst = NULL; > int rc, rc_saved = 0, nr_pages; > LIST_HEAD(unmap_folios); > LIST_HEAD(dst_folios); > @@ -1888,42 +1963,11 @@ static int migrate_pages_batch(struct list_head *from, > thp_retry = 0; > nr_retry_pages = 0; > > - dst = list_first_entry(&dst_folios, struct folio, lru); > - dst2 = list_next_entry(dst, lru); > - list_for_each_entry_safe(folio, folio2, &unmap_folios, lru) { > - is_thp = folio_test_large(folio) && folio_test_pmd_mappable(folio); > - nr_pages = folio_nr_pages(folio); > - > - cond_resched(); > - > - rc = migrate_folio_move(put_new_folio, private, > - folio, dst, mode, > - reason, ret_folios); > - /* > - * The rules are: > - * Success: folio will be freed > - * -EAGAIN: stay on the unmap_folios list > - * Other errno: put on ret_folios list > - */ > - switch(rc) { > - case -EAGAIN: > - retry++; > - thp_retry += is_thp; > - nr_retry_pages += nr_pages; > - break; > - case MIGRATEPAGE_SUCCESS: > - stats->nr_succeeded += nr_pages; > - stats->nr_thp_succeeded += is_thp; > - break; > - default: > - nr_failed++; > - stats->nr_thp_failed += is_thp; > - stats->nr_failed_pages += nr_pages; > - break; > - } > - dst = dst2; > - dst2 = list_next_entry(dst, lru); > - } > + /* Move the unmapped folios */ > + migrate_folios_move(&unmap_folios, &dst_folios, > + put_new_folio, private, mode, reason, > + ret_folios, stats, &retry, &thp_retry, > + &nr_failed, &nr_retry_pages); > } > nr_failed += retry; > stats->nr_thp_failed += thp_retry; > @@ -1932,20 +1976,8 @@ static int migrate_pages_batch(struct list_head *from, > rc = rc_saved ? : nr_failed; > out: > /* Cleanup remaining folios */ > - dst = list_first_entry(&dst_folios, struct folio, lru); > - dst2 = list_next_entry(dst, lru); > - list_for_each_entry_safe(folio, folio2, &unmap_folios, lru) { > - int old_page_state = 0; > - struct anon_vma *anon_vma = NULL; > - > - __migrate_folio_extract(dst, &old_page_state, &anon_vma); > - migrate_folio_undo_src(folio, old_page_state & PAGE_WAS_MAPPED, > - anon_vma, true, ret_folios); > - list_del(&dst->lru); > - migrate_folio_undo_dst(dst, true, put_new_folio, private); > - dst = dst2; > - dst2 = list_next_entry(dst, lru); > - } > + migrate_folios_undo(&unmap_folios, &dst_folios, > + put_new_folio, private, ret_folios); > > return rc; > }