From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E76F0E77179 for ; Fri, 6 Dec 2024 17:31:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 184036B02B0; Fri, 6 Dec 2024 12:31:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06FFC6B02B1; Fri, 6 Dec 2024 12:31:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2B456B02B2; Fri, 6 Dec 2024 12:31:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C175F6B02B0 for ; Fri, 6 Dec 2024 12:31:33 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3791181B4D for ; Fri, 6 Dec 2024 17:31:33 +0000 (UTC) X-FDA: 82865225478.21.C73E8D5 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf28.hostedemail.com (Postfix) with ESMTP id 3103AC000E for ; Fri, 6 Dec 2024 17:31:11 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WYxI9GY+; spf=pass (imf28.hostedemail.com: domain of vgupta@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=vgupta@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733506273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cDewpNOZhWDjQMF7Lhzo1b4KrgQhtwV/+6fL7MNxyHA=; b=28Jfh5aZJ5EwPtQQp/pfhlhDhoZk2VcND33BSBiBc638Ek8OZyFIOmygGG2sP9gIiUKIyK 7roWroroag2GGNhzXYDqYuUbsMXGmC+7Rff6BY6a7v9V4+ETGOBdoGfFC+9ghn/04WB0GY CkBBd2PwtAQhBNPmdGfRz73qj6PVYt8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WYxI9GY+; spf=pass (imf28.hostedemail.com: domain of vgupta@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=vgupta@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733506273; a=rsa-sha256; cv=none; b=6fEmedMZRd/SpegHUjBE0MNdjTKdGCKSLUw0UyFWOSNRPWK5N+SR/OFkQz7IfR4nguPZxD veS6XTcFFHBhUr8pr5dzfraq7+MWL94BtplYntAJRgabIviK1FAUzJLyI7iIX7YQkvlNTw s7O3XgkpQQSUmMKOHQPAUsZ8iWxNiHk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id DCF59A4157D; Fri, 6 Dec 2024 17:29:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5771C4CED1; Fri, 6 Dec 2024 17:31:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733506290; bh=cDewpNOZhWDjQMF7Lhzo1b4KrgQhtwV/+6fL7MNxyHA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WYxI9GY+v0cl3lqqvXLiYaPc/ojnMiM0ZDQK0sC2sM8yVYE94eR5nwQEFmF/WWjxl MopF+I8i0SZRk7H5NvOVW0mZjK7w6bvojazvv4eBEkVyH14z6+7OZnzXylHJqkQGTl 2SV2JnaSx8ow1XryCWN5PpTthKXbRydiB0IdJK04YpN40LyxiUuA5OTHGrG5rfD3gf NtSx5hiLPEzpETBDJZ0GrzuaY4pY80FsGs5n+2MUxBG0+Qt12KaWT3GqEz1uStyNIx /X6u9UOCtklahP5KFZj0oZ0qn+qSjxaulOR8tKHxbinDwJuxSMinLQZehgUmUfjZ/m VxCi2VFUqbEAQ== Message-ID: Date: Fri, 6 Dec 2024 09:31:27 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: use clear_user_(high)page() for arch with special user folio handling To: Zi Yan , Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , Geert Uytterhoeven , Vlastimil Babka , David Hildenbrand , Miaohe Lin , Kefeng Wang , John Hubbard , "Huang, Ying" , Ryan Roberts , Alexander Potapenko , Kees Cook , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Vineet Gupta , Mathieu Desnoyers References: <20241206141938.2750393-1-ziy@nvidia.com> <78D4C1B5-3EE7-47F0-A7A2-F1ACFE71CED0@nvidia.com> From: Vineet Gupta Content-Language: en-US In-Reply-To: <78D4C1B5-3EE7-47F0-A7A2-F1ACFE71CED0@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3103AC000E X-Rspam-User: X-Stat-Signature: 74wp6rott97yd6x7w84hr3zyo1qtyuwz X-HE-Tag: 1733506271-209068 X-HE-Meta: U2FsdGVkX1+RF01nZl8krHxqIuwS/IPOuhlLQ/sTVYGNrf8l/r6VYCb4sppGyp2iN0VjhIbphxTUU2IslpXEcF07/du/S3g/JRe5OOgUK8+1hiNpyxsVgcsOloEXJSFhubslkYqoWl+Yc2Rmc3ddycRxjjTsEKMgnbwv1RUYRPEjZCLiLY6P7Htv43z3wIqMBnKbHdjVww0zOm2+LrIYLP7w1b2XS6CRHBmlavvVFzs4I4SAhnvOTXx1IWD9XyE4kEkfogKkcoP0j2D97K5LxH1/YPbTz7IVYSYgo66BtizQzvRCmPN3ULP5qPXrUuxjCRAe9J9ocJ9HQsWEwyQhD9JjsWgiWR9wlNwxjE7RojQoZFSPVZlcYh7oPRjeyCqBjE70WbY6VLT2ZPVd0EU5vcmY/hsWfHORvfCpY9YkMgI9u1Uwgv6+JAnoLGcUq5M5rJFZNDm+BqUyYcBWiRyU9xKeaEv6W7TJa87+SM6o1cuipjHNiChdTai3TZIcdy0kaHMk3uIdW+RjTAli/XlBUYoP9l96H6gs35KBKW3MqQlNpT0CqzxzHiAIvPmdTeWe4lKvkR/NAMO/AHcVKVktx2cQff0Uqzer06Ub74ydBTAijl0kjX1DxYkOn8XRWuVdzieJbMM3uRzgoGmbH9DtPcjCumAx8XnQ2oXlbaUXMC6B/2cz0BPM1EOs9jBxYqyN3Ds8go8bPAgjP/aIX8HhW2mgtspLQ8fwsTzDS8ed3wnZfaRphFnifu/+XqsEJxP9THHsRXC1lIxi7E2y5g5xv98wWODnEFoa81ZMyj+JRb9q3eMQO4e/ZqkquNfbY0QU94zDHj152YWGghpSHd6L557nfge67JAZUlZQFV5/eFv+p4L681To+r/x7colcluhj05DQNEm+649oDfwp1ZLXvo0aveJIFGHhiUhg+pXAwBESnZan8itApeCBx6u+BkvdY+7bHeLM35ehv61DEp V0d4G4hW d9VNga6iqmT1cr7KaLNcn3/YIynTRXaaY1+/pVXNvVDpwTvtBAJIRSllYZRUlKzbzkHX1MMBrzyj3VdIO6+yMoFcDHyBHBlm0+NnCr7TN5t73feOKCQGohhflRriPu98BDmuJ8eWlHcrlgxdVF7WV0+T2TUdzNZlEDQ0YxYCWsklw7tx9+o9ooalkLWM/vNOrUGMtusR4sSTTHAGTUw6LBpfWSOlpV8FVaQfdTPdiZhNrKOOlBln36CzNH2FAk/EUi79o57weuWlaiCni8vX4MRDdCLLnNZ/eFszAjoyzG2UQXKM8VX/p0yZYOq19t+Qm5vuYOzIFG2u/HW4613+GKhSNmmTkp8TxZqk1T+raS6/hFYMSdPDViQGy/7OE8cVkd63p X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/6/24 09:08, Zi Yan wrote: > On 6 Dec 2024, at 11:42, Matthew Wilcox wrote: > >> On Fri, Dec 06, 2024 at 09:19:38AM -0500, Zi Yan wrote: >>> For architectures setting ARCH_HAS_CPU_CACHE_ALIASING, which requires >>> flushing cache and arc, which sets folio->flags after clearing a user >>> folio >> I think arc just has some legacy code left that needs to be ripped out. >> See commit d5272aaa8257 which took away ARCH_HAS_CPU_CACHE_ALIASING >> from arc. > The PG_dc_clean bit seems not to be related to cache aliasing. > See commit eacd0e950dc2 ("ARC: [mm] Lazy D-cache flush (non aliasing VIPT)") Indeed it is not related to aliasing. >> Looking at 8690bbcf3b70, I wonder if you want to use >> cpu_dcache_is_aliasing() here? > Yeah, this is more precise. Will use this in my next version. Thanks. Commit 8690bbcf3b70 was wrong for ARC as it assumed aliasing is true. The aliasing D$ code is all gone and cpu_dcache_is_aliasing() is false for ARC now. -vineet