From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB997C433EF for ; Sat, 11 Jun 2022 06:32:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07B748D010C; Sat, 11 Jun 2022 02:32:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0041B8D00F7; Sat, 11 Jun 2022 02:32:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE81E8D010C; Sat, 11 Jun 2022 02:32:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CCBCE8D00F7 for ; Sat, 11 Jun 2022 02:32:44 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 98F3535F46 for ; Sat, 11 Jun 2022 06:32:44 +0000 (UTC) X-FDA: 79564986648.01.9A150B0 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf15.hostedemail.com (Postfix) with ESMTP id 30457A0060 for ; Sat, 11 Jun 2022 06:32:43 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LKp094mYTzDqnh; Sat, 11 Jun 2022 14:32:09 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 11 Jun 2022 14:32:30 +0800 Subject: Re: [PATCH] mm/shmem.c: use helper transhuge_vma_enabled() To: Hugh Dickins CC: , , References: <20220611022314.21593-1-linmiaohe@huawei.com> <8b34a515-e5fd-731a-4164-9080c275d4e9@google.com> From: Miaohe Lin Message-ID: Date: Sat, 11 Jun 2022 14:32:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <8b34a515-e5fd-731a-4164-9080c275d4e9@google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654929164; a=rsa-sha256; cv=none; b=N4vcFV/3GvN/+jzWeReJlcfX2a7ggLSUBq+W3o5Srz5THQd3g/210EsY/a7p0WYKRuu08J qLDVlkNVe0ys8t/N+ePl+bQJsl4O/aAk/gpArO+ytrZoALeM5CZ/mvDXnMp52Lk/jm+4ts KvGTp/n48QjBUb/eoY3N4fVZGoFFgYo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654929164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TI69HmfuHzJZ1cO5mS6l9mfvYP/SJ3AAaEr0b0X1v28=; b=MS7HAdk6RBMJ5ABdTFXtuK5AKrMmby0ylf45kK0ozlNNQLg+BbH2/Jnhrzg1NQG15prfw4 2M6sy8Y/o3QFCeQWAN34/t4HqJDxrH6N0+Mtma2CnBUOzbaKM4ziK2IfhhH0E8CqHWNaIX SE90SUS5bIDHNveZvWCGNUMeAGjQKas= X-Stat-Signature: d74uoj9up8x14sqxms4sitsa4ndiwxq7 X-Rspam-User: X-Rspamd-Queue-Id: 30457A0060 X-Rspamd-Server: rspam07 Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-HE-Tag: 1654929163-806425 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/11 11:14, Hugh Dickins wrote: > On Sat, 11 Jun 2022, Miaohe Lin wrote: > >> Use helper transhuge_vma_enabled() to check whether transhuge is enable >> on vma. Minor readability improvement. >> >> Signed-off-by: Miaohe Lin > > No thanks, that's a readability regression, forcing reader > to go and look up what transhuge_vma_enabled() actually means. > > What you call a helper, I call an obfuscator - as I implied in > b9e2faaf6fa0 ("huge tmpfs: revert shmem's use of transhuge_vma_enabled()") Oh, that commit also cc to me. But I forgot it... Sorry. > > Hugh >