From: Miaohe Lin <linmiaohe@huawei.com>
To: Hugh Dickins <hughd@google.com>
Cc: <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/shmem.c: use helper transhuge_vma_enabled()
Date: Sat, 11 Jun 2022 14:32:30 +0800 [thread overview]
Message-ID: <bc1fba72-ccfb-d53f-8101-e7d20eaf5eb9@huawei.com> (raw)
In-Reply-To: <8b34a515-e5fd-731a-4164-9080c275d4e9@google.com>
On 2022/6/11 11:14, Hugh Dickins wrote:
> On Sat, 11 Jun 2022, Miaohe Lin wrote:
>
>> Use helper transhuge_vma_enabled() to check whether transhuge is enable
>> on vma. Minor readability improvement.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>
> No thanks, that's a readability regression, forcing reader
> to go and look up what transhuge_vma_enabled() actually means.
>
> What you call a helper, I call an obfuscator - as I implied in
> b9e2faaf6fa0 ("huge tmpfs: revert shmem's use of transhuge_vma_enabled()")
Oh, that commit also cc to me. But I forgot it... Sorry.
>
> Hugh
>
next prev parent reply other threads:[~2022-06-11 6:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 2:23 Miaohe Lin
2022-06-11 3:14 ` Hugh Dickins
2022-06-11 6:32 ` Miaohe Lin [this message]
2022-06-15 5:02 ` Anshuman Khandual
2022-06-16 0:40 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc1fba72-ccfb-d53f-8101-e7d20eaf5eb9@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox