From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65ECEC00528 for ; Thu, 3 Aug 2023 09:36:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04A93280227; Thu, 3 Aug 2023 05:36:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3D9A2801EB; Thu, 3 Aug 2023 05:36:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDEDC280227; Thu, 3 Aug 2023 05:36:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CCDE52801EB for ; Thu, 3 Aug 2023 05:36:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8921EC10E8 for ; Thu, 3 Aug 2023 09:36:49 +0000 (UTC) X-FDA: 81082288938.01.4177B74 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf09.hostedemail.com (Postfix) with ESMTP id 638AA140009 for ; Thu, 3 Aug 2023 09:36:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="idJP/bqJ"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=el9ojAmS; dmarc=none; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691055407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=goH0RGRJhK/fH7zf9HOfwIEiuL8jO8QFiZpqtIWmMRU=; b=PF+sPFcgMQeeW+WUsZs0Tr+Z3FPZcVlwg7RoICZV1JhRsReYOHzPdzKI6k/888NeMDypzq 5yLEAogTjd5UBmMw0NQZxfljJRYOirrsWrYxLN5qALwqy+llsniLWSYMO5uJmg4Kf8Fyzg OoW0cZmoINV1OXm8zoHRGsaRiCXqADI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="idJP/bqJ"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=el9ojAmS; dmarc=none; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691055407; a=rsa-sha256; cv=none; b=3so5dnn6deSzF6tD9GA2sXt9ozDkVhUBfqfobziRXkr8+2+J4KaQZakHOFXzKbkdX6hlo3 IdLOjGmB7UmDQo+4UC6WgmttHiGhS+3E9ULHIVMjg5ManTR5sTymVR1SihwTHWiL6cYm83 Nk8FBqPEEir/ZBHhDoBWtGh+ntwfrFM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D0341219D4; Thu, 3 Aug 2023 09:36:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691055405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=goH0RGRJhK/fH7zf9HOfwIEiuL8jO8QFiZpqtIWmMRU=; b=idJP/bqJMlFV8Z4SD8NT3qylf/Q5haz9vMLly6Aks76OLgyNjYBQBuPlJELdvXSqhQc/wn eWT7ydzq7defa0ZVcrm9o/N85F6Wd3oDNHUugOYWvKgMBoE9XY5kPZBktuUF+00QnmRdfq Ayh2Jn26k0GqeqebmASpfmDatyfbz8w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691055405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=goH0RGRJhK/fH7zf9HOfwIEiuL8jO8QFiZpqtIWmMRU=; b=el9ojAmSgdIsxss/3BGTff0xvJ7J71SqHIDjuwLRyN/SpWelmabz8pYD0a39vcLrQqyvqi rSFVrFcYCzGSsnAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 780A91333C; Thu, 3 Aug 2023 09:36:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EhiBHC11y2Q1eAAAMHmgww (envelope-from ); Thu, 03 Aug 2023 09:36:45 +0000 Message-ID: Date: Thu, 3 Aug 2023 11:36:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v4 1/2] mm: Remove kmem_valid_obj() Content-Language: en-US To: thunder.leizhen@huaweicloud.com, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "Paul E . McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , rcu@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Zhen Lei References: <20230802130918.1132-1-thunder.leizhen@huaweicloud.com> <20230802130918.1132-2-thunder.leizhen@huaweicloud.com> From: Vlastimil Babka In-Reply-To: <20230802130918.1132-2-thunder.leizhen@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 638AA140009 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: qm94mwo15j4ee81537xeu65irezxp418 X-HE-Tag: 1691055407-594557 X-HE-Meta: U2FsdGVkX1+/rexhzuUu2KKXzXsdGoSdeW4GipbjzI/XaCzkdakGEnNjrEtZ86v8H7ty3AqLCcZf/P6L+XNErT16lePk1+O18jR0cAaXSKcyG3GU1Wg67r3zQQ4Tds18CJGGUwPzmEipGXzEnRiuyDqBb9+6gcO/JFg6KAZAX+nJkDxPNwUmEH/48fpe9hXg9iy4BEPZ+H+R259KLiIPIskyGQeOPeElazqDrXYkNNe9pftJipjM6WQp0gVnJeVAdNq0/Pkh485tiboYHPlchIPSBLWr/IEQ0KOWpTxTVHRQvy5rQ2uoedHccnsOK/nOPI5MA4z5V57mPMomX+gD9J0+WfuMdZz3bZVrCBS/zrjmtakjnRaVZFZyJIZgsV0roFmXXOcdLb/eg5B4wvj9We/NiYiDHkI5QnEgYOsCPbsrz0oiMZKZUF4gFJPLoqboKIGuaz+RZXEb5EPCHCnbpUBhWhIBgE5LCIyWNphlofT2rnWi0dzUuAm9gxdWmcFT4tPA9SAsgqwpOv8jFrnsodFlcmeEBfwRz1CvN8MZ1wLtUrz5GnFj278RshYl7mZ039bBZHA+2kGA8GpRREKOhk+S6N/c2sMFV2hrENTLtXod40XmBcVxz/bY6PWxpqyejzqZ6e8ZAydLpHHcGsv2GP/Y3c91MPVzySlOjvmIbq3hU+tX0btEVIwLSqLyBdbvtB6kYITPr3iBn6sPM8cSWc9e2eAt1vyAnMJAvlPXWAY3h+uu7SKPDvL+9Xqtma7OH84p7IuIIZDCKWYWgrpiqpc3dSB9W2hLGIfFnFqljJ19ik04zmoSEGqjqEmAYc84jSO+H0PBrciENuNDrRouI8/fIaWKzokMQ6PfkEb+sFXRiZobTOZ9Hn7NtXF3usTaiaLk2g1GNVxABCsmNTZNrI+41816+yWwpJKr+eKYePOmi6pX48Z224dp/kDTJ8nOaqDQqVsud+3LVt20uZE wy4UXNrE uEw5aZVyXu64J5ri1kbmaQ0yIi0zCcs8WInbsNdL/3SIDsc0Krr+6aujtoCt3vXUFF8iNf741k8xOx+4rd+jiGnmdyA3sFlpaO/qhTKmIFgh3FKQ+KZhG2eQHWL3tqzql4aLioQVb3NWHLmCgd9fhc9pqrkZtEvKOwwL6GfjPcAz8S179AIE9YaumOLAIQdjWjRW3bI+T36Y7lJ8uAjrKV6nXcRig69hY3I1zyLH/4/vzKsqgyeIqTxgBFka/i+kpry2BfqzRx7h6W6b4/xI+scA4LX3LSsuZOO3SdQ8PCeN3nArH22hYX7z2KhC8AMuk+dXKORq7qGRhikEaqJrEzh8/8hoqoPy2lrPmnb/aM7ey6zVRHUl/wHTqCwM8IiDRu5ViGXw2zgso4rquKUnxWOkGccSDBETPLz+DZVw7VHQ/uAENTi/8ABkuEGz55guqGOCO/ly2dYWCbR8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/2/23 15:09, thunder.leizhen@huaweicloud.com wrote: > From: Zhen Lei > > Function kmem_dump_obj() will splat if passed a pointer to a non-slab > object. So no one will call it directly. It is always necessary to call > kmem_valid_obj() first to determine whether the passed pointer to a > valid slab object. Then merging kmem_valid_obj() into kmem_dump_obj() > will make the code more concise. So convert kmem_dump_obj() to work the > same way as vmalloc_dump_obj(). After this, no one calls kmem_valid_obj() > anymore, and it can be safely removed. > > Suggested-by: Matthew Wilcox > Signed-off-by: Zhen Lei Acked-by: Vlastimil Babka No problem if this goes through rcu tree due to patch 2/2.