From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDDC1C369AB for ; Thu, 24 Apr 2025 18:45:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9F966B0026; Thu, 24 Apr 2025 14:45:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4E676B00D9; Thu, 24 Apr 2025 14:45:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC9FB6B00DA; Thu, 24 Apr 2025 14:45:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9A73D6B00D9 for ; Thu, 24 Apr 2025 14:45:00 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BEF2D141930 for ; Thu, 24 Apr 2025 18:45:01 +0000 (UTC) X-FDA: 83369814402.25.966F414 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 54C9318000E for ; Thu, 24 Apr 2025 18:44:59 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jFL5U9+Q; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745520299; a=rsa-sha256; cv=none; b=oGZcv9yYxTnmi3YNlYqPv8kQ+bEN0dMl4uSPQa172QMr7QR1SiTOpYK52iV+i3e9R4YDRw 25FavLv0/aeGBpCa5ePi7Yc8einSwbdXtINXdjq9Nffw087sRRQqtgEDJhI2QOYlauQsHl CrC+7mYyaCC5U/A7/3iNua/kK2/xw1k= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jFL5U9+Q; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745520299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Wgp7mJTIaWr4iSqP087qB/jzFoWHBMGQ7zhcWzTy3E=; b=VaMngd6vAMyKWjRrg/eqyMu2HIbdtBLboy60+rRPBVORTdvt1ArSfW+4StfZ3Y+luqqJlS znBAGImO86s8SofrmCyNRK93eCb5XdG2ZYrgl2kPVFW0zdddjeggRSx11vZN+EsLmW1zuJ H43EryNQiL5HoJoyQBL7V/9zXfxXeso= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745520298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4Wgp7mJTIaWr4iSqP087qB/jzFoWHBMGQ7zhcWzTy3E=; b=jFL5U9+QtgTtlSOlAl7Q/CKhq1aYKIPXCZFHDP6XqPfvA8c5KymhfL17M8hCYuhoWg6KgQ 9HDXW2VLbi524FkUXXD7jzF2eUhBkr6CZvuUf3ykXxWR3L4JVEhmjBFyklQXOOYnRXefCm z6UNIAvpo81o4mqAfk6j0IkS24gc7F0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-kbixxa0dMh2VtpGrchFiUg-1; Thu, 24 Apr 2025 14:44:56 -0400 X-MC-Unique: kbixxa0dMh2VtpGrchFiUg-1 X-Mimecast-MFC-AGG-ID: kbixxa0dMh2VtpGrchFiUg_1745520296 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3912fc9861cso476276f8f.1 for ; Thu, 24 Apr 2025 11:44:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745520295; x=1746125095; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4Wgp7mJTIaWr4iSqP087qB/jzFoWHBMGQ7zhcWzTy3E=; b=EoUFHo7UP4FAOwUdtLAOLn4NjEGTMkCTXA7sE/zhGvIaTKXZHacHGCP9BlZOCK6ez4 Fz0a0PFCWPbJGVCLnSSIQli1s5E/tJAMxZEulIoQIcdorpWXU+ItwoC+TZx4HBPmnM+I DJ3e+9CkG9MdBofWLu3Bfimnv8DPpqLHHnyGlzDSvqqNQd7bd5sO4ECw8JLBFQHxdgxV zGLfLFVrhDazTaU1GaR7yMaqrv3bDkaU6bfPZiS/WHLYT61YDICo9n/eTbNw3RiZ7WDY T+30UOsvMLXYtfmDbUFkxzlavzKWFIQ40PcLFd9wckJPZCPNEGldgQftzbCTl1Cha/5e xGJg== X-Forwarded-Encrypted: i=1; AJvYcCUK/vJGdR3tZpL2bJhi4k3ElLZG1Gz+60DAK7YtrANTVe1CXL/yAC7OubChkzGlKmfyOdQ2BC494w==@kvack.org X-Gm-Message-State: AOJu0YwesfsXw9iqNmrGOU4caVzFCMYGGHMxMZbl6hn6/IEHW550zWAB RRgKU/xXD94KG/PXJCxZN45x+y0zEnLQo0QFakFOdhxwnQtY/HWj7oLBSi3zY7QYZXDE0RR6AeE c7Zhsv8LjR8e3jq6qX3g5AXMfMvXsMTObekp0WDNuSmRNynYc X-Gm-Gg: ASbGncssbzvZxrNEQx+gWBgxzet0T9XEtJpZteWikF4MdTmXbVinl1YKR3kNkJSPpur mCkakhjdOA1xF2/0yNeDsiy1gAVjXqaJ4hM07UHAXbUyPoKlfuTFENuib/EF+4omkBuQ5cYF7Ql NvyXN4TwKkxcyg287KMIPixdNpHtcTdZKKD1m9wxF/NEY6wJazfkppLXSeWIyQ4v21ivl/CuOzs tg6PpHmmV7jcVCZlFXeOjtfbQGQDc0pqlAQubscfCn/xYtKNuie4unGk9EjmZRtTiRSSqz6OAp5 KR5yd8F38vK4WJuhXV0+gMltOBpcst9w+X7Xls+y X-Received: by 2002:a05:6000:1845:b0:39c:1257:dba8 with SMTP id ffacd0b85a97d-3a072bec7bamr352121f8f.56.1745520295619; Thu, 24 Apr 2025 11:44:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVrk0FlqgHVF3dFVdVkNQORTSoJDd7kHK+rTY2xooC8UvM8KNQSh1LVG3nMO2+UDuefg0LEg== X-Received: by 2002:a05:6000:1845:b0:39c:1257:dba8 with SMTP id ffacd0b85a97d-3a072bec7bamr352098f8f.56.1745520295142; Thu, 24 Apr 2025 11:44:55 -0700 (PDT) Received: from [192.168.3.141] (p4ff23144.dip0.t-ipconnect.de. [79.242.49.68]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e5d479sm47286f8f.92.2025.04.24.11.44.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 11:44:54 -0700 (PDT) Message-ID: Date: Thu, 24 Apr 2025 20:44:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] MAINTAINERS: add mm THP section To: Lorenzo Stoakes , Matthew Wilcox Cc: Andrew Morton , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250424111632.103637-1-lorenzo.stoakes@oracle.com> <40e69993-e83b-4019-943f-ab90a43eb0de@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <40e69993-e83b-4019-943f-ab90a43eb0de@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0DcBv-pfq1xHodmqlDm6TJ64Z65VSOI-hdPf6qVXz5c_1745520296 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 54C9318000E X-Stat-Signature: hfgo7sctp544jidroecefo3gret3oqni X-HE-Tag: 1745520299-228117 X-HE-Meta: U2FsdGVkX1/fFk5Oi4gdjmrjzbTE6GmFVmG0flVMCfx5UFfy+TY9B6SGq4kHZc2KdSyWsKrfSc2D7xOJ9B30W7oPHrolkVBrohlqQdGEU73NNT6MahNldxTYc2xtwF9zdZ8OjEFUpUNUkfT8Eyo0a3rc/faPy2OlgMcsSRrT2N7eUHOx+7jv0315XuqVRrJ8YOJW1S7BbJ1WGvE9Rri1ShBTcFFRP7h8CDqMcHNBlj1ysAJLclIPRILWHpn1LHyjarmBBZPRGSemKluFsByyoNKfGZ7Zuc8bMFFQO6/YvQZNpuDxh3gteGggLlxSwDxJImffgI4ARcDIRNkPVJOTwmWbCOSynQMXrz4N0JKtMPquLSctc/BgUllI0DIWUFIeJUNc5JsoAZd/7DFpzzZbe+35gwAv8LWnRthKDVDClDuCPcL4Gbw2PK6gFIXVprrhQFfkx53Nir3oQyVR+9Rpf1Ot/vj8rdy6SUS9Xpz/F4rNolRcyvj5X/koj9rOYy4S2QreSYd8z5fN5s8HCFPjvYD2bnM8f0LjpjEL77eg+Sxzi1dU12X4m2BDurcMV8tKrAyVqXWtkelc/TfnWuHHht4Jot1PcGJI+xK5GMBc7ZepQNEhMOTfDSBl+DarpexfLmgOyc+VrEET1r0wbvCR4akXL9N/qsXLJEV34hMHTH+Xm55iy/ATWpXbotEhDnrz+ct+6CPM3jbquT8EAATfxWaQmhHrnH6WkZxqD07XjQcCDOTDUF0eftEu6MdC7UGVlM0SrZkm4KVwS88rdfV2hKr+4R9I2cMkvn4eOeQbaegyTF81zjj4Kkz2OdvmERwnoiz+OeYS3YSb+GWSfM4xx4mnGkjLxyV1RYSUXNfBXdW6abBWwj/DyB5Bm0DqCWyPVppr/pbPxcHNjLpxOIMu/cUiqMGF6lvuHU9G4oeSPjjATHpfjG24Xvse1gFdI4AWIiUA2XGViLWzv2QBWpt f7J/0Xgg tr20uQNqUsvuJe67ZFbcFBuNq8TioCcQnSMgAz7C2KqEdUSjplmY7f48ZpF5xZSbQOjnPilXo0zEt0UhBAShpOOtDWRzWuTlPRMYtVJBcmoOmYLSXJAPDpOK+QtJS/DM4Rq66FVw/CPERzwtzASH2WyckvN5US7zvf3U+vNIELlZAI7G3cL/MOEqIGN0deytAMKocdGZyLneAzqndxrjBzu8MlWr58F7hWS2cjkQyzjaf39MRNj9iEJYPkzjTNqeObYtoM1/u6HdgJyB5fRYaLiIBTr4GPbx4x6T5jLAeyCaFMsR4HfMEk62Je0y8iUFgogpIAVrCNJtjax1A5C8IGf0wlvqSmyrQaJLWDQoR+svm6xgzmaTqBKOVvcbr5s4dTQEsvI5fWWtBbEUkq4OreFxGz4iRqF5TY95bklH6KEj5huI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.25 20:11, Lorenzo Stoakes wrote: > On Thu, Apr 24, 2025 at 06:57:22PM +0100, Matthew Wilcox wrote: >> On Thu, Apr 24, 2025 at 12:16:32PM +0100, Lorenzo Stoakes wrote: >>> As part of the ongoing efforts to sub-divide memory management >>> maintainership and reviewership, establish a section for Transparent Huge >>> Page support and add appropriate maintainers and reviewers. >> >> I'm quite queasy about this. I'm doing my best to make "THP" disappear >> as a concept. How would you define what THP is? Originally, it was >> PMD-sized-and-aligned allocations, and some of the way we expose it to >> userspace, that's still the interpretation. But we also have folios which >> are of some hardware-defined magic sizes, as well as (for filesystems, >> at least) random other non-zero orders. >> >> Memory is just managed in variously sized quantities. There should be >> nothing magic about "THP", and I'm still annoyed at the anon-mem people >> for baking various magic sizes into user-visible APIs. > > Right, but as it stands, we already separate out handling for a whole host > of different THP things by file, which get_maintainers.pl knows nothing > about. > > For: > > include/linux/huge_mm.h > include/linux/khugepaged.h > include/trace/events/huge_memory.h > mm/huge_memory.c > mm/khugepaged.c > tools/testing/selftests/mm/khugepaged.c > tools/testing/selftests/mm/split_huge_page_test.c > tools/testing/selftests/mm/transhuge-stress.c > > This is not a philosophical position as to where we _might go_ in future, > or how we might decide to treat varying folio sizes going forward, but > rather a purely practical step so these files get seen by people and the > de-facto maintainer is ack'ed as such. > > When we get to the point where we can simply treat all as the same, we can > reflect as much in MAINTAINERS too, this is not set in stone. Yeah, I think we all share the same long-term goal of not even having huge_memory.c anymore; it's simply not going to be special anymore. My hope is that with the planned "auto" mode for anon (m)THP we'd be able to switch in the future as default to a "let MM manage all that, it's now smart enough", to slowly phase manual control it out. We still have to deal with the legacy Huge/PMD-mapped stats that keep annoying me. Personally, I wouldn't mind moving it under MM core already, but for now this might be better to find the right reviewers. As you say, we can always adjust -- especially once huge_memory.c goes away because it will simply be memory.c, or whatever that file will be called then. -- Cheers, David / dhildenb