From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D04CC433FE for ; Wed, 6 Apr 2022 19:38:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E21C66B0071; Wed, 6 Apr 2022 15:38:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD1A76B0073; Wed, 6 Apr 2022 15:38:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C98AD6B0074; Wed, 6 Apr 2022 15:38:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id B81066B0071 for ; Wed, 6 Apr 2022 15:38:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6A4B31828AE26 for ; Wed, 6 Apr 2022 19:38:37 +0000 (UTC) X-FDA: 79327466274.28.6B3F7BD Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by imf09.hostedemail.com (Postfix) with ESMTP id CDC9D14003B for ; Wed, 6 Apr 2022 19:38:36 +0000 (UTC) Received: by mail-io1-f45.google.com with SMTP id h63so4200711iof.12 for ; Wed, 06 Apr 2022 12:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vGHNAGNQJ+jili+nDe/Ec5j5ASwqbtr085CgGssJUDU=; b=I0xeLq/G4IGv2sgI720zwJl21NVzHNM0zXEmIIoNpVWVvAuiDk++aM58zqwTTspPp/ nx+uQRw6RU+ZMJaEglvXfzu7kMuQEurl1j67Rb2Q1T5MyE0s5r15Zt6XyN672AWgpnCb MwNjLn8PPJY1qY9bP3MJ56sF3OPkym0v8KiGQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vGHNAGNQJ+jili+nDe/Ec5j5ASwqbtr085CgGssJUDU=; b=r5SkJdhXoE1XDMJjgKVQO1MMIQYhwbjnwNEL/WQOyVvzWnKA5Z1OtkXNTDbUUZH/iU ByJFKTimcEL5UY1WCmWRi2ngoDUNd5UGvd97n3vEPV6/uWE5Sx0g9ClP3PZxSwAOO7+n ajqSF4vQymJLRT8IjEdmKtBoWoLqfXt+tSoRvoaaZqpoDHLmWnGRVBonNtxIw+BX+3LO EpmCRbtI51ZVZJYUfy8jAiQhPsoE2crciy25DAME52WC0yUutro/W385sWmzGRJ08B4u b8/FUtcwk49EgZzEC5YRWEz0M47jOTFZFYHIuOSSZYhTlz/9GG7eEBh9scgtARwIJtE5 mCCg== X-Gm-Message-State: AOAM531pdxx+IOzZtY6zcSUVXxqvZrbqJRGqSTuHWSbycYyNbVjBAoG3 tpYGNljgEN3Ef/ynmTXFRiy2FQ== X-Google-Smtp-Source: ABdhPJysv2MloHTozqtk5nZiHOCb1+hWcKHSHjfhz5NKnhYsEEK3VKL1DiiZ7tK4C6bXa/5onGGRfA== X-Received: by 2002:a5d:83d2:0:b0:64c:fbd3:e792 with SMTP id u18-20020a5d83d2000000b0064cfbd3e792mr4841279ior.59.1649273914715; Wed, 06 Apr 2022 12:38:34 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id k3-20020a0566022a4300b0064ca623b65esm11875297iov.4.2022.04.06.12.38.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 12:38:34 -0700 (PDT) Subject: Re: [PATCH v2] selftest/vm clarify error statement in gup_test To: Matthew Wilcox , Sidhartha Kumar Cc: shuah@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220405214809.3351223-1-sidhartha.kumar@oracle.com> From: Shuah Khan Message-ID: Date: Wed, 6 Apr 2022 13:38:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: i5zy99mrd8simyt3g7ykuhqwroi4kn5w Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b="I0xeLq/G"; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf09.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.45 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-Rspamd-Queue-Id: CDC9D14003B X-HE-Tag: 1649273916-810766 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/5/22 4:33 PM, Matthew Wilcox wrote: > On Tue, Apr 05, 2022 at 09:48:09PM +0000, Sidhartha Kumar wrote: >> - perror("open"); >> - exit(1); >> + switch (errno) { >> + case EACCES: >> + if (getuid()) >> + printf("Please run this test as root\n"); > > Shouldn't all these be fprintf(stderr, ...); ? > > printf() is consistent with the other messages in this file. Either works. thanks, -- Shuah