From: Shuah Khan <skhan@linuxfoundation.org>
To: Matthew Wilcox <willy@infradead.org>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: shuah@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftest/vm clarify error statement in gup_test
Date: Wed, 6 Apr 2022 13:38:33 -0600 [thread overview]
Message-ID: <bc04ce83-eed8-f35e-9816-bdd9d0ac1470@linuxfoundation.org> (raw)
In-Reply-To: <YkzDoBUAhydtvnR0@casper.infradead.org>
On 4/5/22 4:33 PM, Matthew Wilcox wrote:
> On Tue, Apr 05, 2022 at 09:48:09PM +0000, Sidhartha Kumar wrote:
>> - perror("open");
>> - exit(1);
>> + switch (errno) {
>> + case EACCES:
>> + if (getuid())
>> + printf("Please run this test as root\n");
>
> Shouldn't all these be fprintf(stderr, ...); ?
>
>
printf() is consistent with the other messages in this file. Either
works.
thanks,
-- Shuah
next prev parent reply other threads:[~2022-04-06 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 21:48 Sidhartha Kumar
2022-04-05 22:33 ` Matthew Wilcox
2022-04-06 19:38 ` Shuah Khan [this message]
2022-04-06 19:35 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc04ce83-eed8-f35e-9816-bdd9d0ac1470@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=sidhartha.kumar@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox