From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4AEFC001B0 for ; Tue, 15 Aug 2023 02:57:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31319900017; Mon, 14 Aug 2023 22:57:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C2B890000B; Mon, 14 Aug 2023 22:57:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B143900017; Mon, 14 Aug 2023 22:57:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0B25F90000B for ; Mon, 14 Aug 2023 22:57:37 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D6DC7A0C72 for ; Tue, 15 Aug 2023 02:57:36 +0000 (UTC) X-FDA: 81124828512.09.8759034 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf04.hostedemail.com (Postfix) with ESMTP id DE16240006 for ; Tue, 15 Aug 2023 02:57:33 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692068255; a=rsa-sha256; cv=none; b=xcYKX3dMoJaN6XQwnaKQsNcB8dB0zvd4BLd7+N4b1/RH3w2WsnqYH5FRGRgviah6Vw6Ppn tNc7m9nTkzc+E+IytcBflFqUHpr+Gz/bsFn0vhE9zVXZi9kmede1i8UEcYjvLiXygeuDca NSZmUKFNTO7ZqU37NBiOz6F3Utu6Zk4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692068255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VRGGkjKNDoN1xd6fDfugUTJ1X9oIh/iloCMzdvk/Ilk=; b=oS0NlPvFriU+Bfi37j90eTd3oK+dhiTaAjxgvPCyrjxh1K9QClWxoHXuxpeRvm/qJJt3cS 50X0n+2LNtZS3UoYbBEvPCImHL8FZAz/SUSmkO1DoXJiun6Q+HZ8I0+FiJB3WU00xFskRH Jwfs3S+4XuPODa6LhusHInZW75lwWE4= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VppsQQz_1692068247; Received: from 30.97.48.59(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VppsQQz_1692068247) by smtp.aliyun-inc.com; Tue, 15 Aug 2023 10:57:28 +0800 Message-ID: Date: Tue, 15 Aug 2023 10:57:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark To: Kemeng Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mgorman@techsingularity.net, david@redhat.com, willy@infradead.org References: <20230809094910.3092446-1-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230809094910.3092446-1-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DE16240006 X-Stat-Signature: ae6yds6epjmpk5u5ui3mw7rzaa9wposw X-HE-Tag: 1692068253-378381 X-HE-Meta: U2FsdGVkX1+MJQIB6JbM+DOp5+OV+TO7089jJWpdmy3NJVxnIbprfpCuhLmWhPMT9ZzA2qLoMAuZWjF0Z6EbNiGrd4E97pI73Dw45fH3JlBCuNFW/6pi9rNvRSwCz8jsYv6KECQpH9sbZNvqxMw9FhDl2UR4Bi1Mb+KjGyjo1A1JZcXkWkdE41w1QJ5/2Uu/JTESYhQx3AUNS06ao1Dp1X9U3PIInCoIQ9GkglYBmsNEILZEuOimEj/TbGA1VMyf01JLw3+w5CCEiBHJ6K6cWG+X+T9woQk8bferrGzmOvRLnERh/nAmke33/3ofDZEtuv012HC+76JDWB870fhHNpEvwm8r8ai7gFXAY2nGMWOJNqD3hESL5WH+o6UTXYS25pI2h2/KpheUgV6XDfXOJlOPJ+AgqDNsU37veIxg2RDn+Mww56XBkZAxM64RlYsRAvcGlrPHLdzNLb+1mEkkExObAauqhmUquiBTi3BQMNcKfqaw7ZonU+ZbMR+c5qvKE6CmMkJDv2dmaCe5e8CC8t4OPWbZi7B5ihf9gBBAGPV6iQkT2KUpxNVHH94u/Zb7O3IulGaR6dn1BkU+vFrHPwpRvsR+7Tirm1vWiTtCM3ET2t4Sfj/tPOwWmpu5ir6fTzpOD3aDl0+RQiim/Uh5NHA7UrM2XL4JCqb+6e6ddjmOmJQRj6nCHUNFBPH8eimhhtBybyUtfBCVYlB8fJlNzaUzyQacZ3hR9G2eIqjNnf6m7MRuUYD26CmlTIhEKD2O51Y5JqDjQcJhcblyvYHhHc7Ra3vG7B+TzjAOE99YdZbGhY5ROUGzN7BuLv0KeTr4BSR4O7Ra8xEqA7fJmIwgYrvr65mz79fM0BfsVfihVeOYqewRKhEsK1+dvLP7XaubcsAXYVpiD+lhxAQWKlyTQyDkVCExn7KamXhClLV8vzs8WIHmR+3wPRgXrd81u6lzvIboBdF8bs1SqOa497G hJ8a2QAs MhmjoOvNllT2i27fBdRGB0vJKlN7YOPxpFf0WlLZzKLdN90Au3xO5T/VpDZiIg8x0gYqlUXOlgcFeKL5vnMaCssUUuIIKIgUg/BVwFXvNE8pwcWoYcgwjRqv5W8p6FWf3XwAVqkS7QIBtutlSeqrOpGVZFumjvwysB9zrukfqEDfxDWcibJ+8ZelwWQHLihpG+69+BA/oLiWBLyVMIqJUROjyjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/9/2023 5:49 PM, Kemeng Shi wrote: > Parameter pgdat is not used in fragmentation_score_wmark. Just remove it. > > Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang > --- > mm/compaction.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index ea61922a1619..38c8d216c6a3 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -2142,7 +2142,7 @@ static unsigned int fragmentation_score_node(pg_data_t *pgdat) > return score; > } > > -static unsigned int fragmentation_score_wmark(pg_data_t *pgdat, bool low) > +static unsigned int fragmentation_score_wmark(bool low) > { > unsigned int wmark_low; > > @@ -2162,7 +2162,7 @@ static bool should_proactive_compact_node(pg_data_t *pgdat) > if (!sysctl_compaction_proactiveness || kswapd_is_running(pgdat)) > return false; > > - wmark_high = fragmentation_score_wmark(pgdat, false); > + wmark_high = fragmentation_score_wmark(false); > return fragmentation_score_node(pgdat) > wmark_high; > } > > @@ -2201,7 +2201,7 @@ static enum compact_result __compact_finished(struct compact_control *cc) > return COMPACT_PARTIAL_SKIPPED; > > score = fragmentation_score_zone(cc->zone); > - wmark_low = fragmentation_score_wmark(pgdat, true); > + wmark_low = fragmentation_score_wmark(true); > > if (score > wmark_low) > ret = COMPACT_CONTINUE;