From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44227CD4F25 for ; Wed, 4 Sep 2024 20:13:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5EC96B03BB; Wed, 4 Sep 2024 16:13:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0DFF6B03BD; Wed, 4 Sep 2024 16:13:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3A516B03BC; Wed, 4 Sep 2024 16:13:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7FCFE6B03B4 for ; Wed, 4 Sep 2024 16:13:38 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0E9A7AAF21 for ; Wed, 4 Sep 2024 20:13:38 +0000 (UTC) X-FDA: 82528156116.28.A7B6CAE Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf14.hostedemail.com (Postfix) with ESMTP id 75145100002 for ; Wed, 4 Sep 2024 20:13:34 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=Qwc4ETNq; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ugFDCKTx; spf=pass (imf14.hostedemail.com: domain of steven.sistare@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=steven.sistare@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725480686; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0pStRXEjnih+38W1/zVW2Km02jUZY4cQMTpjXlTm0l4=; b=RchKIEAAjJ/0uBwUYpRCMo8V2immQCq4I7wJ1evPoGaZ2biH+mjFPdizN6AoEB/oullPBl R0VW4ZZAMk6ji8AEWggbIj07CPudZhAgqteLxyFnvvvWR3j8zBu0Roqb9zYBqZa1+Nqxnc 4fng6Z/A6TVb9Tebkq6vHXDwRQX3ebY= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=Qwc4ETNq; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ugFDCKTx; spf=pass (imf14.hostedemail.com: domain of steven.sistare@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=steven.sistare@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725480686; a=rsa-sha256; cv=pass; b=oH57WvcGbEzVC0fEvJ1QcLlGyfknoj40QC/HdkUSb9wDgfeNVXIMsH32L22xyeBH7eDm9a +RNiWOHwngksvTEKag4ICYJyhJnKcIwNcENRpof51AvzKm/62Y5CA7/GnS0eEabR/Py+mv vRjYizkt7D46PIMtjZCOcUXeXeMhaZs= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 484I0Xoc028375; Wed, 4 Sep 2024 20:13:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= message-id:date:subject:to:cc:references:from:in-reply-to :content-type:content-transfer-encoding:mime-version; s= corp-2023-11-20; bh=0pStRXEjnih+38W1/zVW2Km02jUZY4cQMTpjXlTm0l4=; b= Qwc4ETNqLLbK6Ley0EnMtoCoxxDpdqc7oxBBNup7QQ5/7qEbyhWzn7ONfRzOYzOi 9VVVus/LTbopS6zViTM6GznhjfiKkIwkPU0RoJMiZpSDh9yNw5GNW6NML1kN4WxN pXsPFhEkYKjbGzdugoox+RvzOHa8cN4cBOTcP+i4efhdP6vF8Q17za1dRPbzHNPo VnYH9yGvZFJbJ4EoPvY3zo6tSyrH4d5STrjJ+WRrUVy4hEct54DWLtpO1ssyfsBu 4yCPitV+W6OHuIao1hmSs7w/UcPk8a3Oy5bwpFpQmP9r4RUpYFzwsdae9o8EDRBY 7vtDs98DqzZEdDplmB2THA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41dr0jvttt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Sep 2024 20:13:30 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 484Id9NU018328; Wed, 4 Sep 2024 20:13:28 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2170.outbound.protection.outlook.com [104.47.55.170]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 41bsmgkxew-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Sep 2024 20:13:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F4B0zmF9Rv4xsYsyCRaucfDrr2jy5QBZwQi/SwKYCYSKoG9QFa4g3Y+PmBBwPiQM3VPJkDlDBLgd8fthXE+2mxkIfldWdoa1e4XSb3NZh2Y/qJ9ondp8EOxw9W8tHUZ2lyKoED5tSptARsxwYyEoJ0YMhIYXLpbhbMwjkbT8LF01NnxZbuWNOuCkkO8jiowp9Lzrt74bzmaTZ6KFnpGxQNhnE1zoxpIQa+IjGojhWMZGKBnifArPhBCxeED6iNTcqvpPtMn5E9zyOj1mRF86rOxrt7el/8WoweDWVPbpmpafwTJz68FD8UG8SnhXDL2B33v+Y5Ac7uSezOa9wYV3Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0pStRXEjnih+38W1/zVW2Km02jUZY4cQMTpjXlTm0l4=; b=bguJOh1rY3iyeQPc1or4j8hzNnT3PLGMP9nwoXJGruEozkPI6saR8/bJDnwdsosvx2LmQxbLv1IJ2NL47UvTm3ZgW9BkNu128/SVoRFRmLTlD/Lc6bxJYKwFjggyUzficNaEeD5ER1p7aIW274Iv99SvZkc0XHl4Y1T6AbRbcjdvX3yXWiwXClTRa/cXYfwkkoTik1nY3AugOXDssFVNi78BlvG0c/IN2Sm2/kF9hnLMNHMvsCyAvj2ct0iPgDwlLIp7UjhmWXmmqP21vOHWJOPe138ULK7DLfumlwJJEaCUkNvh9pdFqUHRK1Z7s7YlM4bMeH9hLkPUu+b2sJq0gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0pStRXEjnih+38W1/zVW2Km02jUZY4cQMTpjXlTm0l4=; b=ugFDCKTxgdXyZAOkJitwPCzwTx7FypKVQxUUk9WFVE2J0bY2kpOZvGOcQfIcGSxPNFfIwxYKqzyKhlmXEqbFWXsCk6AHUh6+B4mRAmM3M71UGco2iGGVgrWwIG5AnZV27DuRtgo2iD0uEALaNGeaYsLfYyLJ7yIG8O6qgrxmcsc= Received: from IA1PR10MB7447.namprd10.prod.outlook.com (2603:10b6:208:44c::10) by SJ2PR10MB7084.namprd10.prod.outlook.com (2603:10b6:a03:4c4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.24; Wed, 4 Sep 2024 20:13:25 +0000 Received: from IA1PR10MB7447.namprd10.prod.outlook.com ([fe80::f2fe:d6c6:70c4:4572]) by IA1PR10MB7447.namprd10.prod.outlook.com ([fe80::f2fe:d6c6:70c4:4572%7]) with mapi id 15.20.7939.010; Wed, 4 Sep 2024 20:13:25 +0000 Message-ID: Date: Wed, 4 Sep 2024 16:13:18 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: simplify refs in memfd_alloc_folio To: Matthew Wilcox Cc: linux-mm@kvack.org, Vivek Kasireddy , Muchun Song , Andrew Morton , Peter Xu , David Hildenbrand , Jason Gunthorpe References: <1725478868-61732-1-git-send-email-steven.sistare@oracle.com> Content-Language: en-US From: Steven Sistare Organization: Oracle Corporation In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0293.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:38f::11) To IA1PR10MB7447.namprd10.prod.outlook.com (2603:10b6:208:44c::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR10MB7447:EE_|SJ2PR10MB7084:EE_ X-MS-Office365-Filtering-Correlation-Id: 78737059-2853-412e-d670-08dccd1e0887 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OFAyWXJuN3dzcXJOenhlMDVNUHNuNFVVcjFiYzhnUTdYTStpQ3g2T2VWS2E0?= =?utf-8?B?dkN6ZXdqNE5Jb2pmUEJIZFFJNzZ1YzVaSlJRQWxkWWQrdjJIRUxQS2xjaFc5?= =?utf-8?B?UEowc0l1bTJFNCttR0M2SzJSU2JGS2NJaU5VMDd4eEJ0YnIxNG1SRjRwdlY0?= =?utf-8?B?Y1hWVnlrTUp6SnY1SVpBSmRWRnN1bTk4cTkrZVJZc1NOMnoyd0ZUZmRFS2ps?= =?utf-8?B?cU05QmJnaFA0QndtSjdyOHpqYTZjbGVObTFtMUFtWDZvTHUxazE1RGJDZmlN?= =?utf-8?B?Yzl4cktOMkJ4aHpVbWhwL215bnNQWkpmcDA5dFRiZVVrYnR2aVBSUXJmcWk5?= =?utf-8?B?anQrcllKUXczekVUSmRyb0gwa2NGbk1NUm1BWVhHRUxETGRnbkhpUXZJVVJn?= =?utf-8?B?azVub0Zxd0lsVXkxeVd6a3dNNk1TdUVuOUhSOFJQeTlMakJkMG41ZFA3UndC?= =?utf-8?B?dDJOSVRYTnc3aGIyN0IvZVhidVV0cFBIeDlxbmt6Vk02N3l2UW54Njhlbjc0?= =?utf-8?B?ZVRRUjViWTN4TU1tcXNEREU0R0Rpc0V5RzQyY0c2bjVtS2lSYmhzaHdvcFkw?= =?utf-8?B?NE9sUTlISVdoMFlVSWNjeFdzVlY4dDdna1dKeTVJZkhhd0RBWk1FTmpodzN4?= =?utf-8?B?SHlIcUZaQ2laM2JmZVlYRndsM2F5VittQXNuaDNFKzlZMWNjMU5Vcjhpdm9U?= =?utf-8?B?NTg5MElmUmViOEJ1cEp1bjFMMjZ0bXVnRWFDdGozTllNSzBaZjVZL0ZXaW1E?= =?utf-8?B?R3M0UGFnWDBOWWlYbGxHeTk1eExFTHJDNHJKa3g0UGhkbmlRZkVoQVNsTUlN?= =?utf-8?B?bUlLaHIxVUhHcHlhR0lRR0NPL2dTMXppdm54VlROOEM5c3ZzOHYzcU1ZZGFM?= =?utf-8?B?enY4WDZQenBxU0V5UytLMnhmbkFEK2Vlb08zck9yc3VicitXUVJheUJtdUdU?= =?utf-8?B?UlBWam56MGh4S1M3VWxFQ0Z0K0Q0WWJjeG5QYllvZW55MGtoVHQyZWZTMVRL?= =?utf-8?B?Mzl0QlAzeEo2d2hvdUpTY3pmMnJ3M3UwcE5xY0N5cFNmZGJUTlg0QWlXa1Jy?= =?utf-8?B?OStVVkI4V2x3OWRMK2NCL0l3VHRBTTZWZk54dXViK3pEUUVlOUNtMU5haWpp?= =?utf-8?B?L1FZNzBTWTJBSXlKS21zN3poVFFTSDEvNGdKNlkyVlhlb3RVbERWTFlMcVI0?= =?utf-8?B?WEpDaDNCYlczcStBWXp5b1lETDlWMHBPM0lwazk0UEt0c0Fzbm0xSWxtMm5F?= =?utf-8?B?WHliUGY5cHQ0R1JOWHpXN3MrTm8zWEU1VDcyajJsdlJhbzFTV1RWWFl1K1Qw?= =?utf-8?B?VVB0N01ORGZmcHhUdDNmYWp4eGxTTzczeTZLUndheURZWExPdXJlcis3TkRR?= =?utf-8?B?eHZVWkxmNy90UVdkR0xYZXlyazFpN2ZYQUIydmhWSlVleVduc3o1Snlla0No?= =?utf-8?B?Zk83LzA3SHlzaVdwRzBLOFplcWU1UmFVQkJ0TGRxTUJYSzNLdEZ0eDRmTGVl?= =?utf-8?B?VWFXRllsN01LeE9FdEs2RVFXV2NmRWpPNDhyZEFxTFYxUGVLblJiSWE3Ujcy?= =?utf-8?B?azN2RE1JTStGelY0RVFNVHJkaUNMM1lmTFhwcnVHZ1ptUmlqbzhsTUxaQXhS?= =?utf-8?B?TkZaZXpZUVRqZzJGeG9vSTdUamhQWTlnUDdSQzJwaXZ2eEV5TFg1Y01LdUI3?= =?utf-8?B?ZmhhY1dZWmM1bGt4RjBQYmdjdFk5U1kwcWlsSDVSeHZPdVg4MUV3aVQ2bHpZ?= =?utf-8?B?M2hLMWJFaUlHQWx5QjdmZXVJK1A4c3RxUjl1ZFhCWEZtSEg2ZERRRENiWkE2?= =?utf-8?B?dnVOTW1IL0FPWlVhWHFDZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR10MB7447.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmI5Vk1qd1JUNklOTGRNeURqRVpWeFk4bm9QUlFGRFR6S2hlcm4ra1FMb3c5?= =?utf-8?B?cGlvVEdLbUJwbWR6MW1ndEw4TFV4Sk1oVGc1OGxMbTJDRm5ZUmlUSHc1YkNR?= =?utf-8?B?bVl5WFlZZWhZM3ZiT2J0QW05aW43aElSMkZNcXdDQnBsS0pLaGFOaFNHcXUv?= =?utf-8?B?TmZybnk4ZXdPMEJlSEY1blczY1BPYmVVUFpORXg4VlNzaGV3SWZlTGk0d0ZJ?= =?utf-8?B?YXdJb0NoTlp4OFA0YVBpbHc4SXA1RFI0VEFwLzVudTRxWmlkaDMzODk1MjVs?= =?utf-8?B?OUJ3UFNBbUlGcUNlVWVaVDR0WGNGbTlKODB3VjdzdTJBOWh5MXVBQThTUVZ0?= =?utf-8?B?UUN4bXM5bHdUTjI0RGR5Ykg2bFVzUm9KS1hHUHcrN0FiSTA5eVB1dElidUNP?= =?utf-8?B?d0Q0VTYyaDlyRzQ2dW01aHNMdTBUZDdYQnJTRmRaa3A0YjdqQm1vc0M1WXNI?= =?utf-8?B?b0doU05tVFJsaHFlVjRIKzQ2RHhOQ2pCRTM2TXdpMjVHcFU2MER6MjBXdzVl?= =?utf-8?B?anY4MEU0Y00vNnZ0ZC95cjRLMHBZZFpjcFFKODRJWGtKQXNEMDdzUkx6Uk41?= =?utf-8?B?dS94VGxvQmdtNGxIOTNCWHFpME83bTNGa1k2SjJSTWxuVXRwMFowMmNsVi9r?= =?utf-8?B?ak1OYVcvVmhhV1VrTGcwb3JCb2lZbzR4OVZzZWdvNForM0RNd2gwdy9mTnNB?= =?utf-8?B?b2VBdDBYYnR3a1pLK3R4cDJLOWFOMnJTWDRNY3RvQkpHZGlKdmhJU1hqWVNm?= =?utf-8?B?eUxVQlpWNjdxc2hqQW41OGw4Sk9ZUCtybDQ1N2EzMDZYSmtaL1l3bkhoSmRJ?= =?utf-8?B?cVNkRDZjTzlFUjJyOWJsUVp3RWhqWkdGbGltbWgxenFpanN6VkYrckFwR0Za?= =?utf-8?B?MDRvN0d1NjdNeFA0UGsxWjRyU3cvZUt2a2tueW9EY1RHNEV0QTVLbUJKTjU5?= =?utf-8?B?dlJXcHRVRHdpREJDOE9QYWJpVC82MHkwL3FkYVNCUzhTaXNDdGJjZXRaRmo4?= =?utf-8?B?K1Qrd0ZkYXVFWTBKbzRBazlvQ0JsWUpvRzRvNXBRRHU3alZKSkxZNHFmbGNJ?= =?utf-8?B?T2dqT1RRamQwNkVVN05PVzE3c3lIU3Rvc3FIRkFoYmJWQmtSRnYxVnB4akhq?= =?utf-8?B?aE1SbkZRbjNPbnF5Z1poWVQ5ay9iVjRiWG4xYkdmMzg4UDhmUDMxVmlYRE1a?= =?utf-8?B?RFdyWGRhaVF6R2xwSFNjczloK0ZmNG5hcUlEd1hDeVBiVnhlcFROYmVDVTBx?= =?utf-8?B?SFVRU1JVdDJsWjZtajIwdFF6Z3UyMURPS2lJelM4RXcwelVkbjkrSDJZWUcy?= =?utf-8?B?cVhNbG8rZTdJMGduU1dqN0l3OWFVbGtrWjl2SVJLMWU1ZGljZXVrOUF1K2c2?= =?utf-8?B?TDgvOGxYRTZzNW9OK2l3L2sxOG83Q1d4Um5OWEV0S21HK24rbEZiL2RZaHBo?= =?utf-8?B?REQ1NnZSL0xwam40c09IakhMdC84Q1RJeWdRc3VrTkJJRXFRVysweVlVK3BS?= =?utf-8?B?MG9mWHRSV0kzM3FHNG0yVHI1MWcrSCt4U2dMNWdRSytMUWNrbHJ6cGtGc1E1?= =?utf-8?B?azdCNytEY1FCeXR1SXZEeDBTNWNRcE52L2x3YlpuYjM1M01SeHFmM1QyYmpZ?= =?utf-8?B?M3ZmaFFGNGdCNHdsYXQ4b2sydk5zV2J1Q3Byc0pCbVErS0ZNbi9NczdkT2V4?= =?utf-8?B?K1FkeDVGNW1CendaN1R1QWUreDJPSjV4ejZIaU9XK09pOGhITnhKZHVPVnA1?= =?utf-8?B?a29FSUpkckNFdFhtT25LbVJRWEhLUkdRcGFtMWhMN0tlSEhzRDR5dUJFSVJM?= =?utf-8?B?WC9mMjJFRVdoZjVTRiszZHowMUhBMHB4bENUT0RDcFdCN1RzaGNVZ1FnVklM?= =?utf-8?B?MzZUYW5SV2JyckdsOGNKMXRUTHIwMUFXbU53RnhzWERJYlV2OWlvN2RSM3VB?= =?utf-8?B?OUlrY3c4S2NYeVB0YVRrUWVGeWY1cXgvU2ZxMFlIcThQZ2ZDdWRWZ2dQZ083?= =?utf-8?B?dUpZSEJ6bno3WmV5aHNPMStqOTNiN0llWFV6MnFFaWRvUDhuQnlzeDBJZjg0?= =?utf-8?B?eGJQOHR3c01Gbk00eE5LbENWVFowWWpCUUYraTVyM0RLVkVtMHphT1U4YnhH?= =?utf-8?B?M3lZamhoQUhGL1ZoanJNcU5KdStKS0RBci9VTFY4SjBjRHpmNlg5THpGd3da?= =?utf-8?B?TFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: aHmaR5iNtjHeuGP76WkD59jRMkTM5ypyoEbprcc94nygDnkSW2MgOcUii3esINuGTLfelscIj5pLDGO9UwqwLgB+F+LRUy0DXKtmlnJPfHdithwtC0a7mC9NHTmfyUh7kJ4JFdKCSbM+R+1qCYMA4wFud4fRary66U9L/W1zhgs1fn+AAl7h5X9/cLRHvDOxHjGkytHr9IaR+Wm3hqF+g00YRKziWcNqN7DRrITuJXC8D6x/3Oo5YBjliMwMzgcNbLARD/XBGgniu0RINUS72hEO+T9jVyjJ+qITDInWlNxNbWAx35ls4CsO+tVHMQXkWZD3Tk/9CVX0K4dQD0A6tAW95jPyOwZWEORSWn7Ac1/qGoXvm7Qe/f5bFRshpba/D8WtRVovRM8qm+lqyQI/lvf/r8j+2RBNoK0W4TwUAq2TsTep7u+qQJmjkyx5HknZ8O+xmDzv2wbcpQVr1zHkcBf28lFHRb2Hxa40PndIFWW6+Hx7GEoslqds2hIfnuUGF/zjeKqaIWX8hXdlj0XvdLk8nZm4enz23N0bMISYxHdc4brgbk/0GXL0RbQFcVYL7EmO+pTRuipMPfLriR8A5Kqt09MVDKMAJ5V/XicvMOc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78737059-2853-412e-d670-08dccd1e0887 X-MS-Exchange-CrossTenant-AuthSource: IA1PR10MB7447.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2024 20:13:25.7471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8Q3wDleFGagzUKOJ25/SYpCyrQ6gODGJbqh04vU9p8Rgjr7Ma4LqR3U1zSCAUCg7ron7xZouudz50mAaWd6yXMxxdwRKtOX5iBUKf4Rh30k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7084 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-04_17,2024-09-04_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2409040152 X-Proofpoint-GUID: HS036jrV4OjNXJo0_FnSm3jjTA232a4K X-Proofpoint-ORIG-GUID: HS036jrV4OjNXJo0_FnSm3jjTA232a4K X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 75145100002 X-Stat-Signature: iqb5wbojyf8tum44oxw578ehuhiwf7tp X-Rspam-User: X-HE-Tag: 1725480814-902557 X-HE-Meta: U2FsdGVkX1/31f07hsWXZO58WRh5j/05mj555bJRsFooyJnBp/p/hdDSnYrL/p18Ftksa5tFlaMb+XlCyERCT5I9COb7ESlZsjiMsO9+cx2aXPzhN3btv/tByHofjRXy1/Sftz3S8T+Yii6oFXi9l9IGBTDmPDgh8SPfwCSmvsXHnWQieTxmeH5EZH1U4SDbgMRk8wwTu6j9lIXHapXJxX2C4nZnw4LggWZt5vwQJ2UUvoudFgTADt3fU46WXZXAaRUno4beyxF/8wF2hEbmvT750XF66/s44rPwokreXNx/3kIYZ06D4lwcifyd+kcwxdhbGZ72rHeJHGxWTUGMQDSQY4KKA/ddK6OCO0MV18E1yynb0DWZUQeRW8fSqh2uM+Zi/4r0poapfMPfb7CiqP6JoeYbZlXq9BKxTDqjU8jQQ0o4PJZXZpHsniuuq7hf9RntuQiOE2wkwrcezpVgI+Hwd9sMa6dguuxk9U0WWXThr/XYczzoX1hKgJSgIQ1vksYabBkFdx33rh+H1F3VQQnrK26FsbZyKX2Aq0izytETqJvQ7eYd/RPSZAQQz8cCSEr5UcMQhOXZxPg2eQyqD+GKh5jYNERY0U8mP7jitdeUWK05s4ZZ6cbCQ8A4zpYePVzOQS9Y/dYxCQWm/5QFIIdZYc2rQ55YSSxyUaiE5Q5IWrg/dW3IciJcWNrx2fK9HPLIPn551rwdqSoHNdoZ575RbNDn0zbHj0vafqKbtsAQSGsSeRPaKKEBIgEzFDQIfFibWtaLUhT2LVrfrsetWZsxiybZ34zLCDu1ShMHc5KSf6Rc533xcn6DkCrg0xgf9PInkhBNzImXNjeIeAmDviXTWzeTQ7ge+PAjpMYi6PM7TNpTmAQPLh4A1ZilpST+IGQ5SLeyU0y2M1d83nvdJvWtOfN4WUp1XMuCTj+1I8fo4tij3RzBHM7Hv/O3m9TANeIR7+LXXepaurETSnJ /sqySCWC 3SSqeh/KffgrYSXI9qPHHFN1RyDGivVvKNT1TxDSx3eLDBUcMpUYq2b+qEzQknYpkr9pgghWhgxX5iJ3kOBRXTjfydhXxu/yIBxLcUSZ0onpLrz5zK4PLr9WuwQgc3Rf9Zfhcz71Zk5kRNYjIUNRtHQVMzZwP+hlXW17H9KTCMdBWz4s0Jyk99fP1Dr4VgE+Hy+aQd1yD9XGy85Yw1sjnfjV4eKZOPrIneUf6GSyQNyT4+DXRsr0oVYDz3pq1apRSZaVLMyzsTvbfJAAqWS07zfncEgYyxW5O3ljB54hphQZGuaJE2tunTokN0jAsg81Hb4oMFXWMim3IchVFPoDdY1Rx5125o3YvBKvpeJ6oyO9RIn2qn3T/UXKqS7N2uyXjxvO4PSC82zYJmPwtAAM95ItjdhLk/lctVU/evywlNaI71ONcudySziScVBHqTb1ntVdZukAlppChwV+6hD5r81wRS4ov0A0bYgE7k/S/vLmcZen/uV7yppca5dd9KWBdMkO7SbkTp+m/IoMn1DM1kKGqKCtX7ZTfzwwRmHNV8quThZADTfNK1V0IWZEy79vcldNyMD2U2sFBf5QnYQwvwZ3NhxSosZdobKYBQYuRi1wmIYaFpqEf2tni2HfLmKH1ZUOf1KDSi180EbscL4gvk2Wlx4eUxsgey8LOmfnMUYeSPeA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/4/2024 4:02 PM, Matthew Wilcox wrote: > On Wed, Sep 04, 2024 at 12:41:08PM -0700, Steve Sistare wrote: >> The folio_try_get in memfd_alloc_folio is not necessary. Delete it, and >> delete the matching folio_put in memfd_pin_folios. This also avoids >> leaking a ref if the memfd_alloc_folio call to hugetlb_add_to_page_cache >> fails, which would otherwise need an additional folio_put. This is a >> continuation of the fix >> "mm/hugetlb: fix memfd_pin_folios free_huge_pages leak" > > I think you're right, but don't we also need to get rid of the > folio_put() call in the 'if (err)' case after calling > hugetlb_add_to_page_cache()? That folio_put drops the ref obtained by unfreeze: memfd_alloc_folio() alloc_hugetlb_folio_nodemask() dequeue_hugetlb_folio_nodemask() dequeue_hugetlb_folio_node_exact() folio_ref_unfreeze(folio, 1); ; adds 1 refcount - Steve >> Fixes: 89c1905d9c14 ("mm/gup: introduce memfd_pin_folios() for pinning memfd folios") >> >> Suggested-by: Vivek Kasireddy >> Signed-off-by: Steve Sistare >> --- >> mm/gup.c | 4 +--- >> mm/memfd.c | 2 +- >> 2 files changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/mm/gup.c b/mm/gup.c >> index bccabaa..947881ff 100644 >> --- a/mm/gup.c >> +++ b/mm/gup.c >> @@ -3618,7 +3618,7 @@ long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end, >> pgoff_t start_idx, end_idx, next_idx; >> struct folio *folio = NULL; >> struct folio_batch fbatch; >> - struct hstate *h = NULL; >> + struct hstate *h; >> long ret = -EINVAL; >> >> if (start < 0 || start > end || !max_folios) >> @@ -3662,8 +3662,6 @@ long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end, >> &fbatch); >> if (folio) { >> folio_put(folio); >> - if (h) >> - folio_put(folio); >> folio = NULL; >> } >> >> diff --git a/mm/memfd.c b/mm/memfd.c >> index bcb131d..f715301 100644 >> --- a/mm/memfd.c >> +++ b/mm/memfd.c >> @@ -89,7 +89,7 @@ struct folio *memfd_alloc_folio(struct file *memfd, pgoff_t idx) >> numa_node_id(), >> NULL, >> gfp_mask); >> - if (folio && folio_try_get(folio)) { >> + if (folio) { >> err = hugetlb_add_to_page_cache(folio, >> memfd->f_mapping, >> idx); >> -- >> 1.8.3.1 >>