From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B36E77188 for ; Mon, 6 Jan 2025 17:21:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC1126B0083; Mon, 6 Jan 2025 12:21:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B718F6B0088; Mon, 6 Jan 2025 12:21:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A11AE6B0089; Mon, 6 Jan 2025 12:21:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8377E6B0083 for ; Mon, 6 Jan 2025 12:21:15 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 260178015A for ; Mon, 6 Jan 2025 17:21:15 +0000 (UTC) X-FDA: 82977692910.30.F7924EE Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by imf23.hostedemail.com (Postfix) with ESMTP id 45E0A14000E for ; Mon, 6 Jan 2025 17:21:12 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LAvKK+8k; spf=pass (imf23.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736184072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2wnv//QTSFn+9n6myXN6otWIVgqcCp+eNVgKhbMk7w0=; b=EJ0EEQ6E3Edqr56CExIIDLLhSh4fzxwQQaYSIsVxQfe+t1ci2E3eJ4NLj1FBanoKz415A1 Kv68EVJMi5nlUZ0S3/+io5rh1zl5mEDfeVOyxVxsHXu62d4BnCTuCWgvCRvcpGhKxUF30B fuZYQ2/+cqKW4DCUnQyjHHUBvuobPDY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LAvKK+8k; spf=pass (imf23.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736184072; a=rsa-sha256; cv=none; b=AF1fmL+x13B60YUpr/Vo67xaBZPekC4d/K+YeYd01Stgl6PFZWBZ5fLp76Db9UOW+EMIxn fq4Rk1P8N0XiE71KAvXtzoEiKcXWWYoifu5Xsj5GkaM0gyvy1tMi5yxbWQ8GIBW2g/+L0C x/JX2ZHMVhgnHd2lPg6RsWPW2L7/oOo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736184072; x=1767720072; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=RRQ7xaFgROz9UC6MWoaUr9Qx1O0OENC2uN9BGB9y35I=; b=LAvKK+8kEDkyukjNhTv7BeF1tRvGA+C6oh84YumtMoldphK4DGpOWeJU znbvu2UKTRmoGRl234iIRrUbPGk3pce7tRmz+o0Rnw4pYp4AbrZ9UN2bz O4HRjkpR6LHopz5Acx+Fh2yzMJkyS7te+mYHUI4f39BhmLhUexArYu4p7 qrMwNlQUms2VY7o1d5dT7/RjJOR3Xra5aFy2WIuQTu+3qlXrpIhsyv0kL aXDU233srG2FzcyvAMqYCCgTXGM38jABPAZruprAplGIAxJT82IGzL0tA 4/btDhrsRrP3oRKH0LiAQvuVMYnOZSqLc0TDm5Yai/DHq9hHQJy/2R+UV A==; X-CSE-ConnectionGUID: 5tzzsGrVSzmpoco8auv5jQ== X-CSE-MsgGUID: U0X8PSoLTEmH0ULK8z9vpQ== X-IronPort-AV: E=McAfee;i="6700,10204,11307"; a="36495023" X-IronPort-AV: E=Sophos;i="6.12,293,1728975600"; d="scan'208";a="36495023" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2025 09:21:10 -0800 X-CSE-ConnectionGUID: x3Dcx6f8TKmcFYLgW9znxQ== X-CSE-MsgGUID: R5Ebei62Q1OQuSxEtN0CBA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,293,1728975600"; d="scan'208";a="102690247" Received: from lbogdanm-mobl3.ger.corp.intel.com (HELO [10.124.220.224]) ([10.124.220.224]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2025 09:21:10 -0800 Message-ID: Date: Mon, 6 Jan 2025 09:21:11 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/12] x86/mm: use INVLPGB for kernel TLB flushes To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-7-riel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20241230175550.4046587-7-riel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 45E0A14000E X-Rspam-User: X-Stat-Signature: etr6thajtp54d74hzhdtrbgg51trriz9 X-HE-Tag: 1736184072-468811 X-HE-Meta: U2FsdGVkX1/3yxz5qDLvi29qIJ/djYrVGWKdfaKNtbn0HRxeolDaG+xbTOEPXrccIrn/wXXmKXMM3UVF/PWFclfF4Y6YUwpfVRmJkBuCh+sd9CGffIZuvsFhU4Gns9ngqrx/5jwtrpDZQoqN0KpIMERx7+QNrCfBpkFJd3ZulvacRCixkzP3Ak9sICUGRJn/LBAoKs5THuuTCX1K0EHZ+ZwhAS29XPF+uRYCDDwHp3HPb1bjCMD1EeNuwP8JRHP+4GR9+CxcM96bQLF0mzVfPZHlpmbXHMxRN9XiuNPi8SGZTf+aWoH6SlB0yQ0GWALoHZW25W/Av63uwiCCgfdgFttE7176iuJuW1WEQw7gs7dmo0wIcfoc+M2NyEXI6SPqrVvHW6DdI9qpz0koFMckabG0BmXR7K7rhGUVARXGrSHPh5iPYBDsJYsMgY5Hh8npzLaQFuPVEVCdOLQHVcd5h8h+yxau+aZDmvAEkDwe9txX3Kdcbb3uis5RnBsxK+X1525DVfyMeBoDqZAfJwUYLinexuYOhOe/udAft44V7Ir4iBhbYiyr3/BKMck4WJLGiVWWzNY8jJcNs+aTQHkMHFSocOins0xDHDoMoW5r084uMxkCJchUvTZjzCcPlrc/YLoBPNBOS+LGMMq35sZZ6TfcPdmsAnvna8XuPf2kVCrZBpS1ux48+9in/WqmbrDomFzbSAYhF7QyFHgFtTJ1Rr8/r+GciEfRZwRi+vCkU7MPQJA0s1LYkARIOCbA+9ZMpoxqWSse4t73D0pz0p5Do1MdKuzdCdRFQ6YxAGOdEyimZ+B+W0vYCQ6/MAo7nYpg7iXl9X0/44sGgqFGRDZ33yKN0dW8quOnTN7/z4PfvskUff/LaU37FT1qoNGRaOsyHAakEOVdXDc5jiil/4xzQ2kQh0iz+47Bvc4sW+Z3gDdCdqLAp+UQsef0WdgX6Y/0ukZ7voQLdoDCvTgnZDy baqibDSy jVH0lgDSP46DhGdYdzArYTGmN/7x+Z0acuTA0VyU/1Q1Yqr7UofBOl9/bNnAnD7i8oVnHLfVyXcKrv6SC//ZInlfbICmxWRfG6/3r4nkMFM53EK0RLqjh4CAqcmMrdvceGytkp3fXdK/tXwjPuzxL59Cmj8NIuRuP3/uPS/LnMSD47GH5aT3iNFU5sLJQtZXOOl/SzNuqAg9O3/iWofOi9GHQbpszlH8PTZfuKlqC9KGoox6R4fS+76bTm4lKpB2LurNJnRYRdy/CyggbN1RrJXf7GQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/30/24 09:53, Rik van Riel wrote: > Use broadcast TLB invalidation for kernel addresses when available. > > This stops us from having to send IPIs for kernel TLB flushes. Could this be changed to imperative voice, please? Remove the need to send IPIs for kernel TLB flushes. > +static void broadcast_kernel_range_flush(unsigned long start, unsigned long end) > +{ > + unsigned long addr; > + unsigned long maxnr = invlpgb_count_max; > + unsigned long threshold = tlb_single_page_flush_ceiling * maxnr; The 'tlb_single_page_flush_ceiling' value was determined by looking at _local_ invalidation cost. Could you talk a bit about why it's also a good value to use for remote invalidations? Does it hold up for INVLPGB the same way it did for good ol' INVLPG? Has there been any explicit testing here to find a good value? I'm also confused by the multiplication here. Let's say invlpgb_count_max==20 and tlb_single_page_flush_ceiling==30. You would need to switch away from single-address invalidation when the number of addresses is >20 for INVLPGB functional reasons. But you'd also need to switch away when >30 for performance reasons (tlb_single_page_flush_ceiling). But I don't understand how that would make the threshold 20*30=600 invalidations. > + /* > + * TLBSYNC only waits for flushes originating on the same CPU. > + * Disabling migration allows us to wait on all flushes. > + */ Imperative voice here too, please: Disable migration to wait on all flushes. > + guard(preempt)(); > + > + if (end == TLB_FLUSH_ALL || > + (end - start) > threshold << PAGE_SHIFT) { This is basically a copy-and-paste of the "range vs. global" flush logic, but taking 'invlpgb_count_max' into account. It would be ideal if those limit checks could be consolidated. I suspect that when the 'threshold' calculation above gets clarified that they may be easier to consolidate. BTW, what is a typical value for 'invlpgb_count_max'? Is it more or less than the typical value for 'tlb_single_page_flush_ceiling'? Maybe we should just lower 'tlb_single_page_flush_ceiling' if 'invlpgb_count_max' falls below it so we only have _one_ runtime value to consider. > + invlpgb_flush_all(); > + } else { > + unsigned long nr; > + for (addr = start; addr < end; addr += nr << PAGE_SHIFT) { > + nr = min((end - addr) >> PAGE_SHIFT, maxnr); > + invlpgb_flush_addr(addr, nr); > + } > + } > + > + tlbsync(); > +} > + > static void do_kernel_range_flush(void *info) > { > struct flush_tlb_info *f = info; > @@ -1089,6 +1115,11 @@ static void do_kernel_range_flush(void *info) > > void flush_tlb_kernel_range(unsigned long start, unsigned long end) > { > + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { > + broadcast_kernel_range_flush(start, end); > + return; > + } > + > /* Balance as user space task's flush, a bit conservative */ > if (end == TLB_FLUSH_ALL || > (end - start) > tlb_single_page_flush_ceiling << PAGE_SHIFT) { I also wonder if this would all get simpler if we give in and *always* call get_flush_tlb_info(). That would provide a nice single place to consolidate the "all vs. ranged" flush logic.