From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D671C04A6A for ; Tue, 25 Jul 2023 03:28:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8E996B0071; Mon, 24 Jul 2023 23:28:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3DC86B0074; Mon, 24 Jul 2023 23:28:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B057C6B0075; Mon, 24 Jul 2023 23:28:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A16816B0071 for ; Mon, 24 Jul 2023 23:28:14 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 773A8B22BE for ; Tue, 25 Jul 2023 03:28:14 +0000 (UTC) X-FDA: 81048700908.17.41D7286 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf29.hostedemail.com (Postfix) with ESMTP id A608F120009 for ; Tue, 25 Jul 2023 03:28:11 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=PknHptOa; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690255692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6wY4cILkEhsrpRf+mNddP0nleKOSU9sayj8Z5h0ToXM=; b=zVtqfCnRNr8rpudmmNxh/DFyctldc2WlrxkuB2jjmcyVhwP0IKvpzUUVbKKOoEZeR9YWll TTy9CSB3fzkylXawbKvQJ+abTb9KqpF5qLPv/9xYtEq63pIz1zma7hxfCJ903laKzOvJsb Yj8RMOVt79X+eUkLay4atMKnn7zRET4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=PknHptOa; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690255692; a=rsa-sha256; cv=none; b=PVK/62UMyb4w53JmvpF8QoTNtXJjXxDm8HI6wuxCgrs+I0yjwO8s5UWL4RksloVhmLzhud X4shCTounyffN5C0lRtSDl7vWNeSTxslw4vEg7v8GV174DxlAmM/CfB+qwv47GasSN4a61 hlEHdGl0aP6MAmB2PU3lnwavovv4MtQ= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-66d6a9851f3so1183682b3a.0 for ; Mon, 24 Jul 2023 20:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690255690; x=1690860490; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6wY4cILkEhsrpRf+mNddP0nleKOSU9sayj8Z5h0ToXM=; b=PknHptOa2Z8+2vaclzexjcjHcgGTKnQ0JRJ89LK+GvkJZyUzNmFYDaw4LaxhrbAB97 Qlt49eA21cgLfip1YkLzQvNHl9NRE1uu+H3yLMzr5GUQw2R94ASja3LKRc7K2/IuJ877 /rUQws3HOX4h/pSV0QLIC/txctttQBZDy4goWlpNGxYwzk8J6CttdGDNpskz9IiWFE6E W06R7YBvAlwN2Ll/k0WZ+e8J2UJKgy2rlagtK3lUaqPgpyCrwLsDTNoP/0MXBrAUaLK4 fe8VXE6m3BmotnBeZ7KmASyzpGnPX5FsNzpJdMUNn5TjD0dfcmx5lygJuqraNOT+sjor yB3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690255690; x=1690860490; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6wY4cILkEhsrpRf+mNddP0nleKOSU9sayj8Z5h0ToXM=; b=JSsTfYzDNQ9GiZcfeMWCqEbMZjtpgXJt0/pO9sFfmSk8Eqk9XKJ9SRBS5qdfiRd3dX ToAxAJuvc4gyjOJG6qhvyMs8N+kcgGKmYk9jgHHChgXm3vgoGmYLS/7cx6nhE8No7Sk4 VdFGrp69C6kiWe6jj1/m/BWW1QwQ71QrTei93vkTfLSjLuxoXEbuhQvLwm0Z3wcQceRI krNJxMdCcs4WSHSh9XJrlnHHZpB0p4tuxP8+PXq1WZ26Y8G6v9Ymn92OwjBg2IQ3bSg1 jIPsOtkPoOTkJ9jidUxuRd2KIwEVboqg6R6XcqZe4dBO3WV7X6rva6sm2ETtIzeq4Ge4 2VuA== X-Gm-Message-State: ABy/qLa9BKSRLxQ71fxERKzIm+5DZ83lXtgdhi4kH7mccfNirclWIxAF iW/rTXteXQt3C5uMfOq9R9DwYg== X-Google-Smtp-Source: APBJJlHvnzRChS6v/nee9rDGEWxm9C29UVXVwYKOSH3HP5ue/guAsHAKmcdiSeukVqd30tCkGAz2cw== X-Received: by 2002:a05:6a00:cd1:b0:677:bb4c:c321 with SMTP id b17-20020a056a000cd100b00677bb4cc321mr15272930pfv.0.1690255690395; Mon, 24 Jul 2023 20:28:10 -0700 (PDT) Received: from ?IPV6:fdbd:ff1:ce00:1c25:884:3ed:e1db:b610? ([240e:694:e21:b::2]) by smtp.gmail.com with ESMTPSA id s3-20020aa78283000000b00682a9325ffcsm8407714pfm.5.2023.07.24.20.27.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 20:28:10 -0700 (PDT) Message-ID: Date: Tue, 25 Jul 2023 11:27:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 01/47] mm: vmscan: move shrinker-related code into a separate file Content-Language: en-US To: Muchun Song Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, Greg KH , LKML , Linux Memory Management List , x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-2-zhengqi.arch@bytedance.com> <97E80C37-8872-4C5A-A027-A0B35F39152A@linux.dev> <6FE62F56-1B4E-4E2A-BEA9-0DA6907A2FA9@linux.dev> From: Qi Zheng In-Reply-To: <6FE62F56-1B4E-4E2A-BEA9-0DA6907A2FA9@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A608F120009 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 7gb6jfxykhfe1cggp9h45gbpuueqcie7 X-HE-Tag: 1690255691-313238 X-HE-Meta: U2FsdGVkX19CL/07DseDyrp1ghkkzLMDEqQL1byK+x5q3QnVVMOPWWhBFnoZjSKorX4gZj1FJ26uenfJJzd9ag2H+5cqJclaC5V7+m0NKfGMeM9Gktl4zEbfzRd5OkevbxOuRrrZbUUUKDmQ6iyFn7ZjxkcFbwnomZxJi7VbLlcKDhCyfeNnjjk5D6a5NrjnT6iEpWHQcLW8JtUovjoDja9faDpRai85x8ruo6E99jstGmAGtYr+Rvd6OaUFi5sPwsWrGlS2xII702u026TUdAEkblGzUhwl/WtWVQpI+AtT808A1vGhW9LcqvdHRVFQxB7LhNRiS8A35stLfL/5O2v+stdtE1xkBjLwvCjo+orEY/z+JNNOahKayuosuQ5OSB+x3TOPe/bYTHlT/KVdFgWhbbEv8IGWL+hH75YUK2nk3OQLCm6Ev0vRhpEfUQl53CY8W8sE55j4stlC8T3yUegFkpgrk7pBCaoMZ8UI60Svu9pCwYHWfqfGN6+oZA+1OprN83pXZDjCc60YFxcjxAxkBaYM787L4wAfskzrfH8wmFGDAK7hE8BN/4X80Qn5JUR4RvdDzzXwNyJVYFDvK3dy3d6/E8jhloO37qs5eQ2S4Mti+cxKRORQps4RoaL7B6jcQqoDuInVWuwCweB/juVSTugDW4SCm059BY0UWceKsiNPVHM6i98SUq/dI6QVSMIbxOVBn+2JUARItGLSCnm9SHU9NVHlHURKwfKapy0X9IB55FnxHTIODCCuW9JsulBWlRKh4ENea+/PiRW6+vmr+EDs+65Ih2vb5ftvnA87mIWJeC0ML0GfzHGN2kUbVtfaTTzKUP6NnEmgl76Sh+lEl+76kb0tbcR/sSWJQtSxKDGp69ciY6bjQniMTuKz5BxnG8NivY2u/HgirHQbmflCg+dETBfYrKSrA8kknrIeS33tCu+YwQvz3KyxXgWEGRTnP8oxHN7sjG6fuNR XKvbua5f NAyfNagAS9s2uLOI8jfeCUI6P9HkUUSfK6+FWGNYj1Gb12uLGHD3cHJBTMXkSU58zwvXmc+KrY/dxjZH4zlJd55qGrBudsxoewLISl60HfHgezwvouo9D+YZyJ4rJb58JwgJHqcz1vryyJGmS1KbR+NcmYow+Y9FWZCjB9DCLMPtDzv6LSkwVFV14drTt3oRM7iUeXgRQL+Q8l5e1ktxxilAkrM8HpIsBX891rVVN8zDx1qh39DTMmQv7Cvz1wQGDAoO0KPUHMEF/k7YdQsTluXxoxdvP92RzI5I5gZtbfEpmpQLiHM9HGYWp5GgH4lPE67RVbLLj8qhv+2sOcL79y4xGhN4cXugjpD9px5fIX5Ye7omRKEydD08trCyH6FmD0d3ezzwWUQVLB1UP0DrJEcoTD6QHeQ393kis0xD5lpg14v01/K+0cwQljA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/25 11:23, Muchun Song wrote: > > >> On Jul 25, 2023, at 11:09, Qi Zheng wrote: >> >> >> >> On 2023/7/25 10:35, Muchun Song wrote: >>>> On Jul 24, 2023, at 17:43, Qi Zheng wrote: >>>> >>>> The mm/vmscan.c file is too large, so separate the shrinker-related >>>> code from it into a separate file. No functional changes. >>>> >>>> Signed-off-by: Qi Zheng >>>> --- >>>> include/linux/shrinker.h | 3 + >>>> mm/Makefile | 4 +- >>>> mm/shrinker.c | 707 +++++++++++++++++++++++++++++++++++++++ >>>> mm/vmscan.c | 701 -------------------------------------- >>>> 4 files changed, 712 insertions(+), 703 deletions(-) >>>> create mode 100644 mm/shrinker.c >>>> >>>> diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h >>>> index 224293b2dd06..961cb84e51f5 100644 >>>> --- a/include/linux/shrinker.h >>>> +++ b/include/linux/shrinker.h >>>> @@ -96,6 +96,9 @@ struct shrinker { >>>> */ >>>> #define SHRINKER_NONSLAB (1 << 3) >>>> >>>> +unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, >>>> + int priority); >>> A good cleanup, vmscan.c is so huge. >>> I'd like to introduce a new header in mm/ directory and contains those >>> declarations of functions (like this and other debug function in >>> shrinker_debug.c) since they are used internally across mm. >> >> How about putting them in the mm/internal.h file? > > Either is fine to me. OK, will do in the next version. > >> >>> Thanks. > >