From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39AE7C369DC for ; Tue, 29 Apr 2025 09:15:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 868D06B0006; Tue, 29 Apr 2025 05:15:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EEAA6B000A; Tue, 29 Apr 2025 05:15:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 645D76B000E; Tue, 29 Apr 2025 05:15:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3FFCA6B0006 for ; Tue, 29 Apr 2025 05:15:54 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C86C180929 for ; Tue, 29 Apr 2025 09:15:54 +0000 (UTC) X-FDA: 83386524228.12.66DD92E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 33B8C40004 for ; Tue, 29 Apr 2025 09:15:52 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="EQHej/8e"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745918152; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZcwgSF8VPBQ4GrzqeTBGO0gBdExjzBeKM9YAxqzWWgs=; b=ceoZXGR8a++g3SkHJRnlmZS8/svIQKFPu7YluFeBhilw4grNKdfBVeReqVm9K1lC2i3JfP xxrXCr/6MEaVcevvQVAForDLPHFycEtOmvN8MPyg69WhkzAK256JFIblMhqLLACvndcsa7 yrN+csOyAEBBI3ZgcL8pJCh2uQzf/tI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="EQHej/8e"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745918152; a=rsa-sha256; cv=none; b=wAJ/H7decx4HHenMnNcplG9Pzzerd+jKk6JvjusJ+PXZjKrUHUcdYXagN0zqyUPGynS/BA kbkwzqP7zRWSHjSTbQtZxUYOJaUUSGg2hvjJ/XKwcyDdWo3KJ7dBKCrHxV7XxFD0pK7+8y +CYC7xvBFV20RrylM8eIG4uNG8Sssho= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745918151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZcwgSF8VPBQ4GrzqeTBGO0gBdExjzBeKM9YAxqzWWgs=; b=EQHej/8e8mVdu0u9xzFOdqj8irmrf6w5mVh22kfoIJZDhufHBGwbN6/KGg+bjnUcJaCZnX 83ZRA6NarP+apWwxO//Xw1jrdwYQLV7t9i4mqZtTVLHI4z4XpdQxbeDsFTURKsjEX5akut JvbZwaSw84XNYDXz0aiTZ75ILiFnYlo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-A6p4CRlwOHW3HI1RdxQVVw-1; Tue, 29 Apr 2025 05:15:50 -0400 X-MC-Unique: A6p4CRlwOHW3HI1RdxQVVw-1 X-Mimecast-MFC-AGG-ID: A6p4CRlwOHW3HI1RdxQVVw_1745918149 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43d5ca7c86aso33350345e9.0 for ; Tue, 29 Apr 2025 02:15:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745918149; x=1746522949; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZcwgSF8VPBQ4GrzqeTBGO0gBdExjzBeKM9YAxqzWWgs=; b=ao+44XsZxv6OVchv1It8RBDXjkfzIZnvq/f2ZkhZ2844BNbpqrsEKMRcvLz3KV9IQT Rar4vtfmB8fCM0pKrzUNc+R5OLfUTTfcFpu2ecVnxyPcbz0FiZ/LVb5QlBA4TCi80p9u W3Gh7xvFO79czMR6Dzdho/fh68Y3FWqYpFqOshV4zIBTO07zW4yfJtKho1mJoWpJzC4c NAFWytAcolO2AKBq582I1dKlQWmvGmQGinNp6TGrGmAhmcL6GnOWakMzzOV+fLqFcX1V cW1AgAc7FAm/5VW1tbKJZd0E1KWJ2ThWy+UNbHqOMD2xu5d2dafjoVazP9W3WpmP9EAI qI0A== X-Forwarded-Encrypted: i=1; AJvYcCV9p2Q6mmAXyCpmJUpDUfMQ463SWprnPKx/r/ofMU40iya1HG1zRrPspRGmD2HBZ8WEbyGEmqv2sw==@kvack.org X-Gm-Message-State: AOJu0YzBtar+GVlCPRfSPvsdJKZOjo2PjRXGb4jAmh3JCw+MaGlWIYB9 dCOLaCtv4e/QTn8xlovpAc20WtBSyy+S3IuPrLh1ncjTCa3xGDjD2c2eDSA19+jClC4op5JDfNh s6xtzFKr0Bull9ahOCMYCXYmNyAmp7q873wXjnJBwxnD63yOB X-Gm-Gg: ASbGncuQIEV4TNxv5sGsB1FTtX5kZD5/I6b/JrGlMp10hvr3spR3EEgcke3dMc0ejlc Q1opGITVBm5vnZFYRjNEFtpcTCRa4XW3cGxHw9PAsHMDS6BV8L531lrqrJKuTixbkU5UxsmA6zq GH0WC+nvGaXz0mFOJfupxTN9e6FBiWuofj6unsNjVPpxJD6oYXKzZEuOD04cr6dqgd7fW6F5y5H OQCUDD8QWO8VVGCEjp34m6gEGX5EhQ1yb/Bavv/TVTKtEsCuhXV9Dihwnyiy+wvTNvg8NOlbYwc 4B7I06px6V0R0Pt+p8AIg2HG2zqIJDiw7zbMrptqQJ52Jf1UKoXdTAydHoMwPLZIjsvWlszWogL YshRu01w599bjHpUrp6cHZ8JqlDG1L8s9RGPf1AQ= X-Received: by 2002:a05:600c:1e27:b0:43d:2313:7b49 with SMTP id 5b1f17b1804b1-441ac8eb188mr20551645e9.12.1745918147556; Tue, 29 Apr 2025 02:15:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELhiEp0lABCNLnJeW2eLuvjciUB25c0973dnzFKV0LJPmcTWuy7SPqkifmdzuBt3v5z/C/6A== X-Received: by 2002:a05:600c:1e27:b0:43d:2313:7b49 with SMTP id 5b1f17b1804b1-441ac8eb188mr20550535e9.12.1745918145671; Tue, 29 Apr 2025 02:15:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c73b:fa00:8909:2d07:8909:6a5a? (p200300cbc73bfa0089092d0789096a5a.dip0.t-ipconnect.de. [2003:cb:c73b:fa00:8909:2d07:8909:6a5a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d29ba34sm187785875e9.5.2025.04.29.02.15.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 02:15:44 -0700 (PDT) Message-ID: Date: Tue, 29 Apr 2025 11:15:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/7] mm: Batch around can_change_pte_writable() To: Dev Jain , akpm@linux-foundation.org Cc: ryan.roberts@arm.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, baohua@kernel.org, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, namit@vmware.com, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com References: <20250429052336.18912-1-dev.jain@arm.com> <20250429052336.18912-7-dev.jain@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250429052336.18912-7-dev.jain@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PRE4nnjz5FJhL47Ksem6V3-XzLLSsP3ZTlNlQIOFyAY_1745918149 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 33B8C40004 X-Stat-Signature: 1ea915xhfr3zyrfrhyamodfyfj1awidd X-HE-Tag: 1745918152-25070 X-HE-Meta: U2FsdGVkX19HQHwepCW4FrxsBiqnPI2bIcq4XP36EsQBien8q/R6H/mhCSaAvCSwoeUckszuT7mjA4ae/w9vCgf43nZL2QfWNtZheRVizF/1/dk4JtPAVEnatOQpoYOtCblrzo8Rw1QG8kadCzU8lKDY8L8sNjDS9IUSDSKY754zmgp1tWfHC7bYHBY8CiajxRnQ5G71+13JzDFiGAix8iAIIlUpboxEIJ08wvdz2iqxo5pinLL6qU/iSZm2/iv2jWxKf5cVKQ6sQH9wnpebufY+WDmE/OBBzO2M1+NrXSHjKL8wexYsmiJ1kYOhZjnBeOl0DKWSCFh8ATHM28VF/AbYxbyqKIuW+uaJf6fvCBfsBleDpyeScvbRNBkW4E3mGbrN3dwkb7iH/OuY6iEid7IL0HxYr2xLwCb9RU6PdaoPxKFoER+Htfy0YBEeOUFsl6w56Vou21K4eDCVZlp6i+CwQRR0GSdRB6Hq/8JXPf8K1jAB6PLZL8kFOcDrbBEXHJYEpLYR/I8Ce3Fv7Hu7xBvFGF/Dy6AU9YjnWA4HiGRwY9gq5gjBY7HO5INR3kIPG5pm+lmxi/VQ1F6CBaElV4BaoOBlUuMKgOXulBfl0b5MMW/z5qyApS9cAl0v56MHkNIWmmUC1c0mS6yU4XdmKRw2vt7ttd0rtfESTwANDQ80d2iXUdGFCE5I+rc6FiI3TTorj3Ygptn3iDLZx247qDrckZEEqGHynwTCk3WI/048/1jfRmBGfnc/b6SIRDOh5+e5Y/tdwdtoOIG8UDA2Nc1gO1HZuVJLfrT420ua0pBVOQHT+/s+gLe5B5LhOYDKmff4FKYa2OaQBWSAYQARwP1RgfEULPXZk7YNlAG/1b1DvpER3HSGbS5h6ixz+EQx6xn9jCjzdbfDDS2ruueZ5vVmp0eQfS0Wq53V5TCGuFfr0DpmagKWTq9pO1l8eBbM6ukisv80C1X6AAUj87K gulcDW8m dA+ORMrPZyyMOVracpMOFFmkm8dYODDdcDlFhQxJPdwnExN506zV9/IYFdA4AdU90h+PPdzCtQ8Bk9HnZvuNZAJ1AVqdKdK2AyhGIrX5KpMkp51TKlBT0VNd2WgHWWZJj7pfFHFbyosFVQWjxF2Go/sMWH7pOsRrq3TAlDjB+gyo7oiHZbRxpzQcudt0wt0L9Gw9e6iltW2ucC4ia/R8OrZ2QdnuOeYyWXGM3tdk5FYHvohZYjGVPGrdEeKgUX1Guk3PF+mT83R4cODnye54KSTTHiQ/Kt7L9iulhipRyTln6kWtgYTn2KmEwSvIC+ga4wefjwh7y/zKGrWbo+TbHnTC0xU38nMNaa3NyIjlDcW4yeKkFbfW+EBQePO9b/Qon9qEXjomXS7YtUZ1a77D5G88G2GWZWVb3z8U6pedqrnN0DGGaHD4xlS+wTkObDKHZQ9TAmA436n6wSzzwfI+z7qb+8fjWd8/b8khG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.04.25 07:23, Dev Jain wrote: > In preparation for patch 7, we need to properly batch around > can_change_pte_writable(). We batch around pte_needs_soft_dirty_wp() by > the corresponding fpb flag, we batch around the page-anon exclusive check > using folio_maybe_mapped_shared(); modify_prot_start_ptes() collects the > dirty and access bits across the batch, therefore batching across > pte_dirty(): this is correct since the dirty bit on the PTE really > is just an indication that the folio got written to, so even if > the PTE is not actually dirty (but one of the PTEs in the batch is), > the wp-fault optimization can be made. If you want to add a batched version of can_change_pte_writable(), do it right away instead of just adding parameters to functions. Then, add a simple #define can_change_pte_writable(...) can_change_ptes_writable(..., 1); So you don't have to touch all callers and don't have to update the function name in comments. -- Cheers, David / dhildenb