From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B48A6C761AF for ; Tue, 4 Apr 2023 08:26:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5377E6B0071; Tue, 4 Apr 2023 04:26:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E7D36B0075; Tue, 4 Apr 2023 04:26:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D65D6B0078; Tue, 4 Apr 2023 04:26:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2DF816B0071 for ; Tue, 4 Apr 2023 04:26:37 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0E46280D21 for ; Tue, 4 Apr 2023 08:26:37 +0000 (UTC) X-FDA: 80643027234.29.1B1AC64 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by imf12.hostedemail.com (Postfix) with ESMTP id 147C640010 for ; Tue, 4 Apr 2023 08:26:34 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf12.hostedemail.com: domain of morbidrsa@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=morbidrsa@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680596795; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P+IA0sfS8Hko6hpK1HZztJ6kiawc/hgiN78OoxbJlkE=; b=cZ+8o7Wq98Xv5m+Ov17PAI3yqodJAh94o7FUmrb5ns3aFNyMekopEOGUVU6jXHAERmm00F PvRncnI1o6n9ac5llMRrmr2ue/ti6rVtTQk6OD+HxmG6YGLQKNndwJPIqZzXA/TkCfZZm7 UvaZHRYO0cBGSB/ap+T8CvEUDENkDAI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf12.hostedemail.com: domain of morbidrsa@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=morbidrsa@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680596795; a=rsa-sha256; cv=none; b=qSOS56IsZe2YCv6lg/Ja+zLkBidhwAUpFl1axTyF3SuShw8kRz5OJYdbWCMVTUw7eyLrWZ pIMNLuMIRVkr0B3ZOaAdSYnqv3bd7TQJF9TdqHQf08SEqMw9v3GndnVR6tZbIoe81scozl DFyHsVqTl/x6pVUf6gpmEfH9Uu3fl34= Received: by mail-wr1-f41.google.com with SMTP id v1so31871769wrv.1 for ; Tue, 04 Apr 2023 01:26:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680596793; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P+IA0sfS8Hko6hpK1HZztJ6kiawc/hgiN78OoxbJlkE=; b=ByvIWtaxHY35AS6pDvDnvHDX0NjZTIE4FJcZ4qYdbaSfEU1i1q4CH8njv7Wa7gDZCW KMsNPYO4y95eu8qmjTQ2NvRVR8Anx/uwVSiyX10CUsQ5bgMh/ZxbR2Bo9ETtE88/Bnvy bbm6imOGonmEAWQU9hwJdn+h6qi7YgOjoB+chTVr2CryzM4P/iBnfZlfPaekluyp2bLU 9Rf/qJg7DMwLTABg45tSSSPIeCXk2feWRW05Ew18k1oqkY1tzzC83Ldi0aDJ0O5MWKkL rE3b8SePoa4m7Pec965hxbaSCcxs2Oe4cC547CpVnNHMu0FHjZr6F1n0pT/VfTi1zpD7 6zkg== X-Gm-Message-State: AAQBX9fVPaNUtBHX/UPYdVlsGfJITqfXF2Z67eTz2ORwSYQBuVHrbhpz 1cZQyfus1163K34DF+ngMMk= X-Google-Smtp-Source: AKy350YRAl3M0jE5+UynIwckjiW+CsHm28SGM1LHNiMQ7J8tXe8xmw1F2qmXD/R4sfgmgOX6wBeBhg== X-Received: by 2002:adf:e0c3:0:b0:2cf:e747:b0d4 with SMTP id m3-20020adfe0c3000000b002cfe747b0d4mr940685wri.40.1680596793398; Tue, 04 Apr 2023 01:26:33 -0700 (PDT) Received: from [192.168.32.129] (aftr-82-135-86-174.dynamic.mnet-online.de. [82.135.86.174]) by smtp.gmail.com with ESMTPSA id t6-20020a7bc3c6000000b003ee1b2ab9a0sm14294575wmj.11.2023.04.04.01.26.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 01:26:32 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 10:26:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 17/19] md: raid1: check if adding pages to resync bio fails To: Song Liu , Johannes Thumshirn Cc: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org, Damien Le Moal References: <8b8a3bb2db8c5183ef36c1810f2ac776ac526327.1680172791.git.johannes.thumshirn@wdc.com> Content-Language: en-US From: Johannes Thumshirn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 147C640010 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 4txw5jd4qk4t5bo3f5gpbenfzw3m31u9 X-HE-Tag: 1680596794-569593 X-HE-Meta: U2FsdGVkX1+3lREJkQAqC0GJVDQuz9d4UdcyE9NMxr5wavhQEUBl9Fw+5KxIQ6g/PRtZiMUUJSIuTYGPlFpw/wPlMiO0IVXja3A3vTFSBATL2vaCvSyAtYhkXVFzY0j67E7yuni0A5AXXL1reUz43mSt/HCYHJFE6kmoE+6lzixlz9s1JQ2KqdMJ7psYhV7Zw3P/7/Y/J83KsNmG5/4Tja2H9mt+Ad7Pid6YLQBBm8AMrVQ20NFczlJGGrMkQmnax/cXOPKZz1CdjsTGecFRVJ98Eu246TN/kQX5wGTQRtZKiayzdbj1kjVwc52XGd/APJhw6GNo+ftNIpJHsWR5xJCb/Zx1O5reAjP9pWXUCInuek4JNNHEm0Z3HxKR+MfLxVbm6vh9Sn6lALnlbpamgDvLsFDXYDI9ztKd9024OgnV6fKfAMtwrxFYhkUDGjriyExpWBPzy71RpLY1aVY6jHk3EzLhHFEECENU/MSrBAZP/EZq+EoQrvv3LCw714Pssc6mqYJyNk9Sk38L3HrTzLUFUBloYfTQJs4yLyfBFw/SepEB/H9hrV4LMKnuicNT1mcIDoXc8NjE/8D8894mjNQG0vMFjtzsYp8gO6JQ/tyHWnjhfbUkHQ+BFBeP7aQfNlfxgH9EjHuBNG9yGo08d4lY8KkBTYN8ufaZBFBgGPO6g2t89/Nkxr7LTVbHix9ehvvF3Sb5CqE/muqfvs+7jyWlHQH9ZQ4u2AvD6LuOW085dJYx1O8elxLAsw+9g9wWjFulTpYGNLBrRlUe7kKFb7CqugFFESP2Kozv8gvmc+amtnvZ8X02pkpD3heKpMS78aUjR+aqt3WWZFzloeB4jvFQs2yFobLNeaQeQrWXMicpbWxn6LlwhBJIuFfD6/z/d6WMw3dvnXiU/29CgJynzzdcOx+NeccFu+BeHm3zMLEzI0j9bHu2fGjQMnKXF3diB/H3a4v7mSP0Cta2hwP /83sq0Kb V1OMxRwrLF55pe1aL8b3DrWkLm8CuJQY2MCxl9z5G54YaMI2qrlGTg2V1pQjIlmFbeNGLiczXt8oc5Qmbyxq9JkHO6ahpUejtkijiJ2Ox1uu98aHB7ryu4PReldSbNSR8KRZamGHMNYME1g3iPwfaGTzxXmj2PLp7Bkozu78P23x4WcOV8mD7fo33kb+dI7rZTTTDAWimRw4SxLW2x3HPWZKZwbsOzbxaEos2Gd42H0XwKLGsqysWHXDEHaW0wqD2pU7ey5EzjoiNQ22wNDLi02OW1OdE2Urfn+mhwwXcr3o2Nf/+b+5IoO83PyrOgFjx7A3A7fURCfvtCrRbbh+CSh1aEoyKoKolntxrHQuvQDVRvHZNCbULmFb+ea9VEq41/PBHoW9rQRO0KZ/dZQ92lhnSTQhMR+QtaabG+H/1TyuSLdsD0/rDpXL4Gqza8YqROlmf+GBwDmnqJ6kfiqZuWENa2yR+WzXecKRb1NBPhAJiJoXPHSqJJbTjEROBdy9z6UoWqByXwNsvQK6/juxvIPWJoSyB29cDSQzxDe740It9HHn/moPRtoITWQ3g2162f4jJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31/03/2023 20:13, Song Liu wrote: > On Thu, Mar 30, 2023 at 3:44 AM Johannes Thumshirn > wrote: >> >> Check if adding pages to resync bio fails and if bail out. >> >> As the comment above suggests this cannot happen, WARN if it actually >> happens. >> >> This way we can mark bio_add_pages as __must_check. >> >> Signed-off-by: Johannes Thumshirn >> Reviewed-by: Damien Le Moal >> --- >> drivers/md/raid1-10.c | 7 ++++++- >> drivers/md/raid10.c | 12 ++++++++++-- >> 2 files changed, 16 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/md/raid1-10.c b/drivers/md/raid1-10.c >> index e61f6cad4e08..c21b6c168751 100644 >> --- a/drivers/md/raid1-10.c >> +++ b/drivers/md/raid1-10.c >> @@ -105,7 +105,12 @@ static void md_bio_reset_resync_pages(struct bio *bio, struct resync_pages *rp, >> * won't fail because the vec table is big >> * enough to hold all these pages >> */ > > We know these won't fail. Shall we just use __bio_add_page? We could yes, but I kind of like the assert() style warning. But of cause ultimately your call. Byte, Johannes