From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4967C54E71 for ; Fri, 22 Mar 2024 18:21:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22C476B008A; Fri, 22 Mar 2024 14:21:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DB596B008C; Fri, 22 Mar 2024 14:21:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A4256B0092; Fri, 22 Mar 2024 14:21:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EEE796B008A for ; Fri, 22 Mar 2024 14:21:08 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 81D3B1C18C0 for ; Fri, 22 Mar 2024 18:21:08 +0000 (UTC) X-FDA: 81925491816.01.0DBA4AD Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf26.hostedemail.com (Postfix) with ESMTP id 8C4E014000A for ; Fri, 22 Mar 2024 18:21:06 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HZoaetF1; dmarc=none; spf=pass (imf26.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711131666; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZCsdPU8TvLgwvx27n1JjkkvlHepysidwj+yYBUyfFvU=; b=USlMu4VDwxX7ZAoVIzprXAIAAb8MxVc06aRUO9SIOEQn00nzca6TqdTVz/CpvXhZ3BQ9X7 fDHSDaCEdSaNK+6TzK7LaQz4be/NngRCVU4luuNvYPypKr4a7quJh88wMn3laSVWNbaWCn SsPM4a33AqArKEQccw+QNjz+bMbI3EQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HZoaetF1; dmarc=none; spf=pass (imf26.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711131666; a=rsa-sha256; cv=none; b=nuUN/y3I5M1d5i/J2sa2hVxxGzyTL9OVsNQqxj+2YKI6MtK8ZCibs+QopNIvrihdxJT7zL T9qScYyrkzjPyJyjVjV/q6yhP2/2E6pXx83HyDOzUtacjJQhjZ9BpogLFlJJv3R3mJ0GtS BNhHKCcu3geSc1SS/p6syMtoNeqedtk= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6e8f765146fso1866097b3a.0 for ; Fri, 22 Mar 2024 11:21:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711131665; x=1711736465; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=ZCsdPU8TvLgwvx27n1JjkkvlHepysidwj+yYBUyfFvU=; b=HZoaetF1c0v1ylINWa5gEC0YxiLAU4oQJjnn8tHyY5HEHZcokm219i08RdaFdVIeqc JvXSX+5/2wXLnTuChIV3ZlvPCF+C6aDr3M/KdU447X5rHBy87tyS/7Fxr3JjpJlGpyRW E3WHr4GG6HusAw6KdNAJttv5IV+owbhqljfJLCd/uLh0P5d1FZVnBVXOBCPlzN9rrGwQ U19FoWz7Rbri1nN5CEyTXCLvSvzwTvaLAWhXA/LDTziExH+CoV2KTqPB0Yj2DQWDmPFU B1RHXSBde62mRd6V0YH8U3lwOMi5XEiiBP8gqUFdctHeZ6P1P5Ci/oHX0wdIoYnCVarb 9wiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711131665; x=1711736465; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZCsdPU8TvLgwvx27n1JjkkvlHepysidwj+yYBUyfFvU=; b=Oe3TPtMaulSR1ono5O+oLz6xfUe3zv58W7gIlwPeacbneL2rDd+iFNpgyUyC1MMQ++ L+R5wDr78GCVHUrZAY9IXslQEJMYrDKRGVEa8sK47bb+jWt57t05ciey3ukfWSuAHO9M sc4QKoPptqsFqpVzoQkEwzoyjB8YL9fHPuYRPZQvMyaGK6Dx3xziAiixVvD7Ov1IvBwk 8woZpGXj43tOFAZB+fVN4c7rOftkSRg5sEpJpeyoTnHGOvy2fpZqPl/rSKapGB9SksOX qpCf3vqQtYpfaib3SmewtYxvy5lRzQKDHA7KRSj/4QCqHNzV97vjvG4Z5CL0JOvKn1tF gAfw== X-Gm-Message-State: AOJu0YySz5Ss6StbJqRCmyRbFLhRDCVUnWsOOEHNkGc7Y1o2TqlvgA8l gvKpFtCpt653z1Ibm126s6P36ZeWkTemvbwYLTpA5nwldpPNrwXgMbkCx+YD X-Google-Smtp-Source: AGHT+IEnHjkLgCac/gX146QfYoCPdmnpDjB2s9pbwb4Nk3vBwjQqkx4dPHNdIUUDr79X6ksMtkucbw== X-Received: by 2002:a05:6a00:22cc:b0:6ea:79a5:3fc with SMTP id f12-20020a056a0022cc00b006ea79a503fcmr734525pfj.5.1711131665096; Fri, 22 Mar 2024 11:21:05 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id j36-20020a63fc24000000b005dc5289c4edsm1880971pgi.64.2024.03.22.11.21.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 11:21:04 -0700 (PDT) Date: Fri, 22 Mar 2024 11:21:02 -0700 From: Guenter Roeck To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH v3 07/11] mm: vmalloc: Offload free_vmap_area_lock lock Message-ID: References: <20240102184633.748113-1-urezki@gmail.com> <20240102184633.748113-8-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240102184633.748113-8-urezki@gmail.com> X-Rspamd-Queue-Id: 8C4E014000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: xc7cyphgk9siab68nbf7q4rs39maingh X-HE-Tag: 1711131666-657188 X-HE-Meta: U2FsdGVkX1/eRvWQNvQivVmrtHd+4lwE67pLmA62uOFIN+jdV+po5H2UIQyMMbiXdJ/afb6jQ903YArSFnD9NrAVoTBWEUXewPwzlOQapRncjfl+ZN3nQSJ6OBQ222L5utlfHSN4qg1/NHpNdLQC+wT2ZjzZWGbF4xZ0BOXgQRXPyRid/9XsIceWygKAY/mXN52AMIc9Cb6Be/OkrO84pFJuduK2xks3cXYNX85MxOt449G0oCEf/1k4OQ8qfwTU9rTWv85kEqDmncsDTky1IFuvnVIEDE1Y8zBQ3S/P6KIpohuBv4TqdLL4Xkm1lqFb6gaVCw+/VWhbZQKoDSztT7QJumMboEiMGxDkIvVcpa6V+p3oW1flDE3iUpvLoixK6gcG9OtzRaSDIUx/EW1xhINJlnV3f4vmgh4TGIwlA0Du8Y6EZlt8c6bwN6aNcbTQN27NDAyhX5R9rX0jcVf2FsSRflhyQJr0Ae/Y0HHhZMSUTKBkidpdYxFTOLJEK6UW1ElCY7FS1TjiFPjv1R7uSrAf1oQe/64k9cU8r52go2TXh3iyHR6RiRJF9Mv+zOgJbfoxpgeQVZq4RppvVKgEWx6j7AWy/NzT88NmD772Z6t8PifCsivD9/H/i1Uhbndfr4jOt+8g8X4Ix2dXlrpPU40m4v2qo+XyJTSQR3TFDPh6GJe6SyQ1p+EmDqCA30mo85absmD90CLO8FcKofQdatBAtSAkVYzd8A666nfWRt96yLIJ74bEz9iN/1Mh+ddmSpe4ARtJslRo6MA9OBmU8O3i6Tyj3ikNHzZMWN6M8xtcS0iP2ifWc2e6RkRhp3X0uDm/Ee09iWgHJXhBNGJYSCPiE7oZQN5/76a4drg0i2bFMJ5+A344K1IXQWgi4rdTqggTL7llY2+O/2etkuLFcOg9/fcjkCHVC+vVO0NQwZFV8f+g9ZzvhMUqh4lWcnsiWcY65YTmpm47r9jNMp1 UPvSC4ZN Z3w1ybIJytXinG7wtUh6YdorzQi9xslSaE785AL+0ymUgtzTZHFu1zAddW3LJEqzc5BvP89HVClNW/rnCeB5LsnSkREPPj4iWLk8AHEMsAH5lpqY+lX2Cj/Gf2m1wdsg/hGf/Tf35SWWYEwhAIKPsLcFNb69XfVQT3JVt2hrrjcyJb/8PoAANsSQ7Q2HW1Uw9euH3VWBdUmzMVNckLfoLRXHhTG9r6RS+i1VN3iBCL5h/6Jm6zpSDMl7QnaVAiZlzblBZUlQMIaiOKOXpbhTBaugwo8yX9HY8fe0PYL/d5bue9Rb9vrVRoXhCeDMsJ9kHqpYyXPHdy/g6iLF3QmPf4C46jw6+3GXNY6CZVbeqjobJayz2FpZk3cPpaJ7z8lNZHSKCcIcx2KIErQLiiU4k9q8pxhWIRSbFxR0pGsHJ7gvieao+xvGxwXpW1UVhXE0CZYhPuag/gMYkMNXEPnhlcpvMJpsmLd2SnHpvn5AYhryIPBXjlPyo9oT5RpUFlZ6TbOIhoDUqa/js8bzD2J0VWk5knvebFQqLeC3gc4dCCrWtT8H+H3Q+5XskjLSHXcuMwcY7FIGahTUIFpGGJ/rzGGADehqslsUBWKQUVEcXIC1IeKJ7P1KSOZdM6rkKTxZ9R8YU+sQ6MRX8llN3dlcD3WXv5yimIM/Giixhc9d/tXYI2RLD+3MAUrpkc7VI6ysNyeOuf1/LKlPjVTL3sd39mQCHqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Tue, Jan 02, 2024 at 07:46:29PM +0100, Uladzislau Rezki (Sony) wrote: > Concurrent access to a global vmap space is a bottle-neck. > We can simulate a high contention by running a vmalloc test > suite. > > To address it, introduce an effective vmap node logic. Each > node behaves as independent entity. When a node is accessed > it serves a request directly(if possible) from its pool. > > This model has a size based pool for requests, i.e. pools are > serialized and populated based on object size and real demand. > A maximum object size that pool can handle is set to 256 pages. > > This technique reduces a pressure on the global vmap lock. > > Signed-off-by: Uladzislau Rezki (Sony) This patch results in a persistent "spinlock bad magic" message when booting s390 images with spinlock debugging enabled. [ 0.465445] BUG: spinlock bad magic on CPU#0, swapper/0 [ 0.465490] lock: single+0x1860/0x1958, .magic: 00000000, .owner: /-1, .owner_cpu: 0 [ 0.466067] CPU: 0 PID: 0 Comm: swapper Not tainted 6.8.0-12955-g8e938e398669 #1 [ 0.466188] Hardware name: QEMU 8561 QEMU (KVM/Linux) [ 0.466270] Call Trace: [ 0.466470] [<00000000011f26c8>] dump_stack_lvl+0x98/0xd8 [ 0.466516] [<00000000001dcc6a>] do_raw_spin_lock+0x8a/0x108 [ 0.466545] [<000000000042146c>] find_vmap_area+0x6c/0x108 [ 0.466572] [<000000000042175a>] find_vm_area+0x22/0x40 [ 0.466597] [<000000000012f152>] __set_memory+0x132/0x150 [ 0.466624] [<0000000001cc0398>] vmem_map_init+0x40/0x118 [ 0.466651] [<0000000001cc0092>] paging_init+0x22/0x68 [ 0.466677] [<0000000001cbbed2>] setup_arch+0x52a/0x708 [ 0.466702] [<0000000001cb6140>] start_kernel+0x80/0x5c8 [ 0.466727] [<0000000000100036>] startup_continue+0x36/0x40 Bisect results and decoded stacktrace below. The uninitialized spinlock is &vn->busy.lock. Debugging shows that this lock is actually never initialized. [ 0.464684] ####### locking 0000000002280fb8 [ 0.464862] BUG: spinlock bad magic on CPU#0, swapper/0 ... [ 0.464684] ####### locking 0000000002280fb8 [ 0.477479] ####### locking 0000000002280fb8 [ 0.478166] ####### locking 0000000002280fb8 [ 0.478218] ####### locking 0000000002280fb8 ... [ 0.718250] #### busy lock init 0000000002871860 [ 0.718328] #### busy lock init 00000000028731b8 Only the initialized locks are used after the call to vmap_init_nodes(). Guenter --- # bad: [8e938e39866920ddc266898e6ae1fffc5c8f51aa] Merge tag '6.9-rc-smb3-client-fixes-part2' of git://git.samba.org/sfrench/cifs-2.6 # good: [e8f897f4afef0031fe618a8e94127a0934896aba] Linux 6.8 git bisect start 'HEAD' 'v6.8' # good: [e56bc745fa1de77abc2ad8debc4b1b83e0426c49] smb311: additional compression flag defined in updated protocol spec git bisect good e56bc745fa1de77abc2ad8debc4b1b83e0426c49 # bad: [902861e34c401696ed9ad17a54c8790e7e8e3069] Merge tag 'mm-stable-2024-03-13-20-04' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm git bisect bad 902861e34c401696ed9ad17a54c8790e7e8e3069 # good: [480e035fc4c714fb5536e64ab9db04fedc89e910] Merge tag 'drm-next-2024-03-13' of https://gitlab.freedesktop.org/drm/kernel git bisect good 480e035fc4c714fb5536e64ab9db04fedc89e910 # good: [fe46a7dd189e25604716c03576d05ac8a5209743] Merge tag 'sound-6.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound git bisect good fe46a7dd189e25604716c03576d05ac8a5209743 # bad: [435a75548109f19e5b5b14ae35b9acb063c084e9] mm: use folio more widely in __split_huge_page git bisect bad 435a75548109f19e5b5b14ae35b9acb063c084e9 # good: [4d5bf0b6183f79ea361dd506365d2a471270735c] mm/mmu_gather: add tlb_remove_tlb_entries() git bisect good 4d5bf0b6183f79ea361dd506365d2a471270735c # bad: [4daacfe8f99f4b4cef562649d56c48642981f46e] mm/damon/sysfs-schemes: support PSI-based quota auto-tune git bisect bad 4daacfe8f99f4b4cef562649d56c48642981f46e # good: [217b2119b9e260609958db413876f211038f00ee] mm,page_owner: implement the tracking of the stacks count git bisect good 217b2119b9e260609958db413876f211038f00ee # bad: [40254101d87870b2e5ac3ddc28af40aa04c48486] arm64, crash: wrap crash dumping code into crash related ifdefs git bisect bad 40254101d87870b2e5ac3ddc28af40aa04c48486 # bad: [53becf32aec1c8049b854f0c31a11df5ed75df6f] mm: vmalloc: support multiple nodes in vread_iter git bisect bad 53becf32aec1c8049b854f0c31a11df5ed75df6f # good: [7fa8cee003166ef6db0bba70d610dbf173543811] mm: vmalloc: move vmap_init_free_space() down in vmalloc.c git bisect good 7fa8cee003166ef6db0bba70d610dbf173543811 # good: [282631cb2447318e2a55b41a665dbe8571c46d70] mm: vmalloc: remove global purge_vmap_area_root rb-tree git bisect good 282631cb2447318e2a55b41a665dbe8571c46d70 # bad: [96aa8437d169b8e030a98e2b74fd9a8ee9d3be7e] mm: vmalloc: add a scan area of VA only once git bisect bad 96aa8437d169b8e030a98e2b74fd9a8ee9d3be7e # bad: [72210662c5a2b6005f6daea7fe293a0dc573e1a5] mm: vmalloc: offload free_vmap_area_lock lock git bisect bad 72210662c5a2b6005f6daea7fe293a0dc573e1a5 # first bad commit: [72210662c5a2b6005f6daea7fe293a0dc573e1a5] mm: vmalloc: offload free_vmap_area_lock lock --- [ 0.465490] lock: single+0x1860/0x1958, .magic: 00000000, .owner: /-1, .owner_cpu: 0 [ 0.466067] CPU: 0 PID: 0 Comm: swapper Not tainted 6.8.0-12955-g8e938e398669 #1 [ 0.466188] Hardware name: QEMU 8561 QEMU (KVM/Linux) [ 0.466270] Call Trace: [ 0.466470] dump_stack_lvl (lib/dump_stack.c:117) [ 0.466516] do_raw_spin_lock (kernel/locking/spinlock_debug.c:87 kernel/locking/spinlock_debug.c:115) [ 0.466545] find_vmap_area (mm/vmalloc.c:1059 mm/vmalloc.c:2364) [ 0.466572] find_vm_area (mm/vmalloc.c:3150) [ 0.466597] __set_memory (arch/s390/mm/pageattr.c:360 arch/s390/mm/pageattr.c:393) [ 0.466624] vmem_map_init (./arch/s390/include/asm/set_memory.h:55 arch/s390/mm/vmem.c:660) [ 0.466651] paging_init (arch/s390/mm/init.c:97) [ 0.466677] setup_arch (arch/s390/kernel/setup.c:972) [ 0.466702] start_kernel (init/main.c:899) [ 0.466727] startup_continue (arch/s390/kernel/head64.S:35) [ 0.466811] INFO: lockdep is turned off.