From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CD3FE7719A for ; Sat, 11 Jan 2025 08:01:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B1266B0089; Sat, 11 Jan 2025 03:01:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0612E6B008C; Sat, 11 Jan 2025 03:01:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E44746B0092; Sat, 11 Jan 2025 03:01:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BD4606B0089 for ; Sat, 11 Jan 2025 03:01:10 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4A4B2AE5DB for ; Sat, 11 Jan 2025 08:01:10 +0000 (UTC) X-FDA: 82994425500.06.155D878 Received: from m16.mail.126.com (m16.mail.126.com [117.135.210.7]) by imf03.hostedemail.com (Postfix) with ESMTP id AB45F20013 for ; Sat, 11 Jan 2025 08:01:07 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b=qHj7BJeS; spf=pass (imf03.hostedemail.com: domain of yangge1116@126.com designates 117.135.210.7 as permitted sender) smtp.mailfrom=yangge1116@126.com; dmarc=pass (policy=none) header.from=126.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736582468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c0dwYtbDF1cRnyxKJ4jlux/jd3LTMUlkMyV24OtljCQ=; b=s/HhbgHgC2wLZJyM+PV2qPTmxNHeqTLf69ilqwGjcVsuzjkcZP5TteIAMUCHHhOyD+m+Kq 8ag2ddgNLZ3zZHlR33WHz9B2E4tAyutnkzB3qejgsQuAMJ3g7GTm3Sq/CsfJFBQugncS60 5qsMSYNuU69kXYlXjDJ0btom5v1t09Q= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b=qHj7BJeS; spf=pass (imf03.hostedemail.com: domain of yangge1116@126.com designates 117.135.210.7 as permitted sender) smtp.mailfrom=yangge1116@126.com; dmarc=pass (policy=none) header.from=126.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736582468; a=rsa-sha256; cv=none; b=nSSJZUSh8OpvekTIyjA+ZiIU8Q9XfhYIcl71p1VawrzyG5R4+2I/75DTiFWQMSKDzxjYbX ygj//z9hKzyQ+A+wTwlm5GdDlk2Ruhr50MpRejAA7q/W/mEwg24lM1rlJEqOsm5E1SJ5pp P8TjM5O/gJWJ6dOIiOfXsjjqUbjz+4Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Message-ID:Date:MIME-Version:Subject:From: Content-Type; bh=c0dwYtbDF1cRnyxKJ4jlux/jd3LTMUlkMyV24OtljCQ=; b=qHj7BJeScxhuh6dU3KTSfH1t39zrhF4J+lW16Afzfb3g3gMh/id/9kCno8JNOj jhFq7W+cz9vGxfqKQPtO0l992kudOZOs0jI0AnqCSJDe70ZEvzahP8jx9ja9EiLR 7yh0+1MED+cJXTV7OxFjK/Y0pTOhDhlI1yyqwD2ntvwqw= Received: from [172.19.20.199] (unknown [112.64.138.194]) by gzsmtp5 (Coremail) with SMTP id qSkvCgB3HG48JYJn4FAODg--.46490S2; Sat, 11 Jan 2025 16:01:00 +0800 (CST) Message-ID: Date: Sat, 11 Jan 2025 16:00:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: prevent reuse of isolated free hugepages To: Andrew Morton , David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn References: <1736477766-23525-1-git-send-email-yangge1116@126.com> <20250110174541.bf22caf1afa227b9a76a7e4c@linux-foundation.org> From: Ge Yang In-Reply-To: <20250110174541.bf22caf1afa227b9a76a7e4c@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:qSkvCgB3HG48JYJn4FAODg--.46490S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7XFWrtry7Xw1fAw1UuFWUCFg_yoW8JryUpF y8K3WDKaykJr92kr4aqan0yr1avrsaqFyUXrn8tF9rC390qry5JrWI9w45uw4I9rnagr4Y vr4kuas3ZFn8uFDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j5sqXUUUUU= X-Originating-IP: [112.64.138.194] X-CM-SenderInfo: 51dqwwjhrrila6rslhhfrp/1tbifgDRG2eCIeMgnwAAss X-Rspamd-Queue-Id: AB45F20013 X-Stat-Signature: gae7h6jgxczmts9twesh3aqecg9z7iho X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736582467-445867 X-HE-Meta: U2FsdGVkX18nhudhSTtXJlRmkXwPtmQ3gWs2u1XO6vyWA7B5vNmkwwNLrwpbjkgckR5jn5Y4O4pLPgATeSHdfPgeezLD4622mdiQ825dJSFuvP7XRPtiUSB1tIWCqJPgwSMZk29AVtFRuEgvBHcnNNsjgzSk5L9Y2gV1fZva1Q2rf9ozCabi1KCC8NsAlb1ZKYtaGkcgj1gE59kMAlUdnh22TeXXaa+VqmKZfi9CYnCUd/GOcV8rDExNwDQYS7UKNHwf3BuW+P9Z7/KgmHhm/jtIPdLqoHnXHIPuCVXdett7sp7EbfDKPx6aJ/mANYy+630A8ubF4c4yPcbzPhxQOX0JWZBcBlwtuLoFCJnv4v4EOHCKdefDqIs1bIaXRlvKcldwsW+y7r49t8FgvH7PP19iNjAVqeJwWv+hXdzZ4CLPb0y+cTCObP4aJRboFxnrgFRO6aTKH5ebL2AoKIqhBLoj9ktSnw/tzFlE829Y3rhCwEWkC2XCic20dY8FGeh8ijsf4Bs/nB9//NH+3Mz+b+ek2XMfRcJVcsChR4CfqhVjkZR/W0TfMRASuLL1pzTs5m9NNwXME/Z3F+SbB9kpdhmBb2rwAIGjvv4dmPs1BZpaW/vZEmqw2qACejBZl2g6aWxfGf4yzTL1Oyh7GRS0jscIIA+OW8vbNQhm/wFy9GXvXY5RP04MiO9nHuYt3f5bjM34BZFB8zuM5klMMMUjQSBzkkrejnsOogkM/YJYAYVxCShZ0WPZ8jexw7lkdPK4DeAqpppFk3fJMdakyenBSraAFSaI4tOgac5kY/gcCHJ6JjbOUVLYZGGUH3bOPO4tX+PUiQDjcHAkmPlIrkeWlbRMxk7s1r3inLsFtQ7x4mTAvB/uylJiczRxEvQXtvT8AAad0x1x8IVZOCPLn47t45zQpS8JaXEH1YEA0FY5h05U8ItMa8MFTZVZRIOnkRjEa61RVU5tZKFDNfUdQJV ve8DCbOl 6/7Mmw8pLp4Q7ZIqFfQszIUAn1nF/JZ5T0dzC6vOeOrVWprD7mpZMwl952L35kLVazCjYHJiqidyp18A+32Sbi2trtGtOViq7hzQJNEVLN78DSFQGHNFR9HBpt6FtwQh6rm+76Pdc+O5dOguLSLzY4pPpaGlrRRmN1peB/wMcmzs1eDPi4KrmBRlN6gLoImVZjLF1dXqB5mBv2K9Eh7NXsjsz3QzFSl1Fk6k7R7l8ugbBrIchYlZ51SX6X9klV7ry8exR7Gq5gVsOkBF8U+BGJdf9miA5bwHwKkTuU5n/PDqq3ZEPvcmmOjCqBIc7LIzVs+h3uSsOSQ7uagHAeqOq/sJ7/OZfZt9ZAd/o1I2EHZuseYNReup8rs57JI2Tt0WQlafdWJPC3TCfwmuIplbRUujqGyGUkVXRhGdPwP1pi5jR1tf5AkJ5m5Xbz68dSdT9TLIjQL4gkM2gEtd0lgIerluNzr8FikIDRR8X X-Bogosity: Ham, tests=bogofilter, spamicity=0.002754, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/1/11 9:45, Andrew Morton 写道: > On Fri, 10 Jan 2025 09:14:47 +0100 David Hildenbrand wrote: > >>> To migrate huge 0, we obtain huge x from the pool. After the migration >>> is completed, we return the now-freed huge 0 back to the pool. When >>> it's time to migrate huge 1, we can simply reuse the now-freed huge 0 >>> from the pool. As a result, when replace_free_hugepage_folios() is >>> executed, it cannot release huge 0 back to the buddy system. >>> >>> To slove the proble above, we should prevent reuse of isolated free >>> hugepages. >> >> s/slove/solve/ >> s/proble/problem/ >> >>> >>> Link: https://lore.kernel.org/lkml/1734503588-16254-1-git-send-email-yangge1116@126.com/ >>> Fixes: 08d312ee4c0a ("mm: replace free hugepage folios after migration") >> >> The commit id is not stable yet. >> >> $ git tag --contains 08d312ee4c0a >> mm-everything-2025-01-09-06-44 >> next-20250110 >> >> >> We should squash this into the original fix. Can you resend the whole >> thing and merge the patch descriptions? > > I queued this as > replace-free-hugepage-folios-after-migration-fix-3.patch. But yes, a > clean v4 with a redone changelog would be a nice thing to have. ok, thanks.