From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93C53C48BCF for ; Wed, 9 Jun 2021 11:27:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 361DD6128A for ; Wed, 9 Jun 2021 11:27:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 361DD6128A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B79DF6B0036; Wed, 9 Jun 2021 07:27:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B29BD6B006E; Wed, 9 Jun 2021 07:27:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97CB06B0070; Wed, 9 Jun 2021 07:27:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 62FD16B0036 for ; Wed, 9 Jun 2021 07:27:51 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F0ADEB799 for ; Wed, 9 Jun 2021 11:27:50 +0000 (UTC) X-FDA: 78233960700.38.04A3C80 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id B7B25546 for ; Wed, 9 Jun 2021 11:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623238070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iF6jqZYlf/bv5JENXOK7CNcI0f9PC8RJLld/dQYmgdQ=; b=MPSB8Pg9rBk5rHNwlG/35MMHhKWJHiwpKdoFpTT5MWZXMC9aIZoEsCXsyp9QWNKq6it53j yF1MmlcXKBSvChlB481+VJGHasj0Kcq7I8P8k+zpByRMM3tTARm2LYFCEMYQ4vYbiWJwcM 6UpUYHDv2RxJrD8Rjd5jTr0t1KAxUcg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-EsULXIZzP6iwiT9_St7Ujw-1; Wed, 09 Jun 2021 07:27:48 -0400 X-MC-Unique: EsULXIZzP6iwiT9_St7Ujw-1 Received: by mail-wr1-f71.google.com with SMTP id s8-20020adff8080000b0290114e1eeb8c6so10628265wrp.23 for ; Wed, 09 Jun 2021 04:27:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=iF6jqZYlf/bv5JENXOK7CNcI0f9PC8RJLld/dQYmgdQ=; b=VwtAYuuBwlY0Uhm4wNQYNGx7DB6Gvaa6NJ1FRP4rFQ1XAdMHcFSiNE1mB2bkK8xqZO DKjCrS/179RJ3jftok2y5VZyJ+lFLIz7YU9zAMamfJHqxiCquSagzj/lPhRzAok5SqLr sOe04E8KkNy2zz7fkjhZKcU9L1J3qvcxozYhlL1VydD48Np3OQg3U8kWPrcI2dGhrUHI XPT7LM4Ysg23t3WJ2f31ZafnxibFYZA7elJyWelYY/qJ+hwMquWDXFMB723jPpc8H2F1 jNPyw6Zx5SMIE0ME7Ko5HEGqpJkD8C/Lgco9UKVptOarPD24SRTkGZJfqwFAkgmgBi4H tYRA== X-Gm-Message-State: AOAM53274Ysog/gjPSRRAasJJhi2p//6q0JiztOYV1xgzU/Mrisk/TY3 Mo2YUTgfEc4ApntsE2gQPQ9SAC7Juap42v2273n41qChZw68VigEkMT2uv98Y9XIR8phGgwJZMr KOmDt/aXSiqo= X-Received: by 2002:a1c:bad6:: with SMTP id k205mr9512138wmf.171.1623238067799; Wed, 09 Jun 2021 04:27:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyL7rALUqayOImlS1fyAzzBYx5tARF2xTQg0IXBsrMcuq9thrQ0YBslazZ4yV2ce3+8jWdrxA== X-Received: by 2002:a1c:bad6:: with SMTP id k205mr9512127wmf.171.1623238067600; Wed, 09 Jun 2021 04:27:47 -0700 (PDT) Received: from [192.168.3.132] (p5b0c611d.dip0.t-ipconnect.de. [91.12.97.29]) by smtp.gmail.com with ESMTPSA id n12sm8010868wrw.83.2021.06.09.04.27.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 04:27:47 -0700 (PDT) Subject: Re: [PATCH] mm: compaction: remove duplicate !list_empty(&sublist) check To: Liu Xiang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, liuxiang_1999@126.com References: <20210609095409.19920-1-liu.xiang@zlingsmart.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 9 Jun 2021 13:27:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210609095409.19920-1-liu.xiang@zlingsmart.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B7B25546 X-Stat-Signature: um15wro6k799s365g11d45z8yisro7sd Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MPSB8Pg9; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf04.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1623238067-548043 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.06.21 11:54, Liu Xiang wrote: > The list_splice_tail(&sublist, freelist) also do > !list_empty(&sublist) check, so remove the duplicate call. > > Signed-off-by: Liu Xiang > --- > mm/compaction.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 84fde270a..5b1dc832f 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1297,8 +1297,7 @@ move_freelist_head(struct list_head *freelist, struct page *freepage) > > if (!list_is_last(freelist, &freepage->lru)) { > list_cut_before(&sublist, freelist, &freepage->lru); > - if (!list_empty(&sublist)) > - list_splice_tail(&sublist, freelist); > + list_splice_tail(&sublist, freelist); > } > } > > @@ -1315,8 +1314,7 @@ move_freelist_tail(struct list_head *freelist, struct page *freepage) > > if (!list_is_first(freelist, &freepage->lru)) { > list_cut_position(&sublist, freelist, &freepage->lru); > - if (!list_empty(&sublist)) > - list_splice_tail(&sublist, freelist); > + list_splice_tail(&sublist, freelist); > } > } > > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb