From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F5FC3A5A7 for ; Thu, 8 Dec 2022 16:16:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 693738E0003; Thu, 8 Dec 2022 11:16:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 643D48E0001; Thu, 8 Dec 2022 11:16:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50A8E8E0003; Thu, 8 Dec 2022 11:16:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 442888E0001 for ; Thu, 8 Dec 2022 11:16:09 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EE15E141074 for ; Thu, 8 Dec 2022 16:16:08 +0000 (UTC) X-FDA: 80219640816.03.288F5F9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf24.hostedemail.com (Postfix) with ESMTP id B119B180018 for ; Thu, 8 Dec 2022 16:16:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vQM6oCgC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="cqPa/291"; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670516167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tRLagXkKmeXcUI+MhtRhuiGQoB9TArlcDvyl6UUGYBk=; b=jWoAq6wEXybCgA9+VmenU+NPD1Xh/iAa1ZUzifuMLtYhQNODHJtnKkzoWg4BEaTpv8QiFu 7D7tDFLa3Gh1a8jEMxADR7mM8H5Ulbu3wZq8H9SdtooBnkiBfljM98HH1YBN2LazC65AFe p99WPNU6qeyh60plCSlMlc/ICegoAWY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vQM6oCgC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="cqPa/291"; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670516167; a=rsa-sha256; cv=none; b=bsRUjaOMmrNdoUWaS3JVQpgkNAK3rHG7r8NH1J+6Mr5kou1A/nOwbHgRU+TTFOp6ai+zTc kkQSIhOS1fO5SQHHoWbgSr28zLuESKgC1nkfcCopFTnXuNFO9kLPGt9DAIXpVs6lFU5FXQ cQr/WLYCUZQu7AEU8cP5Ow7y5rz/SMU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 720B7208B2; Thu, 8 Dec 2022 16:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1670516165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tRLagXkKmeXcUI+MhtRhuiGQoB9TArlcDvyl6UUGYBk=; b=vQM6oCgCOVXwFV5DYj98yA29qsTLcOVugq//N1Aabe0iC9QaR9hMXQXRHW9mQYoqGZgF33 sR6aoF0IInhAbFtJdd+EAbuj+GHUg5FcKuDaLsMLkd27eKX05tiQyxmp4aOK2pd0xzy9wn lYiYYR6749emvc3Kvv+7/Lem33Zde/A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1670516165; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tRLagXkKmeXcUI+MhtRhuiGQoB9TArlcDvyl6UUGYBk=; b=cqPa/291QA0081oNI9E26jjdK0TvifhhMFbqCpEj0LsO1hZfyXg//NECr7lDppmi5C2ZqI +g8Fl6QDdhdO3YDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 52C8C138E0; Thu, 8 Dec 2022 16:16:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6hiEE8UNkmN7IQAAMHmgww (envelope-from ); Thu, 08 Dec 2022 16:16:05 +0000 Message-ID: Date: Thu, 8 Dec 2022 17:16:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 2/6] mm/page_alloc: Treat RT tasks similar to GFP_HIGH Content-Language: en-US To: Mel Gorman , Linux-MM Cc: Andrew Morton , Michal Hocko , NeilBrown , Thierry Reding , Matthew Wilcox , LKML References: <20221129151701.23261-1-mgorman@techsingularity.net> <20221129151701.23261-3-mgorman@techsingularity.net> From: Vlastimil Babka In-Reply-To: <20221129151701.23261-3-mgorman@techsingularity.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 4kuf5wjeaf3i3p73jxdtwyopobub3gds X-Rspam-User: X-Rspamd-Queue-Id: B119B180018 X-Rspamd-Server: rspam06 X-HE-Tag: 1670516166-839354 X-HE-Meta: U2FsdGVkX1/J932a/nnwkHgWSHVgU7vusK064+zEzqzG2rxsvw+ULdOcGC7+XRt9Pghai1zXWpslcK8CFw8SnWnDgRpevCjr/tmMQ7NmsXm6W7g8uE7t0nXrXQRYV7QWgDMnnydJKIpEwoSkgyvrIitBWUW+ifFFUV7ZWXkGNUoL56MLH9pjBhzpxuLCTkU4kdcO0J6TmvsQKwokGogP8iAO85iiCENJOatBQsRigCM8mRSVEc15I/HaiiNDr4eVKNW7vBjbGUPXS1jXMMGdncDRxDaClyKzNBM/ck474UZAl1xi1pr2gJwxz7sJozzLsoR8kdmOoE2IuxaUwodp4Fdw/m/scDXCN3RZGDT9luauzDvB+v/chaoK9qtN760yO+xkdGwPmpieXyE1m6RLn/MpfvHD+q0VDKLdx2NTm0PNzuXg3j17G5CCi/pSUKed0LgeCl1Zk+RKKGbV3ua+HnKISyYFeh9jlMs2JRfES2Uw7g5NVSLVRwnEkyGhalQEBF65wDRC88Uyl8cwHpKZKJCg7BdS0+SpeSsZ4A2sTGpPzcxACsbgA3ME6BRYqjrO6IY3BZiRlRLrT4zos+Gkes6TGFAvEoplwWwopff9cFgWrbuCqU4havsaol7k71Zv7ESSx3AsibOJPnjxJaZT6k8nDeEw5GI1hdfpKUbvBye1ctBpvlnL7N0UJglS87w2OdyoA7/7dX/I+hqacoVrhCpCLO1f/xs6lF7vj5GdZJUkxvx0QBF4UF5/KiUDtWgmklHBhvw6LPVxbLCxbUoztL3/zl1LsR5Whx76btYsNZFIqgBw/kAsOB17t7P7JcV2sRa9MeUNivP3NwEB5ZndZg5m4PlRxMfcuwrgDwGp5YxgjZ/BNgZNV++y01awqJhSXFLhvb6TEdDVlsrvj1n5sl2b0G0edhZgMkMtK/BVQmpOc0hpl0iZy7rcLHEgaXDVnF+zG0xMUuIC/CGBXR5 hO5IFRx9 pH7zbkSmErFNWp7y8RnY8zf2fTuoap+e7Wx8seyZz9ms2G2ctq9LZ9KcxQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Subject should say __GFP_HIGH as there's no GFP_HIGH? On 11/29/22 16:16, Mel Gorman wrote: > RT tasks are allowed to dip below the min reserve but ALLOC_HARDER is > typically combined with ALLOC_MIN_RESERVE so RT tasks are a little > unusual. While there is some justification for allowing RT tasks > access to memory reserves, there is a strong chance that a RT task > that is also under memory pressure is at risk of missing deadlines > anyway. Relax how much reserves an RT task can access by treating > it the same as __GFP_HIGH allocations. > > Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3b37909617bc..da746e9eb2cf 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4852,7 +4852,7 @@ gfp_to_alloc_flags(gfp_t gfp_mask) > */ > alloc_flags &= ~ALLOC_CPUSET; > } else if (unlikely(rt_task(current)) && in_task()) > - alloc_flags |= ALLOC_HARDER; > + alloc_flags |= ALLOC_MIN_RESERVE; > > alloc_flags = gfp_to_alloc_flags_cma(gfp_mask, alloc_flags); >