From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDA7EC433FE for ; Thu, 3 Dec 2020 15:46:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DC9752079A for ; Thu, 3 Dec 2020 15:46:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC9752079A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 418EB6B006C; Thu, 3 Dec 2020 10:46:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CB068D0002; Thu, 3 Dec 2020 10:46:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 292418D0001; Thu, 3 Dec 2020 10:46:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 13E196B006C for ; Thu, 3 Dec 2020 10:46:29 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D1A47181AEF30 for ; Thu, 3 Dec 2020 15:46:28 +0000 (UTC) X-FDA: 77552398056.01.death75_1c01632273bd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id AC8071004CB26 for ; Thu, 3 Dec 2020 15:46:28 +0000 (UTC) X-HE-Tag: death75_1c01632273bd X-Filterd-Recvd-Size: 12249 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Dec 2020 15:46:27 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20201203154610euoutp018031a1091a789a28fa2e8c3a2e53f25b~NP2rXFCdE3260232602euoutp01q for ; Thu, 3 Dec 2020 15:46:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20201203154610euoutp018031a1091a789a28fa2e8c3a2e53f25b~NP2rXFCdE3260232602euoutp01q DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1607010370; bh=z3/D0MJrjrF94npmo1z4sClZBeVcZraVE0CVPLPG7zg=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=KqbHSL+SrT69RkrrVrjvac+gY0GnzGptbDgpfWABETcC6XMxv1QkPlwbFvR0rwVDG FdDgCxmSJ/TOOjINrUs5GPuysc+MrEud1QNUL+3Ur7QG3bKgPr1zdf/GH5GrDpX82K xiakLkkYGGi8vv77qfl5RHvbYuUJbjDDtUfHN/6g= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20201203154604eucas1p201d76d19c7044922f703edb697a16eee~NP2mbgiLy1046010460eucas1p25; Thu, 3 Dec 2020 15:46:04 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 2E.66.44805.C3809CF5; Thu, 3 Dec 2020 15:46:04 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20201203154604eucas1p200d001d25dd344a1dd1c7da34f35aad0~NP2lzGzuR1046410464eucas1p2m; Thu, 3 Dec 2020 15:46:04 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20201203154604eusmtrp2955b24b6b96bb204fdacf8696f76ab47~NP2lyYQXW3076630766eusmtrp2O; Thu, 3 Dec 2020 15:46:04 +0000 (GMT) X-AuditID: cbfec7f4-b37ff7000000af05-90-5fc9083cd590 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 1F.78.16282.C3809CF5; Thu, 3 Dec 2020 15:46:04 +0000 (GMT) Received: from [106.210.88.143] (unknown [106.210.88.143]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201203154603eusmtip1862c92c36bc22a0a3695d5b3b6a86fc4~NP2lIqFsM0365503655eusmtip1L; Thu, 3 Dec 2020 15:46:03 +0000 (GMT) Subject: Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP To: Matthew Wilcox , Hugh Dickins Cc: Andrew Morton , Jan Kara , William Kucharski , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org From: Marek Szyprowski Message-ID: Date: Thu, 3 Dec 2020 16:46:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201125023234.GH4327@casper.infradead.org> Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEKsWRmVeSWpSXmKPExsWy7djPc7o2HCfjDTonaVnMWb+GzeLsq7ns Fqs3+VqsXH2UyeLppz4Wi9nTm5ks9uw9yWJxedccNot7a/6zWmxe3MVk8fsHkPux6R6bA4/H 4TfvmT0WbCr12LxCy2PTp0nsHidm/Gbx2PnQ0mP3zQY2j49Pb7F4vN93lc3jzIIj7B6fN8kF cEdx2aSk5mSWpRbp2yVwZXyYcJmx4Khuxby7r1gaGBerdzFyckgImEjs+f6QvYuRi0NIYAWj xK4Pe1kgnC+MEu+urIPKfGaU2N74lR2mpfnHfFaIxHJGia1fmqGc94wSe17vYASpEhZwlOh8 uhysQ0TAU+Ju1yNGkCJmgUVMElNnv2EDSbAJGEp0ve0Cs3kF7CROHb0G1MDBwSKgInH+ty9I WFQgSeLgxwdQJYISJ2c+YQGxOQUsJVbPOQIWZxaQl2jeOpsZwhaXuPVkPhPILgmB5ZwSDXMX M0Gc7SIxb8EbKFtY4tXxLVDvyEj83wnT0Mwo8fDcWnYIp4dR4nLTDEaIKmuJO+d+sYFcxyyg KbF+lz5E2FHiwOlNzCBhCQE+iRtvBSGO4JOYtG06VJhXoqNNCKJaTWLW8XVwaw9euMQ8gVFp FpLXZiF5ZxaSd2Yh7F3AyLKKUTy1tDg3PbXYKC+1XK84Mbe4NC9dLzk/dxMjMNmd/nf8yw7G 5a8+6h1iZOJgPMQowcGsJMJ7e+mJeCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8SVvWxAsJpCeW pGanphakFsFkmTg4pRqY5Na0qGzi3WPk3/Ob4T1j156m7XH6vQGMuauunuReLlM8yWXDLZ+q yyHVx93/lP358ojrRlrJhj0h1h39Hz83l4rN+Fe6TCm/kvHfixpZJ36Fy5K2rI5HfD6yiG+v f/krcasHj2aSjiD/2eeruOfv1nPbaf99Vu8KztsTD2zuTlvlbCWi47iYY96V2onXpq6O9L8w V2rB3qXym/a4r6vv/XydR5qhwmzuG26l/luHF7dvLSydcvp7jVzbD2dX7qaZE13mulVHzdnN d+P2ym5fFfXMJLeAaSzx8kmKDSp1sQLF4ubRB5+zRO89IPbwlO15rxNTXl+uea14fuEiZ2el hWrvquesKRbutsmucylSYinOSDTUYi4qTgQA8Eo5k+UDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCIsWRmVeSWpSXmKPExsVy+t/xu7o2HCfjDZbtYbWYs34Nm8XZV3PZ LVZv8rVYufook8XTT30sFrOnNzNZ7Nl7ksXi8q45bBb31vxntdi8uIvJ4vcPIPdj0z02Bx6P w2/eM3ss2FTqsXmFlsemT5PYPU7M+M3isfOhpcfumw1sHh+f3mLxeL/vKpvHmQVH2D0+b5IL 4I7SsynKLy1JVcjILy6xVYo2tDDSM7S00DMysdQzNDaPtTIyVdK3s0lJzcksSy3St0vQy/gw 4TJjwVHdinl3X7E0MC5W72Lk5JAQMJFo/jGftYuRi0NIYCmjxKPbJ9ggEjISJ6c1sELYwhJ/ rnWxQRS9ZZR4emkBI0hCWMBRovPpcnYQW0TAU+Ju1yNGkCJmgUVMEnOWzYbquM8kcfXTXLBR bAKGEl1vu8BW8ArYSZw6eg2om4ODRUBF4vxvX5CwqECSxO+la6FKBCVOznzCAmJzClhKrJ5z BCzOLGAmMW/zQ2YIW16ieetsKFtc4taT+UwTGIVmIWmfhaRlFpKWWUhaFjCyrGIUSS0tzk3P LTbSK07MLS7NS9dLzs/dxAiM7m3Hfm7Zwbjy1Ue9Q4xMHIyHGCU4mJVEeG8vPREvxJuSWFmV WpQfX1Sak1p8iNEU6J2JzFKiyfnA9JJXEm9oZmBqaGJmaWBqaWasJM5rcmRNvJBAemJJanZq akFqEUwfEwenVANTh0Nc9nybw86ae7Zv8LJtP8WwtyZsh+jnGIGvM8OPbPf8KSf0MGMdv8R6 o/t+jtpLarPOH1DZGFFet8s6wytVVOjWFQVtS5s0wauTHPd/ffxtR/nOKZdKLvdckNUNftMj zMQzIbg/vfllE2tZk3mE0RMng/k7Wldl/U+948H6/Oqz65fj2I9WsC5KEFnw+lTajtrgoOCK nrkGbcdXrz+gkyd8u+bZgWe7f3Qe15ww2ypcrT7x+jGpXwqTdGZ49F/+dXfKKdO8m7Mqb/Fd qVn3OtHcW8mnNvHq5NsTT63tNnRhKWRylxaPVZkp/8z39d0+4evT5Ce3MZx5qP7u2mPttQcn 8Pp/OXx/k4dJYucRJZbijERDLeai4kQAmtjg1HcDAAA= X-CMS-MailID: 20201203154604eucas1p200d001d25dd344a1dd1c7da34f35aad0 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20201203154604eucas1p200d001d25dd344a1dd1c7da34f35aad0 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201203154604eucas1p200d001d25dd344a1dd1c7da34f35aad0 References: <20201112212641.27837-1-willy@infradead.org> <20201117153947.GL29991@casper.infradead.org> <20201117191513.GV29991@casper.infradead.org> <20201117234302.GC29991@casper.infradead.org> <20201125023234.GH4327@casper.infradead.org> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi On 25.11.2020 03:32, Matthew Wilcox wrote: > On Tue, Nov 17, 2020 at 11:43:02PM +0000, Matthew Wilcox wrote: >> On Tue, Nov 17, 2020 at 07:15:13PM +0000, Matthew Wilcox wrote: >>> I find both of these functions exceptionally confusing. Does this >>> make it easier to understand? >> Never mind, this is buggy. I'll send something better tomorrow. > That took a week, not a day. *sigh*. At least this is shorter. > > commit 1a02863ce04fd325922d6c3db6d01e18d55f966b > Author: Matthew Wilcox (Oracle) > Date: Tue Nov 17 10:45:18 2020 -0500 > > fix mm-truncateshmem-handle-truncates-that-split-thps.patch This patch landed in todays linux-next (20201203) as commit 8678b27f4b8b=20 ("8678b27f4b8bfc130a13eb9e9f27171bcd8c0b3b"). Sadly it breaks booting of=20 ANY of my ARM 32bit test systems, which use initrd. ARM64bit based=20 systems boot fine. Here is example of the crash: Waiting 2 sec before mounting root device... RAMDISK: squashfs filesystem found at block 0 RAMDISK: Loading 37861KiB [1 disk] into ram disk... / / / / done. using deprecated initrd support, will be removed in 2021. ------------[ cut here ]------------ kernel BUG at fs/inode.c:531! Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM Modules linked in: CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.10.0-rc6-next-20201203 #21= 31 Hardware name: Samsung Exynos (Flattened Device Tree) Workqueue: events delayed_fput PC is at clear_inode+0x74/0x88 LR is at clear_inode+0x14/0x88 pc : []=C2=A0=C2=A0=C2=A0 lr : []=C2=A0=C2=A0=C2=A0 p= sr: 200001d3 sp : c1d2be68=C2=A0 ip : c1736ff4=C2=A0 fp : c1208f14 r10: c1208ec8=C2=A0 r9 : c20020c0=C2=A0 r8 : c209b0d8 r7 : c02f759c=C2=A0 r6 : c0c13940=C2=A0 r5 : c209b244=C2=A0 r4 : c209b0d8 r3 : 000024f9=C2=A0 r2 : 00000000=C2=A0 r1 : 00000000=C2=A0 r0 : c209b244 Flags: nzCv=C2=A0 IRQs off=C2=A0 FIQs off=C2=A0 Mode SVC_32=C2=A0 ISA ARM= =C2=A0 Segment none Control: 10c5387d=C2=A0 Table: 4000404a=C2=A0 DAC: 00000051 Process kworker/0:1 (pid: 12, stack limit =3D 0x(ptrval)) Stack: (0xc1d2be68 to 0xc1d2c000) ... [] (clear_inode) from [] (evict+0x12c/0x13c) [] (evict) from [] (__dentry_kill+0xb0/0x188) [] (__dentry_kill) from [] (dput+0x2d8/0x67c) [] (dput) from [] (__fput+0xd4/0x24c) [] (__fput) from [] (delayed_fput+0x3c/0x48) [] (delayed_fput) from [] (process_one_work+0x234/0x7= e4) [] (process_one_work) from [] (worker_thread+0x44/0x5= 1c) [] (worker_thread) from [] (kthread+0x158/0x1a0) [] (kthread) from [] (ret_from_fork+0x14/0x38) Exception stack(0xc1d2bfb0 to 0xc1d2bff8) ... ---[ end trace b3c68905048e7f9b ]--- note: kworker/0:1[12] exited with preempt_count 1 BUG: sleeping function called from invalid context at=20 ./include/linux/percpu-rwsem.h:49 in_atomic(): 0, irqs_disabled(): 128, non_block: 0, pid: 12, name:=20 kworker/0:1 INFO: lockdep is turned off. irq event stamp: 7498 hardirqs last=C2=A0 enabled at (7497): [] free_unref_page+0x80/= 0x88 hardirqs last disabled at (7498): [] _raw_spin_lock_irq+0x24/0x= 5c softirqs last=C2=A0 enabled at (6234): [] linkwatch_do_dev+0x20= /0x80 softirqs last disabled at (6232): [] rfc2863_policy+0x30/0xa4 CPU: 0 PID: 12 Comm: kworker/0:1 Tainted: G=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= D=20 5.10.0-rc6-next-20201203 #2131 Hardware name: Samsung Exynos (Flattened Device Tree) Workqueue: events delayed_fput [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0xb4/0xd4) [] (dump_stack) from [] (___might_sleep+0x288/0x2d8) [] (___might_sleep) from [] (exit_signals+0x38/0x428) [] (exit_signals) from [] (do_exit+0xe4/0xc88) [] (do_exit) from [] (die+0x238/0x30c) [] (die) from [] (do_undefinstr+0xbc/0x26c) [] (do_undefinstr) from [] (__und_svc_finish+0x0/0x44= ) Exception stack(0xc1d2be18 to 0xc1d2be60) VFS: Mounted root (squashfs filesystem) readonly on device 1:0. be00: c209b244 00000000 be20: 00000000 000024f9 c209b0d8 c209b244 c0c13940 c02f759c c209b0d8=20 c20020c0 be40: c1208ec8 c1208f14 c1736ff4 c1d2be68 c02fb2d4 c02fb334 200001d3=20 ffffffff [] (__und_svc_finish) from [] (clear_inode+0x74/0x88) [] (clear_inode) from [] (evict+0x12c/0x13c) [] (evict) from [] (__dentry_kill+0xb0/0x188) [] (__dentry_kill) from [] (dput+0x2d8/0x67c) [] (dput) from [] (__fput+0xd4/0x24c) [] (__fput) from [] (delayed_fput+0x3c/0x48) [] (delayed_fput) from [] (process_one_work+0x234/0x7= e4) [] (process_one_work) from [] (worker_thread+0x44/0x5= 1c) [] (worker_thread) from [] (kthread+0x158/0x1a0) [] (kthread) from [] (ret_from_fork+0x14/0x38) Exception stack(0xc1d2bfb0 to 0xc1d2bff8) bfa0:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = 00000000 00000000 00000000=20 00000000 bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000=20 00000000 bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 EXT4-fs (mmcblk0p6): INFO: recovery required on readonly filesystem EXT4-fs (mmcblk0p6): write access will be enabled during recovery EXT4-fs (mmcblk0p6): recovery complete EXT4-fs (mmcblk0p6): mounted filesystem with ordered data mode. Opts: (nu= ll) VFS: Mounted root (ext4 filesystem) readonly on device 179:6. Trying to move old root to /initrd ... I suppose this issue can be also reproduced with qemu. Best regards --=20 Marek Szyprowski, PhD Samsung R&D Institute Poland