From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 484A7C43334 for ; Mon, 27 Jun 2022 12:09:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB21E8E0001; Mon, 27 Jun 2022 08:09:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B62A26B0072; Mon, 27 Jun 2022 08:09:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B5988E0001; Mon, 27 Jun 2022 08:09:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8D55D6B0071 for ; Mon, 27 Jun 2022 08:09:54 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 60951337F6 for ; Mon, 27 Jun 2022 12:09:54 +0000 (UTC) X-FDA: 79623897108.27.6338863 Received: from mx0a-002c1b01.pphosted.com (mx0a-002c1b01.pphosted.com [148.163.151.68]) by imf17.hostedemail.com (Postfix) with ESMTP id 57AE74002E for ; Mon, 27 Jun 2022 12:09:53 +0000 (UTC) Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25R4ju1w031333; Mon, 27 Jun 2022 05:09:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h=content-type : message-id : date : subject : from : to : cc : references : in-reply-to : mime-version; s=proofpoint20171006; bh=xFMzLrJ1x8KIBlJK498j1GiEB7jRPaY/uPnqfqVGcVs=; b=d4lKUVM9I44Rpw7/HJFB4xaGwmOS6pG6HJ2LY7tDidKOP1+wPpLUBTpcFaGMYtoZyUly LAWtRVC3neGBLPozIKcuxS8SnoJaST5Y0MuJqI6GfMMCO5nSmXD5XEFC44vrTG9N3H2W xMs5Yy1/Ukg1WW6XLNLUlAj2J+J29r3jhyQMv3QBNrLKYrzxoFLLoK7Bok0XnuyRf8Jb Iu42GnmtlnlpRy8R7EjH61hmKXjdXjgqpDu4g1KRJdDjEODgkbrEn+CP11O5YWtYtVZD ME4ZrwxhTc5CYgEkmazMRKzVLOB6ZhIyDQjkq07MxMft9gCGFbr462dF3Je287QFO/6m mA== Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 3gx1egue21-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Jun 2022 05:09:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FMu4q7fNs/PMIrvS+bQtqpMLf9GUF29HgSZYZ72Zkw6B/h1p/zNBnihnAb1faumlUxYD303hHARPs9oTXsPxXmZALAe2VfH0QKtV53zrcTnYl22ib88dLDzqUH2ZJ3nui677jZakCercb5erSytL8paPcT2sDBybIWZBTGTwF7QKcB6+byOsV8uv/nJs2rYr+Q1YoQdTqimFUSFP1JdI3lWYyE5B6sGGXlMzoL8STCQMPzb1pTyTaZpfUhgFLQFIILcgxJHXWn+C3cYXt+oply6dE92koyOLRTYrDrdCv/VemrXwrIrg9xB391aqN10jKvgVlU2sU3WIPFySWNuluQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xFMzLrJ1x8KIBlJK498j1GiEB7jRPaY/uPnqfqVGcVs=; b=EZcwDJgmNmNtMv5eqo/ZUSz5PIy60acoq+oWaj00/6/8Xtg7eOTCYv9jwzMDB0bzAtdKyDL/7Uqpl7TjsHMrmYNsKLE4/iigH1I+c9evm9A3LXPMV1F+ZwjXc2Stz7SMtZUZ2xMOVkKWLy4fe/ks5vLuCsXgvlJwZ8yrSd9znbVo8FLFeS06aWu6wX3FDaHZP3UBiow7NcSnRJ05y87mpSMV+Yq7/rarUfBJF8LLIZ6XS1vlO98RE7hqFKslR05UCr5hoRuVQd4w50VEU0Vm/5ttgXlkrWherXoZsUgszeiFC3RzC9T+6DlzoNc/tHj/7VC7vgC5ruN438LCrChDMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none Received: from PH0PR02MB7384.namprd02.prod.outlook.com (2603:10b6:510:12::12) by CY4PR02MB2374.namprd02.prod.outlook.com (2603:10b6:903:d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Mon, 27 Jun 2022 12:09:46 +0000 Received: from PH0PR02MB7384.namprd02.prod.outlook.com ([fe80::898c:892a:2385:3df6]) by PH0PR02MB7384.namprd02.prod.outlook.com ([fe80::898c:892a:2385:3df6%5]) with mapi id 15.20.5373.018; Mon, 27 Jun 2022 12:09:46 +0000 Content-Type: multipart/alternative; boundary="------------XnL1qExmi7gy4Gns5FRgeEkW" Message-ID: Date: Mon, 27 Jun 2022 17:39:32 +0530 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [RFC PATCH 01/26] hugetlb: make hstate accessor functions const From: "manish.mishra" To: James Houghton , Mike Kravetz , Muchun Song , Peter Xu Cc: David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , Jue Wang , "Dr . David Alan Gilbert" , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220624173656.2033256-1-jthoughton@google.com> <20220624173656.2033256-2-jthoughton@google.com> In-Reply-To: X-ClientProxiedBy: SY3PR01CA0098.ausprd01.prod.outlook.com (2603:10c6:0:19::31) To PH0PR02MB7384.namprd02.prod.outlook.com (2603:10b6:510:12::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 746f6cdc-53e7-42b6-0180-08da5835ecf1 X-MS-TrafficTypeDiagnostic: CY4PR02MB2374:EE_ x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aO5W68+Z/QjTdi3tjdTOgnQQ5pIcui+/fdo4kKQxDttGr8NPrAvBxy+9cyAecOAt3gJkxEOrUNB/1oT9XoPjMIjOXxCH34zjCRoKKgE0ZpmqQtv6GL6U2qhPUW5QA+ev+pEq5vFjdP2sHozi+lwgBUQM6n66RhvekMeo6BuL/yh56DDkInCbRdAJqzLsekdybKCOnGAwmN9HDTh44FFK5w7PGY1kCcS5OEkIhHLbu8jDvwyordAr2mXuI5sEi18gaAmNNQHM4VJRPfyatDbRSJhr+njLVTkLCI+GPIpMbMZagcxSWhpyTcl3Oz9cQbzncKdQc27xfqrVCksSF35HeMxfl2CrQ30UvO4yboTF3hVf82akmWbujf/CerEDhqyoDXglIAL/s9+DbzjdxPICLtabzFbH1AD97MxYQc0c8zuSydVi0ABCPw5zZCJz1uCKqMSH7qpkHZPYd4Z3Ad8xdX+kdcA/Kh32fqVMFGdsnV54X5Pk/vFpPgtQnZVYbsv8ZNl8pZzkCJJKt/wrQvVnsYSY1OwdtwuUdS6r0WflsDFwb0nct14SRsM9KZ0tvAEfv4r1gmMhH3P2eroLakVGZMV/VrjAcjeZj53wvufWKsyB+4kzxipRtx9tlJs1usPX64ak2XVJNb3y52NDWyWSFhF4vB9w0K1AYqsuavuwg3g1Ky5zLscQ73V8Omae9VtG/2fOt7jLhYp/+KhjNvbEnAKSruN7XJwtOA9KCLoMR6v1yfDAOFrgCtQjT29cjJzketiqLgkkJ8crxXKTRLx+frzCkxk+xv4ioeMv4eopN75Vh4y1v7kX9fagOZ8EKsromm/b2Ep72L9NgUR87ShHJQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7384.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(396003)(366004)(136003)(346002)(5660300002)(8936002)(33964004)(53546011)(26005)(4326008)(6666004)(6506007)(31696002)(86362001)(8676002)(66946007)(41300700001)(66476007)(66556008)(83380400001)(6512007)(31686004)(38100700002)(2906002)(54906003)(110136005)(7416002)(6486002)(36756003)(316002)(2616005)(186003)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnpCaXJIa01BZlJ1MDJMaVZ0dHpGWXpySnZlN2Vqd0h5dHlXd0ExcDR6N0NJ?= =?utf-8?B?Y3N6VjZ1akVYS2pqTTZ6d1pjNzdFTmF0MkJ2VmZFOVNldlIwNVdiTUc0QVQ5?= =?utf-8?B?c3VIUXlrWlJnUG9wZEFEYlN5ZHJHM00vNk5zWkVVTkpUdnc1MXpDZll0ODht?= =?utf-8?B?eWI3SWd6RW9wamwrWTQzSXo3M3RaU1JFekQ4U2JTYnVsSzE0c21DS01NU1li?= =?utf-8?B?ZVZnUkRtN0d6N1AzditKVHY5VTFHbVJqNHR6cFpEWlF4NVNMMUFJeVVjTW1V?= =?utf-8?B?V1MzbUJFKzRGS0g3YXlzZmdjNm1WRTFDQUdObnNFdzdlUitjSDFVT2Jib1ds?= =?utf-8?B?Q2gzbCtaQ042Yk55b01nSjRGOHRWcE5rS3BlOVM3ZUhKRzFoSS83SWpyaDB1?= =?utf-8?B?Sm1sRzZGQ0JmRTdKeXNKMzJaamRnZDRxRitiQ0xkMERMY3VmbXBxRnZualE2?= =?utf-8?B?ajA5T1pTMzV4Nkh4M2JreUlqWHJ4YkhRU2xCNXhUWGlabnJJMmQyVHlkZm9Z?= =?utf-8?B?UjNaK3B1VUtzZ2J6ODRabXU1WXNTdXU4UXhsTU9uOHBPWXo1d0ZkNmwyVElR?= =?utf-8?B?R210UGRZYXdQSTdPQmlwaUNWcDlJVmk3a1FsYWJTM3dVZjJBTVd3KzFuU2g1?= =?utf-8?B?VnFudWZFR3FnQXlpR2paaWYrQ2VzNnQrL1h5TjlSQUxJRTJQQmR4aU02NGYv?= =?utf-8?B?Qk13aUJiUm5DVHNQeWdjSWNwZ09JMFNEZzVDMmxOVk1haVducE5JOHpQbTZi?= =?utf-8?B?OEQ0c2JuRHlobzRaYjNLUXd1MG81eHNxUnZSNUJ4WWFNM0FabUFIeFBCT0tq?= =?utf-8?B?RHBaeEhVNEhHM1YyaEJWRElPSk5OWmo1RjFlc3FTemVncUNMUTM4M1BUVmRF?= =?utf-8?B?R2pwMGZOWU1UQVR1c2Z3WkpqVW96ajZNZWtRVERSekNTbTlqeE1rN0xMMStj?= =?utf-8?B?bm1vRXFFM0tkTUlQUE9LMVZZN014dm9pMy92b2JVVWUxUVFvdzdwVHpLSmxB?= =?utf-8?B?alIyQ25SMk8reTVqMWVhSDNoYnZjRUI1Wm5xbkxaNmFPTEZHWk1sVnlnMGdT?= =?utf-8?B?eUtsc05SY0FUMFNYVjg2RkJzWndiY2ZKQnZGNzFHZ3E0SWdJVTd1UjdxVDNX?= =?utf-8?B?ZTVncUlQeitHeTFRc3NIa2g4Qk1kK2Yyd2JFUkwyTHdMZHhmdTYzZ1NxdDZH?= =?utf-8?B?elQ3Z3FzZUJoaWQwSVV5SCtNN2ZsbUN4ZDRSS3U3QnRYSWp1YWNGYi9LbVVS?= =?utf-8?B?V3ozTDRicGpYSWlZNWlDc0ZIcDV1Y3BjV0hoWG1UK1dCZGRUSmwyZ0xyQVhK?= =?utf-8?B?d2lUUG9JRmVnYVFTRWNxNzJXaXYvbmROendJbmZicXhVVVRWSEh5cDRZdWRW?= =?utf-8?B?L2NLSzVtamNtRTE4SUdRVS9yN1BTUmJtaWw4dzc5R0hYUWpFcXJpaG1RNTNF?= =?utf-8?B?ZnRlcEFGZXY3Qm42SHcxdXgyMzNuWDN3NDBiM050R1cySjN4cnFCaHdJSHlO?= =?utf-8?B?VDgxaDNmVmQvS2g2cFFwaUpoNW0xUVpkWUt5TU9VVHEyelFNTzhFSkRVM0pq?= =?utf-8?B?SFJIa0o4S1JkQlhIWnUwRFk0NXBWVFhKNEFhc1h5eW43SWJ6Uk5nTkk3L2Nv?= =?utf-8?B?OHNYcGtRVDhhM1lVYTNxTFBRSGNCOHAxZlo3ZEN2dWZRRDgxL0ZINktBY05H?= =?utf-8?B?a0ZlYjkxb2ZaODZoelRsYVpjWmNBQ2p1Sy9wV0JjYmVPbkJ1ZTJleFBKTEdu?= =?utf-8?B?bnlOUWptRXNvSmsxQ0NlZHRuZEZzRnZyQjIwUktOZXlQdnR6ejFuOUZpOWp2?= =?utf-8?B?c01sbEtzUHZ4ejBaRWNxT2VVcjVPdHhtWUwrT1FOcnZQTWxvem9KNzNEdjAy?= =?utf-8?B?Q0ZTdkV2bXpITjNSaUR3ZjJkMG8xQklDaFRoU05vNnltMHZ0ZlBHWjNnMGh1?= =?utf-8?B?K2xyVmNHU2ZlV0NybVkxZXlUcDZKb3JXTU1JVjlRN05lbURRc1k4alhLYWFn?= =?utf-8?B?cFozYUNKZ1VTYXhPRHBJWEJYQm5TaDVzeVRDOHVFOHZYS1lhSlUxWGVWNmsz?= =?utf-8?B?Z2NTS0dmQWh1ZlNSQys4L1hseE03b1hEV3Qvc0lBc1NGcS92OGZ3QmIxanVL?= =?utf-8?B?VXBKelNjeWtMZE9ZTlMyb1luSk4vQVBaOHhqT01EY3VyaVYyMjNrRVZyNTIv?= =?utf-8?B?dVE9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 746f6cdc-53e7-42b6-0180-08da5835ecf1 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7384.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2022 12:09:46.0730 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tbDbXRIahZCWx3adg+TyDMoki1M2ToyQos8oGZCeMGPMNL+ygGrhrvEzwUUXerc4n7ugqHMGE4BobjDR4a7gU3WfsYXLgDx2vgepyYonmj0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB2374 X-Proofpoint-GUID: E34uRr7KDJ2c7Vd3mhtOfR-Kw25gDPCM X-Proofpoint-ORIG-GUID: E34uRr7KDJ2c7Vd3mhtOfR-Kw25gDPCM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-06-27_06,2022-06-24_01,2022-06-22_01 X-Proofpoint-Spam-Reason: safe ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656331793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xFMzLrJ1x8KIBlJK498j1GiEB7jRPaY/uPnqfqVGcVs=; b=ysMIEFdgKJ8E4myeLS+LUe1eqAw+yl6Cx60U72WlVscSp3Yif/Xk+z0asf9cCRbG2A61lZ ZdtUh99Ehpl4qB6TkaCugTHaMQFr2PmCXBj3op0x1sxNhKszQj+flUXRSNy6LcswcnJKUa WVDOVOHXjSqlCKFV/twOkQuN46+wO0E= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1656331793; a=rsa-sha256; cv=pass; b=B5CednxqvmfG+Ms3diJ3Hkzn/1t9NXSiFVEF0/El51ASofngRPJ7J35Sa1y4mh9yE/UpTF YvEJxZKnDjcYMQAIkMwwwaZEl1jFerXAw07b6fc9VX54yC1P0zOjbGRIDTbfOjqqHDEOEh BQ+g0ii/5JXudEFBRMQjgsJj2lwo2Jc= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=nutanix.com header.s=proofpoint20171006 header.b=d4lKUVM9; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=none (imf17.hostedemail.com: domain of manish.mishra@nutanix.com has no SPF policy when checking 148.163.151.68) smtp.mailfrom=manish.mishra@nutanix.com; dmarc=pass (policy=none) header.from=nutanix.com X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=nutanix.com header.s=proofpoint20171006 header.b=d4lKUVM9; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=none (imf17.hostedemail.com: domain of manish.mishra@nutanix.com has no SPF policy when checking 148.163.151.68) smtp.mailfrom=manish.mishra@nutanix.com; dmarc=pass (policy=none) header.from=nutanix.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 57AE74002E X-Stat-Signature: 8f64d7pyn3s67u1ce1ox1hahyzfq46wt X-HE-Tag: 1656331793-479674 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --------------XnL1qExmi7gy4Gns5FRgeEkW Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27/06/22 5:06 pm, manish.mishra wrote: > > > On 24/06/22 11:06 pm, James Houghton wrote: >> This is just a const-correctness change so that the new hugetlb_pte >> changes can be const-correct too. >> >> Acked-by: David Rientjes >> >> Signed-off-by: James Houghton >> --- >> include/linux/hugetlb.h | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h >> index e4cff27d1198..498a4ae3d462 100644 >> --- a/include/linux/hugetlb.h >> +++ b/include/linux/hugetlb.h >> @@ -715,7 +715,7 @@ static inline struct hstate *hstate_vma(struct vm_area_struct *vma) >> return hstate_file(vma->vm_file); >> } >> >> -static inline unsigned long huge_page_size(struct hstate *h) >> +static inline unsigned long huge_page_size(const struct hstate *h) >> { >> return (unsigned long)PAGE_SIZE << h->order; >> } >> @@ -729,27 +729,27 @@ static inline unsigned long huge_page_mask(struct hstate *h) >> return h->mask; >> } >> >> -static inline unsigned int huge_page_order(struct hstate *h) >> +static inline unsigned int huge_page_order(const struct hstate *h) >> { >> return h->order; >> } >> >> -static inline unsigned huge_page_shift(struct hstate *h) >> +static inline unsigned huge_page_shift(const struct hstate *h) >> { >> return h->order + PAGE_SHIFT; >> } >> >> -static inline bool hstate_is_gigantic(struct hstate *h) >> +static inline bool hstate_is_gigantic(const struct hstate *h) >> { >> return huge_page_order(h) >= MAX_ORDER; >> } >> >> -static inline unsigned int pages_per_huge_page(struct hstate *h) >> +static inline unsigned int pages_per_huge_page(const struct hstate *h) >> { >> return 1 << h->order; >> } >> >> -static inline unsigned int blocks_per_huge_page(struct hstate *h) >> +static inline unsigned int blocks_per_huge_page(const struct hstate *h) >> { >> return huge_page_size(h) / 512; >> } > > James, Just wanted to check why you did it selectively only for these functions > > why not for something like hstate_index which too i see used in your code. > --------------XnL1qExmi7gy4Gns5FRgeEkW Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 27/06/22 5:06 pm, manish.mishra wrote:


On 24/06/22 11:06 pm, James Houghton wrote:
This is just a const-correctness change so that the new hugetlb_pte
changes can be const-correct too.

Acked-by: David Rientjes <rientjes@google.com>

Signed-off-by: James Houghton <jthoughton@google.com>
---
 include/linux/hugetlb.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index e4cff27d1198..498a4ae3d462 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -715,7 +715,7 @@ static inline struct hstate *hstate_vma(struct vm_area_struct *vma)
 	return hstate_file(vma->vm_file);
 }
 
-static inline unsigned long huge_page_size(struct hstate *h)
+static inline unsigned long huge_page_size(const struct hstate *h)
 {
 	return (unsigned long)PAGE_SIZE << h->order;
 }
@@ -729,27 +729,27 @@ static inline unsigned long huge_page_mask(struct hstate *h)
 	return h->mask;
 }
 
-static inline unsigned int huge_page_order(struct hstate *h)
+static inline unsigned int huge_page_order(const struct hstate *h)
 {
 	return h->order;
 }
 
-static inline unsigned huge_page_shift(struct hstate *h)
+static inline unsigned huge_page_shift(const struct hstate *h)
 {
 	return h->order + PAGE_SHIFT;
 }
 
-static inline bool hstate_is_gigantic(struct hstate *h)
+static inline bool hstate_is_gigantic(const struct hstate *h)
 {
 	return huge_page_order(h) >= MAX_ORDER;
 }
 
-static inline unsigned int pages_per_huge_page(struct hstate *h)
+static inline unsigned int pages_per_huge_page(const struct hstate *h)
 {
 	return 1 << h->order;
 }
 
-static inline unsigned int blocks_per_huge_page(struct hstate *h)
+static inline unsigned int blocks_per_huge_page(const struct hstate *h)
 {
 	return huge_page_size(h) / 512;
 }

James, Just wanted to check why you did it selectively only for these functions

why not for something like hstate_index which too i see used in your code.

--------------XnL1qExmi7gy4Gns5FRgeEkW--