From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36E2FC43334 for ; Wed, 22 Jun 2022 08:31:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD1AA8E008C; Wed, 22 Jun 2022 04:31:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B80918E008A; Wed, 22 Jun 2022 04:31:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A23798E008C; Wed, 22 Jun 2022 04:31:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8F0268E008A for ; Wed, 22 Jun 2022 04:31:24 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 52D288121E for ; Wed, 22 Jun 2022 08:31:24 +0000 (UTC) X-FDA: 79605202488.31.F970932 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id B585E1C000A for ; Wed, 22 Jun 2022 08:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655886676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XOgNTkwcAWagD+/8qHv42QL8TsgA9waoElQ8wVBi9FU=; b=eAjKaopUcMp1tV44GcRHAXs4vogAdqZyG9Hs86uqAhR2GsUPijGab6BhOG5c7A0J0SL84P NXjbWXsbrh7/SvQk9adTFW9eQp0pQHTm9Ptr/ix2wbjAO8SQ20HK0w9a4s3A22t8vmBkal ohCnBcHr834+1IM4dt+0c5wisRAsFUE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-341-R6XmPJ2tMFCgvf1I7sou4A-1; Wed, 22 Jun 2022 04:31:15 -0400 X-MC-Unique: R6XmPJ2tMFCgvf1I7sou4A-1 Received: by mail-wm1-f71.google.com with SMTP id k5-20020a05600c0b4500b003941ca130f9so5264797wmr.0 for ; Wed, 22 Jun 2022 01:31:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=XOgNTkwcAWagD+/8qHv42QL8TsgA9waoElQ8wVBi9FU=; b=WKFQuc8QAR7zNCoJsemC+6jbE2sKWAxqLbZJtdle46tdSg1KGN27/aLSZNVLmnJnKs QoyiSZlha/KnXrP/Pyvi1h1QsIV1cFo86AveiPHT4qgn9l/qyeKdkB2g8TEKUZpgaB0G QIRKmFmXF/FZSwVgoOeTdf+le46WKsERRtHlqABWjPYYiwekuVKMk9LxLQtT58nlG8bZ lhbwfR5wRtJ/QsnbwMJGqK6Hn36LijKxt3n1TceWL9OGK4BcARt+rB+9y2qH3j/FdPbg UbDhhW4hPTXiWSB/I82K2MiSaWwj1L7LxOtriWSA9e6VhBzvCW4FW+57/rEqrtWvbZ3j vlSQ== X-Gm-Message-State: AOAM5333rYgyFb2kOrT0+n6rTUk6M+GEPplxm5HdkDr/wVTKHOHqEMAp 0/SJtpKqjkaHFEFZvNuSJLZ1UmQRYKHkk+WzKMb3B7GUN1mIDm3faHXXDDmARsotLzy4sZJPCnl GPRU+V/5qcNk= X-Received: by 2002:a05:600c:4f96:b0:39c:7bd0:d4c8 with SMTP id n22-20020a05600c4f9600b0039c7bd0d4c8mr44443165wmq.16.1655886673885; Wed, 22 Jun 2022 01:31:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx16lJt7BskzRi2HcEZFHzW44YMI7gnzl0NsviMBJcoc315uKONdvJnnum5f8m+18ezKwpOWw== X-Received: by 2002:a05:600c:4f96:b0:39c:7bd0:d4c8 with SMTP id n22-20020a05600c4f9600b0039c7bd0d4c8mr44443139wmq.16.1655886673637; Wed, 22 Jun 2022 01:31:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:5100:9c77:ce13:2aeb:8748? (p200300cbc70351009c77ce132aeb8748.dip0.t-ipconnect.de. [2003:cb:c703:5100:9c77:ce13:2aeb:8748]) by smtp.gmail.com with ESMTPSA id s7-20020a5d6a87000000b0021b8c99860asm9919631wru.115.2022.06.22.01.31.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 01:31:13 -0700 (PDT) Message-ID: Date: Wed, 22 Jun 2022 10:31:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 1/2] mm/page_alloc: Do not calculate node's total pages and memmap pages when empty To: Muchun Song , Oscar Salvador Cc: Andrew Morton , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220621041717.6355-1-osalvador@suse.de> <20220621041717.6355-2-osalvador@suse.de> <506203e3-1de0-1187-5234-7afc66d4ddfe@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655886683; a=rsa-sha256; cv=none; b=OMNBd0B/URNFki0yKqO1nod5Pmc7n7+9atmP/mPFXTn0p+s8osm/oi9E4rt3eGU24fDN3q mSOumxFKeErmyml6Vn7rbZRSUxy+Uwr6xg6AHOImNAe8sn9FBzpzK1u19KHZWqofE688o5 vo2kKhF8ns0hQzvtVK1eKAysOQTBjog= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eAjKaopU; dmarc=pass (policy=none) header.from=redhat.com; spf=temperror (imf18.hostedemail.com: error in processing during lookup of david@redhat.com: DNS error) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655886683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XOgNTkwcAWagD+/8qHv42QL8TsgA9waoElQ8wVBi9FU=; b=tkitJeIKjyjPEtvcsenDIYZOOo992wsHk8XGSMWkYFi5mqxxyFUL1C0myutL1Zz94zz8cr tfu63GaltMbVx1Z5NjS4rqcRODxUgyw84tICd9JFDmUhF3q1XQ03GEMAWM4tvNDd6KWxts gTxRI44iIP4s7+Jv7wqijIZhYw9ik+A= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B585E1C000A Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eAjKaopU; dmarc=pass (policy=none) header.from=redhat.com; spf=temperror (imf18.hostedemail.com: error in processing during lookup of david@redhat.com: DNS error) smtp.mailfrom=david@redhat.com X-Stat-Signature: 6b193emwubxa1k36n3s3inyay4m6ibm6 X-Rspam-User: X-HE-Tag: 1655886678-136713 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.06.22 05:56, Muchun Song wrote: > On Wed, Jun 22, 2022 at 05:47:22AM +0200, Oscar Salvador wrote: >> On Tue, Jun 21, 2022 at 09:44:47AM +0200, David Hildenbrand wrote: >>> >>> >>> It's worth noting that the check in pgdat_is_empty() is slightly >>> different. I *think* it doesn't matter in practice, yet I wonder if we >>> should simply fixup (currently unused) pgdat_is_empty(). >> >> I guess we could change it to >> >> static inline bool pgdat_is_empty(pg_data_t *pgdat) >> { >> return node_start_pfn(pgdat->node_id) == node_end_pfn(pgdat->node_id) >> } >> >> ? And maybe even rename it to to node_is_empty (not sure why but I tend to like > > At least I like this name (node_is_empty) as well. > Let's try keeping it consistent. I think node_is_empty() might indicate that we're punching in a node id instead of a pgdat. -- Thanks, David / dhildenb