From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCCEEC4829E for ; Thu, 15 Feb 2024 11:13:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AEA18D0014; Thu, 15 Feb 2024 06:13:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 436E48D0001; Thu, 15 Feb 2024 06:13:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 262608D0014; Thu, 15 Feb 2024 06:13:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0EC588D0001 for ; Thu, 15 Feb 2024 06:13:01 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D28AC160867 for ; Thu, 15 Feb 2024 11:13:00 +0000 (UTC) X-FDA: 81793776120.04.7161F73 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf03.hostedemail.com (Postfix) with ESMTP id C312420007 for ; Thu, 15 Feb 2024 11:12:58 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707995579; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H4gkTemgXeSmgULXTJlLm1opmEiXwEwoUAWJJkDRKyA=; b=CkXgH9VCBgt6AQuzZ7q0tB5qU94ICz5+rl0JV5bWKD8vqXuEZzwUV6hrplHv9yFFPneJNK I0QcdcuZ2EL8413N6uxN0tzmo3eO0IB8wL/AOzPzuMh4QzGFdkoz8/t7ODwB7WtQoWJ0QD HVGNHEjTDkQlNAWpyinpfhD7uYDxvRA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707995579; a=rsa-sha256; cv=none; b=8cwzO+ggA6F4kq678aZ+qF2/djcx37LdvHBc5SNFOGbaquY6dmvLeXVhTfjHLhvu2SEjLL t4Gh9TiPjyRpGDHGBoTE9A5brBEJ/+uAr/2vwORKSHUh7x4sD1CVrhqU6A1aLeJUvMLB4o WA1eJvCkuuoOsu8eGSHOQakqAgeSPBk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4502A1FD39; Thu, 15 Feb 2024 11:12:57 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2D5D613A53; Thu, 15 Feb 2024 11:12:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id tzNrCrnxzWWJNQAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 11:12:57 +0000 Message-ID: Date: Thu, 15 Feb 2024 12:12:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 6/7] mm,page_owner: Filter out stacks by a threshold Content-Language: en-US To: Oscar Salvador , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Marco Elver , Andrey Konovalov , Alexander Potapenko References: <20240214170157.17530-1-osalvador@suse.de> <20240214170157.17530-7-osalvador@suse.de> From: Vlastimil Babka In-Reply-To: <20240214170157.17530-7-osalvador@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C312420007 X-Rspam-User: X-Stat-Signature: 8at5tpwxxysrf7baok7w7edo7xod634s X-Rspamd-Server: rspam03 X-HE-Tag: 1707995578-44556 X-HE-Meta: U2FsdGVkX1/ecOD9j164NSkydCYka+lAmK70G5NAM2JYSTtsYAZR8fVzGIf/ivkI+av+LU0zuCFuQKe7R0wFj4CtIfI1X3nlnN6nn3SqPtYyzBZldYc4sX1RvEVCWzH8YbZgD+y8PSePD5csM8Diit9SFmRMXOMR46XsLtd7TfChP6JROUb+1Na+hJEecrlGqkMelBeXjFpG9ldNFG3ilfj6i8uyFjkiqzm8r+b9k4SANPZtkb+B4HmWbwkIq8KqtnTY1IQQATo8E8bKVIZs1Gr5nD0vkxzuCWGcJfs90BxSk0uR/69jnjK7O2uFEASGT6h3Swg4mmEAsuwp6bhe3EsUKiLjWE//i6zFFXrl5DGc/+0HfP6Ys8v1FE6aK0wrLU9D1W7oO8aCAp4xZtcn/UJvRlq/obFZJ4nCRhWSz3RO7Dcu3iKoe1bZqWmYBo2Ru7haPJxRNLl3SkIZzw+WO0EPka+CVsVlxD/rFYbwT1bMYMpMgWHh6h3MBRmwFuw0mpLCpCI93TxoPmLgm6Hr6SjAnBeWyWSq4omM4OlVm/yAeZ5O//pybRdy82W4wOh0ZyjIb6qwpKJj9l/ZKhSXY9zZsnaJ773Wuo/y5UyuQCf8aqUHQVOCl3y9rZcVO47DMm5Yhvj+adpbopmWQdPi1poDaEBDXH0ANZfBxn/qsCMW8zthrDj7oE16OEwONtLmoNAbPKfBmTJ5qNCZwAQpZyFq5cdeZ11PoHekq1ZLFr958/XE5wMi4CuAdX6PlpE6NL8y+L/Q9i2pWh1LE0kTJ1VmpmtHgie5V7qILfm6npEp4jdP/4TTAtoM5G/PMulcbR/A/4tSp1xr7EOujeac61q+2UJoY32ExBBhKB8vMZJrQd8kpmJMqjeSXZpaWOydx0ZeeDsjBOrWcXPCEWvo4jDQ0VKYGkNTvqMI1vebfDHvLhNnL7iuOYrg8QP9c/l9RA8d8vynOcMAz5GY9lV mNvD9BxO 5d2FYOccgm6Hj8jUp6IZH3RZvdsmSuJvxtcnNOx9El+b4DnQv0RvCwzRzSB6xVrFxxUSTJfJv+7bPJiLJzGx8zckHLtyXBrFXMh8gB3Ly6GDiZE0CR0OVTPkYAQaCrYxFYx+cR4ocf0WgA+KYPovlhzu7oEmwRhwqEPAGNJU+AmyFw5LG6W3FhH6bgmj0+z+U+aIIaxn8XDEc4d4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/14/24 18:01, Oscar Salvador wrote: > We want to be able to filter out the stacks based on a threshold we can > can tune. > By writing to 'count_threshold' file, we can adjust the threshold value. > > Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka ... > --- > mm/page_owner.c | 29 +++++++++++++++++++++++++---- > 1 file changed, 25 insertions(+), 4 deletions(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index 5258a417f4d1..9b975f59b773 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -846,9 +846,11 @@ static void *stack_next(struct seq_file *m, void *v, loff_t *ppos) > return stack; > } > > +static unsigned long page_owner_stack_threshold; > + > static int stack_print(struct seq_file *m, void *v) > { > - int i; > + int i, stack_count; > struct stack *stack = v; > unsigned long *entries; > unsigned long nr_entries; > @@ -856,14 +858,15 @@ static int stack_print(struct seq_file *m, void *v) > > nr_entries = stack_record->size; > entries = stack_record->entries; > + stack_count = refcount_read(&stack_record->count); Again "- 1" here. > - if (!nr_entries || nr_entries < 0 || > - refcount_read(&stack_record->count) < 2) > + if (!nr_entries || nr_entries < 0 || stack_count < 2 || > + stack_count < page_owner_stack_threshold) Which will also correct the comparison. > return 0; > > for (i = 0; i < nr_entries; i++) > seq_printf(m, " %pS\n", (void *)entries[i]); > - seq_printf(m, "stack_count: %d\n\n", refcount_read(&stack_record->count)); > + seq_printf(m, "stack_count: %d\n\n", stack_count); And no - 1 needed here then.