From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ankur Arora <ankur.a.arora@oracle.com>,
linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org,
luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com,
hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de,
jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com,
boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
jgross@suse.com, andrew.cooper3@citrix.com,
Joel Fernandes <joel@joelfernandes.org>,
Youssef Esmat <youssefesmat@chromium.org>,
Vineeth Pillai <vineethrp@google.com>,
Suleiman Souhlal <suleiman@google.com>,
Ingo Molnar <mingo@kernel.org>,
Daniel Bristot de Oliveira <bristot@kernel.org>
Subject: Re: [POC][RFC][PATCH v2] sched: Extended Scheduler Time Slice
Date: Mon, 30 Oct 2023 14:05:05 -0400 [thread overview]
Message-ID: <bb628206-28eb-470e-aaea-0f18ce94e983@efficios.com> (raw)
In-Reply-To: <20231030094508.031357b4@gandalf.local.home>
On 2023-10-30 09:45, Steven Rostedt wrote:
> On Mon, 30 Oct 2023 08:56:50 -0400
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
>>
>> This only works if "your" lock implementation is the only user of this
>> RSEQ feature within a process. RSEQ requires that multiple libraries can
>> share the facilities. Therefore, the rseq field should include the
>> nesting counter as part of the RSEQ ABI so various userspace libraries
>> can use it collaboratively.
>>
>
> Then I would suggest allowing bit 31 be an "on/off" switch, and the lower
> bits to be a counter. When I first tried this with postgres, there was one
> lwlock that looked to be held for the majority of the run, so I got rid of
> the nesting. But I think a mixture of both would work, where you can have a
> nesting counter and an on/off switch with the caveat that if you use it and
> enable it, another library may disable it.
If you have the nesting counter, why do you need the explicit on/off
switch ?
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2023-10-30 18:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 3:54 Steven Rostedt
2023-10-26 10:59 ` Peter Zijlstra
2023-10-26 11:14 ` Steven Rostedt
2023-10-26 18:36 ` Mathieu Desnoyers
2023-10-26 18:50 ` Linus Torvalds
2023-10-26 18:59 ` Mathieu Desnoyers
2023-10-26 19:36 ` Steven Rostedt
2023-10-26 20:45 ` Steven Rostedt
[not found] ` <644da047-2f7a-4d55-a339-f2dc28d2c852@efficios.com>
[not found] ` <20231027122442.5c76dd62@gandalf.local.home>
2023-10-27 16:35 ` Mathieu Desnoyers
2023-10-27 16:49 ` Steven Rostedt
2023-10-30 12:56 ` Mathieu Desnoyers
2023-10-30 13:45 ` Steven Rostedt
2023-10-30 18:05 ` Mathieu Desnoyers [this message]
2023-10-30 18:19 ` Steven Rostedt
2023-10-30 18:27 ` Mathieu Desnoyers
2023-10-30 18:39 ` Steven Rostedt
2023-10-26 19:20 ` Steven Rostedt
2023-10-26 21:35 ` Steven Rostedt
2023-10-27 21:52 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb628206-28eb-470e-aaea-0f18ce94e983@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.cooper3@citrix.com \
--cc=ankur.a.arora@oracle.com \
--cc=bharata@amd.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=bristot@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=joel@joelfernandes.org \
--cc=jon.grimm@amd.com \
--cc=juri.lelli@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@amd.com \
--cc=rostedt@goodmis.org \
--cc=suleiman@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
--cc=vineethrp@google.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=youssefesmat@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox