From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF4DC54E65 for ; Thu, 22 May 2025 12:01:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E8C56B0082; Thu, 22 May 2025 08:01:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 799986B0085; Thu, 22 May 2025 08:01:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 661A66B0093; Thu, 22 May 2025 08:01:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 442366B0082 for ; Thu, 22 May 2025 08:01:41 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 059281212DB for ; Thu, 22 May 2025 12:01:40 +0000 (UTC) X-FDA: 83470404402.02.9DC3BE9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 21B3240021 for ; Thu, 22 May 2025 12:01:37 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZeH8Xnmj; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747915298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iNKHItieFldlVHFOlaztfdsZmomMboRlw+z49HMe4ok=; b=k6yJc2q8e7lo+QIiuVbZw6C7zBMq6iVT6QgfnxOeCPYLhZ9iPXbXkWXcK0ORFQPYd1VSoA YE5kz7sF8JXfHbrHDoyUr330xctXJOBKuiq3U668IpEDfbdKTv+L4AyRLo3XgFAicilDbi 9/sieJDXmzGUSX8EIZfPd9uj78r2x5Q= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZeH8Xnmj; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747915298; a=rsa-sha256; cv=none; b=JbYzLiOwKpu5GDym2qCen8qXhYIr4DLXpRAkYGcDGn4ElLA1Wc3WMjojh/It2PKQuYnk9M IXTgpqyVzjjiXhtftm3JmTZAbl8PE86+6LX/G2r5GjpqyM7djf54bczdjVz3DGvT5Hd9+f /t0WttrwGYSzyhUeo+tvUmBhqFhQ23I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747915297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iNKHItieFldlVHFOlaztfdsZmomMboRlw+z49HMe4ok=; b=ZeH8XnmjQfFv5xdW3cVDjvmhZfuLhCAytImSVY+75YaeDAnA+hqglQsR32JVz4N5saTXbD JnEIWdieJAP7QOCADgRBxUzc2otnoZQmJdjfzV9YfslzIkHESRfIo7EjSXYIyhhPxcThiZ cKsaM+FwG4YyvPWxOSk1YVpCI5Zh7Yk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-501-UgXf7r2DPRWJMiI2ExkXWQ-1; Thu, 22 May 2025 08:01:31 -0400 X-MC-Unique: UgXf7r2DPRWJMiI2ExkXWQ-1 X-Mimecast-MFC-AGG-ID: UgXf7r2DPRWJMiI2ExkXWQ_1747915290 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43efa869b19so61129725e9.2 for ; Thu, 22 May 2025 05:01:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747915290; x=1748520090; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=iNKHItieFldlVHFOlaztfdsZmomMboRlw+z49HMe4ok=; b=KDOT0ws0aCBcHsT0/fGhmmQEZiFsdAdkkdWDybIYlZ5BNzKSUKQReYX1BM0ZUbBdkz UJJtB1Hluq7bzWS3n1vIEbedR3hMUA5SVwsmL38ryOW/AlEv3HppqlR9jDzxpr9uAhtW f1K/a5j0GYXchhtuPF4g4LSg7BRe1cDT+0oqF6HkYITjI6JDX21I9/xL0gltxemdDQtc +Qn4w66GhbF1jDaJJ8xvm5sOBKsD9QN9ClvTmEA6279EpUmNTVtdY7AuA3lrPXZQesSC SNd4D5MFBfzz0lR+3ufVpYHr76CWhddLnV6UTBsEGJBsJ9cy/J6X1wdw2qBaGjokVOOK 1jAQ== X-Forwarded-Encrypted: i=1; AJvYcCUh1+TUlc94tgzfF9kg3EPh2Lv2FAQrnEkuYFBCMRsKiuhAPIGurVKw+sxCtcbQJeLeqlu72Cg5BA==@kvack.org X-Gm-Message-State: AOJu0Yye/pVwlVuz5W3pxc71NOCnBsgnE4bh8CZynuQOrTKGokGzwdqN xeR05Q/05ZljEZUbvT2reamDg7nQjdFyJXbL8NG7CWHEHomI8LFUFpd8IZ1FA3kgvjb2MnakUNQ u2PEwPEt8J10Fpmba0WiBM9BtuCNuh1Iajcohs8TteYgW7gorO63T X-Gm-Gg: ASbGncuojqokBy0mq1UwvWZD108mt7hO7++m9VIT+wYTGkh0hTukVMa5z9vOHyDIWS9 jmcDG5xqJU3h/uNGcNivVPv8atXojNI4GpdyFToe8MYFd6ltd9lYLXh1InRnTXdmIRI4k9fvQkY 2FLSBTyqNWQ37jtG0DDyOR0o1aVuEqq+YHzbTJ+wLuu8ll1Jfsl4xfBiBa0AhpMsj/mtIHm9hVN DC3x6+YTiYxVH5Xw6MsORDPcwzXcG+lSkFnpGUD9h/A66hn6wL5meqMl8P72cgvwolL3oEmmxvF QhNomn2UxjT0ogZgyHPXueSs0G7MjYcXu5CAt84E8A== X-Received: by 2002:a05:6000:1862:b0:3a1:f69f:3341 with SMTP id ffacd0b85a97d-3a35fe929c0mr20912564f8f.26.1747915290001; Thu, 22 May 2025 05:01:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErMUayE2jYtY0hACROYIHryKUvps/DNFcId2ztdIhvw5IaHZ+RDOk4bPfWfqVqksX/ZTFcKA== X-Received: by 2002:a05:6000:1862:b0:3a1:f69f:3341 with SMTP id ffacd0b85a97d-3a35fe929c0mr20912491f8f.26.1747915289482; Thu, 22 May 2025 05:01:29 -0700 (PDT) Received: from [192.168.3.141] (p4fe0f532.dip0.t-ipconnect.de. [79.224.245.50]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca4d230sm22458617f8f.4.2025.05.22.05.01.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 May 2025 05:01:28 -0700 (PDT) Message-ID: Date: Thu, 22 May 2025 14:01:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 0/2] add THP_HUGE_ZERO_PAGE_ALWAYS config option To: Mike Rapoport , Pankaj Raghav Cc: Suren Baghdasaryan , Vlastimil Babka , Ryan Roberts , Michal Hocko , Thomas Gleixner , Nico Pache , Dev Jain , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Zi Yan , Dave Hansen , Lorenzo Stoakes , Andrew Morton , "Liam R . Howlett" , Jens Axboe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , gost.dev@samsung.com, kernel@pankajraghav.com, hch@lst.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, x86@kernel.org, mcgrof@kernel.org References: <20250522090243.758943-1-p.raghav@samsung.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bBEM2I0mHTOAT-XuZTE7iOEPquZthIHkVwjUoVo5OFQ_1747915290 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 21B3240021 X-Stat-Signature: xq6q5bmzzupss8auu6w3stgcu9or1jiu X-Rspam-User: X-HE-Tag: 1747915297-133138 X-HE-Meta: U2FsdGVkX19IZNzcZ9Hiq1SefsncOOL8LXpWkHivvoyFp/h8irlkVlGba5W2aEtfjSbvX2PTdGY7t3qjSMV3xwK586J00yam3P5fjmgjY7tdYMgfr7oa+0Nj18y9UjoofK+jLqBpxbakXxbAvXqzbLIBVSKGjK1mzrQ2tQvkWaEvQ0jUi2f8kdgljsW5+JgjlLFKgi2XOgP8CZvGvrfd/Zal7+jTbpIyOINe5eQFl3GozVjc1izCErXEfa5pHvbq8DGd7mGILe1tNFZUDL/p0AMDvrTcrhfGZnHypOuNk6SeD8KrZDWM7ZOnLLWXnA0UINMuhW0GC4StPF1hbFyBFp4sDt6K3doMBdHkbQ0mgWHx8nWYQigO41dDObrKTp02dB3bYJwZ71uIlOlG8tCvY36MM5Idk2VMwIKvubW1uI0pv5zUM1im24/Dhp8yVlgvWejtulbnZa22j6+Z0nZjCYqfX3cIcaCieAfIhAXrP/df2+ayb+Ha6CJwUHpNr6FdH0k+jmn7tOe50NCkmXikARPuZQ0sd6lYC1yISxubk6ItIxSv0oB6PQiSaiHRyJSzEkeAptY29dxIMN1u8U3B8qvwxE2RuJYMWZFDHgM8sI2cl8jEJwLR1tQzdrQkOzyNsH9XQ6lEGAfT71ut1UrB4jX2hPIGIf4SbyWxBnXlerZ+2KTHdm7t7waTksstDt+uSsOHZUKD+wXPBMC5sVdQY+G0nMYTPN6CZmmvQKle/5EKLpOd2M91WJrH+HuqnU+DQki7nWvLE4MOAGpa6baeNVXa3NWfpVNs20xY0Iv1OS3O3iWCdZeEPvWaKA7DND6WUGVc2pAHk35iSijAiqn14kPNhXnASbp8YpXyqkXol1af0/fAe3DTYpLOE0Le+Dex7osHtcP97tm9ZAyC3KfQktpJk/+1okZd888gllo1q1SDfNbMjc9DP1V4yzv08Pp6RegRcbnGIbsgX6Qzxc7 w9Kpzn7e Hj+5TapSdV5qwostMhT/3RM5U+a/pCcZJD1dYrrRVvpa977aW6O6lV1j+t+M34ymXTg1JiU3wlUbIeXSMQD2CbEPBlu+G6SfMg0KZcqPQfn/9l9+YhvvVmhdsqhM696dE1grd0g7FXSmgeeHYuEOlvzv8YTQEzXNqbpU9sn0GKCtbSQ8rTq34IEROO3pd9h27KN67lsXACRYUmEuJCdMHdsZoUR0cK5vvEclewzFIerP9OGJ9vkZyqHk/fj7QfmVJr0SdZBaz5VEcRVsUsQDu/z0a+Bj3gOo4xXuuLAQj8YXVLUXjhaDZhgep/YpdfYoLprde54AeCf2ssQF9LmxzqX+hoZR+w4ylblD7HFVu9pSC3WZDvOxfhJmAGT2hTw/v4lGixIkc+B59OZE+99ciNig8HvRnH6rN5z/z2dZeVFKVtfVbIrjfiXkW1o8MBB2ll3Z7zmuu/3M+rlzbY7oy/n6xFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.05.25 13:31, Mike Rapoport wrote: > Hi Pankaj, > > On Thu, May 22, 2025 at 11:02:41AM +0200, Pankaj Raghav wrote: >> There are many places in the kernel where we need to zeroout larger >> chunks but the maximum segment we can zeroout at a time by ZERO_PAGE >> is limited by PAGE_SIZE. >> >> This concern was raised during the review of adding Large Block Size support >> to XFS[1][2]. >> >> This is especially annoying in block devices and filesystems where we >> attach multiple ZERO_PAGEs to the bio in different bvecs. With multipage >> bvec support in block layer, it is much more efficient to send out >> larger zero pages as a part of a single bvec. >> >> Some examples of places in the kernel where this could be useful: >> - blkdev_issue_zero_pages() >> - iomap_dio_zero() >> - vmalloc.c:zero_iter() >> - rxperf_process_call() >> - fscrypt_zeroout_range_inline_crypt() >> - bch2_checksum_update() >> ... >> >> We already have huge_zero_folio that is allocated on demand, and it will be >> deallocated by the shrinker if there are no users of it left. >> >> But to use huge_zero_folio, we need to pass a mm struct and the >> put_folio needs to be called in the destructor. This makes sense for >> systems that have memory constraints but for bigger servers, it does not >> matter if the PMD size is reasonable (like x86). >> >> Add a config option THP_HUGE_ZERO_PAGE_ALWAYS that will always allocate >> the huge_zero_folio, and it will never be freed. This makes using the >> huge_zero_folio without having to pass any mm struct and a call to put_folio >> in the destructor. > > I don't think this config option should be tied to THP. It's perfectly > sensible to have a configuration with HUGETLB and without THP. Such configs are getting rarer ... I assume we would then simply reuse that page from THP code if available? -- Cheers, David / dhildenb