From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C00C4C77B61 for ; Thu, 13 Apr 2023 11:19:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24CBF6B0072; Thu, 13 Apr 2023 07:19:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FB0E6B0074; Thu, 13 Apr 2023 07:19:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C5D2900002; Thu, 13 Apr 2023 07:19:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F13A96B0072 for ; Thu, 13 Apr 2023 07:19:12 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 90DE31A033C for ; Thu, 13 Apr 2023 11:19:12 +0000 (UTC) X-FDA: 80676121344.14.6C78ED3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 5654740018 for ; Thu, 13 Apr 2023 11:19:09 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dCiphMxI; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681384749; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XuDaODPg28/lbKls3iVZv9/j3tAy7pEuJB1+NArX0sI=; b=mBcA+uk1Gg06v2FghkzmKnbRtwt4U5X2semRVYWCpGRgJjnrhgxdiUSVb4Akuox57F42Ra oUoEyhFjDof0fb1E6ndlpvrk82KinJgi1OVO8PImiCHmjgrJSw3Rvpbx6pPGvlnL+qkSBf 8KtE5qszhP1CzyzY5E6sAD5/OFtoia4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dCiphMxI; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681384749; a=rsa-sha256; cv=none; b=fHE37DCHnhnYNXhBo/saj+p9PJGQc0d/VE7630MdToVYlR47tZN5jfji8QdgFb9g19zTaP 8tBZNHTQhI/YnBbnrv+LiibYoVFTHkKBnsEdV5tqVFK8EeUvTfmJUMWlRahQku9/fmRdFe zoEZ024mwiOZs9cIDC9QmTwpS0QhEvc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681384748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XuDaODPg28/lbKls3iVZv9/j3tAy7pEuJB1+NArX0sI=; b=dCiphMxIDyFQDoWreIiJ7CvZwV759blUxkYS+1NpIdE5MVOERIzGpHuF+wfwJklYEhtHZj FbAysGvv7JZxAHWgsIQbm6lxaA5sNvsMFoDKHqccOSltlKNYKsCzrp22nxPWqm5iWfpi1G Uuok0siJa5zoAw0eTJ33fLySQB+E2e0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-ztmnNDmENQuzI3w9ycDpTg-1; Thu, 13 Apr 2023 07:19:05 -0400 X-MC-Unique: ztmnNDmENQuzI3w9ycDpTg-1 Received: by mail-wr1-f72.google.com with SMTP id d30-20020adfa35e000000b002f53b0a3377so681155wrb.5 for ; Thu, 13 Apr 2023 04:19:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681384744; x=1683976744; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XuDaODPg28/lbKls3iVZv9/j3tAy7pEuJB1+NArX0sI=; b=JA0NMb1c92hdidO9HLpMIcIpTwUdv/75r8tgg7NbgY75Mga1EnWiuUTDUC7DdSpWSz scXnhGr28ZHzsHeXHEr8A3ndWQrBma/RfstO94SUcnRrtXcRgon75avj67JaXbr1J95a UXy6Kj5MD3Kmcd1SQJOK1z/1quINtQrz1/RRqu8httOw7Re4L3k8X4IPrGzWDE+HMG5a rHkUL88TS0xHsDk8cc6ACXciqShTegJdvDhHNiZudJvgriPVomaoC79/5s2lHlwg6V0x ap5+/mAXOm13CKB6RfKS+MJTbtKnIEpox8YfMW7rebYt3jzR5UX/71vtixBCW0qb9M/o M2cA== X-Gm-Message-State: AAQBX9eXNF8mmz6B4myxGAwawU/CbAnk6G2MJQ9xvOuZttqi3y2RYnRd aR+jP4CH9/k7h0MA/w+5s3xmgoUpNLSTBK8z3e/iZqisA1NoFy1Jm5Av3rwelo/EdL+tEDBrFdF +3Is4hnc7fQA= X-Received: by 2002:a7b:ca4c:0:b0:3f0:7147:2ecd with SMTP id m12-20020a7bca4c000000b003f071472ecdmr1571281wml.7.1681384744362; Thu, 13 Apr 2023 04:19:04 -0700 (PDT) X-Google-Smtp-Source: AKy350bLB2veUASI4/m+qmmFnnoaJ0DjGho2eJAioBtjyEBuvdQ48H1Q2Wt23LlVt3082GLF+6fzbQ== X-Received: by 2002:a7b:ca4c:0:b0:3f0:7147:2ecd with SMTP id m12-20020a7bca4c000000b003f071472ecdmr1571251wml.7.1681384743997; Thu, 13 Apr 2023 04:19:03 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id bg20-20020a05600c3c9400b003ee9c8cc631sm5196264wmb.23.2023.04.13.04.19.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Apr 2023 04:19:03 -0700 (PDT) Message-ID: Date: Thu, 13 Apr 2023 13:19:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v6 2/3] mm: vmscan: move set_task_reclaim_state() near flush_reclaim_state() To: Yosry Ahmed , Andrew Morton , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , Dave Chinner , Tim Chen Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org References: <20230413104034.1086717-1-yosryahmed@google.com> <20230413104034.1086717-3-yosryahmed@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230413104034.1086717-3-yosryahmed@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5654740018 X-Rspam-User: X-Stat-Signature: zgttoepnysnebax16am5qsfzgaug3teq X-HE-Tag: 1681384749-184728 X-HE-Meta: U2FsdGVkX19x303k+XMAwC7nWrFuF46lunx9V7ulaHkIbsYBzB/KU+Mj5UZEgTAsf4o5k59EhAXdxR0wpEhxvs87tCrY7UjVC/9Jy0vR8aD/QuYWnySi2KS/D2i3WCeWiL+AIRVpmY0g30pP07h7IJe8VGyfgXqSmo0rl97Qzm9rgOay+AHGZLWPD+rfuII+aZX+NelYavRvvpjrVV51bSmGMk3PMPPBYHpW+9Ysn/noHVMKkI/Do5bBOnE8VQMD6kBEWf/xA42+gB5TYoDNnRnNuNQ/lmXedmBjJDMSVnCPPOjnqUnN3IsB7CH8BzHTdqqtQWHRKaDTExj4hVQUJm35f/S1IXt6/r9jl4O7asGIiD/g7HWmL6ywNfDowXLm9nDIFhIgWuHEUbeuUNT+qWyMXI0ijPxqL1I5Tqg02dRELKjIUqnyQ97i5Fa0uUV8PxP4JCt1pxEZffstXIiLD+S+Ws3/8FlIQQIvTzBgosmCYCdgyTili1dqjI39f66+yeQdtiNX+WjWwTBGZLeHwD6IO7MZFS2xXCSl+ujgAYg0fcHd0B1D1l91so6fFDOKpnW4TdxtxwahHlrBlSGM535e+LMxsMfNaTdVWFvZCeBxbnCYj32uTBmRBKwmqk3z9GChdl0Hi/21BmYtVSJ9JApVXmtgdCCfcFL37NK90ef/rA7KA1nYBuiL4oOBiSiRf+dHM88qDMnbgm2AYC6xq/E4FsAKulSpMh1m3hEb7NiYbpUO5TbaWKPxFXfj11Mrh2RnnbrHFgXWGyv2psHWk35pC2vQnbAkwZoA6lJlxoCpe2BO+RTR4VsA6FFYJCwWW5D4Vpd7/Ps5SEnS8ySBBVhq6RGnbDcBc3i5ApHDcC+f8TpTb3gaaHIUr6PxerKEd7FylteThuroApHc+vDzMurEpRvh3upzDkPVk4aAP+9FauVOmtUqKwhIoWoyDD1BaWtt4B7sbOgwVTGY1iW 7O+Jmo/2 r8zK1BrJfMR+kJRd2gJDLIdhzD/8n3qHNx/+SGomxpz2AHLjWwsa18WWmciRDyzwVigZqM2zi4lWY0hl4IMiRLjHMBxVDrLCif9EVOjnh1WHoLRT/Rp9+OyqMD78QPkP295MA33FumyohrykkXjngOwsha2rZMqxYUrMjnw9TIa8VeTSPm9Gslhw7A3Ex/QuKjY0bUWYtRPcr3n6WCnE5CWG0hIR1eHAxuiI5h1LaTDAJzYjh2GEJSjuw/dTTl/f5+UkdHcirGUV38xOlkKgpFEWKyU+1qIDOEGmSHy1hl6jJd0gjrl5lQkD3MYTU5GGwry57/L0qeA8et05pQ0/IPC/jP3l0K6Hgsuv1/NwO10GpQ8rccj8d77ncXbpFuHPISagQ73hETVS1CkPyOzMoAEHBHXMPjtOBjZ1L3ioALN3wfIeWYaxIbWLwidpCzHTW1V8c+NcOhuPzriZcrCPrBRUdAxyDLtYquHMkEz2X1/mgZS9DtvWTPWejHdJyuj5Bro0zgJgw5gxAtfP0XxgM5fQO3yrAcjdpkF43ZL50iV8kHtNw9PuNGxojN24mBIHDeiCe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.04.23 12:40, Yosry Ahmed wrote: > Move set_task_reclaim_state() near flush_reclaim_state() so that all > helpers manipulating reclaim_state are in close proximity. > > Signed-off-by: Yosry Ahmed > --- Hm, it's rather a simple helper to set the reclaim_state for a task, not to modify it. No strong opinion, but I'd just leave it as it. -- Thanks, David / dhildenb