From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ECC2C3064D for ; Tue, 2 Jul 2024 09:31:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C82D6B0095; Tue, 2 Jul 2024 05:31:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0782B6B00B5; Tue, 2 Jul 2024 05:31:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE5D76B00BA; Tue, 2 Jul 2024 05:31:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BDD716B0095 for ; Tue, 2 Jul 2024 05:31:09 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2E8781C365C for ; Tue, 2 Jul 2024 09:31:09 +0000 (UTC) X-FDA: 82294293858.20.FCCC392 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf08.hostedemail.com (Postfix) with ESMTP id CAE61160002 for ; Tue, 2 Jul 2024 09:31:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Or6wJIF+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=IR5aqluV; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eqmkFc27; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zAAWmqUw; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719912650; a=rsa-sha256; cv=none; b=OL9uPdMaPAUbBl0+otQjkRMwoQHyv8QAmerUIFUBHAZetuWytuJmGKzWHUIiUwY0UqH+Z+ FwXlvAGFQodSCF2tcpO0M5/4EwLFyLyHEYLnpr9Yd59d8iUVl6wKyB84/e6ckoVO8QyWz6 kUuo2sDRURDVFcPtFWPtKGocC8CIfCM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Or6wJIF+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=IR5aqluV; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eqmkFc27; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zAAWmqUw; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719912650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VN2koVPOWj3sGqHMQ5WBQyHX/C5oZKpDGLxXVxlIKlM=; b=El564p3tYZya52oG3//yJqBEPb0D1JcU6Gb9wl/C5/FtEncJ0L+65g5YDvgM4lTr3CuDLx 0tEZHgl90e3X5RlNCoIwZ8hZfU5ASj9xk3KOXxMJV8D+hXjneIzkvM6LyQuPO+o4OraP+r hmmjZARSP3adpUofO49PFVNPS8iyLqM= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E226D1FB90; Tue, 2 Jul 2024 09:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719912665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VN2koVPOWj3sGqHMQ5WBQyHX/C5oZKpDGLxXVxlIKlM=; b=Or6wJIF+odV4MjKWnmt40ZA8dcZ1zhFSzyMFuUWHTEfLZHYeQcIaeICDqbT3Lq0zDs/Ao9 XyJDh74D7G6SL1P1tzVaRazxxRbZBOZH8BLbFGkROvxN74QHnV3nc6EMnznO9wlxd19JZk kJbh38ikULvNn/BvoaCDAc4s8YB6OJ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719912665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VN2koVPOWj3sGqHMQ5WBQyHX/C5oZKpDGLxXVxlIKlM=; b=IR5aqluV6soLhf11GD63gba5KwADgbmh3rf5sjvzbVUweEW/G4oGMBlr32/YhcgX9fTStx Azr+7W2lNis7PeCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719912663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VN2koVPOWj3sGqHMQ5WBQyHX/C5oZKpDGLxXVxlIKlM=; b=eqmkFc27yUiFhBYzKJdGjJxtD75N3ApNZH3wb6LyUgSmrSokF1Tnw1K4fYBVSfPq0x0xmX 2m7T5ZVq/F40PnPSUgnqkYFshs/vNR3ZCZt/fvmN7zKmlaKIrPmvG2zJQ3qahLm5LCbOPq fcGaWvlm+XU0g2Zo6jIFzV8EJLtHxe4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719912663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VN2koVPOWj3sGqHMQ5WBQyHX/C5oZKpDGLxXVxlIKlM=; b=zAAWmqUwuS0BN8TYJADfAsYGEWXbyvO5kHzrYnUfLjYTH52JL2i1sWkadLieGjokTUDwye LIBSRmssnmR6ZgDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CB7CA1395F; Tue, 2 Jul 2024 09:31:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id B2hUMdfIg2bZLgAAD6G6ig (envelope-from ); Tue, 02 Jul 2024 09:31:03 +0000 Message-ID: Date: Tue, 2 Jul 2024 11:31:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/slab: fix 'variable obj_exts set but not used' warning Content-Language: en-US To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot References: <20240614225951.3845577-1-surenb@google.com> <18a30d5c-abf3-4ceb-a7fd-2edfd8bee2a8@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: CAE61160002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: hcoo7yarbofepinsiswkygw19p3469it X-HE-Tag: 1719912666-882882 X-HE-Meta: U2FsdGVkX18/Hi74b3WxaRGMOG9cuWLZZLPCYjVSnE04Uq1zwCjrMfUdaKPUZ/9U7A3BmodZxqvCb7G6uUV10b1a00MuTdCyj1v35/Dw6jR3Xx8jRX4OMg5Md/9s0rCWvpJavIMaaanat7XjHzXolscHSCJim/yHS14OizYGPh5VBgHwUMuO1J2PC0X4MOHIDSvevBLPUsOcCZTTarbw9d4PZtbPl/CQRtqcds2cR0oDgKsqlXQ6AwF+npLUuaAPhfnf3m5J7fh4O24eULj8ZXRP87dW0iw8MPIPz7mAI2QBSKZNm5M5pAqUUjpk9VbrwAoKRouxan4/e0KTKEaw3jV1A4iGyaRDzhIjuRl+FXrm3RIoBbGHvVFmxX/Q2tCT9GFro1O1tby6VdRhNDA3huWVXlF3Gw2QChcNj7MD4Macw34ARB69/bn2A2QJ5TtumhfBxngRqx9fPqNTFlA3fzSx4svhjkP0DBp4dCjFkTWh33bdXEp3ltc1bAVxPCvLv+dvr2ipjVZvCOMIwZTspelEHzLMPWMDQcKnYhcY3WOtxZzjlA8AklZ0QfelwR9vjH2YPDcegqx39MxCcMVf5mT3BLj3cn5juLxl08CZwS2EIdS7prLY55anka6O+rKIA1JygFEmPYA1p6UqDA9M7jYtbxv36MuR7PBJWHIzziOo1jG08fK3wg8m5OQ3o7rahEH9vOWgUy3qRqN+fujY7kxpDF/Pkx0fLON+vh1kjGY6qXQPxm16FmsJXTDRs1UCv1nkbeGQJ+rJBvA3eUOgCOOmEyRGU/l8UzEP9KUhLrjLkptTXMWCE5IPm9qBG7Q3mVNPpsc5VoaPeUtJpHCeY8gEkCESTHaR4sgvFJcVb2/Z286aRbAKaQbN2piqkwNSf2WCuNYHbQ62DimnlS5rqriJM4E9zArfCxWwlhKwC0ddjmFwAWEf4P4lf5mmWZcCWQtPNfs+gpb9ahBnabH tdH/XaeL lmV+v8CTp1csTq0mSZ6Q14Aj1+vKFgbv/oKk3qrwY2qcaYp55GgQ2Gp6cFjDjUpojUfwMWhXLSq44ZuGV4qngdb6jpaStAbeZSp0Ix1HpDxWIocwD5dp/8nm7c73S7PCto1F2KTcU5m3iLS2CDWoM214g5sWfRUWvVnzu2kyE4tt3mXmasmh7SwSF1HLbbSkyuiJKoXdjXChPsqsYMdxBxHbhtvlmS1mIc4t0uR774lZ49/PJOt59ASCtVaFFmS/Q4vi97ZLvk7Q99HruZeZkWcDaCAVG/0ozL5ponbsaXkoPzlB832BC9Cp4Qka2dckl7M7rlEJvx5zzpreuXUc2ufHuaQx3HTiRLmtIW3hcffT/9n9sjxMBzGTx+J+PvrmSdO1+ITPQpTdJRW9yk9w1IU/rBxaoRq/68p5Dtb158FF8LNOM+tzjI1qZag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/30/24 9:20 PM, Suren Baghdasaryan wrote: > On Mon, Jun 17, 2024 at 3:04 AM Vlastimil Babka wrote: >> >> On 6/15/24 12:59 AM, Suren Baghdasaryan wrote: >> > slab_post_alloc_hook() uses prepare_slab_obj_exts_hook() to obtain >> > slabobj_ext object. Currently the only user of slabobj_ext object in >> > this path is memory allocation profiling, therefore when it's not enabled >> > this object is not needed. This also generates a warning when compiling >> > with CONFIG_MEM_ALLOC_PROFILING=n. Move the code under this configuration >> > to fix the warning. If more slabobj_ext users appear in the future, the >> > code will have to be changed back to call prepare_slab_obj_exts_hook(). >> > >> > Fixes: 4b8736964640 ("mm/slab: add allocation accounting into slab allocation and free paths") >> > Reported-by: kernel test robot >> > Closes: https://lore.kernel.org/oe-kbuild-all/202406150444.F6neSaiy-lkp@intel.com/ >> > Signed-off-by: Suren Baghdasaryan >> >> Acked-by: Vlastimil Babka >> >> But it seems to me we could remove the whole #ifdef if current->alloc_tag >> (which doesn't exist with !MEM_ALLOC_PROFILING) had an access helper, or >> there was a alloc_tag_add_current() variant? > > Hmm. I'll check if current->alloc_tag is the only reason for this > ifdef. If so then you are correct and we can simplify this code. The fix is now in mm-hotfixes-stable but we can cleanup for the future as a non-hotfix.