From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 596ABCD484A for ; Wed, 4 Sep 2024 14:52:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D945F6B04C9; Wed, 4 Sep 2024 10:52:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1CD76B04CA; Wed, 4 Sep 2024 10:52:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B23DF6B04CB; Wed, 4 Sep 2024 10:52:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 882B66B04C9 for ; Wed, 4 Sep 2024 10:52:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 42726141030 for ; Wed, 4 Sep 2024 14:52:19 +0000 (UTC) X-FDA: 82527346398.04.99F8E40 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf13.hostedemail.com (Postfix) with ESMTP id DC54120005 for ; Wed, 4 Sep 2024 14:52:15 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=eVPbL0sl; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=bWf1oGxS; spf=pass (imf13.hostedemail.com: domain of steven.sistare@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=steven.sistare@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725461511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A+p2XqNx5Lfz2uLwMeKJIPsI7UdX/L08mkkC7EPrEfk=; b=RuYVTEap7w7bHdi4TnV9aVrPdIAn+vYccMnQ+6NbQJ5Kg16O2ZyNkbFa5wy1C9I/lAH4RC v41QQd1HirJDo7iQujnyA80K1skC5NESQUPjEumCwk08N9YfaauWyVF//qXMIxe+Mm9RQp GdOKFltmg1nxNutVD8lRLlj+Ut044Mk= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=eVPbL0sl; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=bWf1oGxS; spf=pass (imf13.hostedemail.com: domain of steven.sistare@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=steven.sistare@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725461511; a=rsa-sha256; cv=pass; b=CDr+bsOFF7CdYEYND4fQS1xly1X/0Ml84NWHfiOjhjEtVM22cALFGrjL1f8M3SHQeMCqRw z4SGtswlLFt26iBQa+z5xONt4/apEd3SeYmXj3oM8ifTk6Bwk0BB0WqKFzSMq4kE1mTV46 xqlIFhHpM13UGfSqgMLwlDxE53ozcgA= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 484DXVua019468; Wed, 4 Sep 2024 14:52:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= message-id:date:subject:to:cc:references:from:in-reply-to :content-type:content-transfer-encoding:mime-version; s= corp-2023-11-20; bh=A+p2XqNx5Lfz2uLwMeKJIPsI7UdX/L08mkkC7EPrEfk=; b= eVPbL0slITz65CF1yGgXPU9J9aBY4QLoX8K/P7OWHvSwjGW65GZ/svr2Da9Ht7qy +NLAvXTOP2K0Afdq++xFG4uF1WI4L38IzoDyd18uUuACcqyFIVqHHgB1bM7WVsGR jA3yhsmjwazGpir+F4hnzZOINKMDAYZhmAv++aVZXahINt8lz3qwPV7wPYZ2E0gF /9VBxff+1nuQOWqQRxA9jQrU5yrWTuitCikKb5aXjZ+r3674mYKomKBZMwaGk6I4 CtgphOPH+OoSLaNXFCvOj7Tu+5EUyaEkOIFBhNTU7N674KPPiKUZyLUbtamYjrY2 R6SFWeCP67BzlJLL6reXnQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41dvu7bn1a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Sep 2024 14:52:11 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 484DlaML018346; Wed, 4 Sep 2024 14:52:10 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2177.outbound.protection.outlook.com [104.47.73.177]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 41bsmg7m8b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Sep 2024 14:52:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ei7ioxFhzdTe534m15Tv7bn6BSO/V2/APFkcHNo7mS5qIF9nrumd9TQer2fQbe7dFui3Ni1CO+LOzjLImmFaTht9ghZmV2GqTXA/gCZ0MwioHHMjVsJLGWoyizmEQpRZcUB2K7ro2j6a84Iaz/udO2nj2JRJYiNbCQgz544ZXzo1xNVq4tnhEkpKCvCMFJANCs5AFdJKNJGTJZGaQRV9dEp5WGROESnnAiHQAIWz/SmiLXwMNRc9kTXclBCVeeI0xtaAWX/xce8KAeN+83Bu8DC7cDQIJ6+g84gniZGKy2s57w9ersyYa9E9X35/zLpwWnhGyP6vdGTchPVj9IRGfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A+p2XqNx5Lfz2uLwMeKJIPsI7UdX/L08mkkC7EPrEfk=; b=uZ5ZbNQytFlF8d9SKOwXJRsQSP6Vs0Q7+WO9qq+2XaUxyLVlunkgVUinuC7D5U1VrMdRm0ZZei9u1F6unorWgx1Sevw7xVqCOmI+FzDCcC8FjZXo2gYDnUUFc8F7tixLlCo7AVI2tr+FI3PbizDmKrlnn9cVxMb9LGMCkIJCx3c0t5IKlLycEQgOOCLirIkRw3G2Kp27X3fT9Nc3eXc20FGHhqKsxNX9T9iN76JvGKrbq9xDGWBhZJIY82dD010gHaUwsXrAr2nbQooRaS9YCNpRZyMlJ3WfhGdZ+5r83UKzhabz3KRlJRqvi3pIQCVnD7BROJaP8no/cUVFXpzozA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A+p2XqNx5Lfz2uLwMeKJIPsI7UdX/L08mkkC7EPrEfk=; b=bWf1oGxSwz3IclyMh+RwSvSmhs8D5I5E0eh+l9CRnlyX+1RJX7C2xmCQb8qUsXTQWslaB6PBjxE1rAS7dtz9dKFeTxeBL95dtG0wRSXT+wN6Vkg5ZFBokL4Tcb86hyicuj8Gj8Tqc1aq0mrx8+Vn6QyLfA0mSUIn3yR7owejJXw= Received: from IA1PR10MB7447.namprd10.prod.outlook.com (2603:10b6:208:44c::10) by DS0PR10MB8102.namprd10.prod.outlook.com (2603:10b6:8:202::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.14; Wed, 4 Sep 2024 14:52:08 +0000 Received: from IA1PR10MB7447.namprd10.prod.outlook.com ([fe80::f2fe:d6c6:70c4:4572]) by IA1PR10MB7447.namprd10.prod.outlook.com ([fe80::f2fe:d6c6:70c4:4572%7]) with mapi id 15.20.7939.010; Wed, 4 Sep 2024 14:52:06 +0000 Message-ID: Date: Wed, 4 Sep 2024 10:52:02 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 2/5] mm/hugetlb: fix memfd_pin_folios free_huge_pages leak To: "Kasireddy, Vivek" , "linux-mm@kvack.org" Cc: Muchun Song , Andrew Morton , Matthew Wilcox , Peter Xu , David Hildenbrand , Jason Gunthorpe References: <1725373521-451395-1-git-send-email-steven.sistare@oracle.com> <1725373521-451395-3-git-send-email-steven.sistare@oracle.com> Content-Language: en-US From: Steven Sistare Organization: Oracle Corporation In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR13CA0015.namprd13.prod.outlook.com (2603:10b6:208:160::28) To IA1PR10MB7447.namprd10.prod.outlook.com (2603:10b6:208:44c::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR10MB7447:EE_|DS0PR10MB8102:EE_ X-MS-Office365-Filtering-Correlation-Id: ae75ce1b-b3b3-4f9e-b80a-08dcccf12552 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VFpKbEtvSFByRm9oak9KbnBKdWYyNlhqYm9tVXRNSFFwdFIreVcwRXVGbms1?= =?utf-8?B?VUZvd0hZZ0k0Zm4rSGJ5YWRXai8zakFaaS9FMEFDeTZMdDBJZXZobmVnbkRh?= =?utf-8?B?OGp3c2RTRHVZZEtndGNDYmpXdE1WTmlmUlFXejZiTWorT1ZVZkNWVkNFMmNE?= =?utf-8?B?ODA3QTBiTnRZaGVRRGFzYmhKWlNDNWZXNnA1QWhTZG1BdnNmNWxNQVlHa2l6?= =?utf-8?B?UHJ3NUg4Z013aVVIOW41M0FUdTFzQXFvcnVJb1U1RGtpUHVwYnhZNU4zUEpv?= =?utf-8?B?U2JCelR5UDFjMGRMYzNqZDBqNk1sLy9Ea2hDWUJCTHE2WDhTTWRrbHU2Um4r?= =?utf-8?B?bkNNUmFrMnNFc09QL0hGVW5tQmtYQXVBdWNibkVxVEM1UW1UTEVNQ1Z3Rm1x?= =?utf-8?B?ZEZKc3JuNFErM0Q3RW42SkxQalJTS0RqRkpkdEtQTDRxZEw0Q3VBTGJyazVs?= =?utf-8?B?RVhjQ1ZOVlVqWFVjQWwxZjFlbXdxNkR1QVFNd1d2eGZJdERWQmM2WnBIOWIr?= =?utf-8?B?SklsZHZ1VjhnV2E3b09ZemtFMjVTZGNqZ2R0WXFZVUdLNTh0aE12Z2pYT00r?= =?utf-8?B?ZmJnOTFmT1MxN0c1NDVLS3ZwTDdpdVdxMnF1cXJ0K2NQUHp0NXo0NmNCSkJh?= =?utf-8?B?TDI5U2RHVHdYbjQyUWtiUDJuNEFUcTY0UW9GOUxLdjlhOVlOZjZqTmlRZHJD?= =?utf-8?B?YmltejNWS1NidGsyZ1JONW1sVDFvd0lqQ2xaVS8wcUhVN1k1OVdhdExJM24r?= =?utf-8?B?M0Nick4rSHArSlAzOSswRmtwVGhWenRCT2lYOXZZTXBTWko1aHpEdjhkc1pO?= =?utf-8?B?Y0tMaE51TVVDN2xlMzEvQ0tSb1dFYzZRcDg2QlhOV0RIa0dqMkhOKzBONEI1?= =?utf-8?B?bnp6UTBGMW5vUExFYjlYOW90Sm94VVB3R0IwSHF3TU1rV1JGTWs4eldrN24y?= =?utf-8?B?a3d4bDNvZUR4YVMyVk5XRU1uQ2pLZGlqeUFzNE13VlpwMjFtKzRwaFVIK2Ny?= =?utf-8?B?TXNWdXhqOGNiM25iUUI2U0FyTGJKZ1hLUlB5cnU0NlViTXIyR1BXSTdGME1x?= =?utf-8?B?LzJNTzRDVHBDOGYzSFZVSEJNSXNOUkF1dDFRNkdrSTFNR0dTZTdXU3lJb1Bp?= =?utf-8?B?NGJVaUYway9LUVlJTFJIT292M3VXNmhobG1BVHFmM2hUWWwwOG1IUlk2WExu?= =?utf-8?B?c1V4azlOZVBxLzRLcFFWeU9RZVlIRUVNcCtXbkIzUUR1RkVzSi82RUpGNkFs?= =?utf-8?B?L1REc0xVbTJVblFkZ2MvR2dBNWVROGp4VUxXQXN3RjFQbmZpaXdDM3dMT1Vo?= =?utf-8?B?U1ZPU3ozK1FyRTlTaGNmc2VuWGxvMTM3Ny9zV04wZm56d1QyWktqTCtCWGF0?= =?utf-8?B?aHRWcGdmRWRoOEF1THJwck8vRVdaNGxhK0oxM2RveGhPSG1qODNHMlBjcjNp?= =?utf-8?B?TXJxamYzd0wwWjJyR0xINmxTekIreFk1aktwa1NPNW9CNEVxSmVnSkxQK1JF?= =?utf-8?B?bkRYRzVDajBYbE9vT0dPQkdweFF1ZGFnRGgrbU56cGZiOG4yTVptZlo0TjR1?= =?utf-8?B?dUhsSjlFT0I5a0NZa1BqMVVUQjJueUx6ckU1bFZOYWQ3bjB0ME5xa2NYNXpH?= =?utf-8?B?eUN6RnhzK1VCUDk0RERXMHFtUU5yeG1McUNQSzNsczIvSlo4bjBhQmZnYzNH?= =?utf-8?B?Q0RKMmNxWVFWTlVJTlRpUk9EbkI2U2ticUxNbXRjUEZwNHZ1WEI1WEY0VnJT?= =?utf-8?B?U0JjRnFzNlJmam9JbVFQMWNEOHlyUnM1THU2RUxUS05hS3JjQXMvVjFiTkRr?= =?utf-8?B?bnhxVjFNUWdsY0xuNjNmZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR10MB7447.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHJjMVJiZFdHdUhqanBaWEJJOUhacnNqd1A1U0dlRWR3dFVXTE43anZ3aVEx?= =?utf-8?B?RGRCYmNCVUhJTTlqZjVoNXl0SDhCaW5GUWV4dXlXYUZYK2xOYTFxYm9xU25B?= =?utf-8?B?SzRmV2ZYT2U1b0Noc3ZKemRzREt0SGlMT3VnMllSRjNxVUdLVkFRY0J1eW43?= =?utf-8?B?ZGRsR0R2ZlFndlpzZzIrWk1MVEhySmZMbEZlaTBUZURkeHdIVUdDc3NGVmRE?= =?utf-8?B?YjhUMndGRk9xajJRTys0aG1nSEhIMDJIUzFkNXFhV1FQd0Y0MW96VnU1NTdq?= =?utf-8?B?K3FxUFRWVlVNQ21GT3VFRDYzc3lML1FkdGdjTm5OSk9yR2JTV2JaZ0hNd0V6?= =?utf-8?B?M3pSL1IrSVRzZmZ1emxqQzBVb0YrUlVJYy9sRDR6eFNxM3RaSFpGS2VTQmw3?= =?utf-8?B?ei8wWUtjbFgxbXJ6dFNxVUxkc25NMFNTWHZEYmVNMlhoSTFVV0xtVUFTUlRn?= =?utf-8?B?MU5rL1YzbkYrZmVmQ0pPNDM5MkVRL3J4TWh1QUZpc3dodFdtK1VRQXRtM05p?= =?utf-8?B?K21TV21zU3BnUkJMcXBJeXVmYklrdlNFY2oyYmY4amJ4RnhpcnZOMzZtd29L?= =?utf-8?B?ZTNyT3JTcGtMb2ZEV0h6cUtsdGovS2RPTEZJcEx2b2tsZ2V6YXVXY0VINTli?= =?utf-8?B?QW0rMVgrYzRGL1VKelc4MnNUOFNaLzBjTFFHMEk3a3FkWFF4aXJVVzNmYWx3?= =?utf-8?B?eGl1M25XeUJ1cWd3NUNjMi9QYnFMc1RROG9KMWFlYVdrbmYwZC9ueHhPdkVo?= =?utf-8?B?SjVRN1YyRE5TMGJ0cCtlbUt4KzRkdDl1d1VpRTFwYk1KbUd4MWZVOFA1bFdX?= =?utf-8?B?NEllaDlTblZabHdHQVdGTmNWZGRjVWN0NS9kcXpIWit4UUdNY09TNFVWTjJi?= =?utf-8?B?d1MzVU1pc0t1V253UHZzNWl2RGoxNGJUaEI0WDZMUTF6dy9CdGlqRTlFMXhk?= =?utf-8?B?TS9FakJ3cFpGYW9od3hFdkx3UjFFVjYxUitDL2xQZmIxamsxSWFkcm9qMFhD?= =?utf-8?B?UU5uQy92ZGNjRVVpTUptQk16TlIxcVBBVkJNWm13dmkrK1NvWUFubENjWENY?= =?utf-8?B?NXFTL3BrM3FGU0RIZzh0aU1rckdqK2tSWnpPbm9Pb2wzbEU5Y1NWMXM0Mlk4?= =?utf-8?B?SXRuelZMMHpBOVVqVzZKc3RsWFh6YzhJSjI4bnNlK3lUTlFlZ2Jsb3Iza1BL?= =?utf-8?B?M2krbXpnMURpL0JnY3hLTi9hbDJxdFRSQjJjVTRqT01pemxxcjY5Q05WU2w4?= =?utf-8?B?bzJadktFa3hqTWVEQkJsaWFEZGk5QVkxZ1htMHByeEw1cDBtcXUrTGl1Zktt?= =?utf-8?B?RURoN2I4SkVVd3N0VFZ6c0lUbjBFK2xnSy9CQ1N5K2pITUt2amVnVHQyUWwz?= =?utf-8?B?N1B4bmttdWVlVVFDcXlmQlh6VEVSTVp0RU8yL2JsZW9zNHFlTzlaY2ZlNXhY?= =?utf-8?B?R3M3Si9wUWJ2QmlYNS9BTmpKLzhPY0xTS3FZNTBhTERpRVhDbGhSbFp5bURi?= =?utf-8?B?c2JIV3lhNXcvMk1EWnQ1UmdmeXRmNEdjYmgweXA3TW9UeFMwUUJGM0ovWnp0?= =?utf-8?B?cm9QMnJ2UGJvcG5EMDNFeTJrekNqdXpCMmRlRENWc1FENS9ZVHhubUtBVDZS?= =?utf-8?B?OUswZXB4Ky81MTQ0U3ExN1dySll4TkZibTlUamlBR0lvK1dwREpIRk9qMmhr?= =?utf-8?B?VzRxREJqOWVvQWNINDVKVk83ZVVzd3hvbzRNeEZjK3pQZStwaUlwYmx4cS9E?= =?utf-8?B?RFMwRXB6L1ZPU2NVZHRNU1I5NTJTK05MZ29EZENMdUpZQXdybGFLY0tVaG53?= =?utf-8?B?NFVKOElaZUdERWdXVE92WTdIU3IyYmN3ekF5amZHSHNjTDZ5bzU5bSs2Z3Rj?= =?utf-8?B?UDJaRXIyMVhOeDFvbVppRHp5emFic0hvOHdsR3VUT1VEYjVOa2pVN1JsdU1T?= =?utf-8?B?eTE3VWNmV3VGbnQ3Wm83blFzY1J2VGs2YUQ3WkVGQllaTUtNYXhMVXhwZERo?= =?utf-8?B?SVIxUXVWWnJXTVA5OHFNQUwxdXhnNkx4STYwdFJJWDh0aU5renJ2TElURWpw?= =?utf-8?B?akRSVGdHTW1SL3BSNml1RTNjRk42UVBDOTVXWUVML3pYdmFJWnVVZ2d1bGFX?= =?utf-8?B?YnNWTHNueGQ3bHI2WWowdlg0S0Q3Y0E3RUxpaURrL0hVQlZYY3cyU2RnT2pR?= =?utf-8?B?SHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1fWX2gKUH2sqb9LuZBjjbJPsRqefTezfGFaWEDE9pXgbmN4h5+vvBYDI2HOU0I2d4qdbXzmcgRBIy5b3M3NoAZE5g+Y+msOtfjG6kuJAvjkisQfFOT0vKNmkQtAXJiYD7EKE9eV3wgyMeDyy3olWcxDLFwmvZu6Brw6KcamMZFjAQ0guzSqKxO0NgEDxdqDtPMWsN0TNNy7QsabYzitYf27cw0Ebyy7vv8GOeDBi2zDlgEq3smoCKpdTCp3KeWVD5Q7pz8mctbxI9Nebpy2cUR4c7rT09JDAtENzP8o7dDABwpEdyLuXbYAWW0GLqDvtNe3LMYP5CKFW7F4hF64OGu2Lxo+9Ny6HUM06w+9WiOu2PaCvKBy0UQjQk3QkrH4bq5UswIzS/7BwSBjuVYKFp2pKugnr/HPeTBbXnzEwhhvdrkDSYPVn5Y/014nKeEPFAD4Ji86tpHJBxCDTfb3Y0GfWecoZ8srybmp3hGGCtywuDTy/raYmDnCwgJresGTfFsCt22h9CJ8aRm9uoN2+ONH6/mxj1J7i+YNzz5TwCu/m7mP9lVsvw9yjfyseGElbbG1VYYiK7Fz2ATALvJQbZm75EfIXc3wLaRdGkeyg/PM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae75ce1b-b3b3-4f9e-b80a-08dcccf12552 X-MS-Exchange-CrossTenant-AuthSource: IA1PR10MB7447.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2024 14:52:06.6243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +5OEJh4dowvJRjac/H7Bf37bpAQbDpC1VUxMQGHAZECpDV1f3OQa2J8HSiwi3KL8T9rLY/YZbwG1Q5FuP+1cFPSdyyIF1lD28BP/33YJyEc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB8102 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-04_12,2024-09-04_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2409040112 X-Proofpoint-ORIG-GUID: l294Eah2Hf23jdzJMuSi1qz17ivHDsT2 X-Proofpoint-GUID: l294Eah2Hf23jdzJMuSi1qz17ivHDsT2 X-Rspam-User: X-Stat-Signature: b7xx8wd76duu5cqw8agfjgmpmzoh418p X-Rspamd-Queue-Id: DC54120005 X-Rspamd-Server: rspam11 X-HE-Tag: 1725461535-184466 X-HE-Meta: U2FsdGVkX1/tiN/uLGGcfHVcUaWrI0d4g6Jxfyd+nUhQDLE4RUHT0qdMnDZA+SxNJC8SyBLBjrIGM/F74zjtJj2KGKVzy7JBNi7NFNVOQszz7HjI2gBDk0XNCEFCTAk9tRKf4S3eoBEkKfrCaBA1ic0ZASZvtoPZfjl9yr3T457+wUIS7atpclRi7mo1fN5c4/VpUa5l3NksIhfF9dnZHD4WS+V1Xi3021DG6JurDwz37+N/3P+OoNi0Lwz8E975u+xL4vP6SepovmDMbLConq9ybmBwkuyJ0b2dfj0YC0WVsFOW4Loq5THxDaJk35bimMdQqJ9l0oOu3SEV8Vmj29aeg2pl2GK6bgAfuhEj5k82Ywa2AEpt2TaS3yycKA1Tv0NHA2teUUlbzzwCK3NsSShjFhCuFc0CYpHM2zoOh1DRDxk2dXmlVjrt6PTGqd5bA7ijzp88WOIOw/seDscU5NfaU5mS17HGG17m+jTxHlzwXUj5GBZRKiHqHX7vxviOoOmmGfdUVyo2ud98t1DT5/1AD6JjwoqyJOed0MT9ugqkqqQ3khBz1dvwVMgL6/Y7eB2VStRaGnMUl4mX0SMkTAlpYDgSAt/iuxNhR5otfEDH3qZBDJRJMN1XpB7nyDbjt35giDkn5G3SoroXQceQYasGgkzc/JvAUGE8Afm7CZ6KDIT8JzuuCor5mZ+reGvTcUAEy2uKReUXtgdkL1ZpX+eVJFTOxtWnJ4HGjbMcTyCif0RdsNZ7gSr9N53+XEL9YrTt+6nwVUovbwDhLp/LS7c/20AmE8oXrtrHt5izeEdsHJLfaBCOdZ9A26Vumr6BoAb/nK9vOLBral9v2CCF3Ua+zl1InGUiS0B3LNiY/cX4/jz5hJbGYs+xNIc/jv9whOD892tAEPB8aoJf8XnG1nHJ3lt2GGZJd1iPhvEkBhzRfMqqkvjhdKi7xU+hEnUAea2uDVNOz954b3DtCuN 4I/vzpKZ lROXLuPRJXJ7z4fzOlNUZFxuhwyuwaAgj5DRD5QTMdcTLu9AKrt6qWRJPT3h54ZWXbtGsb+0vZIJSbiXfOwNcNzrXyMCItPYCIA3bTP8IyFaqPkusRKxvX96fk/JiGFIqG1Cnb18xQnb3P3PWrvuUmpLpiuqtkJe4ewg6iFMR60O3GHdyA01ZXuT/kud/uHWFczisrZ/QBHqZtZa5oJYhxOqVDQQY9OgP9VXpTYr1JT9X3efiD/jHoUaN5+krCBW6pxRB4wegxGG4hT6BLXX7nYbVHc8jG0nGS4xmntBmFjJgbN4yNOD+4BxxN1Y5NcGtpEl3MdlbKOqwkf+u+huYF5WGf+dk8SvdS2jfZw0OWPdrGGmpUea+vIoPeGPishRQ0RxOcJ6f/oXM7z9OTSUomezbZEGY8kIe50MGUj5iXr7KfLY6KBAeZsWgDDOCMLEnz4zB2efaqYHZCRsPa8ELMIj2jeY9hJ1tVXNG1zAFIka1ixR+m2PtRKXRv1DnJVjtN3gG963mv0W57qfOOt4fJNeUOALYLQ/OnUxZSSJ3DA+5GmmFIKEBrJEqakLZLM9txvEHYgpPLcsrXk509i+jOmZQU7ZmZDKfBpnMNNCOS+7f/vpMvIkP9H0LZ6V+W7cJtr09hj+4DHxGGvdoWwHJ+6f5DSIbiwc8hq34bcGOlUbpPovvXXptDI70Y56UMTdi8iSF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/3/2024 8:45 PM, Kasireddy, Vivek wrote: > Hi Steve, > >> Subject: [PATCH V1 2/5] mm/hugetlb: fix memfd_pin_folios free_huge_pages >> leak >> >> memfd_pin_folios followed by unpin_folios fails to restore >> free_huge_pages if the pages were not already faulted in, because the >> folio refcount for pages created by memfd_alloc_folio never goes to 0. >> memfd_pin_folios needs another folio_put to undo the folio_try_get >> below: >> >> memfd_alloc_folio() >> alloc_hugetlb_folio_nodemask() >> dequeue_hugetlb_folio_nodemask() >> dequeue_hugetlb_folio_node_exact() >> folio_ref_unfreeze(folio, 1); ; adds 1 refcount >> folio_try_get() ; adds 1 refcount > I wonder if it is more optimal to skip the folio_try_get() above. > I think it (folio_try_get) was probably added because I didn't realize that > alloc_hugetlb_folio_nodemask() already adds a reference. Agreed, that is a simpler fix. I tried it and my tests pass. >> hugetlb_add_to_page_cache() ; adds 512 refcount (on x86) >> >> With the fix, after memfd_pin_folios + unpin_folios, the refcount for >> the (unfaulted) page is 512, which is correct, as the refcount for a >> faulted unpinned page is 513. >> >> Fixes: 89c1905d9c14 ("mm/gup: introduce memfd_pin_folios() for pinning >> memfd folios") >> >> Signed-off-by: Steve Sistare >> --- >> mm/gup.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/mm/gup.c b/mm/gup.c >> index 54d0dc3..5b92f1d 100644 >> --- a/mm/gup.c >> +++ b/mm/gup.c >> @@ -3618,7 +3618,7 @@ long memfd_pin_folios(struct file *memfd, loff_t >> start, loff_t end, >> pgoff_t start_idx, end_idx, next_idx; >> struct folio *folio = NULL; >> struct folio_batch fbatch; >> - struct hstate *h; >> + struct hstate *h = NULL; >> long ret = -EINVAL; >> >> if (start < 0 || start > end || !max_folios) >> @@ -3662,6 +3662,8 @@ long memfd_pin_folios(struct file *memfd, loff_t >> start, loff_t end, >> &fbatch); >> if (folio) { >> folio_put(folio); >> + if (h) >> + folio_put(folio); > If we stick with this change, I guess there needs to be an additional > folio_put() in memfd_alloc_folio() as well if adding the folio to the > page cache fails. Indeed, another reason why just deleting the folio_try_get is better. Thanks! I will submit a V2 of this patch. - Steve