From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83196C4345F for ; Mon, 15 Apr 2024 16:29:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12E566B007B; Mon, 15 Apr 2024 12:29:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DEE26B0083; Mon, 15 Apr 2024 12:29:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0F1B6B0082; Mon, 15 Apr 2024 12:29:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CDB4C6B0087 for ; Mon, 15 Apr 2024 12:29:09 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 634D612052B for ; Mon, 15 Apr 2024 16:29:09 +0000 (UTC) X-FDA: 82012300818.01.6FDE4EB Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf25.hostedemail.com (Postfix) with ESMTP id BB8CFA000C for ; Mon, 15 Apr 2024 16:29:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf25.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713198546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hXolhQhA9Dv9AM1bqXBIJ040TwuJtDk5WqadQIUQH/E=; b=TfrS+DcG335B3PqK/yh+tEsF69A+6M4RQj+LFmFlIcW55euqDII9VN/1JW+ffTJDPxjLIs 7DG7UhV8qs10jEMayk7GbYZq+wnpWw3+JBAdKMOoumt0A/iZWZNaE8s12Uf7XGLusfj4St g01xCUtumPhaUbogAM4HVl+fGhIsy6s= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf25.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713198546; a=rsa-sha256; cv=none; b=TlExsJijz7cORAyMofFodr6k0Xy0zzjtuTqVPmXwKT/LqQbLTPOVd9zZw3lf6GiKpqIXkw bVVCCJ0603UnAgiB1qfijDDzQSn0jlGxSlMrrjaQaYYbpmskAPpivs0pPevzzHPptRbhhv +hTqaQ90YZ3QCuZhQ+QWcaS1DVoSvTo= Received: by gentwo.org (Postfix, from userid 1003) id EA2D140AB5; Mon, 15 Apr 2024 09:20:29 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id E97B04037C; Mon, 15 Apr 2024 09:20:29 -0700 (PDT) Date: Mon, 15 Apr 2024 09:20:29 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: Jianfeng Wang cc: Vlastimil Babka , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "akpm@linux-foundation.org" , Junxiao Bi Subject: Re: [PATCH] slub: limit number of slabs to scan in count_partial() In-Reply-To: <5552D041-8549-4E76-B3EC-03C76C117077@oracle.com> Message-ID: References: <20240411164023.99368-1-jianfeng.w.wang@oracle.com> <38ef26aa-169b-48ad-81ad-8378e7a38f25@suse.cz> <1207c5d7-8bb7-4574-b811-0cd5f7eaf33d@suse.cz> <5552D041-8549-4E76-B3EC-03C76C117077@oracle.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-810623552-1713198029=:146654" X-Rspam-User: X-Stat-Signature: qhakw5gc4eucg4o95uhd5wswa7315j15 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BB8CFA000C X-HE-Tag: 1713198546-187995 X-HE-Meta: U2FsdGVkX1+ANLPubZHrOZwpMrsWzPVwOGbjn85qsCcsak7d9UOw+1xt0xfWSUZDG8YEsjYMvq0Cdw1s8PQu0C34cSblP2tA9fgeG8k+6+xZWovjnpZd51vNv2zma8NOSPitES7BUWlh5wmeeXUCNKqe2BCfODMTt9osjb+OiCtrqBXTZoFgyPKHnc98w7PaSbjPEJ0vntW+sdl6imO0zNBtz6HA8YkqYwmkjenvyHrCKb+EEIGUiCkpsC9tzk4YPpWN/CxW0fNNWorTUxlAQ3JCsVizlqUkbVk++7jbZSITe3OLiHNyjSXpAVYMKm5I4d9G92+8RtbvQKDwayydGQSS2ifQ/CEtDcBFhQElmfsXUlCs8Zhl2m7EhnhrQaLdqJcdXyYjY+ZIqhQxQi0t6LPhEVaPTnnvkflKsWwuNDrNpv2WoJA1L16J1PuJPsaJgEhpSuyAbW1aJy++7C9aII+ZckyKUoeEGxGFhAx/Ta5q8IYklcE68RvbCGkC3R32QkkCnqRq1JppDXormZ2TNXB4eOCHrVjwyjQTtZAewwVMiN/y4/Ekr704OLDxyb+lxnZw3JhOrgTrp80Q/tQs+pnEyBGLIYY47ZKhryLOhzQo+uEznmAkgLRulY57AUwyix0fTo10s6Hj4qg/iFErQdw6JhZY7CqruMSOkju6MhBFFUeJj+2wMcjpe/auxLJ4l0PUBohn9+Ee+PF9s2Q5el9+GywY+eEdRbNrtRMfkyEVNklEhDFkZ0SQZjInSH1iagmQOkmn6vQysUQdwNROBRs5fEVEqP/1SXx5ucvO6a6PW0lX+76ERfA1CFqrWs2+FLqdld+XePq+TiED2w+WZ5lM5JagCajBqloE9ggT7kutjHiGheU4Trnpx8HPpAqHxlV7FYGPkTtRDeVruG65mIaZ2ke3NtT0W6Z3CTv5ms+2nFa0EUZsE2xrJ6ARA38v5jau1dSYccHPtE/Cvmr pA5G8v+P DL2hoU3cCQp/EFv6gdxnzNPgnemcDYHvey/LlRWrtj7g7DrkG531UrFJROrTfjpE6S0pHuaG7gqvTiCLOtjuQA7wuLF2trP/J4tlCvJIpOaUI/GpK6gU28RyWINdZhuWn++E7IJHKu7MKPDaa/fxsyeWMegKxCFiVDzqh8Oqve2JSKByDf3WtjRfRzZWSwZD5PrNUUfB0I6l0tJW4EGaK+OJoHB6kwFuFgBEayp7Q3R676KJGAfbwd4dm01IjsxXxR8llR7S/f7HCnoBqJtM/gljFAGZErfoNEDkQ9es8TJHaNsHl4vq3gfFxZF+g+WgbXNRt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-810623552-1713198029=:146654 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Sat, 13 Apr 2024, Jianfeng Wang wrote: >>>>>> kmem_cache_shrink() will explicitly sort the partial lists to put the >>>>>> partial pages in that order. >>>>>> > > Realized that I’d do "echo 1 > /sys/kernel/slab/dentry/shrink” to sort the list explicitly. > After that, the numbers become: > N = 10000 -> diff = 7.1 % > N = 20000 -> diff = 5.7 % > N = 25000 -> diff = 5.4 % > So, expecting ~5-7% difference after shrinking. That still looks ok to me. --8323329-810623552-1713198029=:146654--