From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Lance Yang <lance.yang@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Vlastimil Babka <vbabka@suse.cz>,
Jann Horn <jannh@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Lance Yang <ioworker0@gmail.com>, SeongJae Park <sj@kernel.org>,
Suren Baghdasaryan <surenb@google.com>, Zi Yan <ziy@nvidia.com>
Subject: Re: [PATCH 1/5] mm/madvise: remove the visitor pattern and thread anon_vma state
Date: Fri, 20 Jun 2025 06:10:34 +0100 [thread overview]
Message-ID: <bb1bb862-7b48-4a90-9d96-9ad3da36b995@lucifer.local> (raw)
In-Reply-To: <4729217e-9bf5-48c8-9f93-fd33b66c5bcd@linux.dev>
On Fri, Jun 20, 2025 at 10:43:30AM +0800, Lance Yang wrote:
> Would this be clearer and more closely describe the code's logic?
>
> /* Reject naming for regular file-backed mappings. */
Yeah here's the fun of 'anonymous' being super unclear :) it's like the 'no
true Scotsman' fallacy in mm form... ;)
'Anonymous, no really really anonymous, not even file-backed' :P
it's a good point but I'd rather keep this as close to the original as
possible so it's just a code _move_. Perhaps we can update later but I
think the context makes clear what is meant here at least.
>
>
> > > + /* Only anonymous mappings can be named */
> > > + if (vma->vm_file && !vma_is_anon_shmem(vma))
> > > + return -EBADF;
> > > + break;
> > > }
>
>
> Thanks,
> Lance
>
next prev parent reply other threads:[~2025-06-20 5:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 20:26 [PATCH 0/5] madvise cleanup Lorenzo Stoakes
2025-06-19 20:26 ` [PATCH 1/5] mm/madvise: remove the visitor pattern and thread anon_vma state Lorenzo Stoakes
2025-06-20 1:32 ` Zi Yan
2025-06-20 2:43 ` Lance Yang
2025-06-20 5:10 ` Lorenzo Stoakes [this message]
2025-06-20 5:08 ` Lorenzo Stoakes
2025-06-20 13:05 ` Vlastimil Babka
2025-06-20 13:17 ` Lorenzo Stoakes
2025-06-19 20:26 ` [PATCH 2/5] mm/madvise: thread mm_struct through madvise_behavior Lorenzo Stoakes
2025-06-20 1:40 ` Zi Yan
2025-06-20 5:12 ` Lorenzo Stoakes
2025-06-20 13:19 ` Vlastimil Babka
2025-06-19 20:26 ` [PATCH 3/5] mm/madvise: thread VMA range state " Lorenzo Stoakes
2025-06-20 1:54 ` Zi Yan
2025-06-20 2:13 ` Zi Yan
2025-06-20 5:21 ` Lorenzo Stoakes
2025-06-20 5:17 ` Lorenzo Stoakes
2025-06-20 13:49 ` Vlastimil Babka
2025-06-20 13:51 ` Lorenzo Stoakes
2025-06-20 14:16 ` Lorenzo Stoakes
2025-06-19 20:26 ` [PATCH 4/5] mm/madvise: thread all madvise state through madv_behavior Lorenzo Stoakes
2025-06-20 2:20 ` Zi Yan
2025-06-20 5:21 ` Lorenzo Stoakes
2025-06-20 14:16 ` Vlastimil Babka
2025-06-20 14:17 ` Lorenzo Stoakes
2025-06-20 14:32 ` Vlastimil Babka
2025-06-20 14:58 ` Lorenzo Stoakes
2025-06-19 20:26 ` [PATCH 5/5] mm/madvise: eliminate very confusing manipulation of prev VMA Lorenzo Stoakes
2025-06-20 15:02 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb1bb862-7b48-4a90-9d96-9ad3da36b995@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=ioworker0@gmail.com \
--cc=jannh@google.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=sj@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox