From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C430CC4167B for ; Fri, 1 Dec 2023 00:13:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17E718D005C; Thu, 30 Nov 2023 19:13:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 12E4D8D0001; Thu, 30 Nov 2023 19:13:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE9B28D005C; Thu, 30 Nov 2023 19:13:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DF5678D0001 for ; Thu, 30 Nov 2023 19:13:44 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 96F1AC01BA for ; Fri, 1 Dec 2023 00:13:44 +0000 (UTC) X-FDA: 81516325968.18.23D66BF Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by imf29.hostedemail.com (Postfix) with ESMTP id 52A2512001E for ; Fri, 1 Dec 2023 00:13:42 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=flygoat.com header.s=fm2 header.b=p4TuFmo2; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=AseeZUAs; dmarc=pass (policy=none) header.from=flygoat.com; spf=pass (imf29.hostedemail.com: domain of jiaxun.yang@flygoat.com designates 66.111.4.29 as permitted sender) smtp.mailfrom=jiaxun.yang@flygoat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701389622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6hNLsCFhInh22vC2aH0mgObvwR0nMUCdEXPsUGEMxfE=; b=rSVoONmgsD4f3IK/XNB01Ma/Fd25Qr+/gwX3bJN7m6GqzXdamqs/isvl4TjfuGVqdcp3n+ wzvf8pkwK2ZOx8HcXMNdlVSRW+dA8Tr3JZtOjMnyt+Y99m/7v306rGnDz9rvz3m5c/UJgs yTN/efF3HOuGcI/2FtZG8gWvmsXt2sc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=flygoat.com header.s=fm2 header.b=p4TuFmo2; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=AseeZUAs; dmarc=pass (policy=none) header.from=flygoat.com; spf=pass (imf29.hostedemail.com: domain of jiaxun.yang@flygoat.com designates 66.111.4.29 as permitted sender) smtp.mailfrom=jiaxun.yang@flygoat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701389622; a=rsa-sha256; cv=none; b=cWVuwD7aiqX+9IimBeAQHqqbyVKGLO/So6FNto6OueYqhzo8uuvMu1sryjgjKHwwkCs8Gr 5BY7C6paIzs5QFQuq9ZhEB/0Hfb5iG0Jjfo6fo/RaEA2/YlT6iiIwBlkt5+uboZ9x2Pd+n KhSzdi+S4em3kkmYEMjrmYoJ0s6zLlo= Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7DA245C0114; Thu, 30 Nov 2023 19:13:41 -0500 (EST) Received: from imap44 ([10.202.2.94]) by compute3.internal (MEProxy); Thu, 30 Nov 2023 19:13:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1701389621; x=1701476021; bh=6hNLsCFhInh22vC2aH0mgObvwR0nMUCdEXP sUGEMxfE=; b=p4TuFmo2BFWKo6nUyzd0VhruEGR7APHOVeHa7t90HtYDDkV2GOs WbwD4W+8XGQHFzA6R46rClyZ9uhsApeYU9Bq3qCK8SOAbEH0ByqRIqlcdjEyI9+4 LxyiFamBQFNzRhGxUmy0PggFnSiP6eH0bMoFtnjor0Jxw2KO97FXc0npahB0MDqx wVtXRagjRm3scqpbc//fDJ8vLhjMOfDqJZMpZvh8Osj9a5xJoo4qedI3SECKEzqX yA8wjoIYfNuFwD89mweOxyuhcxV/gxq5W004xEYCe92NUWczdo0+u8adnH67fqgD JuPP/kpRa3we6p4x8IrsfM+zUIO/TXvFjrA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701389621; x=1701476021; bh=6hNLsCFhInh22vC2aH0mgObvwR0nMUCdEXP sUGEMxfE=; b=AseeZUAspHBmVT0quRu/fmAKonz1GQGNxx9/2hHz/DOFvlD86Tc WSxoaTL/yKw9O64tFfm+I9zOS/vN8FdAwKrKUw4CNwDfJdoBZWldSBgz96c2nGIN vY2YNoLDLYX7w7mlimXfIwhfCCcYIyc/MutJhgQLmFnoPvq2vu6oJ6dKfYFE+SKX ONJVmDmyPtN+tF8DkvxuvUlN1+2G2Fk1UigU4ZYt/r/1kXau4YGaldnbxInqe2sA 31hYutAGc2pxbjhnU1B+qqeUd5UqVwQRv7TtXOj+4rjdH3iyCbdGSzlwgNZMRzis NYnIUgGwy+ZPjKej0V4+3mmgnqVNtNU3NKA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeikedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdfl ihgrgihunhcujggrnhhgfdcuoehjihgrgihunhdrhigrnhhgsehflhihghhorghtrdgtoh hmqeenucggtffrrghtthgvrhhnpedufeegfeetudeghefftdehfefgveffleefgfehhfej ueegveethfduuddvieehgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehjihgrgihunhdrhigrnhhgsehflhihghhorghtrdgtohhm X-ME-Proxy: Feedback-ID: ifd894703:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id DD1A836A0075; Thu, 30 Nov 2023 19:13:39 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1238-g6cccb1fa34-fm-20231128.002-g6cccb1fa MIME-Version: 1.0 Message-Id: In-Reply-To: References: <245d3985-9085-4be0-8c74-d95d06334584@app.fastmail.com> <3iksuovvsln3cw3xpmjd7f7xixfvwaneu4ok56fnookvyolpco@wrxxew3thgnq> <3pgnihbrp5orh4tmj45fipbfoxdwzjh6uefitdpcea2vgkarcm@d56gv3areswl> <2148a67f-bd4f-432e-aa0d-c914a4bd5e0d@app.fastmail.com> Date: Fri, 01 Dec 2023 00:13:22 +0000 From: "Jiaxun Yang" To: "Serge Semin" Cc: "Thomas Bogendoerfer" , "Arnd Bergmann" , "Andrew Morton" , "Mike Rapoport" , "Matthew Wilcox" , "Tiezhu Yang" , "Huacai Chen" , "Yinglu Yang" , "Alexey Malahov" , "Aleksandar Rikalo" , "Aleksandar Rikalo" , "Dragan Mladjenovic" , "Chao-ying Fu" , "Marc Zyngier" , "linux-mips@vger.kernel.org" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] mips: dmi: Fix early remap on MIPS32 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 52A2512001E X-Stat-Signature: zxxyc3umdcwmbeepi8nuq931jr49bpi7 X-Rspam-User: X-HE-Tag: 1701389622-244901 X-HE-Meta: U2FsdGVkX18acI0reu4P5jPiyv9IwyOfTLJIN/Jt7Picm6uLnkE9g4YyG2rNg5Ow+UTg2TOCsVwQAlfLB04t02+mlgf3K6rpstlpabdbFosHxgwVhCoxX6UyfbXAkFi2IgLr1VVuv2YSa+8IUoeOiyS3XI5gaHczqTKHdt+/wFWCv5vKBKtkDgG9HjmATRva8bFTYbV8RkVNdZ7cWRDc9uEcgdPlkMogiaR6l3MNOFwJ6KxIiyTeb5jdn6Yrd2tNy1PSWIYlUISqm56sV4buY4BKQUHHfUMao7ibEL4EvcNSYgjTXH/qBHSeceulGOlYRLKPCDrl20D5Q5qJl4p6smUgbncRfaFoOWuAUuF9q/MgrQn+9KJ3dIQHsxf22mub4+X7PNgaQ3U1O5hKDaMJBxuZcpnccgGTN6C9lRKaqxm52ac1x8/6KfNZs6Lz4oWSubGYUa5GiQ785rJhKKHP82lkHAqQXBUFZserF7vQa3CQzkz262kloMEgsyL2pP3w1bRMrgwcuNFApDq3hhmh7qkG+8zJTiozMaLtmrMZ8TCIwnH0BDgbgnuYBH3UOOsFRYSyj9Vu7x4kI2bAWXGxnXqiORaoijL4tvI05jCXXsi0WAS4FGOSKy5y3Wgle+a+zurx6qmZpxq/N5+6dHlqjxKjukuqdx3b4DGo4VuSk1U8Aia9ZbXRX7VNymY4PqZJ6n7giz8HXYO8P4EsRu4haeat//3Sdex8Zh4iJiuoS8TVbmLB0CKJ9Sh6SZxW+Up3VlwAS5xGIiyTNcoOKvn+oyhb8DjjvK3aIxLTptPhqAQMD0sjXxOkh6ekHrDMqwAIFDUAJzw/Ahj0r1yItC22lhRSk9bf1BRs58ps9YKbcUQElp3kqE36ID4cWFqflkieMvIy1k7+7J1IFcZhe9DOcQgxVdf3RMgfr1foATCxIheA0qu6tiIDsmOISJG1y6fsr4CJeu5h0JObTJwxawh CaROXoLU kZyUe+7LF9alPzfpgdy8xz1eMA1VqgV7/xzw+jCGL9pbkd14u3sYyPsc2YSbtVr84IxCsJtnl1tR5+9wuzya+0VWOJsQA0cWoFjLB6yU/rlTqmOUgb41Ri4NbsZeP9vO7UEURLJ3vogSUp1aap4Pf5SS7hiKz4VjM+LRZdvjOxEFH9iQ+DuOzXYzSFUCZmSlodM5vlJM02F2P/lXOvqQgAmjN2b0RtVO43L94Dmq+rs/jVPGtVBQrjBZ6s9K+2Gxm+2y0HPVmKqkSiXDYu+nZMTArFK2x043fuNEEAVwDGcjg9UgSBM690SwCIPzISNl4uS88NTDcV+QqxavcxhZ/iuD1MQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: =E5=9C=A82023=E5=B9=B411=E6=9C=8830=E6=97=A5=E5=8D=81=E4=B8=80=E6=9C=88 = =E4=B8=8B=E5=8D=887:16=EF=BC=8CSerge Semin=E5=86=99=E9=81=93=EF=BC=9A > On Tue, Nov 28, 2023 at 03:46:37PM +0000, Jiaxun Yang wrote: [...] > >> I'd say the safest option is to use CKSEG0 or TO_CAC here,=20 > > I would have agreed with you if MIPS didn't have that special > _page_cachable_default variable which is undefined for some platforms > and which might be re-defined during the boot-up process, and if > MIPS64 didn't have ioremap_prot() always mapping to the uncached > region. But IMO updating ioremap_prot() currently seems more risky > than just converting dmi_early_remap() to the uncached version > especially seeing it won't change anything. MIPS64 always have IO > remapped to the uncached region. MIPS32 won't be able to have cached > mapping until VM is available, and paging and slabs are initialized. > So on the early MIPS32 bootup stages ioremap_cache() wouldn't have > worked anyway. I really didn't get that, using CKSEG0 on 32bit system and TO_CAC on 64bit system won't hurt. Something like: #ifdef CONFIG_64BIT #define dmi_remap(x, l) (void *)TO_CAC(x) #else #define dmi_remap(x, l) (void *)CKSEG0(x) #endif Can help us avoid all the hassle. Since it always ensures we are using same CCA to access DMI tables. We can always trust Config.K0 left by firmware in this case. You may add some sanity check on 32 bit to avoid generating invalid pointer. (And perhaps implement it as ioremap_early.....)=20 Thanks --=20 - Jiaxun