From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A23D4C433EF for ; Sat, 11 Jun 2022 18:29:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B764C8D011A; Sat, 11 Jun 2022 14:29:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B25C58D0115; Sat, 11 Jun 2022 14:29:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EEC98D011A; Sat, 11 Jun 2022 14:29:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8F2F68D0115 for ; Sat, 11 Jun 2022 14:29:56 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5F0DB205A5 for ; Sat, 11 Jun 2022 18:29:56 +0000 (UTC) X-FDA: 79566793992.19.0AC35BB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id B87AE40003 for ; Sat, 11 Jun 2022 18:29:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654972195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pcxlPosDuNYZLF+xkyfBuM18/wNn6c4mtAX4pgyPBoM=; b=YxmAEEpu9ZRdBlJiVTD9cmort7UdwOiWGMDriub+v/GrkWT4lSQz25AspXnQVhO34yo56x WKCaRSkw4SaDMP0j1qtXFaY3d+og0fS6xSXIk7wwQcECO7V/NMMMYiq6rF0l1WjrD4HC/p 5HOhteztdeQ7YLHCouBkUmHq3gFUarg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-278-JwHjWOSWOlicGghxjnitNw-1; Sat, 11 Jun 2022 14:29:51 -0400 X-MC-Unique: JwHjWOSWOlicGghxjnitNw-1 Received: by mail-wr1-f72.google.com with SMTP id w8-20020adfde88000000b00213b7fa3a37so180180wrl.2 for ; Sat, 11 Jun 2022 11:29:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=pcxlPosDuNYZLF+xkyfBuM18/wNn6c4mtAX4pgyPBoM=; b=qTSzfPxmGiXoiOwB7WepVPQRSKeJOYhTMOHYHdprAxFqqSWeSVyEw2yPa7S7Kyjm8y UR+fZOI91p2EmOLRn8sByI/T2rMoi9wNJzcnjdoGY2SA+3ZuP83BcuJY3U9Nfs3DBkES xb/F9BPi2+t4nrY0Vy3UoGwHDgWikwwSswhg75MOk0ijqsAJq2EEciKsr+TXWSsvfdHJ ZWLoiR/BWK1KFdvHiDbe72+zqqckA+YISuMNuGKgPwtOPdFFk/NRVwvaVBNPZshyxzD7 mv/R23rpmj+DC/i3vZTWuEgyxd46lBgm99oupgmCLJX2oHSXLR/d76tuWlpYAPbM8WBs m1RA== X-Gm-Message-State: AOAM530c/YPZrFbjhmtmelr3u0i0/SF7UT+X8K9blY3NDISqc2CZQgxR ezDyviGpf51yDANVTGetXsfbu2NVoXOabLdzrJX/GJkxwqnC6a1iAjEKp39fUMxPT+pZyZWtkJz EvwRCWZjOH5A= X-Received: by 2002:a05:600c:3790:b0:39c:7dc2:aea0 with SMTP id o16-20020a05600c379000b0039c7dc2aea0mr6010388wmr.112.1654972190627; Sat, 11 Jun 2022 11:29:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrYrnw+ck5JXVgLSNaYccrM3xEoJFNJyTxJ1A7dw5yPRd/CG4ZB1PEvF7LgsNSXQjVrBQLWQ== X-Received: by 2002:a05:600c:3790:b0:39c:7dc2:aea0 with SMTP id o16-20020a05600c379000b0039c7dc2aea0mr6010368wmr.112.1654972190341; Sat, 11 Jun 2022 11:29:50 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:c400:dc43:2462:b7e5:dd7e? (p200300cbc719c400dc432462b7e5dd7e.dip0.t-ipconnect.de. [2003:cb:c719:c400:dc43:2462:b7e5:dd7e]) by smtp.gmail.com with ESMTPSA id p24-20020a05600c1d9800b0039c8a22554bsm728282wms.27.2022.06.11.11.29.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jun 2022 11:29:49 -0700 (PDT) Message-ID: Date: Sat, 11 Jun 2022 20:29:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 To: Alex Williamson , akpm@linux-foundation.org, minchan@kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, paulmck@kernel.org, jhubbard@nvidia.com, joaodias@google.com, jgg@ziepe.ca References: <165490039431.944052.12458624139225785964.stgit@omen> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH] mm: Re-allow pinning of zero pfns In-Reply-To: <165490039431.944052.12458624139225785964.stgit@omen> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654972196; a=rsa-sha256; cv=none; b=cnrsVDwoNqYC7HNzsmOec61sJEvhkejercCIdjM/tH71HVnjSgC5kkYX6Kw/IUvs7TeoSo Ncjz1tkSSKg3pP2pKd3U40bwX4GUke+GVKWG8AmPNv1A+MIdmg+RivypdeBc98exF+VnxT +8/Mxt7dtBlqmj0rhWWfvpdbAcdrB4c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654972196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pcxlPosDuNYZLF+xkyfBuM18/wNn6c4mtAX4pgyPBoM=; b=r/opFFHJc4oJibcsYJ51WVl/rgZZ6tzFOpXVJ4F4nWXXivRVu6BwMvRL6OjK2gLHR6eOFT IcVEsHqf/fviaNsUXeFVrJd+wacZ33++HlBYvH0SNFFkI5/DbrxuIN4lF8/R4yVrZP32oX anIGBjmWkrZKnGXIuib5voZHmd5C55o= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YxmAEEpu; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf01.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YxmAEEpu; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf01.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: gtwi77ppnhttebrqs8kfzj3z1j84ugjn X-Rspamd-Queue-Id: B87AE40003 X-Rspamd-Server: rspam12 X-Rspam-User: X-HE-Tag: 1654972195-568808 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.06.22 00:35, Alex Williamson wrote: > The commit referenced below subtly and inadvertently changed the logic > to disallow pinning of zero pfns. This breaks device assignment with > vfio and potentially various other users of gup. Exclude the zero page > test from the negation. I wonder which setups can reliably work with a long-term pin on a shared zeropage. In a MAP_PRIVATE mapping, any write access via the page tables will end up replacing the shared zeropage with an anonymous page. Something similar should apply in MAP_SHARED mappings, when lazily allocating disk blocks. In the future, we might trigger unsharing when taking a R/O pin for the shared zeropage, just like we do as of now upstream for shared anonymous pages (!PageAnonExclusive). And something similar could then be done when finding a !anon page in a MAP_SHARED mapping. > > Fixes: 1c563432588d ("mm: fix is_pinnable_page against a cma page") Having that said, it indeed looks like that was an unintended change. Acked-by: David Hildenbrand > Signed-off-by: Alex Williamson > --- > > At least I assume this was inadvertent... If there's a better fix, > please run with it as I'm out of the office the 1st half of next > week and would like to see this fixed ASAP. Thanks! > > include/linux/mm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index bc8f326be0ce..781fae17177d 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1600,7 +1600,7 @@ static inline bool is_pinnable_page(struct page *page) > if (mt == MIGRATE_CMA || mt == MIGRATE_ISOLATE) > return false; > #endif > - return !(is_zone_movable_page(page) || is_zero_pfn(page_to_pfn(page))); > + return !is_zone_movable_page(page) || is_zero_pfn(page_to_pfn(page)); > } > #else > static inline bool is_pinnable_page(struct page *page) > > -- Thanks, David / dhildenb