From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45582CDB465 for ; Mon, 16 Oct 2023 16:11:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE5958D00B1; Mon, 16 Oct 2023 12:10:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A939B8D0001; Mon, 16 Oct 2023 12:10:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 934E28D00B1; Mon, 16 Oct 2023 12:10:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 840D68D0001 for ; Mon, 16 Oct 2023 12:10:59 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 567AF409FC for ; Mon, 16 Oct 2023 16:10:59 +0000 (UTC) X-FDA: 81351813438.04.716F7CD Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf08.hostedemail.com (Postfix) with ESMTP id E756D16000D for ; Mon, 16 Oct 2023 16:10:56 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oZSi9Cr4; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of jlayton@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697472657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RkWUp9Qav4M98scaBzbNFGOuR0YHcW9ypUC6Vk5+tlY=; b=rJp6mqrNnzZs8CWcKmWsa0L3nnbfLPBDPfFpHPlUjmac/1goBIv7mV8aAPWkOdArikYfp0 fzbwPsZjZL0vkR1FCUaULSdX2vDBXSccnH5UBk+nR0qb0wmjji4MpCijBmP3PTcwK5eDQL OEPFgWhYG2C+p2BxcBQKDdPOGeuUGNQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oZSi9Cr4; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of jlayton@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697472657; a=rsa-sha256; cv=none; b=z2TcZ9E2u4uValSRRmWS+j4Hwu/aJ6dZ3PUvbNuEtzFEPKM9vicEaC/VSzApodRHhqua50 L7Q99ytzod1/IaVw2ZLX4S0zRQuxm6aLeBu4vyT7XZN91EgWUE3cNCf37HV46Ortm3HreX 7wA1bddUFj7McSio77XbOPSmnPcprsQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2AFF3CE181B; Mon, 16 Oct 2023 16:10:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6700C433C9; Mon, 16 Oct 2023 16:10:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697472652; bh=gWHVm67UjtqFw6+7yv4rt62zVL2QbQsf6kz0OqfM+T4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=oZSi9Cr46VJvDfJqXMvyt3WZMnh3kWQOGId5Ykf8NhRUkV1JLSq60ZEuW9aLkCetX sil+IjGAZbvHruvhuOiI8djrgL/SiaanaZOLMiaQa1tSFyoNb5Nlkh0TjdFGAJiay5 SfJPKb8r8exJavmsBQGw4TiOA8LZFqvuinK7G3ADrnTpV7Idmg/KlDlaR5SYbA4LeI X6h60yT/c0b1f+iN5XqRzmx03D1z5a9WHAS97cpg8XRftJnID1Kr4zsHf46LaSw39s Sn6yblOrRc68OCh2l6paV3F2P/vXsQoBQ8A3E/1gLqYl8X+0LyMWIKHZUPKSFQWxv3 idwbIz0NRNM+g== Message-ID: Subject: Re: [RFC PATCH 11/53] netfs: Add support for DIO buffering From: Jeff Layton To: David Howells , Steve French Cc: Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Ilya Dryomov , Christian Brauner , linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Date: Mon, 16 Oct 2023 12:10:49 -0400 In-Reply-To: <20231013160423.2218093-12-dhowells@redhat.com> References: <20231013160423.2218093-1-dhowells@redhat.com> <20231013160423.2218093-12-dhowells@redhat.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspamd-Queue-Id: E756D16000D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: dwhzarij46ozjs5o8g77yps1j1nfz1kb X-HE-Tag: 1697472656-643897 X-HE-Meta: U2FsdGVkX1/s7LfLOAZ8Q7IZ4xQGSLxbPlQvhyKUs/UQ/Guveau/EBu9v4Jbi/KYPhDHw/3oIy6p6znlR4Cfk4aGHDTsHKAIE5adneAUMJ1CSH3C3VzK5VHiIm2Dinfelm23woTgqjRhehf024S+dHNAuPECPxnY9ZtoWANtrRR1yp2OwJJQN4VQGjSewrXB/zC8hrmmdC1Hu7gnDqyOlILSVZYQB8+LPRuDo5JybHLS5z2rK+Inm/wKF1Jfa7HsvZy1QsRFykfrHTM//fS81w1/laT8hTstaWwexfo5X42x5Ppl194Emb9h5ktFXgQCg07/RpKMJfhusd7p6f1CfBae9F8jwKfVDPKsDcU/o+S/+CcpAgPpQd6u/riya5hEvncvj5+97FG2QrQ1CpILW+S+SQXpqYDS7mLNqGh79v22LRYYYyEDDd6hX+USme7rTKmyQIveYyz/fOQoFRfgCcivXafMzA4vYvlXM09LLAngxnplGiDjSV4OIz8rLpOTbQPlTSf2xxk7GeV29/rGDfbEQfJP3DQxQ5zGIxa0GhizafDCfg39iS5c+uY8wGWkvF5v13TiHVhK8u7Lqb0wQcWQ6XLdzlIDXFvhj+4Bqx0RwuevPEqJsv7nxCuX7mP+nd+sjkCeFbCRtoL5r+X9x51Uwp0ob6kmJlHkKl+qhTAfOMYWfe/Vq8rWzp2P6OL3beTZKNBW2+Boqygo9OweWknzCPNlK0JQQFnJqmIr3zuXgTUBuc2KZMK48X87HcoLjP/WVTRXJXVPIhDGjqYgJF9V+6vuNLqrOAtlqemCxFs4aenzSDgyZC9A02RBb/eB8d4jp1NIgtAev6meJVvhALeYS6AN4E/zp7K+JlCi3XhO2GC46MiZ2SjD6TFatgxkgqRF8SJEXCWTy9q1gSnvKAuYtP1AVL16y2r+S/10Xvwj+WbHN/9Iu5A+yxfgrJdAQKGdljq1x5HePRkqsIH V74h8jer /WBJedRDpcgEKPm0yS4vfblCDhak60C2QqHxtpgrx5HT6H2d1pAWJUToqdojM9I8G5MJ8LbsKHoAu54bn9r86QnoPZsx6aA0iTVqLn4Mi/gdEr+fl/30TjUDLC2804LO7G6Zo7CKj7Z7ub+gW21m6OGq1caUH4+23eR1In0DfKB3+ZArAxiF0gPPU7n6cgnvDRuY5w/ksOdGrKR7g0ufIlKaM9PpazMa0ZXGyA2ivfePl93rOosjnsaDRSewjST4f+pSM1rWObot3fNjYRtDV9ZWcfyiDK6SY0jdtgz4imRBdnKcCsSHiBoz/UwZIlT9nP7OR6WCQCmUMq4g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2023-10-13 at 17:03 +0100, David Howells wrote: > Add a bvec array pointer and an iterator to netfs_io_request for either > holding a copy of a DIO iterator or a list of all the bits of buffer > pointed to by a DIO iterator. >=20 > There are two problems: Firstly, if an iovec-class iov_iter is passed to > ->read_iter() or ->write_iter(), this cannot be passed directly to > kernel_sendmsg() or kernel_recvmsg() as that may cause locking recursion = if > a fault is generated, so we need to keep track of the pages involved > separately. >=20 > Secondly, if the I/O is asynchronous, we must copy the iov_iter describin= g > the buffer before returning to the caller as it may be immediately > deallocated. >=20 > Signed-off-by: David Howells > cc: Jeff Layton > cc: linux-cachefs@redhat.com > cc: linux-fsdevel@vger.kernel.org > cc: linux-mm@kvack.org > --- > fs/netfs/objects.c | 10 ++++++++++ > include/linux/netfs.h | 3 +++ > 2 files changed, 13 insertions(+) >=20 > diff --git a/fs/netfs/objects.c b/fs/netfs/objects.c > index 8e92b8401aaa..4396318081bf 100644 > --- a/fs/netfs/objects.c > +++ b/fs/netfs/objects.c > @@ -78,6 +78,7 @@ static void netfs_free_request(struct work_struct *work= ) > { > struct netfs_io_request *rreq =3D > container_of(work, struct netfs_io_request, work); > + unsigned int i; > =20 > trace_netfs_rreq(rreq, netfs_rreq_trace_free); > netfs_proc_del_rreq(rreq); > @@ -86,6 +87,15 @@ static void netfs_free_request(struct work_struct *wor= k) > rreq->netfs_ops->free_request(rreq); > if (rreq->cache_resources.ops) > rreq->cache_resources.ops->end_operation(&rreq->cache_resources); > + if (rreq->direct_bv) { > + for (i =3D 0; i < rreq->direct_bv_count; i++) { > + if (rreq->direct_bv[i].bv_page) { > + if (rreq->direct_bv_unpin) > + unpin_user_page(rreq->direct_bv[i].bv_page); > + } > + } > + kvfree(rreq->direct_bv); > + } > kfree_rcu(rreq, rcu); > netfs_stat_d(&netfs_n_rh_rreq); > } > diff --git a/include/linux/netfs.h b/include/linux/netfs.h > index bd0437088f0e..66479a61ad00 100644 > --- a/include/linux/netfs.h > +++ b/include/linux/netfs.h > @@ -191,7 +191,9 @@ struct netfs_io_request { > struct list_head subrequests; /* Contributory I/O operations */ > struct iov_iter iter; /* Unencrypted-side iterator */ > struct iov_iter io_iter; /* I/O (Encrypted-side) iterator */ > + struct bio_vec *direct_bv; /* DIO buffer list (when handling iovec-ite= r) */ > void *netfs_priv; /* Private data for the netfs */ > + unsigned int direct_bv_count; /* Number of elements in bv[] */ nit: "number of elements in direct_bv[]" Also, just for better readability, can you swap direct_bv and netfs_priv? Then at least the array and count are together. > unsigned int debug_id; > unsigned int rsize; /* Maximum read size (0 for none) */ > atomic_t nr_outstanding; /* Number of ops in progress */ > @@ -200,6 +202,7 @@ struct netfs_io_request { > size_t len; /* Length of the request */ > short error; /* 0 or error that occurred */ > enum netfs_io_origin origin; /* Origin of the request */ > + bool direct_bv_unpin; /* T if direct_bv[] must be unpinned */ > loff_t i_size; /* Size of the file */ > loff_t start; /* Start position */ > pgoff_t no_unlock_folio; /* Don't unlock this folio after read */ >=20 --=20 Jeff Layton