From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD08C7EE26 for ; Mon, 22 May 2023 08:55:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB144280001; Mon, 22 May 2023 04:55:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E60CE900002; Mon, 22 May 2023 04:55:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2868280001; Mon, 22 May 2023 04:55:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C3438900002 for ; Mon, 22 May 2023 04:55:37 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A347EA0CEC for ; Mon, 22 May 2023 08:55:37 +0000 (UTC) X-FDA: 80817282714.03.B068935 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 80CC84000F for ; Mon, 22 May 2023 08:55:35 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DISBGxk6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684745735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZPSy40Ik/lXr1edVRYw63Ydc2QclByRoU1Cs393xPXE=; b=Sd+N69dEG7CTS+h2VVXN0hJMCUviJqXytNmQADVnrjOxWpPCC3iYdxCZIVr/QeyQvzqsmg hDPiM+G9pdqvf3YPsNZYrYOV+15+y7Bg5sMlOVFUHDBSkKqKv1wnBXpwraNNOXFlVqtI8G oBN6rZAwDq8476k9qWFjr/1UX2I3Jl4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DISBGxk6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684745735; a=rsa-sha256; cv=none; b=OwWYLQcHKng+SIBNgUUxKZfhqsZQT6Dq/I0eHfPRVFuUaymT7rPLF1YOtvttlhjsxQNkiT 71uBQPN4OvEqTGCxnigTOHNjjMuvWVeKfwu7IF6Nt8XJVXlPqZTPH2AwjfnfMTh69/CcXL zuX8JXr+2IxmvoBGRMoBudxsEQuhBR8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684745734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZPSy40Ik/lXr1edVRYw63Ydc2QclByRoU1Cs393xPXE=; b=DISBGxk6r7qEQ7L4wSSUNC7qwEdDoDPyefEPQ+oprm1eNydL73PEL5DppGZmVXXB+3GomJ AOThl3SEgxBiPJbTKVMGENaeSBpFeZ3UE1c/Uh/OzNONOkljj4eC7sf2QvB+iCbqcpdaKn OE74VWMVTWzSLn22JusZZ3/KRBDrT/w= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-D6PGf5h7NpizFfpKqajUNg-1; Mon, 22 May 2023 04:55:33 -0400 X-MC-Unique: D6PGf5h7NpizFfpKqajUNg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f4245ffb03so34588055e9.3 for ; Mon, 22 May 2023 01:55:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684745732; x=1687337732; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZPSy40Ik/lXr1edVRYw63Ydc2QclByRoU1Cs393xPXE=; b=E0Ph9N0IHexGpeuPbwjYa4P7Oyc2NflrzFm8F1YqLsjB9Y5ZYqYP1oObFzzssT5tu+ 3jRs4VzK91fWY+QUP8ZvU9boY4namP7BzeIvo6jkL/hNg+S4TOMzjdEFd4r/UvlFaIb3 FlUUWNioFDEfqz0sYb7d8wcz9Cgu2r1Qf47MryzZu2scrs8FGHgGRKfd4KM8c2Ka5wZS pWJzIQTm1Xm+RQATKqO2TUT6CT6etrN2tbLrRupCAWIzwjcgoV19KTX9nEg7V0tpdzS0 /xHzzTHQF6vw+xOujp1kiQMKwpLXS0OU2VvQkdi+vmxp6BWEeZpDjIas5S76d+2OaG8F kOaA== X-Gm-Message-State: AC+VfDxctHuAJ08PTJFR9XqaZ7/Sa9qzHj5L0OM2L0ol9fS23EzYDmUt Zmu2AYxEehHPeSmAMpvD2fe5h+gNmWm+zSq7kUDz7XaCFLvSMmYF6I88R7qzIgSkB6jLgkvIpvd /hb4E+afdMI4= X-Received: by 2002:a7b:ce0e:0:b0:3f5:1bca:345a with SMTP id m14-20020a7bce0e000000b003f51bca345amr6751138wmc.21.1684745732259; Mon, 22 May 2023 01:55:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6IfyeEnjp7Pfim3zymj1hor8xyUZVI6Ko6H9zwVNZrHsgCWOSKpODloCatqykLSZbOw1M8UA== X-Received: by 2002:a7b:ce0e:0:b0:3f5:1bca:345a with SMTP id m14-20020a7bce0e000000b003f51bca345amr6751111wmc.21.1684745731895; Mon, 22 May 2023 01:55:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c742:c800:d74f:aec6:f8ac:558? (p200300cbc742c800d74faec6f8ac0558.dip0.t-ipconnect.de. [2003:cb:c742:c800:d74f:aec6:f8ac:558]) by smtp.gmail.com with ESMTPSA id l10-20020a05600c27ca00b003f4290720d0sm10709279wmb.47.2023.05.22.01.55.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 01:55:31 -0700 (PDT) Message-ID: Date: Mon, 22 May 2023 10:55:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 3/5] mm: Make PR_MDWE_REFUSE_EXEC_GAIN an unsigned long To: Florent Revest , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com References: <20230517150321.2890206-1-revest@chromium.org> <20230517150321.2890206-4-revest@chromium.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230517150321.2890206-4-revest@chromium.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 80CC84000F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ys61y769agwwxza13tnmjt9p38w6cocm X-HE-Tag: 1684745735-351149 X-HE-Meta: U2FsdGVkX19HDU3DikWAXuk0A+IsetgqaZBcpEKJqzkNa/71NNKq6/lm6CbpeYlXX9zSkj6SEUg4v2S64v1frddU7pNAV9YFEkERvhprr7qukdqT1y3UqPLKpo4AixK0Qv/k7h/B4LrdcYH//qDYgBOwPVLLt0Ek7GbujZxCERs2+fiwrIvUVGrfrUnOFsV+O5F0kEa0UIwSXI9+dVyNRrLj7Ntqe4P+8xelDiR1oQ5XJfOJMxdDmqkOMAtI8PeSvCbNQyrhwRKZiOz8IXsr0k14+A1TfL+lRtfZspoAqf/DdnGwfVelLRNJeyoQEcg6iuOQoKZm9ftfJnSNPTiTtJ3x18pMQ1W1EwEhvECXSD66QpkXM/B3uwTa+SZMTrZp6Ah9SEYV0xsWYOo1tiz0Rf88WXlvgmpzOtnaOFn9SuwCnAuoocAaAyn0x8kQbW4GFgI7LGDsrHiEWcANecyHmRRxWhKVihPyd8aSRLJjDgqBFB5snu4/p++rNjqvtZDDkzXTEdcBoXuBGIQ1Iz8VtPXMWVPVqGFU4i/8MTzXQFXlOU/dZ5sC1udqbr9LHOq+dpALxEUdZuYssWM4UbOD+UhNxw7XLc/jmnx5G7CbMtk03Y2kY6A3JB+GyyRRuMIDJ+eEn7pY9Zvwg6sWm77vBwYp04RkDQskkmd2wTByG3AYh1qIKqOHWfKfgDHVWCtLPWl2XM7n2mxCD8q63YYl5lNq75Yz2IMoUFH+Ssacq/yRO0MRhe1WChUChfDSP+0r1R/EqdZO6IcSYvWVKoFPPm7q24SORh++W/G56332v7GxemtroPx/ZGhjyPujexWmpH/c5i+Jlo7wrqfkp1SU1KWuUk40T3s8lpN6Ct0wN2ukOYRK7gHkL03DMX4UNfT48zkwiG1LIvmsZtJ9x/xsuTocoLuvMXPwTIgIJEN2aX5AUhn1DcNHaNzg9wHIy6OO35LeMT8uABBEwzi9B1G FPwrDjNN a1a7Gctbw66v24R5HH1WQN18n5OPYkO3gi45R7apbxGjv8TLBgYNw4uFDT1RwgGlafrKweOEeChTsPHY+yY+gAu8M0v+5G340fe291If+0WlmzYJzAavrEe55AuSXtqZvDrCxXPNI6YANH0b0ursAhAUWLTMpe9+J6PkWhGqgqsA6GWZfoBqHrjBn+9DlQckZ7oo4Gw2cD9E5K1qMTAXbQEL9U7BBazS8aiAif3q28Pn0m1yLulUBFGb/N1e2h99KK+PIWfG4qU8yCU1/+sNwAakNoWsiCyndnVCOTzeyZYq4zJzNSi3wea+1xnsuwlvsuLAcYiFts+hqqeRc2NzGXw0GfamHwQaKO03/MSSMdqMwmpHb4bsXEJy3BkNqyt+NsV7ysTiLVAjsuArfF584vx/TJAa/co1dbca/bFetIk5GDQCVFHYPDlPScyBfulFIhLZNpg8m3NNcHsmriuogxjtzO5qAMT5j3kFOHGDePbEBsaQ1mEYNfiCUOwL2QDsPb3Shjjc9RqIImIV4AgqJE4+5UtZeMZDISWDSRTgMUZh9BmI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.05.23 17:03, Florent Revest wrote: > Alexey pointed out that defining a prctl flag as an int is a footgun > because, under some circumstances, when used as a flag to prctl, it can > be casted to long with garbage upper bits which would result in > unexpected behaviors. > > This patch changes the constant to a UL to eliminate these > possibilities. > > Signed-off-by: Florent Revest > Suggested-by: Alexey Izbyshev > --- > include/uapi/linux/prctl.h | 2 +- > tools/include/uapi/linux/prctl.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/prctl.h b/include/uapi/linux/prctl.h > index f23d9a16507f..6e9af6cbc950 100644 > --- a/include/uapi/linux/prctl.h > +++ b/include/uapi/linux/prctl.h > @@ -283,7 +283,7 @@ struct prctl_mm_map { > > /* Memory deny write / execute */ > #define PR_SET_MDWE 65 > -# define PR_MDWE_REFUSE_EXEC_GAIN 1 > +# define PR_MDWE_REFUSE_EXEC_GAIN (1UL << 0) > > #define PR_GET_MDWE 66 > > diff --git a/tools/include/uapi/linux/prctl.h b/tools/include/uapi/linux/prctl.h > index 759b3f53e53f..6e6563e97fef 100644 > --- a/tools/include/uapi/linux/prctl.h > +++ b/tools/include/uapi/linux/prctl.h > @@ -283,7 +283,7 @@ struct prctl_mm_map { > > /* Memory deny write / execute */ > #define PR_SET_MDWE 65 > -# define PR_MDWE_REFUSE_EXEC_GAIN 1 > +# define PR_MDWE_REFUSE_EXEC_GAIN (1UL << 0) > > #define PR_GET_MDWE 66 > Both are changing existing uapi, so you'll already have existing user space using the old values, that your kernel code has to deal with no? -- Thanks, David / dhildenb