Re: [RFC PATCH] MAINTAINERS: add further core files to mm core section

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

On Tue, Jun 17, 2025 at 09:59:01AM +0200, David Hildenbrand wrote:
> On 17.06.25 05:53, Mike Rapoport wrote:
> > On Mon, Jun 16, 2025 at 11:10:41PM +0200, David Hildenbrand wrote:
> > > On 16.06.25 22:38, Lorenzo Stoakes wrote:
> > > > There are a number of files which don't quite belong anywhere else, so
> > > > place them in the core section. If we determine in future they belong
> > > > elsewhere we can update incrementally but it is preferable that we assign
> > > > each file to a section as best we can.
> > > >
> > > > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> > > > ---
> > > > REVIEWERS - let me know if these seem appropriate, I'm eyeballing
> > > > this. even if they are not quite best placed a 'best effort' is still
> > > > worthwhile so we establish a place to put all mm files, we can always
> > > > incrementally update these later.
> > > >
> > > >    MAINTAINERS | 28 ++++++++++++++++++++++++----
> > > >    1 file changed, 24 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 4523a6409186..a61d56bd7aa4 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -15740,10 +15740,6 @@ F:	include/linux/memory_hotplug.h
> > > >    F:	include/linux/memory-tiers.h
> > > >    F:	include/linux/mempolicy.h
> > > >    F:	include/linux/mempool.h
> > > > -F:	include/linux/memremap.h
> > > > -F:	include/linux/mmzone.h
> > > > -F:	include/linux/mmu_notifier.h
> > > > -F:	include/linux/pagewalk.h
> > > >    F:	include/trace/events/ksm.h
> > > >    F:	mm/
> > > >    F:	tools/mm/
> > >
> > > Probably better to have some section than none ... was just briefly
> > > wondering if "CORE" is the right section for some of that. Some of that
> > > might be better of in a "MM MISC" section, maybe.
> >
> > Maybe rather than add files to MM CORE we should move mm/ there and add the
> > MM MISC section for files we explicitly want to exclude from MM CORE?
>
> Also an option, yes,

These suggestions seem to be roughly the same no? :)

Maybe the MM section itself should just contain mm/ and we move everything else
+ stragglers to misc?

Now who, whose's first name begins with 'D' and surname begins with 'H' should
we put as M there... :P well...

>
> > > > @@ -15764,16 +15760,40 @@ S:	Maintained
> > > >    W:	http://www.linux-mm.org
> > > >    T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > > >    F:	include/linux/memory.h
> > > > +F:	include/linux/memremap.h
> > > >    F:	include/linux/mm.h
> > > >    F:	include/linux/mm_*.h
> > > >    F:	include/linux/mmdebug.h
> > > > +F:	include/linux/mmu_notifier.h
> > > > +F:	include/linux/mmzone.h
> > > >    F:	include/linux/pagewalk.h
> > > >    F:	kernel/fork.c
> > > >    F:	mm/Kconfig
> > > >    F:	mm/debug.c
> > > > +F:	mm/debug_page_ref.c
> > > > +F:	mm/debug_vm_pgtable.c
> > >
> > > Wondering if there should be a MM DEBUG section. But then, no idea who in
> > > their right mind would be willing to maintain that ;)
> >
> > The same people that maintain MM CORE? ;-)
>
> Heh :P

...hmm yes easier to just copy/paste these good idea ;)

>
> > > > +F:	mm/folio-compat.c
> > > > +F:	mm/highmem.c
> > > >    F:	mm/init-mm.c
> > > > +F:	mm/internal.h
> > > > +F:	mm/interval_tree.c
> >
> > Looks like VMA to me.
>
> It's more about anon_vma I guess, so rmap ... maybe.

Ack.

>
> --
> Cheers,
>
> David / dhildenb
>