From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.or, linux-mm@kvack.org
Subject: Re: [PATCH] mm: numa,memblock: include <asm/numa.h> for 'numa_nodes_parsed'
Date: Mon, 12 Jan 2026 15:12:33 +0000 [thread overview]
Message-ID: <bb039bce-03a9-41bb-a806-65dee5739c8b@codethink.co.uk> (raw)
In-Reply-To: <aWNnyDTTRoO2HKnD@kernel.org>
On 11/01/2026 09:05, Mike Rapoport wrote:
> On Thu, Jan 08, 2026 at 10:52:20AM -0800, Andrew Morton wrote:
>> On Thu, 8 Jan 2026 10:15:39 +0000 Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>>
>>> The 'numa_nodes_parsed' is defined in <asm/numa.h> but this file
>>> is not included in mm/numa_memblks.c (build x86_64) so add this
>>> to the incldues to fix the following sparse warning:
>>>
>>> mm/numa_memblks.c:13:12: warning: symbol 'numa_nodes_parsed' was not declared. Should it be static?
>>>
>>
>> huh, I wonder how that snuck through and survived more than a
>> year.
>
> Probably most configs include <asm/numa.h> as other header dependencies and
> Ben's config does not for some reason.
>
>> Thanks, I'll add
>>
>> Fixes: 87482708210f ("mm: introduce numa_memblks")
>> Cc: <stable@vger.kernel.org>
>
> and please add
>
> Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Thanks.
I think I was building the riscv64 defconfig
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
prev parent reply other threads:[~2026-01-12 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 10:15 Ben Dooks
2026-01-08 18:52 ` Andrew Morton
2026-01-11 9:05 ` Mike Rapoport
2026-01-12 15:12 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb039bce-03a9-41bb-a806-65dee5739c8b@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.or \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox