From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EBA4C636D4 for ; Thu, 16 Feb 2023 02:17:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A0956B0071; Wed, 15 Feb 2023 21:17:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 350E96B0072; Wed, 15 Feb 2023 21:17:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23FA46B0073; Wed, 15 Feb 2023 21:17:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1107D6B0071 for ; Wed, 15 Feb 2023 21:17:18 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B9310120D7B for ; Thu, 16 Feb 2023 02:17:17 +0000 (UTC) X-FDA: 80471542914.06.CC6C1AF Received: from out199-14.us.a.mail.aliyun.com (out199-14.us.a.mail.aliyun.com [47.90.199.14]) by imf19.hostedemail.com (Postfix) with ESMTP id A78B51A000B for ; Thu, 16 Feb 2023 02:17:14 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.14 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676513836; a=rsa-sha256; cv=none; b=efa4B9b80mpVQW8+P4Qm/MaJFPD6CEbPwoU7n3qWap9bd39ZKZN9hC6j9bLnC6hg6PSeGC pGOAYHGukS0FpP20+FIUECow+n4m5EMlwjgtmdCo3nbvK39J36kPfGdnPA1B7AWD51QwMa wxxAkjSQSY2sUe1UaG3Y0wMBJG4/ubo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.14 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676513836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8FWIQ+gLSNygnIgXXemQ16hYR0PitkxwsP150Lljdlw=; b=2QjLhy8aOYOtbxJoezyXzWt1VH2OWQH6q63va3xbaQlwJn+9uu+kFlO8b7uS9r0t2SGDU7 frsbbSdyCDl1QBChyby6tGn0bA4N3eap4i4XtptaikzQpWK61Ub/jC84vjp+OGfxXjQPJe T4GL/RHufnFx/Se5c3DtUouhu5/G6Tc= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0VbmFOuB_1676513225; Received: from 30.97.48.85(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VbmFOuB_1676513225) by smtp.aliyun-inc.com; Thu, 16 Feb 2023 10:07:06 +0800 Message-ID: Date: Thu, 16 Feb 2023 10:07:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v3 4/4] mm: change to return bool for isolate_movable_page() To: Matthew Wilcox Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, sj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, naoya.horiguchi@nec.com, linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de, mike.kravetz@oracle.com, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: A78B51A000B X-Rspamd-Server: rspam01 X-Stat-Signature: pcect58w5f846z9wu7qshrg6epdofg3b X-HE-Tag: 1676513834-501958 X-HE-Meta: U2FsdGVkX1+IlkYMrsT+vX7cO95931+7aNTOo7w8Wq4eZAcACAddk5YrSdaRDaEY5itvhxgl8DBic+hUy1YvGWXkwRv/YrXcG88y9FZMLHZOafSxJpNx4tu65PXa5nT7gzKSOZ8E4wmbxns91Rck3jmAATiE5ixjwSS2gKIeP+Xx8QmhzV3X3S0P2LRf1D4Yjw+nc75Zglhpx7/CqnP6n+CPXEG69QXTGpTJR6TqaAL8oAr2UqGt09TPtMN8jk+pYUmh/8rEu8jJ8h+zkHw/C68nKxL8P11u+fjRRKI+oJl4ZEIFjwjpzyuKPB4jJgaKdBjhCymHSq0QknyExJb44cNVfMAnetu+dznH73Z2mnIajKnU7NmxjSdJDTMQYiu/Cr1v4Rm68UDBJybuml7km/ZUg90lVbClL5VDxCwbg0kah5DGYp/msY5A/A7bcE9YdJbRx3kY/9IFT8ErKu68ls0GWP76GZ9m4h0VwXTCUFOb2uDOMUeNEW7b2fw0xRyVaTDo08iGa0ikOpzto7Jk1JPYunPebdrPvFQ4XgNCMjYuh4AP4lH6PSF/MevhZAx2amsFnCNaQRQApm2B35Nh/JHtfiNpVtRTfRv1gFI3OKad9iRRbNwQwNyXrkoTdy+T6cPWe6Eo59JIgPE1SLymTJ2v16X1xvMPmeDrFMN5pWHnvJa+YG/rHFloaqU2WASYzu70JPndndHMPvsALFEOOtIbQvvTHGqiIHaTW110cyVGLl/lFbWaskW9nanc9auPS64TCO2mune26HaGiCOQOLxrHC7EmUNLsRy7ZWuHk3yEDszC71uJj1RrACzhTbu0IQl6nKZrThE8fYH5edLOhL+sdVy/TMo8TJ3EZA9QJFHO4UDegau5jCZ4UZjKBw1d7PWkl4flxzcEdj5Ebtt+ITMu00gByLzABoj4B7Bj8EdojhL0UzFysTDmKnhf8DPUCE5SH96E8LtVloCQ9EJ UhTw5ISU e9QULmyanoktDozLrLT0lpaiJhsFgkRCmg219GsxbwSuSTdodOMSEDbpKr2R/m6ADQj/nRTEcB7nZHmD9yXDdCjdjsU4dyAjfE2AGUQSE8Phys9qLpCKmw+3TGhDJdGbxnCIaVu8T8Ekm8UkqANPZYLEvd6GeN89rBgP60VcS3/7LyzQESXp6BkcC6PielAJqz6IKr9PbHtwBV0qQtZEt/cCnE7lBhH/aCMN0M1Y98qg6dpFvEyid2zXa/rFwZ/n1e0wa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/15/2023 11:44 PM, Matthew Wilcox wrote: > On Wed, Feb 15, 2023 at 06:39:37PM +0800, Baolin Wang wrote: >> Now the isolate_movable_page() can only return 0 or -EBUSY, and no users >> will care about the negative return value, thus we can convert the >> isolate_movable_page() to return a boolean value to make the code more >> clear when checking the movable page isolation state. >> >> No functional changes intended. >> >> Signed-off-by: Baolin Wang >> Acked-by: David Hildenbrand > > Reviewed-by: Matthew Wilcox (Oracle) > > A couple of nits below, not worth respinning the patch series for: > >> diff --git a/include/linux/migrate.h b/include/linux/migrate.h >> index c88b96b48be7..6b252f519c86 100644 >> --- a/include/linux/migrate.h >> +++ b/include/linux/migrate.h >> @@ -71,7 +71,7 @@ extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free, >> unsigned long private, enum migrate_mode mode, int reason, >> unsigned int *ret_succeeded); >> extern struct page *alloc_migration_target(struct page *page, unsigned long private); >> -extern int isolate_movable_page(struct page *page, isolate_mode_t mode); >> +extern bool isolate_movable_page(struct page *page, isolate_mode_t mode); > > You can drop the 'extern' here. > >> +++ b/mm/memory_hotplug.c >> @@ -1668,18 +1668,18 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) >> * We can skip free pages. And we can deal with pages on >> * LRU and non-lru movable pages. >> */ >> - if (PageLRU(page)) { >> + if (PageLRU(page)) >> isolated = isolate_lru_page(page); >> - ret = isolated ? 0 : -EBUSY; >> - } else >> - ret = isolate_movable_page(page, ISOLATE_UNEVICTABLE); >> - if (!ret) { /* Success */ >> + else >> + isolated = isolate_movable_page(page, ISOLATE_UNEVICTABLE); >> + if (isolated) { /* Success */ > > I would have dropped the "/* Success */" here. Before, commenting > "!ret" is quite sensible, but "isolated" seems obviously success to me. Right. Hope Andrew can help to drop this unnecessary comment:) Thanks for reviewing.