From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF6E2C83F34 for ; Fri, 18 Jul 2025 07:23:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F0CD8D0006; Fri, 18 Jul 2025 03:23:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A0E38D0001; Fri, 18 Jul 2025 03:23:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5696A8D0006; Fri, 18 Jul 2025 03:23:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 468768D0001 for ; Fri, 18 Jul 2025 03:23:42 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1C1DD1A0324 for ; Fri, 18 Jul 2025 07:23:42 +0000 (UTC) X-FDA: 83676545484.23.51776A7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 9904280006 for ; Fri, 18 Jul 2025 07:23:39 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hult3zZ0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752823419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9RrBmzunL6zDwpq0gyC63RDwoM41jxR0aq1ACrL2Tfs=; b=Y7jO9C5SCiKDyMa7SE814bbaKm7LJgvjYSBa4WnD046PhDeFYkGV6m7C63ESC+jzod/srO vTzLLzQKTpKmI+PRPC8MWoxieS0BbR1///U6vrlwNAUi/z4rpKJ+OHi0A81XBxwPIdARTc VTFPI1V2dMJ81zchQhfpsRv853GgulU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752823419; a=rsa-sha256; cv=none; b=LcC9f28lsTfVUrwr+g8uUyazdO42CPsH9iqk6leEoGNgcXjYPvMepeJgTodWesqkal0o/6 CnnC6/Rzqkh8n1VSnbVD1968bI173FdH4YlraHB+PGnI6hAX95PSyg/92P8puqkAQoF8Ar 356XaMFLQiKHGLtxXXDykqrLBuMK7mE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hult3zZ0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752823419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9RrBmzunL6zDwpq0gyC63RDwoM41jxR0aq1ACrL2Tfs=; b=hult3zZ0mGZ9bosPmpsjtMUnjUv3qmoZWqw9UQEArOcaefE3QW7V0mPjNnLP/EHNrnrIpv Ybm47d2+H794HyuQSxB+qAUgyutq15Pitbd1auvvg/92zn2z/ykEN40+HWnz0spoLr+rAK 7IOe4iCc2WR4JaO3wpoe+ms0BL7LQ9Y= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-eviFKhq7NGubNpb91zwQgg-1; Fri, 18 Jul 2025 03:23:37 -0400 X-MC-Unique: eviFKhq7NGubNpb91zwQgg-1 X-Mimecast-MFC-AGG-ID: eviFKhq7NGubNpb91zwQgg_1752823416 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4eb6fcd88so1112940f8f.1 for ; Fri, 18 Jul 2025 00:23:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752823416; x=1753428216; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9RrBmzunL6zDwpq0gyC63RDwoM41jxR0aq1ACrL2Tfs=; b=P1ajLFhLRecpjRNVn9ymwRHIs0ffzDLrzRjhToMWMfdZvKeVyM4ZuzzPGbp6P7UGer rn9viRO9IPzF8R28KICWzTCxVtHYLy5QD4rULAMen4LqrTEfkK0fnkEB6ROcyYDo2azZ a5wt9Dg90vp2wAOjGDv9vwuH+Z/gXCXW653EgddDDQHF0D9TluI3H0XG7YRFcdMwxdC3 I5AHqYk7zAPb1gvbbKTHtOr9WQJYG7bhm+TMIYSo4hhQg017XncjR24y6h+fD5/rTCLI FoZpoHC2O6qQV2lhhO8Bj166Y3yTNZmtv32etEM7HY6wmiidj6/el5g2UFDtL7JfGBwm ge+w== X-Forwarded-Encrypted: i=1; AJvYcCXncqjFuvvV1tGQGVzMZTx1jFGPpUzGmFQRXL1j4IWK6AZSPP9sPz5OyepEMk2nEBOBqcBo9VpwTQ==@kvack.org X-Gm-Message-State: AOJu0Yw1lHANSHyt31i/J4S1KcC9UjRhljmiIoMUitdAjuyX9U9MbBtm vKiWTY0dLIhIiVzeiWWIVm4+LifHLfrlWmL5qXLVujJ5SLI1i7A/7ezkhpD4NiNszkyS4/q+b98 AvbqyhAU4lDoXBLOKtfCXFjpC6CNYklz95VI3BKKTJhenaK4LP3BX X-Gm-Gg: ASbGnct0MTqjawJE8lAYdZMf2+MUtgNjviQ5BY5dDjJmXJF9woUBlD1HmIzLGxizeba /1ha2fnKfhwuYj3RGdqnhUSMvqrKh+X+0ZfTrLTCYYUCSvIuAZbvNd1WXQ3m6u3hzoNGGonPVYj 5MS0wYtN5s7VhGmLLFwt/xCNgyCGzlTKo5gjN5HiK0VWhJ/ERTrwb9xZG2Q0oNxi5EqMA5OLoJP 2weRbOwSSQBTkHOjm/bA6FDoMpbGP/Xt2RvHFi3Yjk9YpBldTSlKOHHfKVwNF+r53GgIKsJ3JfZ FuPAswiz3QBRfCcRpNVV2crRXHpA9351dsi2t2aw7EKkf0FdAg+LvUs/V2ml/NO2KnzTVladOtK rJgEMZONmU02BULfSS17soEeNJFBpqryaoTKGJ78rXRSJaXYtGxNbWG7WC0vRN9yrEkE= X-Received: by 2002:a05:6000:3113:b0:3a4:e7b7:3851 with SMTP id ffacd0b85a97d-3b60e518b07mr7444617f8f.58.1752823416396; Fri, 18 Jul 2025 00:23:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPLQJZzQJGEsBHKh/thGKZkG3kVil5IpltpWb3jW6yuo1iOm1PVuY5GWv9nLd1miTHeqyQsg== X-Received: by 2002:a05:6000:3113:b0:3a4:e7b7:3851 with SMTP id ffacd0b85a97d-3b60e518b07mr7444569f8f.58.1752823415807; Fri, 18 Jul 2025 00:23:35 -0700 (PDT) Received: from ?IPV6:2003:d8:2f43:8900:f364:1333:2a67:d49e? (p200300d82f438900f36413332a67d49e.dip0.t-ipconnect.de. [2003:d8:2f43:8900:f364:1333:2a67:d49e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca25410sm1037849f8f.1.2025.07.18.00.23.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 00:23:35 -0700 (PDT) Message-ID: Date: Fri, 18 Jul 2025 09:23:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] mm/huge_memory: deduplicate code in __folio_split(). To: Zi Yan , Lorenzo Stoakes , linux-mm@kvack.org Cc: Andrew Morton , Dan Carpenter , Antonio Quartulli , Hugh Dickins , Kirill Shutemov , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Balbir Singh , Matthew Brost , linux-kernel@vger.kernel.org References: <20250718023000.4044406-1-ziy@nvidia.com> <20250718023000.4044406-4-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250718023000.4044406-4-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hi4uhZMZGLbgaBfZbEJOkb_SrfKsEXE2yEIHR5X9CJM_1752823416 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9904280006 X-Stat-Signature: g3uwdytiyccu5h6mds9akm5rhzdpe44j X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752823419-322388 X-HE-Meta: U2FsdGVkX190WQI3UwW/RvE15nPPHRLOZeZZoW+pdUymUC4k3AJhKM6DdrJE0HP9wZgcSx9zylL0SIM+nUoLIqOXyp+jgsh9QGbB4hVJsqeVY6k5ZEWXVNTj02Gn8fMDY5UdtqdLr0pLme7eEPE3speojjTF/c9jZVPrhWKJpXKjGOs9ogaL5EkrOpFsGQ3ttBh6gc6R4m+JzVmur4L+N8AXpJGE0Tn0bbg4Inw7BcBrhC7Ic8h4jc/glGhNTjkLWLZaLLXp/8J+c1kmrb3z+ZfHwCknVCOHLmDc5b8DekVS4aZS0olhCy8GaOt9kNGm3yd6t+zmWbxQH0+Kj2eUgG5VSa0WQGoOZ+DRK1jEh/2C2hdOXTgY+Gj8TRSf9QySTsYA+aNoXsusBsNFhh6g73sk/EgYYTH1+TGbWz8pbJ5BdviLdRVifwLs8K6sAq6ubKvepVhxObehx1twP2YOWvrPTjOsc6Lk4IdHJPBhTxrOBVqVMb2aChoRmf6RukUE5XhHvIFSXA4nwewhiIxaNflJNyDI5KgEB6Vr6EfzmkioSVidSFGJ/5dmWFoNwmUxv0lAFfnbZvqTUz/SfH1MUXp6eJF9rXrgfOIyWmxGCGwOnUJF9FPITOyD2RLR6M95/v2Yzc2tSpYPyd0x5asicti25FaSuUymD4SW8LeqgMtu9NLNvS44EWG6DpJ1x8mV8Gq8qBJfOj5cqllIL9K6RLvb4DpWy3V/8S2CkUlsaqWPr0hZIssC8gZxL7zVa0sEDfq9MRle4/AvUph1LLi1IQzcfhwF1sLFzuyl6WljqJMUB6DV2hbw2NWuH2Nre8Rhhjilp8mxddrVsYcepZZ0sjZzYD0QRnIQvqqnvnbuHjufFFqVRdZoRCrevwSThdKEcoA8tZAIkIQM7jWyvJyZqPrG47aJ/PQNUjp8t2SeIEqrxuTlrKOblAVxgcNTmvLgwaI5uwUqUoGNRQS/OKh Wyteuuel cddGeHcX5pFrRqZfW9g+zhW8YLs9fSyh5ID3smypKOTOltBv3lF3cIZ4G8CarL3+NWWrZkxYLLVrkedMJOIQ6dm3nnE94M87XUwytluxAzTPBR84ZeTe2c9v9PAdaa4/eAUF80j8Kdk5HmmrN2nKbwKMpPy+MgLPNx7ucnwLxyQntKMCkE3ybEGTrN9WnnSR9aYcDHiX30jG1mpkbz4UTusfkb+AhC4D842Dg9yM4jgTngae2r2yDobt0TUMNt/OE3rNlHDwr8zaJO7GCjOH4elE1N81M5JGfu7ftM4wIlKE4hwBsRErBYUfxt0+zUBusCVIwjikPF+UsFu0A+/CxlL4NgK6UOjviiDpfkWUi8X/SccASx6K9YeVm7IRY9aKFhKkrB9kwv7k0DXZaFcjqwB6EYck5SZxf6eUXVPXWfd2ZkNi3t8bX3RnEz3XGAMW5WpW101yQRBL0f8pDmfbRFMc0xybZEHGxAqjgfTLMHNOJ7VBU4BggLS0a9kkrS+lu4yPBlzoLwzDX/NNKJHKCxfnFkMmyvY/axKiKQ4jwpI9H6nYaWnw5g4omrbYS1+4q+dzmpBahp95lUjh3MfBP7/IEOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.07.25 04:29, Zi Yan wrote: > xas unlock, remap_page(), local_irq_enable() are moved out of if branches > to deduplicate the code. While at it, add remap_flags to clean up > remap_page() call site. nr_dropped is renamed to nr_shmem_dropped, as it > becomes a variable at __folio_split() scope. > > Signed-off-by: Zi Yan > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb