From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF3BC433EF for ; Wed, 18 May 2022 07:27:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 505D18D0001; Wed, 18 May 2022 03:27:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48DDA6B0075; Wed, 18 May 2022 03:27:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32FA38D0001; Wed, 18 May 2022 03:27:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1DA7B6B0074 for ; Wed, 18 May 2022 03:27:04 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B8C0B222 for ; Wed, 18 May 2022 07:27:01 +0000 (UTC) X-FDA: 79478032242.17.A686521 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by imf17.hostedemail.com (Postfix) with ESMTP id 01105400D2 for ; Wed, 18 May 2022 07:26:36 +0000 (UTC) Subject: Re: [PATCH v3] mm/kfence: print disabling or re-enabling message DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1652858818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZqfBdkcmlkwWYIyfRhtrFzKDZTsuUSEPNTrzwyKaxFg=; b=ZtfLMMXk2wyU4Oo5Ldp2wLTshI6uUrDbB7NrAQv6fH/Fy/H6jJsOLHOKlVoLS0JRrJBXBI B8SAvkI/8Mq2WW1V4JInUDYuIvLAAW2g5JAOc2KsXgLf8dXc2IqrNNnYlDdkwj9J6OTry7 KUw4xBmWZN2lTajjgBx2V766jGNbge4= To: Marco Elver Cc: glider@google.com, dvyukov@google.com, kasan-dev@googlegroups.com, linux-mm@kvack.org References: <20220518010319.4161482-1-liu.yun@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Jackie Liu Message-ID: Date: Wed, 18 May 2022 15:26:48 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZtfLMMXk; spf=pass (imf17.hostedemail.com: domain of liu.yun@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=liu.yun@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 01105400D2 X-Stat-Signature: p5feb7x6ngkgytphxgmiedch1sq4i9hq X-HE-Tag: 1652858796-115553 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/5/18 下午3:24, Marco Elver 写道: > On Wed, 18 May 2022 at 03:03, Jackie Liu wrote: >> >> From: Jackie Liu >> >> By printing information, we can friendly prompt the status change >> information of kfence by dmesg and record by syslog. >> >> Co-developed-by: Marco Elver >> Signed-off-by: Jackie Liu >> --- >> v1->v2: >> fixup by Marco Elver >> v2->v3: >> write kfence_enabled=false only true before >> >> mm/kfence/core.c | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/mm/kfence/core.c b/mm/kfence/core.c >> index 11a954763be9..41840b8d9cb3 100644 >> --- a/mm/kfence/core.c >> +++ b/mm/kfence/core.c >> @@ -67,8 +67,13 @@ static int param_set_sample_interval(const char *val, const struct kernel_param >> if (ret < 0) >> return ret; >> >> - if (!num) /* Using 0 to indicate KFENCE is disabled. */ >> - WRITE_ONCE(kfence_enabled, false); >> + /* Using 0 to indicate KFENCE is disabled. */ >> + if (!num) { >> + if (READ_ONCE(kfence_enabled)) { > > Now you could just write > > if (!num && READ_ONCE(kfence_enabled)) { Sure. > .... > >> + pr_info("disabled\n"); >> + WRITE_ONCE(kfence_enabled, false); >> + } >> + } >> >> *((unsigned long *)kp->arg) = num; >> >> @@ -874,6 +879,7 @@ static int kfence_enable_late(void) >> >> WRITE_ONCE(kfence_enabled, true); >> queue_delayed_work(system_unbound_wq, &kfence_timer, 0); >> + pr_info("re-enabled\n"); >> return 0; >> } >> >> -- >> 2.25.1 >>