From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF68C3ABBF for ; Tue, 6 May 2025 12:48:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9A706B000A; Tue, 6 May 2025 08:48:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D47796B0082; Tue, 6 May 2025 08:48:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE9246B0085; Tue, 6 May 2025 08:48:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9E9DF6B000A for ; Tue, 6 May 2025 08:48:24 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 872E51A01BD for ; Tue, 6 May 2025 12:48:24 +0000 (UTC) X-FDA: 83412461328.17.906AED4 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id 3545A4000C for ; Tue, 6 May 2025 12:48:21 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QSfxMzlT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8TItqUap; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dVX6yepa; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="1/PorQBd"; dmarc=none; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746535702; a=rsa-sha256; cv=none; b=3By8fFFqFBlLT+qZ502yJTrBmaSXfV7S1vOtLWm2JqNmuU7Efwk/0Z3PxMFt9wvnIyMTOe 2O4ve84y3RdXUlewE4mIvxtD5woKopTvIqZWxsRXrR4IehZjqnkRBfuzrl0TI5xN2Lj+aH s47efsqWVB/MK3w3neGGk1eTZt/Dpy4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QSfxMzlT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8TItqUap; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dVX6yepa; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="1/PorQBd"; dmarc=none; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746535702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5K/N/0WLkbc+DdrII6oye3X6T8Ni1CdM9Ifo6jBFaF0=; b=ajB+O8ng1gs7ZVyF2eonwdxCWN7ljBoIDNL7/99CrNPPlUOwoszdiWhk0cJ9+fmApKqcRr gE6FLNg08jevVgc36dRrGcGFhITMhLq5l9NZhSJACo3b29ymrh/pf4mm3P+OtBeAzXa29w v0b0t9NT3A75Ty+OXXDGsxRwpVn65cQ= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7953C1F390; Tue, 6 May 2025 12:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746535700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5K/N/0WLkbc+DdrII6oye3X6T8Ni1CdM9Ifo6jBFaF0=; b=QSfxMzlTxlx/0DcSc0Q/Iw2mZ6eLIHjzK5HZqDXAjMHPDH8qJ9BD8v1nPZ12wn7icoXTL0 JTJAY6PjnZvJb8pzWBdrd6Ql6ZXJMP9BPe+np11Q5Ewjm4SgdRl42a5J+ibdsLFPxyiycq uywjCKexqJhsp7FXRpJ8jd9lLYcAD1c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746535700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5K/N/0WLkbc+DdrII6oye3X6T8Ni1CdM9Ifo6jBFaF0=; b=8TItqUaplNDt0Wh9r9FOWtrzKNMcFn2ZHVEDyp+JNpx/P1LMdEaWRfHt/AtzMIE9Iw6p95 TNwAo+TboQbcxxDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746535699; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5K/N/0WLkbc+DdrII6oye3X6T8Ni1CdM9Ifo6jBFaF0=; b=dVX6yepaOsEz2V8wDOPXqEFaw5e9i++/fW/bsz58A44B6rwiwXYQ50bo64MyOjbXDlr4nZ mWR8Xq+v9dfvxlm7QbG0c983qrkuB3CFeHfhMYCPHue7x9uvY1ZCERsMQ9HkcSBMdqrYxh D+wdwBsQyuyrVThUgiR3NLOW1ok9fKY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746535699; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5K/N/0WLkbc+DdrII6oye3X6T8Ni1CdM9Ifo6jBFaF0=; b=1/PorQBdQXDlzKYyY+e2WKbk7dhTiv5GobGnvxKOCVFUMy4d1niEK6oaJCyCrSke7MeqiH mbzaEKCgaeR1ZaCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5582313687; Tue, 6 May 2025 12:48:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qfWIFBMFGmizLwAAD6G6ig (envelope-from ); Tue, 06 May 2025 12:48:19 +0000 Message-ID: Date: Tue, 6 May 2025 14:48:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block order To: Andrew Morton , Juan Yescas Cc: Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, tjmercier@google.com, isaacmanjarres@google.com, surenb@google.com, kaleshsingh@google.com, "Liam R. Howlett" , Lorenzo Stoakes , David Hildenbrand , Mike Rapoport , Minchan Kim References: <20250506002319.513795-1-jyescas@google.com> <20250506000133.ba44539dd517e4f54515751b@linux-foundation.org> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20250506000133.ba44539dd517e4f54515751b@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3545A4000C X-Stat-Signature: snxxugf9w6hq9ckbii9c3wz48o6bsq7y X-Rspam-User: X-HE-Tag: 1746535701-64972 X-HE-Meta: U2FsdGVkX1/YyU0tN4AhaTJAFr/4rh6lclKqd/INBji3KEZFa/LRhwY3Y4p1ERjSWXH5ZYAPaYWO2mDJBi/AMYJehOLovWnQgErn6fs8ZBvQCijSSNyFPtGR4xOB2ApRqiJMg4J55FkHrseUHrNld91Eawk/qjZBe5U7Vll/GKAH64K2NhlhPMx9WevCxf/eR538gqvms9xnPsw+Pu8VHod8H4C7d4XVVz0m43PejMA7/fT5ndUyB2ONtDZXUnrJ0qXunAkQPcPUK8oNqjM8ZeSE+BOCURtTI5rOXbAi3Vvs77HoSovIF+gMR+fBTE+y+4QmruQ5g1t09od0pYEzRTUxO0Y9Ui1aeK1ZrdnxaktGpi3r8mNJzhnv+DcN/lkhYDK7btxSSXA4fhpzyDg1BCz0O/xpCyXoXwKNbBYRWZ9qtD45gfMvQUdEGafjeGBisjzfIbpji2dSzL8UokBKiJkHIPFGI/LwUja+ipszcf/vCD9nX8pf6FqqnzdE44i84/pL2tJXdgX6If9iN7B4jNNwIjDp2BTqpeslM/JGuaTE+S9/xhC2/cjTHNU7buWKbFTdF4Ihm5jQ46rPzN+Pz2qh57B1OHUrHVZuS3x0VTbQJtCxOACG5N4Wwaq6Dmx8k/MYlI85vZAmsEqA7aH1LFHFOR+d79TpEsVrPUj5ctxDIGuywORLJSCAcOxPObX/nIPgMiJmPMTGv6npdHaXq6v+3feE8Gige+4QhLZrwDVrbVgLDZwAt8E3Isp4Z7/KM2JJHJzSGh84aNiO9WuSq+A/Qbjg8QY14+faM25aUkwU7bpXO0MMAMKsGkh/+VXFXQrYeTSNYcaFIyvlumUmBQ2P1WkDcitNHOQY19iodMfDNYp2JhSbxtpBsq5Qe90IE6Fy2Ga/lsulMYihouK/qFF7UqJUlANvPj1Pta+3fxULhL6P1X3IuMw/JhLvJNS0cjzFp2fOXfJE/+Uzx/5 kMDD/dMq 0VecoMTT3Jvi1HtcZSsIPsji1W/TkIAeCXSIH/dZs9aRiR8kVW0i6JJf2nulPKa67bAieQRgV7CLdInsGjK1oH1es9ekpATezTDRerTp100ZveoePpJjMQsj6gFXQQjUzozP2ShhOfMphC2Mua3w7fWT5V5lsnHWOliMgXDf4bCfgUdWL3U4+wMuPZ/VGm8Nb0xDYzUtaRWg2kK5TvCGd6xTMjChbYf7SlBb5h3MEzWbgG+yYoUyo/VMTyWh5sMbD7G5fSi/hEoJ1g9PU6IVoiuzYM7/ekVNrqH7yvvxgle9MEz6m5yncFV3+0kds/0G3PsaWIfDSP8WMaap6/nmKf4Oat8k5RUcZ7vApetDDSEddTK4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/6/25 09:01, Andrew Morton wrote: > On Mon, 5 May 2025 17:22:58 -0700 Juan Yescas wrote: > >> Problem: On large page size configurations (16KiB, 64KiB), the CMA >> alignment requirement (CMA_MIN_ALIGNMENT_BYTES) increases considerably, >> and this causes the CMA reservations to be larger than necessary. >> This means that system will have less available MIGRATE_UNMOVABLE and >> MIGRATE_RECLAIMABLE page blocks since MIGRATE_CMA can't fallback to them. >> >> The CMA_MIN_ALIGNMENT_BYTES increases because it depends on >> MAX_PAGE_ORDER which depends on ARCH_FORCE_MAX_ORDER. The value of >> ARCH_FORCE_MAX_ORDER increases on 16k and 64k kernels. >> >> ... >> >> +config PAGE_BLOCK_ORDER >> + int "Page Block Order" >> + range 1 10 if !ARCH_FORCE_MAX_ORDER >> + default 10 if !ARCH_FORCE_MAX_ORDER >> + range 1 ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER >> + default ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER > > Do we really need to do this arithmetic within Kconfig? Would it be > cleaner to do this at runtime, presumably when calculating > pageblock_order? AFAIK pageblock_order is compile-time constant. Making this a boot parameter was proposed in v1 but explained as not useful. That explanation could be added in the changelog?